From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.476.1588215307850115763 for ; Wed, 29 Apr 2020 19:55:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gmmwD1PD; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: chasel.chiu@intel.com) IronPort-SDR: DvcC1Ha3zCsYOdC2uDxBJW66y8+M4l6w5bcKreFlvMJqTPzSrCp+bR59Wg1T9Mmpvq/jBmEyZd vtBAc5x8tISA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2020 19:55:06 -0700 IronPort-SDR: 6NOGUt+vuQ5HKnaGnt9BP2dse5BPnIP59391MMHzit/LHP6Mq+I0RGeDcc02LWq2a8mGKPRMIA 7sarmCqXgndw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,333,1583222400"; d="scan'208";a="459409221" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 29 Apr 2020 19:55:06 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:05 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:05 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 29 Apr 2020 19:55:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XxEP6jsA1oxy97qbpa6zg8lcK8hqZRlxawYDzxBv5dypORW8qK9AHhMobLeJLY7civKZte1qDUO/+2u+M1+Jtl/yskjOISpjHtsgDkT41BMiw4dwcB7qDVfqLi2gYGmDSVE7k/kunU01kvQkWS8XUl98jLzGFTSqdOcaybwdKTkORapd7+gxjFmCPmb0uiDVfI/GIMT4VWCy6K6wACQcu0v4bu27ghVllJooNkbZa/84ZAjdllpjVtTo0ANT56XS2ReGOOJyDIy8hcl9eW4W0bsltRXBqazzCyEmsvku/GtjEvTJaU1m+GOm2VrYq1HAjmg07THZRFgqCbtZ8bBjGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAwgOkWH/27wmJiOpLNpUf4V2DvvzbbxAHbnAvIIc1s=; b=P4PlGYwXqZtBVNxJ8qBgj+W8WWp7xUbH5/8VdRDHONmwnFhM/ljcpr2jzlCxckTGn+zQKEqpvZBBSMJNiYDyY2iw3x7DCQ9f5pHj+I5BILW00yMBhnmDvd5TNwDPYbVKjdDxz4aP7Yffc8uHeIj6XDalQpvaP1KFY8v9fHtMy7TPolP26bbQsRP9PXSGI5tfR9J3egaZ6HItzt6qtST1OkeyxqvYjSQb1tO73IxPTc2qDQgBm9RgZdJly9JJsLNBpjWjeD4Lx48U/tZ47Xoh+CQvVr1m0+25NfyLO2WrHKnRiTvV3nkCV7+tTsq+jVkSh8IBxS/fxnswClgM6J64Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YAwgOkWH/27wmJiOpLNpUf4V2DvvzbbxAHbnAvIIc1s=; b=gmmwD1PDIm6L1ZolCl3Chpzy0OG9JWReNXi9Pfzx3OyGp49w23/LrUcmY43XpOwHlZmB9dw9WajLbzQjICLL+EVahSr1OgasoA+tlB5S3JdC8FRtvIb/NUctbcUSXM5Z/UAnQUuLTx15z8MW6KpuVisPTdnFxUWk6K/TlV+CxCk= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2991.namprd11.prod.outlook.com (2603:10b6:805:db::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 02:55:02 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 02:55:02 +0000 From: "Chiu, Chasel" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" , "Ni, Ray" Subject: Re: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Topic: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: Removes redundant InitializeAslUpdateLib Thread-Index: AQHWHc57/CfTOzJZvEaDf2267/8bJaiQ+dnw Date: Thu, 30 Apr 2020 02:55:02 +0000 Message-ID: References: <20200429023203.37544-1-miki.shindo@intel.com> <20200429023203.37544-3-miki.shindo@intel.com> In-Reply-To: <20200429023203.37544-3-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f48424cf-f5f4-4964-3dde-08d7ecb1e13b x-ms-traffictypediagnostic: SN6PR11MB2991: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:83; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(366004)(346002)(136003)(376002)(39860400002)(66446008)(966005)(7696005)(107886003)(86362001)(33656002)(4326008)(66476007)(76116006)(52536014)(8676002)(66946007)(71200400001)(2906002)(5660300002)(55016002)(316002)(9686003)(8936002)(186003)(478600001)(66556008)(64756008)(26005)(110136005)(54906003)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OVVAod7vKiOY6cTWaH/epKnEfBrMVbNcIQMiqSbJPQd1YbAztwWSeFqIMPhqWgK3QKsQsLgDX9wJmdfqQxj7L6JQMYRCznFCM0OmaUDmiXsozhB3WJFkaNsvoGBp/1EyVKdt/dRAcs57Ok8nb+F17/eev2nFB3xjGgclh0KTKI6hSkscK70qJZgy9mv2EMrsXaJ0cRO64YX0wis3DLeU7CrrH6YzvO4MUVVt9SlxKVKRhIVNFAkN59ofKQ3p1NWJZOM0Uf/FAPGLU9rODoM7BdqefcGDK6YuNltLlJDyJDpPXi/c6/ZxCdiJsQ2eKwmd8QkF+C5615rPVfj4JdCIzbq/JHDZiNJ3U/cSqQYMGp3L1jRpi0Yi0NyvAAIXk8DDkofKcFjUkw+ge/qqMye7VNKtva8eqwKV7vMP6T1A0hQjv7z1H5ZNBhFY2u6/NJeh3q5RrYx7HZ5/0jZVr2s6UtgTPLlXLWkI69INd/+VGkSRk27jJ28hw81y/cgYgyRoRzLS1PZVr/KoO7O9IuS1Xg== x-ms-exchange-antispam-messagedata: c/i7ydUepfvHuw896K6kxyUmmKfFqkLgNbGc03kXGSQw2gzwOhqigIx0wfbTCNmxBd3gLSv4KP8ltepyvXBVl4zdGCoeqbqxWI/s+9spE+Co131DoBU36GO4mvy1Kr6TAWMQrkJfFGGg13F4ULmHMvlcEXe3wOljWF6iRPFqNtdKfhcWFGJlz1N1OaksywUifj88eyNTNlx4HhzDTyWWfqjIHrRu1yWlS6NHTOtPAynUOYRsgwqKWLLEhQK3oAMg6wYfRgkZJ/zK0p1v4w/NfpTfwsuxaYG/q1xs9LRTOZDfllu4nSw9VllnDaHb3W0/LvRTWVYq3NV2WkJ7EqSiX3M6CoWmnJ5gS2wzbi71l++6krhH/fWfbtkGK26/oQWEm+xcGo+JmhPvGxjuJD/Q6sBo7vvPCBB7VDqTsUQuoZIKRfaEwOUtUM8n/c3OROW0cuDwK2ZDPLAAns/VFODUYUz9r5HwUg2JnrHqHvtLBHLGhqKata1Tk0XGglPrnIuzZjACw5mfLWlGRyWcHo91Xjl+npCPN4ZTx33M8ov/HWuuYGJNm5vQa0iakUfhyCsvPtl4RD/1gUIyuokSJDdYMF9OXRrIsgzZsXhevFLjaM0h8LYItoKNru54uR3L2vG7DxvC+vXaZX+pgs9lzYF+9Ip5qyupWSwjNgTeziiFTCjboxwJH2yiBKZcQSzEGbXfQ6AxJPxP6lFadiPGfqg53wMBt9TXqM4HhqTPBPRuCWZUglA1JVaXwWvgn+d8+PSETYSteUQmDHcHm2iIhiIUjTNMjjps8M8LPoedq7pHc/xITxoPSsxADw4qKamkB/w/ MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f48424cf-f5f4-4964-3dde-08d7ecb1e13b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 02:55:02.6428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1o4zFY9mroNKgxhECspPHqBcUWpPlZvrCbwIfzQpL1PFqv0J+6IBI7BTZyvOjqmoS3tLyrVd9YnoDi7bquE+sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2991 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Shindo, Miki > Sent: Wednesday, April 29, 2020 10:32 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > ; Ni, Ray > Subject: [edk2-platforms:PATCH v4 2/7] KabylakeOpenBoardPkg/TbtDxe: > Removes redundant InitializeAslUpdateLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2536 >=20 > This commit removes redundant InitializeAslUpdateLib call as > DxeAslUpdateLib itself calls it internally. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > Cc: Ray Ni > --- > Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c | > 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c > b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c > index 13a687576c..d101f4bb75 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDxe.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Dxe/TbtDx > +++ e.c > @@ -1,6 +1,6 @@ > /** @file >=20 > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -125,9 +125,6 @@ TbtAcpiEndOfDxeCallback ( > UINT16 Length; > UINT32 Signature; >=20 > - Status =3D InitializeAslUpdateLib (); > - ASSERT_EFI_ERROR (Status); > - > Address =3D (UINT32) (UINTN) mTbtNvsAreaProtocol.Area; > Length =3D (UINT16) sizeof (TBT_NVS_AREA); > DEBUG ((DEBUG_INFO, "Patch TBT NvsAreaAddress: TBT NVS Address %x > Length %x\n", Address, Length)); > -- > 2.16.2.windows.1