From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1364.1587713732103812315 for ; Fri, 24 Apr 2020 00:35:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jK5ZQ7xF; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: chasel.chiu@intel.com) IronPort-SDR: olu2ni0gmcd/wxz7/oqDoUoAJADTseKwg4aK08Z3RzrtlDQXqdH0PSCfinG1r+2fVbgtHUXoIv pG58GrjVM6+w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 00:35:31 -0700 IronPort-SDR: h2KwGFHpEbup412dREyL+uIFVhNoAvJqZsUzwOzxqCDOqiUjNGm7IZaeZMbvaYE57zrMxVp4tD iC1Z7zSX049A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,310,1583222400"; d="scan'208";a="280721952" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 24 Apr 2020 00:35:31 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 00:35:08 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 00:35:08 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 00:34:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwBDw2+uAkKwpwRIYXKdPjZHqgCaKnWml1mgvhrsu+3pWH6t5zdLKQU+gRLIEJUU3PmDEukdrwBxgNE0nxIj1u/atOPeaVxtbUE4UL/0n3mC5rKA5aMq+9P553bQyYn6reFC5BSTp/0I/+QC5yEl7OV7KlvAcY4CTUi4OpB7YkCjDThe9IxtVyZb7fdbGJo8r8MEyd/ex1s0G8RS8yq22EcSe4yJHGCtNGp1xJAP0Q7WruqI31Fl8vlVXDFChumMZnmKyEYQH30dVxm06Ta1R4RCii69ckg3si+/KImS1qBMd1vk7yMey+jVr/HAWmecVWE+xS1Hkc4WMMMqYABOhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zAZxUyD88dd6T2A5cIDwWgAyE25roUsbjv34oV6x9w8=; b=YsAxx4kj8qjQqjhVlPxKPdFpWRRWRkzeHCaRPByDwfg3HQAabv8LeK3xQ4IqMMTxYK0yX14dz73ThucFE9HCsUYVM09J/NFZH9hGqOByIILZj0/WGml1sJaa8A+HYM0ZltADt/WlLMFiTdad11LrnOiEmjYG672ka2znMi24/rDY+aS3IhiPcjFHzbV9IzHjs/pbCQv7/5KG2krClWLm8VxgBIj77ci+69/AgJ0wEDrZVNOXa0ppwfiFiZRxHy4zC/6apYIU1Cw2/+fsrVmWCs5ZKh07IW0qugfiFpb6/Jk+UXthnaWu8PVROSHoJM/XT30AhH37tO0sXd0TMGghog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zAZxUyD88dd6T2A5cIDwWgAyE25roUsbjv34oV6x9w8=; b=jK5ZQ7xFYgrMHwNqzKfWoDqGqFmJLTJUvIROTJszNZLb7QplrpkK9U2QDxvytlRht+SlGDkkJHcQpUhat/bVc7fdz0Bp5KA/EuaPmtry6dVmdjsEf/XMkuURqmsQf4qyCq8wKHpJTsBZjAc0Jeerl3mLPFmQvOUpVgxDRFy/Ecw= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3469.namprd11.prod.outlook.com (2603:10b6:805:bf::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Fri, 24 Apr 2020 07:33:59 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.2937.020; Fri, 24 Apr 2020 07:33:59 +0000 From: "Chiu, Chasel" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" , "Agyeman, Prince" , Michael Kubacki Subject: Re: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Topic: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS Hook Dxe Driver Thread-Index: AQHWGB0yOCULhNb8X0utXZ3vTfUMF6iH06cg Date: Fri, 24 Apr 2020 07:33:59 +0000 Message-ID: References: <20200421204028.10410-1-nathaniel.l.desimone@intel.com> <20200421204028.10410-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20200421204028.10410-2-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=chasel.chiu@intel.com; x-originating-ip: [220.129.96.77] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c8e5df3-ec96-449f-0fa5-08d7e821dad0 x-ms-traffictypediagnostic: SN6PR11MB3469: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(366004)(396003)(39860400002)(136003)(346002)(376002)(478600001)(71200400001)(8676002)(76116006)(81156014)(186003)(9686003)(5660300002)(66476007)(66556008)(66946007)(64756008)(55016002)(2906002)(86362001)(4326008)(66446008)(52536014)(110136005)(316002)(8936002)(54906003)(966005)(7696005)(33656002)(6506007)(53546011)(26005);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZJygNuewvdRN9+aZbX1LEf+bwdHJDhhET/ubnIcP1StZ65/15slFuWxsJf9CTVrqAQuAiuQjMSFlJL7gzmqAJS/iFmTnrfymswxBeP3SmqmBgr5nHjDgjOOJ55CXeeJ76iJJySZZ6j60owdjFj9Roci5Z5O9vniAVnTgY0wgyT6HnTh9kG/rg5u3bw3iOftowJb1roezFsPU2S5hK9Q9FnS/5G9EeNSoe78BH39ixzwDxEYhUoRibmw5uZKW4SW8dYBiYOMDkOXq6KbMOfoTvqhndaSPTeg918FnrY1dV5Dhbsh1KfkjFDPaxXJ3PXrTS8ndAEwrYqSNdbbs9GxLAt3hhcSNxMuFvrDKA3BnRCbXMh5dIFFrVRU6Gd8+25Uv7tMLUbTqu+VILWV1h4vyHozeP4Bg1aght6m9BKNM0TSozEm7s6+uAdDpetrj6Hz/Zp3iyQg8hxG7GlAklZc3hIl8Y5s67sr2Nd65IWdd2wJgfPy86FtgvsvqEOEpQOK10AyA86FYaxBZ/jdXm8bE0A== x-ms-exchange-antispam-messagedata: +jaM9+Zcer4aGqpMfRsBcF34VL6e0Skle0D5tnBGBcGBVr9+mli5kDjFAPnJ1AfxU4lWC3qf752NcfUhMFzHohROQbeA29nnvdsjobmqO6lXf5RyBJeRxEhgTMrzdjwJxsAxZt+SIVFOTHgtL8XOeQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7c8e5df3-ec96-449f-0fa5-08d7e821dad0 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 07:33:59.7868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: moIio673YVXNMrTKGIiuhaRevMaGRTvZOG2F0fVLvuH7l0fxErY8+GnBTFwTAbOk+5H/KOwgTiJgC1wkAlH34w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3469 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Wednesday, April 22, 2020 4:40 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > ; Agyeman, Prince > ; Michael Kubacki > > Subject: [edk2-platforms] [PATCH V1 1/2] CometlakeOpenBoardPkg: Add BDS > Hook Dxe Driver >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2336 >=20 > Added a DXE driver that registers the minimum platform BDS hook points, t= o > WhiskeylakeURvp board. > These hooks are triggered on the BDS hook events >=20 > What was done: >=20 > * Included an instance of BdsHookLib and BoardBootManagerLib from > BoardModulePkg >=20 > * Included BdsHookDxe to register the callbacks implemented in BdsHookLib >=20 > Signed-off-by: Nate DeSimone > Cc: Chasel Chiu > Cc: Rangasai V Chaganty > Cc: Deepika Kethi Reddy > Cc: Kathappan Esakkithevar > Cc: Prince Agyeman > Cc: Michael Kubacki > --- > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 > ++++ > .../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf | 1 > + > 2 files changed, 5 insertions(+) >=20 > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d > sc > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d > sc > index 14e82ba34d..958a2d0c50 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d > sc > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.d > s > +++ c > @@ -224,6 +224,8 @@ > ####################################### >=20 > DxePolicyUpdateLib|$(PLATFORM_BOARD_PACKAGE)/Policy/Library/DxePolic > yUpdateLib/DxePolicyUpdateLib.inf >=20 > DxeTbtPolicyLib|$(PLATFORM_BOARD_PACKAGE)/Features/Tbt/Library/DxeTb > tPolicyLib/DxeTbtPolicyLib.inf > + > + > BoardBdsHookLib|BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHo > okLib > + .inf > + > BoardBootManagerLib|BoardModulePkg/Library/BoardBootManagerLib/Bo > ardBo > + otManagerLib.inf >=20 > ####################################### > # Board-specific > @@ -452,3 +454,5 @@ > $(PLATFORM_BOARD_PACKAGE)/Acpi/BoardAcpiDxe/BoardAcpiDxe.inf > !endif > BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > + BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > + > diff --git > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > index e2d40bcbb6..31f4d22311 100644 > --- > a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > df > +++ > b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.f > d > +++ f > @@ -346,6 +346,7 @@ INF > MdeModulePkg/Universal/Console/GraphicsOutputDxe/GraphicsOutputDxe. > inf > INF MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > +INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf >=20 > INF ShellPkg/Application/Shell/Shell.inf >=20 > -- > 2.26.0.windows.1