From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.4797.1603337297984152230 for ; Wed, 21 Oct 2020 20:28:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=edOwTQJ/; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) IronPort-SDR: BcpZ9F43bLvPP7U3dEd7/APZcGWDGq7/5cI3ig7eWOkMyxCA4t9lvVjTdRFMyFR/n75og/KUyx Sjamm22XbT1A== X-IronPort-AV: E=McAfee;i="6000,8403,9781"; a="166686130" X-IronPort-AV: E=Sophos;i="5.77,403,1596524400"; d="scan'208";a="166686130" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2020 20:28:17 -0700 IronPort-SDR: fkRqzHhl0sMr86yP2N0ucNmgFGu9uL+FMk3kUUs3ozphX8sEXL5Bd1nfKXHJmizw0uojxdziLp 2R7NW+skN0ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,403,1596524400"; d="scan'208";a="348574944" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 21 Oct 2020 20:28:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 21 Oct 2020 20:28:16 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 21 Oct 2020 20:28:16 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 21 Oct 2020 20:28:16 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 21 Oct 2020 20:28:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jLZfoVclxyLlYgdiTwU1680NUiAK5T/BRUbnKar51oBUbBhd/HgM3feuxT9jax0fzZrfKGEmsodXULQDhGyzw6wR63tIidhcvJ19WomAAR3zvHrr0fQDeqoplUl6Cq1UKR+2DcEiCOb7fbiQDoaoSx7FmPZEI+ooNFQJLoeDeHi9Z0O4kDr+XmpsJd1vi/ANjzeM/t6pLLKD2cOboyBxMG0lvGcca+X+q5N0T+Xr7uelBH8NIkaLKVGIDJ9OupXsawL9NUP3qyaRBNSMy7gIj28vGKraDE4Po5pp7qE2RXVI5N2YY7I2JzIkEqn86oaewpd/bBGk/Sz3TmSeY89gbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6CuodReHSPWNC4zEwzInIw3f3jdS05wS5HwmfIBlb0=; b=OCrvghJ3DH6MM6FFPDp578PEyeBSsb84nI/JEKza5Qtb2LJ0Zkwaacw6Cm+Sv/Tqn6NpCsfU6l5bs7UV0jCBoPT+g2d88dE/7JEx4BS6g+B20hS3CVzWs/hfE7SMrzKvIyjs/W/0J4M0VYTSiVll9A4ji7iwEW1auTU+Nm5koD0bS6snqZnenKL3Kl/nTova4QfOisHubKd7F8RcHwG43JqYf2RfiGBe6imEZPZ0y5kWyaQs95z4jaTdbLKH8+biH850ItqAKMEoSreH0bgcWqBuOMlfxrvbGdlPZ3/g64cpt6RAIzvnj6/m5MB800TMcPYFtJuJEehxnakSW6dPFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q6CuodReHSPWNC4zEwzInIw3f3jdS05wS5HwmfIBlb0=; b=edOwTQJ/DS0dJNNWjqiBWPV+LX7mGlknmrhQUFQ12DFQVv6Qanyh0gs631dY2/WBJ7PhCCFJI9TG+A0+1uMXmk9Yl9u2CMz8pgOlwjcxXFUMsodEpFzIrFAuWvwC6t5lRHXIE6Pro9ytenDVyMrJPMyLbHYV7bNAwulLPz6tsgk= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3216.namprd11.prod.outlook.com (2603:10b6:805:c1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.23; Thu, 22 Oct 2020 03:28:11 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82%4]) with mapi id 15.20.3477.028; Thu, 22 Oct 2020 03:28:11 +0000 From: "Chiu, Chasel" To: "Lai, Cosmo" , "devel@edk2.groups.io" CC: "Lai, Cosmo" , "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Topic: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed with padding in FV. Thread-Index: AQHWqB5Mheh+HqZjUkubbSb5DBmU5Kmi70ZQ Date: Thu, 22 Oct 2020 03:28:11 +0000 Message-ID: References: <20201022025127.1136-1-cosmo.lai@intel.com> In-Reply-To: <20201022025127.1136-1-cosmo.lai@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [180.217.154.123] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5a98d73-fc8f-4c54-40e7-08d8763a80f7 x-ms-traffictypediagnostic: SN6PR11MB3216: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:403; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C0xQp9FigfC/ktn6IIXyI4XKCP2LH/bPGwc5qxSvmCuNIzBuCAL/xzQiD6UJf7LiNWAycX4OCod2by+X4j2OC3l/MCFUOoHWhHMD029FESns04Wo3J0+fwcSt9NcHSZOtjbuel+HvXS0zhcqiOKTs7W6oSRO1yQlNRB+4Q6w3Owd3LMbm/za2SA/m00CrsmsdSOPXkc7/z5Uv7dQidNq35F5tYoZ9/NHppQDWxVklwsLqS5jUS2fUkqPVs8SkWtEEYhkHKJ/xZBIN9ZxLn/oPVgcn9dcRD8Ncsn+lbIrFk2MwZXzBslLuGnhUyACwZzTJT69yklyh+JIS3JzUnMlqY8YRnYBigM9VAapCNwXodoyp57WU/KQYPYnMp54QQLCTgb2gdL9FwAI0Kk8wlk3tw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(39860400002)(396003)(366004)(9686003)(66446008)(66946007)(4326008)(186003)(64756008)(66556008)(83380400001)(5660300002)(71200400001)(966005)(7696005)(107886003)(53546011)(6506007)(19627235002)(8676002)(52536014)(8936002)(33656002)(2906002)(316002)(76116006)(66476007)(26005)(55016002)(86362001)(110136005)(54906003)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 38E47yqjUp378hJpWmF9/s01mIK/WT+9/xVbDMzQoliU87WVLEQilf249LjB/YetWwRi1ZA90jpnVDoqYd/Sgrrta3YptGirLdu2HozRVub2nCUNHjxu7P8kZUYUdQPxzOF0IGZjU5MhRFpulh3kA6xbM4jQ+91kQaOYcUSh2vbkrvLjmn2fxgI5f4Es0ViT5l4oFjVyf1G1A81fx+IqfizDVJQmTLS+RGiwZu1TAoXgjgpI1KmCI9t2bfNd4AjUhz1JyKJWQDosqkTFxT2dgqhw2h0ia8QnH4wOPiFJ13slSmgviEkerw/4Gx1V4rmRV4EsIdWErM7448j2FP6Ta/S6wpAP8WCSNpzchOsJanLsTc4MgGXMQFhamNh/6TjrwpDUvxphzfsdvExWV5+JdCjRT/kc4TMtWguk4DPiCyOl/2KTTBIb0AvgH4dhXOIjRQwwwHl9XWZ5Gc/9c9FvxndIYSK33Y7HcExAQgX19WZScskVDjKvuDngSd6jbsyrB0WAZqNdvN5iwIQiyiY2jNIs1f9mYreF+iPgqeWqciSbi2SfKyjLZ2RXpVjYuh0dYG4S/RD35MkjTrSdeuwpNwBcBkmdhNElHuUCMBg4tAWrMjlbx5q32G+SVihPI8zV4oV5sgdvLk2VwU4lDnmbQQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5a98d73-fc8f-4c54-40e7-08d8763a80f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2020 03:28:11.5034 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: digS+I8ruUA3G0l52xVBsPtxub3f8HMHYbDyXZ0NE4GJYwd+EmyonfaiqDGe9892FiCNJe5G1gO3By6Qtq43MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3216 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Cosmo Lai > Sent: Thursday, October 22, 2020 10:51 AM > To: devel@edk2.groups.io > Cc: Lai, Cosmo ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > ; Chiu, Chasel > Subject: [PATCH] IntelFsp2Pkg/FspSecCore: LoadMicrocodeDefault() failed w= ith > padding in FV. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3017 >=20 > Platform microcode FV may have padding between each version of microcode > binary, and current FSP-T/LoadMicrocodeDefault() cannot handle this case = and > return not_found unexpectedly. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Chasel Chiu > Signed-off-by: Cosmo Lai > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > index 7934eab6d7..7fd3d6d843 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryT.nasm > @@ -307,10 +307,6 @@ AdvanceFixedSize: > add esi, dword 1024 >=20 > CheckAddress: > - ; Is valid Microcode start point ? > - cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > - jz Done > - > ; Check UPD header revision > cmp byte [esp + LoadMicrocodeParamsFsp22.FspUpdHeaderRevision], 2 > jae Fsp22UpdHeader1 > @@ -341,6 +337,10 @@ Fsp22UpdHeader1: > jmp CheckMainHeader >=20 > LoadMicrocodeDefault4: > + ; Is valid Microcode start point ? > + cmp dword [esi + MicrocodeHdr.MicrocodeHdrVersion], 0ffffffffh > + jz Done > + > LoadCheck: > ; Get the revision of the current microcode update loaded > mov ecx, MSR_IA32_BIOS_SIGN_ID > -- > 2.16.2.windows.1