From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Loo, Tung Lun" <tung.lun.loo@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue
Date: Tue, 6 Apr 2021 09:09:40 +0000 [thread overview]
Message-ID: <SN6PR11MB2814E39F7CF8D7872BED9967E6769@SN6PR11MB2814.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210402023212.1591-1-tung.lun.loo@intel.com>
Hi Tung Lun,
The fix looks good, but please help to re-send with correct patch format.
Thanks,
Chasel
1. remove Change-id
2. cc all reviewers/maintainers
3. add bugzilla link to describe the issue you are fixing.
4. enrich commit message to describe the fix.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tung Lun
> Sent: Friday, April 2, 2021 10:32 AM
> To: devel@edk2.groups.io
> Cc: Loo, Tung Lun <tung.lun.loo@intel.com>
> Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue
>
> Change-Id: Iad50d68a93ea1da13c2264fac7229f2d540531f0
> Signed-off-by: Loo Tung Lun <tung.lun.loo@intel.com>
> ---
> IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py
> b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py
> index cad9b60e73..5e94e86db5 100644
> --- a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py
> +++ b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py
> @@ -291,7 +291,6 @@ class CFspDsc2Yaml():
> raise Exception('DSC variable creation error !') else: raise
> Exception('Unsupported file "%s" !' % file_name)-
> gen_cfg_data.UpdateDefaultValue() self.gen_cfg_data = gen_cfg_data
> def print_dsc_line(self):--
> 2.28.0.windows.1
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#73635): https://edk2.groups.io/g/devel/message/73635
> Mute This Topic: https://groups.io/mt/81794616/1777047
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com] -=-
> =-=-=-=-=
>
next prev parent reply other threads:[~2021-04-06 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 2:32 [PATCH] IntelFsp2Pkg: Fix multibyte array data issue Tung Lun
2021-04-06 9:09 ` Chiu, Chasel [this message]
2021-08-05 22:10 ` [edk2-devel] " Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB2814E39F7CF8D7872BED9967E6769@SN6PR11MB2814.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox