From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.9518.1617700183731538365 for ; Tue, 06 Apr 2021 02:09:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=L1iwsgTn; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: chasel.chiu@intel.com) IronPort-SDR: r4z6S3RfK1YW2TUd0IYQUYjy2pZSgBK6XRPbLTRU0z3MVsmOdy53lHbeqy3wYK6nX+dHX7TPda 8/JOGKhLJy8g== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="190856066" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="190856066" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 02:09:43 -0700 IronPort-SDR: 9dSrrjSbfG/Ln//fnJ3Z0QBYsnchAUrovAO0aPSk2qSA0HgfPr0X31f8YIWYShhWZEh0iia2hb V1fFNXZXXazQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="597876676" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2021 02:09:42 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 02:09:42 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 6 Apr 2021 02:09:42 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 6 Apr 2021 02:09:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Asbvh6dax4HsLf/IdtCrumX0YvzxUV122vxqMQGAdfnvjpLNVIynChS7I2eIYNgpqkMqtbBTkpCKeDVbHAyMdqVjeP7MYw7s+6mMYmZ6p4GIc1DZFcF1pqtsAbn4BEk2YEosK1QnyXvqWn7OfEF9+qY5PE8CwWAPRqQ2pQj3rJr50MFniiXhjR2J83Kg8IzAhkjbIvu86rcjpsepJ6moJawEUqLFFCQtwkL1IXVC/c/XpmBPAsEbthHsAfFp1JOJD+2G62foJRC2B2W7cYbuA4oUt3ybHFbddTVuvsgyaB94gaLTEjozptY59Gl0/eqgD+BBv7fQjRlwE3YVMADyyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYa9mlLsKjjqS3n96d3i/RLjA2yN71T89ge1bxZubJM=; b=DMiLVUvjDZ6aEwKTxyxvoc/Qsh/3z/t+iPLNwS0vnuWY+79yQeo8IY5suM2oNnygXZo3s9fUS6Y0q5HyIISULx+ZmuabazqnZKqtynxhtSPJdkavEC4jgeIojDCesJm+modOJ0bUO48TVOEPcVCGG5YDlk7x3R/xoGGaoYkys+YJa3wtDIJv9U4cr/4qKy+saDE0NmK/VQmEXKQDAIjVUDJJs8cIYAoLxgPEXJIcjjKaRUZyhDswNck2cwUaAWvp1kuHv7nLwA2L4i2AP6Rxz4SFJZZP73Bim7oDPXOeEltX3sQJcZG5txjlsmzjMCNMeySe66kmCxhRt0b7Q3ULjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yYa9mlLsKjjqS3n96d3i/RLjA2yN71T89ge1bxZubJM=; b=L1iwsgTn/G52VpX7PvbJaobQowT75XOD+F+4TlMKZv82XHBGr71qN4LKYW3sU58jypJR2yfJqOpwICpknorENNs20Yx2Vynlk3kZKJ6owgFmVHfk59P75mMi8CjaxS0E0x7xGWqzCGuAekudrYI+l421P+I+CzK1WI4Z5B7DRFc= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB3309.namprd11.prod.outlook.com (2603:10b6:805:bd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 09:09:41 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816%7]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 09:09:41 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Loo, Tung Lun" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issue Thread-Index: AQHXJ2ht0xAN4KzS5kuyaM7jyFVuaKqnN0LQ Date: Tue, 6 Apr 2021 09:09:40 +0000 Message-ID: References: <20210402023212.1591-1-tung.lun.loo@intel.com> In-Reply-To: <20210402023212.1591-1-tung.lun.loo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3081fd2d-c0dc-4e32-12a8-08d8f8dbb625 x-ms-traffictypediagnostic: SN6PR11MB3309: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: klQ22J+6oZPGkkI2ty/+D67SvCVMAZpLNH1sxoddVk+zeVwOlJRJn/drRi53VQ3ivacsQ9CMsVk5i1soACjCjVvQD6QfLs24eT20ihofIkVCOYUVi9m5WNBQUPbeJ/nDrvA979wcdDvocjf/k6Ilg1zv8/ciuwmktCVFkP8+cfKN2WZ3YWH7BA/jRJj30mYj/roIc1w3bF6EtAdEmDzhphc+xU89qcSJZE+lpoBAi4sfFQcI0xzHfwYItZNkvUFAcTrym/I3K/76siIS/fmsbXvJO/bOkioUE1Of9RiBoZidp/CQ4zZWOOfsHXTSoRIW6BwOMZny8ZMJdR8iiBhrD9c4CeBBLugP1A4iaXqBRnMztLAP7ctiYznRLL60eX5OLjxA6iatC8avj0GgD2n0f0r9e8pHQ6D3LHcKZPPU59t/3VcCJiOkEjI0uthJgCzKKT9CWTYyfgFuqGh728jHJLiohK4wqyuMC2n2HpPe8StsngwYcGULtDnTvibtnxjJan/Dgn6tiNSQrJycnv6wUCTQvcO6F8VDDab4EfStTCIAN3kUst91/RwJURzjk08KdHm51kKXiN+8AzD0Ym64uQwmUiH2lkvogpHg4QvKC4X1hyXsMy0TIGtsZp/lB+O/ypAU+/fO269f1IIpgmiOx3a+rzNtdhclpPRQbXje1SjGYeA2tvqtEEB8agjUip0bBpECMPBuHlrwNmTRfX5pmj0ZF2XojkEossNdXbxhtKoq54+7+WYoTwai7GyhpjGM x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(39860400002)(136003)(366004)(66946007)(316002)(76116006)(53546011)(8936002)(86362001)(966005)(66446008)(5660300002)(83380400001)(71200400001)(66476007)(52536014)(6506007)(64756008)(66556008)(26005)(2906002)(6636002)(8676002)(186003)(478600001)(55016002)(9686003)(7696005)(19627235002)(33656002)(38100700001)(110136005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?lR6BZqc3/Hw0Pbe1aFs79/Y5HZzdvGXCrTCVyMtx/qjaw7urF7L+DYH8qyoU?= =?us-ascii?Q?8c5q8Xe/20C5FQzDVJKGYnOowUv0IHj1krdg7Bjn30v/4wP4zF0z9QLR3RBl?= =?us-ascii?Q?v7d5Tn+WDDR2/lAYuhiuXbYL63lI0dBRYP0sfbHlCGYoWmoXMpGduvHTL1CV?= =?us-ascii?Q?4KSPNtBg5i3wMg+xO5ia7SxARKX6MW9XkNKGydDqaB8yf5d8HadjSMVdbZ8J?= =?us-ascii?Q?0MWs47hXcjkM1HbC9olcM378iD+pCm7mkenm2KcvSVt6A/PepELHlp/3MHgA?= =?us-ascii?Q?p/fIADd6Y5bjfzst7E1IEz0hgXA6l6VK1qeC2SITjSItT6mHFGTSy/TPOuSx?= =?us-ascii?Q?Grn0F8ptqWfGwe4FQgBvp2/aG/6HrC7GROWw6Z6XbcZ+EAxq/Tm01JI/zoEn?= =?us-ascii?Q?eku3N8yG+FPpi9Ot4F9IP2T5cWsGpFOH75l/uKIxIC4UDk1OJXHPKDv0JBho?= =?us-ascii?Q?uZbFwdYNMNiXLhvvAsl4pnNEWQEI5Sc402umJfAeG42+eIl5cafF+930HePT?= =?us-ascii?Q?Mf/RfR2Iucr+rrc4235NXTOd9yBr1pn6+eRRhIbCVTXkZczZLBvGb/Xflhxf?= =?us-ascii?Q?yiJjOjIOufuZI2UFTkdRMeScp+ebyQVVAd/xpWeolDL8WEvOLlWcVPjY4nzX?= =?us-ascii?Q?RvTghEuadiMaFKuzWmog2yuLVPpHxfPDgbnDoxQaSk3ynkWPeNEN5h6y76Uq?= =?us-ascii?Q?2Z86eS87tTBfXSMWQjQxES12ejkooKEfZgqpIcPOhrd78xHcX6+vot98WuwY?= =?us-ascii?Q?nxyXmX1mb7u92Hye8kafUshqaoq678rVU/pdMaSP+uqf2pffBqQ++3SYuDjm?= =?us-ascii?Q?6PX63GTjP+wq0EA4ot/ISCuUMESekd2L4il3OHw7zm03I3uvmqkioav6fwQF?= =?us-ascii?Q?huzwKmHRoJ1nUZRXlt3/3goG8h+BLeRHnJA6RcaueQjYGfUw++EflNNd2PgF?= =?us-ascii?Q?Z1dMCfRsrQzzjNvFZa8Iz1OD7yMajUyji7uqR5l54ozlF1uPZvWYPAeePApx?= =?us-ascii?Q?XIeCPHAfpcYiCV6FSwWWaTafPH57UWInPIij0imUfxONWr/mZclFpaNRoPLl?= =?us-ascii?Q?D6yhQPmSh9ewFJ9xQhZcQ5HC2yzG9vJKhSa24vDICay5qhiYALRfPVi/D3BN?= =?us-ascii?Q?nOaQe1T9aaMQjcC0BWLiREI/2M53Oak71+RYmctrfqjyM3rDY8tbfnBhVy4D?= =?us-ascii?Q?yBix6gB2fyU4gSFDCAsFwPxLRdCd/qJJ+cH+nQWQkm+P7ZUZOzV75MB932OJ?= =?us-ascii?Q?PEcaBP0XBeGMMCVKRfoZbjAkj86MzMxvGdDnjXHtfwm5fNzMNevPGKcQKwWP?= =?us-ascii?Q?mhOsu93Q/HLWzWM9u/ZUDlob?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3081fd2d-c0dc-4e32-12a8-08d8f8dbb625 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 09:09:40.8785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hb8tHqjU3NUYFZ55MTQQWf/o5fUtW8kiwXS0rhP9zr/deRyBwUXSgEDMb1d29YoqST0f5Uja4NLyMWmX0836UA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3309 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Tung Lun, The fix looks good, but please help to re-send with correct patch format. Thanks, Chasel 1. remove Change-id 2. cc all reviewers/maintainers 3. add bugzilla link to describe the issue you are fixing. 4. enrich commit message to describe the fix. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tung Lun > Sent: Friday, April 2, 2021 10:32 AM > To: devel@edk2.groups.io > Cc: Loo, Tung Lun > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix multibyte array data issu= e >=20 > Change-Id: Iad50d68a93ea1da13c2264fac7229f2d540531f0 > Signed-off-by: Loo Tung Lun > --- > IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > index cad9b60e73..5e94e86db5 100644 > --- a/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > +++ b/IntelFsp2Pkg/Tools/FspDscBsf2Yaml.py > @@ -291,7 +291,6 @@ class CFspDsc2Yaml(): > raise Exception('DSC variable creation error !') = else: raise > Exception('Unsupported file "%s" !' % file_name)- > gen_cfg_data.UpdateDefaultValue() self.gen_cfg_data =3D gen_cfg_d= ata > def print_dsc_line(self):-- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73635): https://edk2.groups.io/g/devel/message/73635 > Mute This Topic: https://groups.io/mt/81794616/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com]= -=3D- > =3D-=3D-=3D-=3D-=3D >=20