From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.722.1589328562187613029 for ; Tue, 12 May 2020 17:09:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=rxhk1/pO; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: chasel.chiu@intel.com) IronPort-SDR: jloyJxrtYDINW6iOXrLCjUAlUk+clOcC3t15lhqB28SDhTM5Yna06YJ+iAxgI7t9J5G4MzYU4G ooiYCIvmnsJg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2020 17:09:21 -0700 IronPort-SDR: l8bzzFKJd3D/2UU3dq2rIaswafpyqFMNlB/IUJajDMtgRUqJ3deSrNhrnwBCafMKynIX/gWfn5 VlDtYUugvJNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,385,1583222400"; d="scan'208";a="463735334" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 12 May 2020 17:09:20 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 17:09:19 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 12 May 2020 17:09:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cAmnZPjNU6SocNy6efMyR2Vdfrh7PsenPk5P1DtzQ+0LGQeje32LfpykkEQJgJrjLK8tCuPEtRqI5dHMp5W93KHrg9NWaZkwSPY/JENjZ+51uG0TDzgQvF5eqK18kfcGxU4r4RvOTysC42pNrF83Pd5NgtcDX1Q8ls624ScYF0xHAyFkw0Il8lIJWa6Wbx9+aiQqN0ixRf0KGbA81+02+N+2hRKyYsc3cxZJD1fYgI4HoGOuC2xnFLUhPBqVCYSM6xZjPK1iVlLsM5yQR1lSB7xCoRxHfmBmn8KzrjV5PASWQzwRfFCuHjF5XcQfvhDL4bGa3pnV/uPpL2MG7pAmZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZpBBP1RCYwPAVfmz1tXpEWogHiaV1G/RZu+sBX+wFs=; b=ejrYO2iYCXhmxLwnLgunkc0zCEkkgNX5NhBkI50Ji28BNdvIOgn5ie3CAf0diLuApRJsn/TWgR/zlyVg14iP+uD8bME/S8lLdMZNHDrkMhpLZZD0SOn7Ipz1j8jzAXoOoC3iGDRVswor+kBjpCa4lL0adnHRPvaaC6h0cHzu3qAFu8ntZ6ngzy4AKyoPNf5pDon9qno27kowwwe9YVaOkkki9k2B5UnOWClegqZefy0WZkKydRk+58HPKLf+m+jmD/Fjat1xYkRw+wzG0ctDy+Y7crXRIyoXnBYq8ySAMpXQI3l3aElbbEWUUUKCdS7Wdzi0BiSNrpvU8+oMcwuoJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WZpBBP1RCYwPAVfmz1tXpEWogHiaV1G/RZu+sBX+wFs=; b=rxhk1/pOWi57Fma3ursXn28vzUH4nDjrm61DmZGb4yQbGDAUmKHodYw2LqIaoluTQnaKOBgWLA3CeFQ6Ry/xsfx2imyoR4XvVShGF5HGsOrN+3E5FlpG6toLBbko5R13OpxVkLjcDjxnZ51+CPh4q+uW426YxfJAkauRU1XCNtI= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SN6PR11MB2766.namprd11.prod.outlook.com (2603:10b6:805:53::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Wed, 13 May 2020 00:09:12 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::152f:df2:6370:1584%4]) with mapi id 15.20.3000.016; Wed, 13 May 2020 00:09:12 +0000 From: "Chiu, Chasel" To: Vitaly Cheptsov , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib Thread-Topic: [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib Thread-Index: AQHWKH9IFgThOgFPOkekE8Y6Rz6BrailJG6w Date: Wed, 13 May 2020 00:09:11 +0000 Message-ID: References: <20200512170237.19796-1-cheptsov@ispras.ru> <20200512170237.19796-15-cheptsov@ispras.ru> In-Reply-To: <20200512170237.19796-15-cheptsov@ispras.ru> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: ispras.ru; dkim=none (message not signed) header.d=none;ispras.ru; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f16b1ee6-9949-49f5-271d-08d7f6d1dd7e x-ms-traffictypediagnostic: SN6PR11MB2766: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gCJ33jrBlZ4gzb1zuZlk1WZ31+7Y76N36cFFRW7ep15aTB781qUZoMp1an+JJZMNxc6+zxDmrGpN+6UEb5CWu8mjU/t4eP4uOHnwznyKXj02pHrgAIfyZqlIFuOlL9ctCyr2axg2cv8SZCLTQV/bpq0adTLpcaVF1AcoLutmPqkyCvGULbQnXSm4FW+nG42WK5hL/dphRTIDrsOBvUJUjyYSxwaxoz6ash0ScEBqykBt3DxjOfDLVgd4dwuVo/dBkb+JRA9FZlZ89hf7VdEFZuD/95kSWcLowCOzsSDnMKN0W7/bm290dJI7YbjYn+M50qr2K03jJKQvhAo0jxaAyMw0rs55EV1DsMPhBwBXr5Emmu1hrm8QN1YzWjubRqiHr6ciDXTYx3JCDXNoWTtQwcEpffBmuKfvK+/Hc2iqDa0kS+bjesVS8s8OrvPDJRqyXvDAbQEh3+DZQj+X0szvd48XAVXT8X2zXRuE7T2I1pA47ze2/GP+CgVDiEy0Z6RHK6BWpM2xWIG0SDJASNLiobMA4e9uQhPtFRBbHV19AX2P3hljQmNoKMvlGJ/Nv0Rtm8ZTbMlf500DUCX0PdZewHgSvt0u2GTwQwe+0C9/oo4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(346002)(376002)(136003)(366004)(396003)(39860400002)(33430700001)(7696005)(5660300002)(186003)(66946007)(966005)(53546011)(66446008)(6506007)(66476007)(64756008)(71200400001)(33656002)(4326008)(26005)(9686003)(55016002)(8936002)(8676002)(478600001)(107886003)(66556008)(52536014)(33440700001)(110136005)(316002)(76116006)(86362001)(19627235002)(2906002)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 7kq9194t+Na9MzMFnYsEeDUdYjT6Gda1jcLmdhVh229iL1xwAHQaniDmwdR+gtHAkUrARLJx3teeIG+AXqMoGIt0Xk0UWr7HjIL/RhvohizRs31qP3DCzsJTm8hQEBSPsLXTjvZOuE1gF3XRZCJk/OGr6/XXwZ8Y8/BUKemJ0YoEfHwxXNFRm470+iAcDYtXj+/Z7bRRjHGBDQT47rGadC/qGxylKZt8B+d2fWoMHUhtOphQwOzNYIa1PM4qaklMhBOEVBJJgyKWRN+HfQ3oBL60rOh58E+rREYb3B7jpBIpZfm6oUVdp+G4zQVF33kxJAydDwXPTYQb8taAXavzhts9YSNRo1ZMPEe2CEsDGqSybhaUbVGxosUOkhX1R3MHJ8NKRVoebEsg9Wf7oKKkrZrP5T88JSlm6TRgtIgijXkOUYIjJfdcm74hacZBlCaeBTmo+r9aU3Ak2n3FHuQymSyQdxhkz2c7iM8B8mPw2SuIcvQUxRG9zC/DpmwN1cIU MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f16b1ee6-9949-49f5-271d-08d7f6d1dd7e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 00:09:11.8955 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Nx5etANTrMRaiv+Z001RJBoTutVAldzAhCvbwWtGiyGMcnhNqPhlwqJf9O+9aIDyb9xMpAnxsVrBrwmymWIoMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2766 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Vitaly Cheptsov > Sent: Wednesday, May 13, 2020 1:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2054 >=20 > CC: Chasel Chiu > CC: Nate DeSimone > CC: Star Zeng > Signed-off-by: Vitaly Cheptsov > --- > IntelFsp2Pkg/IntelFsp2Pkg.dsc > | 1 + >=20 > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPort. > inf | 2 +- > IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > | 97 -------------------- > 3 files changed, 2 insertions(+), 98 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/IntelFsp2Pkg.dsc b/IntelFsp2Pkg/IntelFsp2Pkg.ds= c > index 02fe9cb188..3b2d2a5b8a 100644 > --- a/IntelFsp2Pkg/IntelFsp2Pkg.dsc > +++ b/IntelFsp2Pkg/IntelFsp2Pkg.dsc > @@ -21,6 +21,7 @@ [LibraryClasses] > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf+ > DebugCommonLib|MdePkg/Library/BaseDebugCommonLib/BaseDebugCom > monLib.inf > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/Base > DebugPrintErrorLevelLib.inf > PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf > IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.infdiff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > index 14b1899e6c..9198118106 100644 > --- > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSerialPo > rt.inf > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/BaseFspDebugLibSeri > +++ alPort.inf > @@ -35,11 +35,11 @@ [LibraryClasses] > PcdLib PrintLib BaseLib+ DebugCommonLib DebugDeviceLib > DebugPrintErrorLevelLib [Pcd] > gEfiMdePkgTokenSpaceGuid.PcdDebugClearMemoryValue ## > CONSUMES gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask > ## CONSUMES- gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel > ## CONSUMES diff --git > a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > index b34905365d..f2e1de8822 100644 > --- a/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspDebugLibSerialPort/DebugLib.c > @@ -316,100 +316,3 @@ DebugClearMemory ( > { return Buffer; }---/**- Returns TRUE if ASSERT() macros are enabled= .-- > This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED bit of PcdDebugPropertyMask > is clear.--**/-BOOLEAN-EFIAPI-DebugAssertEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_ASSERT_ENABLED) !=3D 0);-}---/**- Returns TRUE > if DEBUG() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugPrintEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_PRINT_ENABLED) !=3D 0);-}--/**- Returns TRUE if > DEBUG_CODE() macros are enabled.-- This function returns TRUE if the > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of- PcdDebugPropertyMask > is set. Otherwise FALSE is returned.-- @retval TRUE The > DEBUG_PROPERTY_DEBUG_CODE_ENABLED bit of PcdDebugPropertyMask is > set.- @retval FALSE The DEBUG_PROPERTY_DEBUG_CODE_ENABLED > bit of PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugCodeEnabled (- VOID- )-{- return > (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_DEBUG_CODE_ENABLED) !=3D 0);-}---/**- Returns TRUE if > DEBUG_CLEAR_MEMORY() macro is enabled.-- This function returns TRUE > if the DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of- > PcdDebugPropertyMask is set. Otherwise FALSE is returned.-- @retval > TRUE The DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is set.- @retval FALSE The > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED bit of > PcdDebugPropertyMask is > clear.--**/-BOOLEAN-EFIAPI-DebugClearMemoryEnabled (- VOID- )-{- > return (BOOLEAN) ((PcdGet8(PcdDebugPropertyMask) & > DEBUG_PROPERTY_CLEAR_MEMORY_ENABLED) !=3D 0);-}--/**- Returns TRUE > if any one of the bit is set both in ErrorLevel and > PcdFixedDebugPrintErrorLevel.-- This function compares the bit mask of > ErrorLevel and PcdFixedDebugPrintErrorLevel.-- @retval TRUE > Current ErrorLevel is supported.- @retval FALSE Current ErrorLevel is > not supported.--**/-BOOLEAN-EFIAPI-DebugPrintLevelEnabled (- IN > CONST UINTN ErrorLevel- )-{- return (BOOLEAN) ((ErrorLevel & > PcdGet32(PcdFixedDebugPrintErrorLevel)) !=3D 0);-}-- > 2.24.2 (Apple Git-127)