From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.800.1619397765889756475 for ; Sun, 25 Apr 2021 17:42:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=J0X+9D2p; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: chasel.chiu@intel.com) IronPort-SDR: ocIZV5R04MixnG9TfoQ+A5tfYFqLXDX0NcsSHDNa2hEYbkhBBV1/MUaZwfL1Ap5baELsFyTzJY sAC9XQDMeQyA== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="281593484" X-IronPort-AV: E=Sophos;i="5.82,251,1613462400"; d="scan'208";a="281593484" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2021 17:42:45 -0700 IronPort-SDR: WeJRF/2P/h2W/6xhBHDy2rdlqAeY81AOrzs23GrKjE0ikzxAFhMty/eguGbSCmFuU7UVMutHlp m4GA2T1ZxVXg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,251,1613462400"; d="scan'208";a="456912061" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2021 17:42:45 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 25 Apr 2021 17:42:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Sun, 25 Apr 2021 17:42:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Sun, 25 Apr 2021 17:42:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kj06Ez/z/gUqJcoz4q1hxHnCxuVYzp8bkEMBRKq1StteSAOvoAFRM+CDwjLZEyqEvWYnh5lPeQzq1bWQAnP8cEag4KmI9D/TU0LPTaMuXYwtixFFVeiG2XpkuhKkhBck/nAQUCJXvjRyeqTcA6h3e2xEHpFZLUWKgfwLm5RKdT8+y0mf59rQ6JG5wZCvlYbWTYv9j5pEXfBQEgr/8nhnfbJk/aM0lZ87oF1nu9GQgYMsBuUgrJRzb5ObrGAtODBS+Qz1Xuuw/gmOT0dKe1K3osNRzZBCvPvZCSB8KTPsH9WHt+o3VgIjB5BVGCoP3Ze940BOmJ7El2yuYDs8Js8lNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wXkfuIQL80ME+QrSpFmf4gW9MZoLMhZlIdxGTlUpxc8=; b=KmPB+DwjnPCWlipuyHtIuzFcCNNhw0MLmQb6CG/SG/BKLRIQoJ6xrg/YqtCFnEV5a1HhCI6ZkIOToB+AC3XnBSSml7tSLw1uy4W00yhGGXCTn0hnz2VRp8C+d/YIbw9P3l+Vu2GIEifHiGFdxyb4q2ScMgKL6hoeTzx1JWfRqvK4QI35oUtFaOZA77aFghe21ZHWzq+UMN63pAPq64SJ6HXRlT4OUzG91HmKqiVbskvPFSJ1o+h73XKcDR32oSQLFJbFnfvLPc3t6NgtoDf+5IXIIVT5Y2DK9EI3eBs5KD3s4B9S3fhbd52QDeDXacZiilKJ9xhDe/wjBbJojHB2Ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wXkfuIQL80ME+QrSpFmf4gW9MZoLMhZlIdxGTlUpxc8=; b=J0X+9D2p8sU+8M3mCXVoI0rZ3RPoBtl8EJXRa4+IQRDx/TlbrIxGrb22VW1OgIm8RQEHFxFA/G4PKpw61eb6bk9pylXvejc0cVnaLV3lMXs10o1d77KiQoGMPrt3Sg25+jhjicowmHCSg+283Z7hVWTbyvONblsNsb88Q7nKFMg= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA0PR11MB4688.namprd11.prod.outlook.com (2603:10b6:806:72::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Mon, 26 Apr 2021 00:42:42 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::3101:f483:8348:816%7]) with mapi id 15.20.4065.026; Mon, 26 Apr 2021 00:42:42 +0000 From: "Chiu, Chasel" To: "Lou, Yun" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Zeng, Star" , "Ni, Ray" Subject: Re: [PATCH v1] Intel/KabylakeOpenBoardPkg: Simplify microcode related PCD usage Thread-Topic: [PATCH v1] Intel/KabylakeOpenBoardPkg: Simplify microcode related PCD usage Thread-Index: AQHXOeEgN97LzzPZh0Ctde9fcCttdKrF9liA Date: Mon, 26 Apr 2021 00:42:42 +0000 Message-ID: References: <20210425144137.16411-1-yun.lou@intel.com> <20210425144137.16411-2-yun.lou@intel.com> In-Reply-To: <20210425144137.16411-2-yun.lou@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 064c9546-1a50-4517-0b6e-08d9084c339a x-ms-traffictypediagnostic: SA0PR11MB4688: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /CakgXsWR/ZMUMWrZFaeVWIybFieEx6QDH3xt5Jw6A0kCocqR7dEOu4f8ipyowT0M7Sz3P9mV5CN1ht1+CruSRfBTFLVn7T6WEyjrg91cuc5JuC/AfWiwQ6zjrS9Xna2dy7LS5/Vz4qdnwo0GAN0feUeC/3bDckBBJFjsvwWUH9NRT/ldyZle6a+1Y6WxKtTpWQbXW7NGurdgx09M607Zuzt5ZEy3xdcqwcr3QqaiAiTc5umtlJun/KbdpbwQ8iRYN7NT1PjyMH3VL9F2TTokCvfZeiAlzvfhtvPblHCW8HDkN0XFOjlFIGlklu8xRdAdMbTjxi8tRDWs7QZGE/nGJuYwFF9m2053vGUAxVLfmX9HGdEaGp2IO6U6VNhAkVLrMuRybelqdsLsznEs2G6j/PH0H2cjnsx5AsDPS0MyZVinPvQUnRYqIeL2kDY8+713j+zH4pV2gBCBshNxJFrXQE8Oa39exRXdomiapJcaPoWEFvXZMeNaweIXBdbQn+vy20Srpwe88MdeawUKOb1k2HTxRhuKiamXL9aKVaqXzQZzEYZ+i2QAXHsaaJam+zdlNrJD9DZB57eL5QLq4oBA3VddFb/Q15OdvoIJK765qvWJ88KzScczdfaZEfG9YddWYHS7JCTyMFgEcQ70T+Gq40duMX9YAatQVn8nm8oGAct3tkjvPCzXMF1Ps3kwYRF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(136003)(366004)(376002)(346002)(66556008)(33656002)(83380400001)(64756008)(66446008)(66476007)(66946007)(5660300002)(55016002)(86362001)(54906003)(53546011)(6506007)(76116006)(26005)(122000001)(38100700002)(4326008)(2906002)(966005)(110136005)(71200400001)(9686003)(316002)(478600001)(19627235002)(186003)(107886003)(52536014)(8676002)(8936002)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?n9Tw8Vr0qZ0ffVE+99NeXGMB/7ekWxfJs0P3TyHiQQeGYcudOsMNYgv8xCx1?= =?us-ascii?Q?SpthiCZDlM4BMbAUay4G2vxarEhAmcDZ/jNdGYG9a3XcRx+JF2b+hIufztGS?= =?us-ascii?Q?Yo46WkgNpgSt0pxNc5MLCgBwYhKoNr0oJkCZ6pnAgNOECDOohoS3AHfy7znJ?= =?us-ascii?Q?mFzs3PouMLAk2iMWBCci/fpcbfRwsflqFpcIedK25mnsmXEHKlVzkKLB4txP?= =?us-ascii?Q?x/4oQqQSTppjt9lQIZw9AjOuhehv+nF6gYPalbpUiE2XOayHkBxmJZA958Ly?= =?us-ascii?Q?veDOTLmzRcC0P+v+j3i9jq2i+hGUu1WaKj3CeBzTZMUSW8xqh4YM6WkCcKce?= =?us-ascii?Q?AA/D6833YGXNzF+Cpfaf/JRk/r0h2wh1AbtdMwKG/ppikVPprm+5SiOsu2kQ?= =?us-ascii?Q?C5TZLvPOMIUBsZztPYtZH60QyGDgvZQUamLwJcvzjXYqZAohenq/BM2wFYQV?= =?us-ascii?Q?GokR2au4gUcaN9Zd4cGAt1aDx51KrxXQaHzPfIc000TYX2qbZhMZ+fCXP0ZJ?= =?us-ascii?Q?hc8NrSX3/x00/JzGdtKFgabZCfn1sUDru1Ko/K2OG5rkZqQX2MiJHnca+Fzd?= =?us-ascii?Q?DBIl8rCW/7FEw1Q+NVUV2FiRt+P19w9sGarSW1Y8ZGeY92s9FOkLImMOWXXX?= =?us-ascii?Q?nn9sMU3AhhEHQI0MnLbvooPJ3pigD2059jOlJBrbssJD7LIXBEWPM+1vKUqa?= =?us-ascii?Q?kvlR5JY1XEAk5wiM1/ZEV/gqglHDsICwAH+B0cIFrQWkzF4Oktt+8TbJjf13?= =?us-ascii?Q?EnrRZqsXfalXORbk267thUXgNRLKyL/nZE/qlnRYIPFuf59qg5uByTJpnnON?= =?us-ascii?Q?brathcB0Rb/HfIWqHouwwc55jCEpymYZmI8LAFzSjKp+JnJ5MFRRoO92WlSB?= =?us-ascii?Q?YGEHDrUh7FWdiWAWCCaf+KSVLK9QwTqoJjWSLDAf30TVI74v8M2A7Rpp1SVg?= =?us-ascii?Q?nsmSfp3qgj4JZyiEBOO4e0RXrB+foxA2qRfGa5EE5jDDTXyXajlQqnkIOY2o?= =?us-ascii?Q?5vZhhKqmfukHkd9x3ba9aRPDx+3TMQ+g/UWp2bNvF3ypL4KmaHN7cf0UWH4N?= =?us-ascii?Q?9IXNoWCp5dYwP6lGgQiJ4t4QXKjce9qa9vUw1kweeKujjBJbujTZXKhU0g6h?= =?us-ascii?Q?oTn7Ba/NjTNfEw0Zu6I7vkAVg+ya1A42vXRcY/VNDbWRjDtN7IO+FB+phZvK?= =?us-ascii?Q?yiXBLDg11npCYXfuZQeMnwCeMAvqZfzHICivn+s/pE9FfxSvLp0iiM14lB0h?= =?us-ascii?Q?bVktFCxAuBMrvnpfTgJXxvjKOllFJkHnyXit3jdJyxyqdaiyqCGqbO67L+zg?= =?us-ascii?Q?gQVwG31HIpwlpL96W4EZqZAJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 064c9546-1a50-4517-0b6e-08d9084c339a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2021 00:42:42.4566 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HEnBql09DLg3jv5OkVFkS7FQnr08y46oXqHY8DCn/VZ3d9Mlr27Ps+VowIDdNbcu2pGvfLsCLQK1k0Tqmdu9yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4688 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Chasel Chiu > -----Original Message----- > From: Lou, Yun > Sent: Sunday, April 25, 2021 10:42 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Ni, Ray > Subject: [PATCH v1] Intel/KabylakeOpenBoardPkg: Simplify microcode relate= d > PCD usage >=20 > From: Jason Lou >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3334 >=20 > There are following PCDs in IntelFsp2WrapperPkg for microcode location: >=20 > * IntelFsp2WrapperPkg: > PcdCpuMicrocodePatchAddress > PcdCpuMicrocodePatchRegionSize > PcdFlashMicrocodeOffset >=20 > The change simplify the platform code to use following PCDs instead: > * MinPlatformPkg > PcdFlashFvMicrocodeOffset > PcdFlashFvMicrocodeBase =3D $(BIOS_BASE) + PcdFlashFvMicrocodeOffset > PcdFlashFvMicrocodeSize > PcdMicrocodeOffsetInFv >=20 > Signed-off-by: Jason Lou > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Ray Ni > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf | 6 ++= - > --- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf | 6 > ++---- > 2 files changed, 4 insertions(+), 8 deletions(-) >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > index 196f04c68d..bcd1ade72b 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf > @@ -1,7 +1,7 @@ > ## @file >=20 > # System 76 GalagoPro3 board flash file. >=20 > # >=20 > -# Copyright (c) 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2019 - 2021, Intel Corporation. All rights reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -45,9 +45,7 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase =3D > $(gSiPkgTokenSpaceGuid.PcdFla > SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase) + 0x60 >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) - 0x60 >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdFlashAreaBaseAddress) + > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset =3D 0x60 >=20 > +SET gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv =3D 0x60 >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset >=20 > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > index f2cfff1c7b..6cdf4e2f9f 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf > @@ -1,7 +1,7 @@ > ## @file >=20 > # FDF file of Platform. >=20 > # >=20 > -# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2017 - 2021, Intel Corporation. All rights reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -45,9 +45,7 @@ SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase =3D > $(gSiPkgTokenSpaceGuid.PcdFla > SET gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase) + 0x60 >=20 > SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) - 0x60 >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D > $(gSiPkgTokenSpaceGuid.PcdFlashAreaBaseAddress) + > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D > $(gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize) >=20 > -SET gIntelFsp2WrapperTokenSpaceGuid.PcdFlashMicrocodeOffset =3D 0x60 >=20 > +SET gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv =3D 0x60 >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize >=20 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset =3D > gSiPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset >=20 > -- > 2.28.0.windows.1