From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.31970.1602470998768893748 for ; Sun, 11 Oct 2020 19:49:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=eDxRPfO7; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: chasel.chiu@intel.com) IronPort-SDR: VlNYyleETTD3QKBOM/d5g1rVtKTDgTOoMGujIWMUARPUJqMSyYAs8W2pbHNKoHvyqkmh+laqeL zal3gjhV0lMw== X-IronPort-AV: E=McAfee;i="6000,8403,9771"; a="153512805" X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="153512805" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2020 19:49:56 -0700 IronPort-SDR: 1vE4vVMaKcpa6Gy/WGiljhUQ5R8ufRhYf0/IJYtF0Do+8JyRpupaLJY1hTkxdp4shwdvD6/SDP 42U1tIyoOHdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,365,1596524400"; d="scan'208";a="355647454" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 11 Oct 2020 19:49:55 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 11 Oct 2020 19:49:55 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 11 Oct 2020 19:49:54 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 11 Oct 2020 19:49:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fgk/gxE9vMOf2yN64E6HdMnshWBozqksZwq191JXVs+XFmVH2cMC+cx/QXzvtDmYI6sh08swRPtK4QuLpuZW/C8/mxVeotKlnxszTybSI09qtgAxrdc+jZ4a2QFhcddVtePyNHdrrMppcN7HYdYikZBgCcKdssgtBxAXniw4FPUk1GwVerb75z82l8sHRCX3fMYZEh7FWxiREQ4RE8lhLv8hJYbn+941Apa2ZI9ASX7q+6GB7a0EV/X9YS5AZdgNuoP1uBeGkLKn27bs1kwkk+rpFEtBnEKIS7ISIl7LeDVtK2rS+fuemCtZMDtNLM8h6r5VGXnwL8RtaZS8gojwlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2oi5tXuOIRic25j5BV8WaL5S/mM58aKPsmCqG8QuIw=; b=Go2aZTlAh7MYKsHbsh1GMouneF3Rus0e4gSUgXxeOCRfxgeZ5AONQjDqiesnJSjd65ylCSxz/S2DxZAMeFHb9BfMmaCPzPV+UOlfjPK5ZYf/TSB9B9JJ6O90vKlVdUp44TulFsz2xMKYpUa6iYWq4ZG/3nBzSR37Rz4ZBR+DdQ5MpWk2YnzcDl95faIiuyAQkL0MOEZr/KKpUbNtP3J1sqeNEVgG+7l5HlnySe+ZuNplHESAj1yQ5vgRuUjMqXI5H5Cyb9KsKHDsk+PINqiHg9HusVT8oOeCmLncIuraQ5LCr/9XDaA7nT6hxqDl+OvyI81YwVauZb8OKPSwDTOZhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F2oi5tXuOIRic25j5BV8WaL5S/mM58aKPsmCqG8QuIw=; b=eDxRPfO71VzGsAaOIKzrMQWno/rTwIoOvv3VwuapGK7sXtt3EtpAiTqTHrjO2CHrDtnh1TuK0GED+CaoPNKDGKfzYS4fN02NW4Zo/2t+S4jTu9t5nT6V+PqvUXE93gK8iw5ceBj4a6wAwHQK38JO1Tp3jQYvzAcDAuUiFKvviCU= Received: from SN6PR11MB2814.namprd11.prod.outlook.com (2603:10b6:805:55::15) by SA2PR11MB5099.namprd11.prod.outlook.com (2603:10b6:806:f9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.28; Mon, 12 Oct 2020 02:49:44 +0000 Received: from SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82]) by SN6PR11MB2814.namprd11.prod.outlook.com ([fe80::4540:a6b5:b0bc:9d82%4]) with mapi id 15.20.3455.028; Mon, 12 Oct 2020 02:49:44 +0000 From: "Chiu, Chasel" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Ma, Maurice" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt: skip unnecessarily header/BSF recreating. Thread-Topic: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt: skip unnecessarily header/BSF recreating. Thread-Index: AQHWl5g809S8aMJyEkKnnbUYADWOZamTVVzg Date: Mon, 12 Oct 2020 02:49:44 +0000 Message-ID: References: <1639BC6A4CE669DC.21977@groups.io> In-Reply-To: <1639BC6A4CE669DC.21977@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [61.60.205.141] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29a595d1-ab20-4d50-e4e2-08d86e5979c0 x-ms-traffictypediagnostic: SA2PR11MB5099: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:366; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6pBIsFBOi0W0igTz7SAzb/El3wK7tFKETTiv6qHH2KfgRt1uJk66CY/jOXZKmZvd24+yFAjP8QzguFM5UCNROD7CIHgkkWcl6OfLyHMTRvN1NIIRqUarZ7idtKozhU7zlvPCRbDLIqIgKwy/VmrFYbIuHfz2Xd+nrwrAke8ZBdCnD218HsGTGikl35czLloZvydRMSmEjEMZozoaFYm8oMXJXbU0xsGx6KnCC+lz0MsM5ZvePpJX0NqVOHqDOHZl0sMjUvS2NmLrQpgDDh1bpixJtKdph9w8J9UW5qBMVkY/go8jJenhwtyxTMpB+n/Ge2l/+n8bxjbWt0Bipt6bduS9Hxuzw68Myx9oR9RLuilH6O64iNiT28Znj17iwBpe8jmpvNqAcPMOR+MxV7Yx5w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2814.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(136003)(366004)(376002)(39860400002)(396003)(71200400001)(316002)(52536014)(5660300002)(19627235002)(110136005)(7696005)(9686003)(107886003)(54906003)(55016002)(2906002)(4326008)(8936002)(83380400001)(66946007)(8676002)(478600001)(86362001)(76116006)(966005)(83080400001)(66556008)(66446008)(64756008)(53546011)(6506007)(26005)(186003)(33656002)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: O3yICOHFWFHHIvk8ZNiOwdHo8aY6isCCfeafKz1JZTH3VCB/Ga0JLizRMVH0HTCKTWNDjBHFowkgOL9C8wsdrYeALYe3U2Tr0bbyYpwXq/QLmwSaw1p6QSVAVPeUmJb5euND+/3KCbrTmd4ijXLWq0gkYbazgt75xD8OHSpREi5AcBgR0wbNVAJvefykYNGNtG58ftV9TBkgYRAHYDVdrE24Ps7kVhPGwXr4NCMHpe+z43R/6+jpD2WfHVNIpYIqOlYq95HLgOkNkph7OhMTaSfziwWrg4q729RZgMUqX7aXdd1ejYJeR5Ccr+10hS9H4JR4pw83x0XgJGgUrbRlPKBbhBL/llZq9OvBC53FgNUAM6cRTQLA7+XecZmAVmaZPflIg8fSwEkirBEztL7jS0cEMnPwbx3/obitZ4Mp85r4NWrH/uUi1ch+xCv3hpZZJlhYntKQaKyVZiteL4XBzoOmNqPWSF9Nj0Ws7rzJvMFvVHsMPhCbR/HowtjuIu32McWIkCet5MgdD/p+rkZboEgooUGyipzMPdc+/YrIBOl1xhCkf3jbiZvpi6bd9MDFPmLh2hVneYo76VDoE3jDz2sJES2XXnmAsM6KZygvII/SpZAt/JixyOx1ZYbhYoTlY0+wh91fhgocGAp/9cXR/Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2814.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29a595d1-ab20-4d50-e4e2-08d86e5979c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2020 02:49:44.4695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TeC1i6VIqVD9yUTO6IrVcqU7NomuZNVCunkTqFG+Qmj4nkAnfsqBaC5/SMNitvMJqJ+UdFlEjuLR956uJ0L2Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5099 Return-Path: chasel.chiu@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Change push: cc942105ede58a300ba46f3df0edfa86b3abd4dd > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Chiu, Chas= el > Sent: Thursday, October 1, 2020 10:12 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Ma, Maurice > ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/GenCfgOpt: skip unnecessarily > header/BSF recreating. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2967 >=20 > When no change in FSP UPD DSC files, GenCfgOpt.py should skip recreating = UPD > header and BSF files. > This patch added a check to handle this case. >=20 > Cc: Maurice Ma > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Tools/GenCfgOpt.py | 60 > ++++++++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 42 insertions(+), 18 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py > b/IntelFsp2Pkg/Tools/GenCfgOpt.py index bcced590ce..af7e14a10a 100644 > --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py > +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py > @@ -810,6 +810,17 @@ EndList > SubItem['value'] =3D valuestr return Error + = def NoDscFileChange > (self, OutPutFile):+ NoFileChange =3D True+ if not > os.path.exists(OutPutFile):+ NoFileChange =3D False+ el= se:+ > DscTime =3D os.path.getmtime(self._DscFile)+ OutputTime =3D > os.path.getmtime(OutPutFile)+ if DscTime > OutputTime:+ > NoFileChange =3D False+ return NoFileChange+ def CreateSplitUp= dTxt (self, > UpdTxtFile): GuidList =3D > ['FSP_T_UPD_TOOL_GUID','FSP_M_UPD_TOOL_GUID','FSP_S_UPD_TOOL_GUID > '] SignatureList =3D ['0x545F', '0x4D5F','0x535F'] # _T, = _M, and _S > signature for FSPT, FSPM, FSPS@@ -823,16 +834,7 @@ EndList > if UpdTxtFile =3D=3D '': UpdTxtFile =3D os.p= ath.join(FvDir, > self._MacroDict[GuidList[Index]] + '.txt') - ReCreate =3D Fals= e- if not > os.path.exists(UpdTxtFile):- ReCreate =3D True- = else:- > DscTime =3D os.path.getmtime(self._DscFile)- TxtTime =3D > os.path.getmtime(UpdTxtFile)- if DscTime > TxtTime:- > ReCreate =3D True-- if not ReCreate:+ if (self.NoD= scFileChange > (UpdTxtFile)): # DSC has not been modified yet = # So don't have > to re-generate other files self.Error =3D 'No DSC file ch= ange, skip to > create UPD TXT file'@@ -1056,7 +1058,11 @@ EndList > HeaderFile =3D os.path.join(FvDir, HeaderFileName) # Ch= eck if header > needs to be recreated- ReCreate =3D False+ if (self.NoDscFi= leChange > (HeaderFile)):+ # DSC has not been modified yet+ # = So don't have to > re-generate other files+ self.Error =3D 'No DSC file change, s= kip to create > UPD header file'+ return 256 TxtBody =3D [] f= or Item in > self._CfgItemList:@@ -1382,6 +1388,12 @@ EndList > self.Error =3D "BSF output file '%s' is invalid" % BsfFile = return 1 + > if (self.NoDscFileChange (BsfFile)):+ # DSC has not been modif= ied yet+ > # So don't have to re-generate other files+ self.Error =3D 'No= DSC file change, > skip to create UPD BSF file'+ return 256+ Error =3D 0 = OptionDict =3D {} > BsfFd =3D open(BsfFile, "w")@@ -1467,7 +1479,7 @@ EndList > def Usage():- print ("GenCfgOpt Version 0.55")+ print ("GenCfgOp= t Version > 0.56") print ("Usage:") print (" GenCfgOpt UPDTXT PlatformDs= cFile > BuildFvDir [-D Macros]") print (" GenCfgOpt HEADE= R > PlatformDscFile BuildFvDir InputHFile [-D Macros]")@@ -1529,13 +1541= ,25 > @@ def Main(): > print ("ERROR: %s !" % (GenCfgOpt.Error)) = return Ret elif > sys.argv[1] =3D=3D "HEADER":- if GenCfgOpt.CreateHeaderFile(Ou= tFile) !=3D 0:- > print ("ERROR: %s !" % GenCfgOpt.Error)- return 8+ = Ret =3D > GenCfgOpt.CreateHeaderFile(OutFile)+ if Ret !=3D 0:+ = # No change is > detected+ if Ret =3D=3D 256:+ print ("I= NFO: %s !" % > (GenCfgOpt.Error))+ else :+ print ("ERR= OR: %s !" % > (GenCfgOpt.Error))+ return 8+ return Ret = elif sys.argv[1] =3D=3D > "GENBSF":- if GenCfgOpt.GenerateBsfFile(OutFile) !=3D 0:- = print > ("ERROR: %s !" % GenCfgOpt.Error)- return 9+ Re= t =3D > GenCfgOpt.GenerateBsfFile(OutFile)+ if Ret !=3D 0:+ = # No change is > detected+ if Ret =3D=3D 256:+ print ("I= NFO: %s !" % > (GenCfgOpt.Error))+ else :+ print ("ERR= OR: %s !" % > (GenCfgOpt.Error))+ return 9+ return Ret = else: if argc > < 5: Usage()-- > 2.28.0.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#65775): https://edk2.groups.io/g/devel/message/65775 > Mute This Topic: https://groups.io/mt/77232193/1777047 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.chiu@intel.com]= -=3D- > =3D-=3D-=3D-=3D-=3D >=20