Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

["Sukerkar, Amol N" <amol.n.sukerkar@intel.com>]

Hi Mike,

I have no issue with generating new GUIDs.

Thanks,
Amol

-----Original Message-----
From: Kinney, Michael D <michael.d.kinney@intel.com> 
Sent: Monday, February 03, 2020 2:50 PM
To: Sukerkar, Amol N <amol.n.sukerkar@intel.com>; devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Agrawal, Sachin <sachin.agrawal@intel.com>; Musti, Srinivas <srinivas.musti@intel.com>; Lakkimsetti, Subash <subash.lakkimsetti@intel.com>; Mathews, John <john.mathews@intel.com>
Subject: RE: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

Hi Amol,

I prepared a branch an GitHub PR with this content.

The EDK II CI checks found duplicate GUID issues:

PROGRESS - --Running CryptoPkg: Guid Check Test NO-TARGET -- ERROR - Error Duplicate guid:  DDCBCFBA-8EEB-488A-96D6-097831A6E50B (2)
	GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: HashLibBaseCryptoRouterPei FILE: /home/vsts/work/1/s/SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterPei.inf
	GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: BaseHashApiLib FILE: /home/vsts/work/1/s/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf

ERROR - Error Duplicate guid:  0D3FB176-9569-4D51-A3EF-7D61C64FEABA (2)
	GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiSecurityPkgTokenSpaceGuid FILE: /home/vsts/work/1/s/SecurityPkg/SecurityPkg.dec
	GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiCryptoPkgTokenSpaceGuid FILE: /home/vsts/work/1/s/CryptoPkg/CryptoPkg.dec

I generated new GUID value for the CryptoPkg Token Space GUID and a new GUID value for BaseHashLib.inf and restarted the EDK II CI checks.

Please let me know if you have any issues with the change I made:

    https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLib_V9

The GitHub PR is at:

    https://github.com/tianocore/edk2/pull/328

Thanks,

Mike


> -----Original Message-----
> From: Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Sent: Monday, February 3, 2020 10:55 AM
> To: devel@edk2.groups.io; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Agrawal, Sachin <sachin.agrawal@intel.com>; 
> Musti, Srinivas <srinivas.musti@intel.com>; Lakkimsetti, Subash 
> <subash.lakkimsetti@intel.com>; Mathews, John 
> <john.mathews@intel.com>; Sukerkar, Amol N <amol.n.sukerkar@intel.com>
> Subject: RE: [edk2-devel] [PATCH v9 0/2]
> CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API
> 
> Thanks for the review, Mike!
> 
> ~ Amol
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael 
> D Kinney
> Sent: Monday, February 03, 2020 11:36 AM
> To: devel@edk2.groups.io; Sukerkar, Amol N 
> <amol.n.sukerkar@intel.com>; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J 
> <jian.j.wang@intel.com>; Agrawal, Sachin <sachin.agrawal@intel.com>; 
> Musti, Srinivas <srinivas.musti@intel.com>; Lakkimsetti, Subash 
> <subash.lakkimsetti@intel.com>; Mathews, John <john.mathews@intel.com>
> Subject: Re: [edk2-devel] [PATCH v9 0/2]
> CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API
> 
> Hi Amol,
> 
> Thanks for the updates.  They all look great.
> 
> Series Reviewed-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of
> > Sukerkar, Amol N
> > Sent: Monday, February 3, 2020 10:19 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Yao, Jiewen
> > <jiewen.yao@intel.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Agrawal,
> > Sachin <sachin.agrawal@intel.com>; Musti, Srinivas 
> > <srinivas.musti@intel.com>; Lakkimsetti, Subash 
> > <subash.lakkimsetti@intel.com>; Mathews, John
> <john.mathews@intel.com>
> > Subject: [edk2-devel] [PATCH v9 0/2]
> > CryptoPkg/BaseHashApiLib: Implement Unified Hash
> Calculation API
> >
> > Currently, the UEFI drivers using the SHA/SM3 hashing
> algorithms use
> > hard-coded API to calculate the hash, for instance,
> sha_256(...), etc.
> > Since SHA384 and/or
> > SM3_256 are being increasingly adopted for
> robustness, it becomes
> > cumbersome to modify each driver that calls into hash
> calculating API.
> >
> > To better achieve this, we are proposing a Unified
> API, which can be
> > used by UEFI drivers, that provides the drivers with
> flexibility to
> > use the desired hashing algorithm based on the
> required robnustness.
> >
> > Alternatively, the design document is also attached
> to Bugzilla,
> > https://bugzilla.tianocore.org/show_bug.cgi?id=2151.
> >
> > Amol N Sukerkar (2):
> >   CryptoPkg: Add CryptoPkg Token Space GUID
> >   CryptoPkg/BaseHashApiLib: Implement Unified Hash
> Calculation API
> >
> >  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c
> |
> > 333 ++++++++++++++++++++
> >  CryptoPkg/CryptoPkg.dec
> |
> > 26 +-
> >  CryptoPkg/CryptoPkg.dsc
> |
> > 4 +-
> >  CryptoPkg/CryptoPkg.uni
> |
> > 18 +-
> >  CryptoPkg/Include/Library/HashApiLib.h
> |
> > 122 +++++++
> >  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> |
> > 44 +++
> >  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni
> |
> > 17 +
> >  7 files changed, 561 insertions(+), 3 deletions(-)
> create mode
> > 100644
> CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c
> >  create mode 100644
> > CryptoPkg/Include/Library/HashApiLib.h
> >  create mode 100644
> > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf
> >  create mode 100644
> > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni
> >
> > --
> > 2.16.2.windows.1
> >
> >
> >
> 
> 
> 
>