From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.5563.1580767423752702898 for ; Mon, 03 Feb 2020 14:03:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=UUASQRkp; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: amol.n.sukerkar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 14:03:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="249140197" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga002.jf.intel.com with ESMTP; 03 Feb 2020 14:03:42 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 14:03:42 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 14:03:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VOLAWgawTugflb9/Wlp1wGwT6Z08Dn57WyYFP2gsJrqDklIvj2b2VOxT08jzGATyGAg+z0Y8cKTSw+3fCGXtefTSCWJR9ablxwx+fCMxhQ4NyWAbxdUCrCYnhXVOP8y7mqgcNNiTd0yEBCaoJi8PuZSQKVWxdJfd4fJXQwIp9cteBuamUNdM8zKX7jzVAjQuoa4aqK3KRivj76DHhG+ayJlpZTHGYheFKdL/KG7aT94AHLLuC281ywjGwgpi+XLCwenAzKZ8YlmBN6vlsWbnrU0YY8yjFqEkRtiQ20BrlXVPWllNilvJu3ZU4a+6taxsLm+NHbcKjgIOzbxcrhf0mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ojh6lG+KabIkGk1lGLkvY/3EGIqAvnCYU0RGkKnPRKI=; b=GzLOTERzJJsMAhddj/cCRC1zG8ZYc1Geti9g0+K0cuqXSXTgh00chDNgR1wovGzQaJOceevyDk03p8U/BAYCl+rxeiBhJIKf1gYj2Jo6Z7Ret/zp38uH91Cd91hrLlnFiLKivs3Qk1CaUP2qrGJspFAtC/0Mj/MV/UxWVEo45hAA4qs3GiieYWyWafKK2FVTsDTeI2ofo2hoMsXcXzjsHrlgi56mquZQKM+Z+SC6EdmTS2XiqVIiHixNb8Ay8OEH448MCC0qwIT/s7z5sZJxEEqveX/pXhpVGdTa1BXGJnfoxPsUMZrHgMa5rSFXr2vbOzGvt7reVI6d4iO6kmSilQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ojh6lG+KabIkGk1lGLkvY/3EGIqAvnCYU0RGkKnPRKI=; b=UUASQRkpW8iDBdPgeMp/sNitpiJ48k9AM0zSyF+abs2XlyhgqFIuwvvWi/L/4p46OLYtBRs4bkRBkZsNVgQVjtGCyqKAemPS5b5KGEjJ48mQ3Z5WOOF7zyXb+J9kQRP+UPlbZpqjsC/osyL+aabWvq+IhUxTfVId1Xbzpmiz0+c= Received: from SN6PR11MB2893.namprd11.prod.outlook.com (20.176.241.151) by SN6PR11MB3120.namprd11.prod.outlook.com (52.135.126.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.26; Mon, 3 Feb 2020 22:03:40 +0000 Received: from SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676]) by SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676%7]) with mapi id 15.20.2686.028; Mon, 3 Feb 2020 22:03:40 +0000 From: "Sukerkar, Amol N" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" , "Sukerkar, Amol N" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82QgAAFWpCAACy/gIAAB3QA Date: Mon, 3 Feb 2020 22:03:40 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=amol.n.sukerkar@intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d935c7ac-1815-402b-64af-08d7a8f4ed8e x-ms-traffictypediagnostic: SN6PR11MB3120: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0302D4F392 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(39860400002)(366004)(136003)(346002)(396003)(199004)(189003)(107886003)(9686003)(2906002)(64756008)(316002)(33656002)(26005)(966005)(66446008)(110136005)(66476007)(52536014)(66556008)(7696005)(54906003)(5660300002)(4326008)(81166006)(66946007)(53546011)(186003)(55016002)(71200400001)(8936002)(6506007)(76116006)(8676002)(86362001)(478600001)(81156014)(19627235002);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR11MB3120;H:SN6PR11MB2893.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8CbfVyOSzd0l6LMgy0y9sVtfjrFFUUBKNWHtzxykQt6LWgGlae7/eLyZH6WxUvpTEiZ3VUXfsTMwl7yYCc9WjvvM+LEWvFMGwQ+xTxNnnQUDQPFr0ynhEN7/OXI+lT/BvNWdFeIGy+CuIdxufcIh17CZg58Q4mWrIg9I3XCoUvahEgYHNolv7CRgcJD1YJCdked4nru0JDTqhvFIrrVoRAXM0U/0ZYKFz280nkmbp60TgAuI9Rns4imv5y5PNwnqV3mcGnAKWjpCJQe5LrMVcsdDje1PRGqnJBwPwgHu93eDHJvYNVojr1fs3fzPSXGycld8dnWAraWaTkF+TpcCgJLVI0uqIDplzUQIvL+6Mjki8HjOoCAGGjLfgIiTGIwg/dSExZRT//DpyXw6LxPqDj8OWcSdZKgWe7p1owKQxlG8fFlzJs/yjy+oU9yvkXF/JRY+xKdX5Q/11N6z3CtsggBYMg9F9g275EQkJuNfUO4vxMkIsYUFGYWNONbNw99jU8VdYAIubD4beCgT5j6gqg== x-ms-exchange-antispam-messagedata: 6eaa2xfNzy2KWrH21Nu+IgmEtM9/xkd33RgmnfA0nM02eE1XEvgS5oImxSRer++qST0KPKWK2gmjqxKT0Q5o/R44zer+C1BZcN1gWimZJ7kFia5hB/2jX1C27HjyfehJ+Jebim5VRyjI+4b5bq8jSA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d935c7ac-1815-402b-64af-08d7a8f4ed8e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 22:03:40.5164 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hMtKHNLDrMkDmGPUz2pKqAmlb+oOSOUXT0znZPFOMrTNFmUK2thYNzzisb3SFu24HieWiODCyyAZCOZtX8GkH/BfYeaV8z0QR+nfdPwPnVM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3120 Return-Path: amol.n.sukerkar@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, I have no issue with generating new GUIDs. Thanks, Amol -----Original Message----- From: Kinney, Michael D =20 Sent: Monday, February 03, 2020 2:50 PM To: Sukerkar, Amol N ; devel@edk2.groups.io; Ki= nney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Agrawal, Sachin ; Musti, Srinivas ; Lakkimsetti, Subash ; Mathew= s, John Subject: RE: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Impleme= nt Unified Hash Calculation API Hi Amol, I prepared a branch an GitHub PR with this content. The EDK II CI checks found duplicate GUID issues: PROGRESS - --Running CryptoPkg: Guid Check Test NO-TARGET -- ERROR - Error= Duplicate guid: DDCBCFBA-8EEB-488A-96D6-097831A6E50B (2) GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: HashLibBaseCryptoRouterP= ei FILE: /home/vsts/work/1/s/SecurityPkg/Library/HashLibBaseCryptoRouter/Ha= shLibBaseCryptoRouterPei.inf GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: BaseHashApiLib FILE: /ho= me/vsts/work/1/s/CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf ERROR - Error Duplicate guid: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA (2) GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiSecurityPkgTokenSpac= eGuid FILE: /home/vsts/work/1/s/SecurityPkg/SecurityPkg.dec GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: gEfiCryptoPkgTokenSpaceG= uid FILE: /home/vsts/work/1/s/CryptoPkg/CryptoPkg.dec I generated new GUID value for the CryptoPkg Token Space GUID and a new GU= ID value for BaseHashLib.inf and restarted the EDK II CI checks. Please let me know if you have any issues with the change I made: https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLib_V9 The GitHub PR is at: https://github.com/tianocore/edk2/pull/328 Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Monday, February 3, 2020 10:55 AM > To: devel@edk2.groups.io; Kinney, Michael D=20 > > Cc: Yao, Jiewen ; Wang, Jian J=20 > ; Agrawal, Sachin ;=20 > Musti, Srinivas ; Lakkimsetti, Subash=20 > ; Mathews, John=20 > ; Sukerkar, Amol N > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > Thanks for the review, Mike! >=20 > ~ Amol >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Michael= =20 > D Kinney > Sent: Monday, February 03, 2020 11:36 AM > To: devel@edk2.groups.io; Sukerkar, Amol N=20 > ; Kinney, Michael D=20 > > Cc: Yao, Jiewen ; Wang, Jian J=20 > ; Agrawal, Sachin ;=20 > Musti, Srinivas ; Lakkimsetti, Subash=20 > ; Mathews, John > Subject: Re: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > Hi Amol, >=20 > Thanks for the updates. They all look great. >=20 > Series Reviewed-by: Michael D Kinney > >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of > > Sukerkar, Amol N > > Sent: Monday, February 3, 2020 10:19 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; > Yao, Jiewen > > ; Wang, Jian J > ; Agrawal, > > Sachin ; Musti, Srinivas=20 > > ; Lakkimsetti, Subash=20 > > ; Mathews, John > > > Subject: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Currently, the UEFI drivers using the SHA/SM3 hashing > algorithms use > > hard-coded API to calculate the hash, for instance, > sha_256(...), etc. > > Since SHA384 and/or > > SM3_256 are being increasingly adopted for > robustness, it becomes > > cumbersome to modify each driver that calls into hash > calculating API. > > > > To better achieve this, we are proposing a Unified > API, which can be > > used by UEFI drivers, that provides the drivers with > flexibility to > > use the desired hashing algorithm based on the > required robnustness. > > > > Alternatively, the design document is also attached > to Bugzilla, > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. > > > > Amol N Sukerkar (2): > > CryptoPkg: Add CryptoPkg Token Space GUID > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > | > > 333 ++++++++++++++++++++ > > CryptoPkg/CryptoPkg.dec > | > > 26 +- > > CryptoPkg/CryptoPkg.dsc > | > > 4 +- > > CryptoPkg/CryptoPkg.uni > | > > 18 +- > > CryptoPkg/Include/Library/HashApiLib.h > | > > 122 +++++++ > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > | > > 44 +++ > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > | > > 17 + > > 7 files changed, 561 insertions(+), 3 deletions(-) > create mode > > 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > create mode 100644 > > CryptoPkg/Include/Library/HashApiLib.h > > create mode 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > create mode 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > > > -- > > 2.16.2.windows.1 > > > > > > >=20 >=20 >=20 >=20