From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.5988.1580769363068881568 for ; Mon, 03 Feb 2020 14:36:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=P/x95rNR; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: amol.n.sukerkar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 14:36:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="231171262" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga003.jf.intel.com with ESMTP; 03 Feb 2020 14:36:02 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 14:36:01 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Feb 2020 14:36:01 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 3 Feb 2020 14:36:01 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.56) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 14:35:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nxief9DH24kwzr2fL4jYTc2a/hXsfa4p26BkknvpT9Ip2mKUrkY7ZVhP307kMv9Bs0kPlHr+pYtQL6VWntqReUwhnfOLe7PBObYUI9L8Q3YHFZowvqZlkG93ZSAeNnw7X6cYOYlNGnHOgKavPqV7j8lix3A7pHcquDppDmEexVDh6C6XIIwOmnkBBnb86QC1wwHmgqt6u3FRJaf5tCtt5ZIZ5g/H3nHFS0xj6nYOit2G03xb/cMGXiTsgU6NMJNvBFabfD7OE3Fc74ksr7364VALnm/ojH4iTO+PWBkgi1PFis50SQ+nbaWIosbdog75oOIBHv/eDAmFgLNREVEZTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C72abtGVp27ZFZQAnSJnzFWZlH5W2IKTwxFYTpDgLRw=; b=ZNfycBPIwu3lTzIkq7VWqnmvcZwELBSCdvivinujUwFteIdL2M2BS6FJsX+ksVGe1ziP/DZks6g3A2j14ihwrrYS+vKHEC5wS6qb0k4HEqFElyIhLBn6ZwRqpJo+IbakOddvyGWJm+yZyoWCxXqCiOuZAgR8uYoU+7HVlzRbGKkPUKlqzoqAQBjkI4GgdG2tLcru7/Gg5rf5dBuAnRSr5SyBzvBtSkBrCaA7dMBnX3Ejv2qEi4x4HdHLhi5BY7/XEgSmbLqn5znmA2zpXb8t3a6yOzx1xsKERP/4CoY9YS+n/+NXQaVw7aGv4cCQhcwiznqNTHi5SZd89yJOkOMg3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C72abtGVp27ZFZQAnSJnzFWZlH5W2IKTwxFYTpDgLRw=; b=P/x95rNR/wIYBNm7SbwlHTgW492Ja8J/0ALxnwqrZ1PQ6LUJ3lJuAb/1VURTLCZA4WfmOn5cGJNAp6Vdg0z8HwfjxN+k6+19TUO/AtXbC3c3XkfJW9r24oMHTurMMnbMohps41JKyVPjuqDVyrCjMMeZLr5tjl28gou6UQ/6Kzw= Received: from SN6PR11MB2893.namprd11.prod.outlook.com (20.176.241.151) by SN6PR11MB2589.namprd11.prod.outlook.com (52.135.89.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Mon, 3 Feb 2020 22:35:51 +0000 Received: from SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676]) by SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676%7]) with mapi id 15.20.2686.028; Mon, 3 Feb 2020 22:35:51 +0000 From: "Sukerkar, Amol N" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" , "Sukerkar, Amol N" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82QgAAFWpCAACy/gIAAB3QAgAADfuCAAATREA== Date: Mon, 3 Feb 2020 22:35:51 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=amol.n.sukerkar@intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a61b5851-b8c1-4f50-fb0f-08d7a8f96c5b x-ms-traffictypediagnostic: SN6PR11MB2589: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 0302D4F392 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(376002)(346002)(366004)(396003)(136003)(189003)(199004)(478600001)(86362001)(33656002)(19627235002)(52536014)(5660300002)(55016002)(2906002)(966005)(8676002)(7696005)(6506007)(9686003)(76116006)(53546011)(316002)(81166006)(54906003)(71200400001)(8936002)(110136005)(66476007)(64756008)(66556008)(26005)(66946007)(66446008)(107886003)(4326008)(81156014)(186003);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR11MB2589;H:SN6PR11MB2893.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tw+7QVX1fV9j4xkMSQQk/yTvM+BgjMBtZqnLcRMZM6/xioE8+tLbfXzF9+LxdAjx6iH0BtvLqIuRcxHvRiGJfhTU2cw3pLmQINZChofm2P84h1k2o+5dFBTYbzfluTVbSWC9iPU+iXPCYvRYEAb5IcwqISe/SBf7JeXafD6BV2Dof/VenYJSfa2GBSAwqD2jY39Ed/pizU96G+h0g06rneQ2qKAgg0LnyjaGso6UiouPaAZYlfFD9hBEfNMLvdhWFl5Lzq2gD2/vDOPxdwUIiFVlhNPgSYG52jNE1JczE1b8VY1BpwzOS8UpUzrCUfaHxHqer3FTVCPXzhWwA6/uSI+aYUvf7s1AouhyONoTAZiPb0sCDsBFOlQechkvSJAIkAn1IY/8Ak1cOTwLEC5qAQN+PSn41I5pwMZlRxwCb7bUyPe8YSQ0vqGXGSXvZXzDXNDDSWX8u/nuDIx6gZH6BL0vZ2MqRSMh3YWYzL6/dXlZRTQhdA2sHSRCPQbyK2gQrcw9NzRDsYnIdBqRQA4RAw== x-ms-exchange-antispam-messagedata: QClmtALNNoRFlQBTj7O6qFn1kSZ0f1GOhZP1aMIh+AnNJuxmyqfilx+OeIWcYI8sQVAw1O/lR3sqmq8SVr8XedSaKELXu5s1swP6nOlH7Io3wa+cgEi4op1SQNNCd0XSdVrh1WwQ8nuix8/W2iJ9pQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a61b5851-b8c1-4f50-fb0f-08d7a8f96c5b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 22:35:51.2426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IElLF4R4HmAWjhNz2PWRl89OBtyVe3E6u6E/1Uyx0FS1GLTF93bqD4M2z8hlAap2uMAoAkHCV6jI57ScCwu80koKBWlmXnG9ouHk2efQgiw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2589 Return-Path: amol.n.sukerkar@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks, Mike! Sorry, I seemed to have missed that. I reviewed and accept th= e change. ~ Amol -----Original Message----- From: Kinney, Michael D =20 Sent: Monday, February 03, 2020 3:19 PM To: Sukerkar, Amol N ; devel@edk2.groups.io; Ki= nney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Agrawal, Sachin ; Musti, Srinivas ; Lakkimsetti, Subash ; Mathew= s, John Subject: RE: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Impleme= nt Unified Hash Calculation API Amol, One additional issue was found by the Linux/GCC build. The lib class .h file was correct, but I missed that the context parameter= updates were not propagated to the BaseHashApiLib instance. So there were= function prototype mismatches between the class and the instance. I have corrected these and pushed the branch again to re-run the EDK II CI= checks. https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLib_V9 Please review and let me know if you have any issues. Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Monday, February 3, 2020 2:04 PM > To: Kinney, Michael D ;=20 > devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J=20 > ; Agrawal, Sachin ;=20 > Musti, Srinivas ; Lakkimsetti, Subash=20 > ; Mathews, John=20 > ; Sukerkar, Amol N > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > Hi Mike, >=20 > I have no issue with generating new GUIDs. >=20 > Thanks, > Amol >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Monday, February 03, 2020 2:50 PM > To: Sukerkar, Amol N ;=20 > devel@edk2.groups.io; Kinney, Michael D > Cc: Yao, Jiewen ; Wang, Jian J=20 > ; Agrawal, Sachin ;=20 > Musti, Srinivas ; Lakkimsetti, Subash=20 > ; Mathews, John > Subject: RE: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > Hi Amol, >=20 > I prepared a branch an GitHub PR with this content. >=20 > The EDK II CI checks found duplicate GUID issues: >=20 > PROGRESS - --Running CryptoPkg: Guid Check Test NO- TARGET -- ERROR -=20 > Error Duplicate guid: DDCBCFBA-8EEB- 488A-96D6-097831A6E50B (2) > GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: > HashLibBaseCryptoRouterPei FILE: > /home/vsts/work/1/s/SecurityPkg/Library/HashLibBaseCryp > toRouter/HashLibBaseCryptoRouterPei.inf > GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B NAME: > BaseHashApiLib FILE: > /home/vsts/work/1/s/CryptoPkg/Library/BaseHashApiLib/Ba > seHashApiLib.inf >=20 > ERROR - Error Duplicate guid: 0D3FB176-9569-4D51-A3EF- 7D61C64FEABA=20 > (2) > GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: > gEfiSecurityPkgTokenSpaceGuid FILE: > /home/vsts/work/1/s/SecurityPkg/SecurityPkg.dec > GUID: 0D3FB176-9569-4D51-A3EF-7D61C64FEABA NAME: > gEfiCryptoPkgTokenSpaceGuid FILE: > /home/vsts/work/1/s/CryptoPkg/CryptoPkg.dec >=20 > I generated new GUID value for the CryptoPkg Token Space GUID and a=20 > new GUID value for BaseHashLib.inf and restarted the EDK II CI checks. >=20 > Please let me know if you have any issues with the change I made: >=20 >=20 > https://github.com/mdkinney/edk2/tree/BZ_2151_HashApiLi > b_V9 >=20 > The GitHub PR is at: >=20 > https://github.com/tianocore/edk2/pull/328 >=20 > Thanks, >=20 > Mike >=20 >=20 > > -----Original Message----- > > From: Sukerkar, Amol N > > Sent: Monday, February 3, 2020 10:55 AM > > To: devel@edk2.groups.io; Kinney, Michael D=20 > > > > Cc: Yao, Jiewen ; Wang, Jian J=20 > > ; Agrawal, Sachin > ; > > Musti, Srinivas ; > Lakkimsetti, Subash > > ; Mathews, John=20 > > ; Sukerkar, Amol N > > > Subject: RE: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Thanks for the review, Mike! > > > > ~ Amol > > > > -----Original Message----- > > From: devel@edk2.groups.io On > Behalf Of Michael > > D Kinney > > Sent: Monday, February 03, 2020 11:36 AM > > To: devel@edk2.groups.io; Sukerkar, Amol N=20 > > ; Kinney, Michael D=20 > > > > Cc: Yao, Jiewen ; Wang, Jian J=20 > > ; Agrawal, Sachin > ; > > Musti, Srinivas ; > Lakkimsetti, Subash > > ; Mathews, John > > > Subject: Re: [edk2-devel] [PATCH v9 0/2] > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > Calculation API > > > > Hi Amol, > > > > Thanks for the updates. They all look great. > > > > Series Reviewed-by: Michael D Kinney > > > > Mike > > > > > > > -----Original Message----- > > > From: devel@edk2.groups.io > On > > Behalf Of > > > Sukerkar, Amol N > > > Sent: Monday, February 3, 2020 10:19 AM > > > To: devel@edk2.groups.io > > > Cc: Kinney, Michael D ; > > Yao, Jiewen > > > ; Wang, Jian J > > ; Agrawal, > > > Sachin ; Musti, Srinivas=20 > > > ; Lakkimsetti, Subash=20 > > > ; Mathews, John > > > > > Subject: [edk2-devel] [PATCH v9 0/2] > > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > > Calculation API > > > > > > Currently, the UEFI drivers using the SHA/SM3 > hashing > > algorithms use > > > hard-coded API to calculate the hash, for instance, > > sha_256(...), etc. > > > Since SHA384 and/or > > > SM3_256 are being increasingly adopted for > > robustness, it becomes > > > cumbersome to modify each driver that calls into > hash > > calculating API. > > > > > > To better achieve this, we are proposing a Unified > > API, which can be > > > used by UEFI drivers, that provides the drivers > with > > flexibility to > > > use the desired hashing algorithm based on the > > required robnustness. > > > > > > Alternatively, the design document is also attached > > to Bugzilla, > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. > > > > > > Amol N Sukerkar (2): > > > CryptoPkg: Add CryptoPkg Token Space GUID > > > CryptoPkg/BaseHashApiLib: Implement Unified Hash > > Calculation API > > > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > | > > > 333 ++++++++++++++++++++ > > > CryptoPkg/CryptoPkg.dec > > | > > > 26 +- > > > CryptoPkg/CryptoPkg.dsc > > | > > > 4 +- > > > CryptoPkg/CryptoPkg.uni > > | > > > 18 +- > > > CryptoPkg/Include/Library/HashApiLib.h > > | > > > 122 +++++++ > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > | > > > 44 +++ > > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > | > > > 17 + > > > 7 files changed, 561 insertions(+), 3 deletions(-) > > create mode > > > 100644 > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > > > create mode 100644 > > > CryptoPkg/Include/Library/HashApiLib.h > > > create mode 100644 > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > > > create mode 100644 > > > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni > > > > > > -- > > > 2.16.2.windows.1 > > > > > > > > > > > > > > >=20 > > >=20 >=20