From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.1939.1581725502351847284 for ; Fri, 14 Feb 2020 16:11:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gpnMj31Z; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: amol.n.sukerkar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Feb 2020 16:11:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,442,1574150400"; d="scan'208";a="234631713" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga003.jf.intel.com with ESMTP; 14 Feb 2020 16:11:41 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 14 Feb 2020 16:11:41 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 14 Feb 2020 16:11:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AOjcCweo6CdZZ/3s5ciPDjrMQEKo1CZmjUj14HbyKatLzIOyO2/KdEFB2ZIanrriM4QExXex0YihfC2r9JBmtgfItVAyYMFW3nLHCthp5LJWupUDKk6iuRIbg61friYfPwVgNYmZc8FUQPQFtCkazQKjq0iaHhx5V6MkxDv2K5y9wLwwVfgAxrsU4F6FU0rFp/cYqCVM/EDJFNfOj8ebockH1SXiGbYo4L2nlAPARy0Yz0Bl2DZLiEbYBmc2lKsC2kR/uvPjsbnvpfBfAVlmmY0nDuJQj1BzycgPP+IAX+/72oz5cdoGY53HqB31B9QL5tUf6kP2fjdbFGqBKCGhlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KqTeF/bKb4W1wbMhcf8YhblSzGa/O5bZuAwpqG2wrfg=; b=QcFAkg3/Ni5hUSXdQEriCLkU6WYhf4r0tYooKcnEjUP3zLhnONTmTIhF083jq8/aL9JT+mkbfg5qJxHN59dpPDE2x5ycppsKAS3/F6cyqqQxCuq+x+F8U6swA/zeUzCjy4zIfjhVfVWGZrJ34Jd4K2XK3Di1t//pOXdcxRQQku+Aa40atcNXmcmXFpJaW30eWhLtOhGt9HNbXBmQLhcGP1Jp98SaYA85o9VOvgPFUxPC+9Zf143/GLQEGJWg5If7tR9iJvmngPDfLGyKeA3TdroqS+bN2K8415HZ2vGPaTrxXM0hYqKVWxxi09Kl0NEk4Hyy9CgOa3l2nLJOicm0fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KqTeF/bKb4W1wbMhcf8YhblSzGa/O5bZuAwpqG2wrfg=; b=gpnMj31ZhmF0M/VlC2I5ucy5NKXDMhnpWn0oQt7C5V+HGujBGcQXrpog9nT6JqjiN/I5Ez6cCUtvlDE6/wwBsYuErkF5jv4aWz3zLgm4l9SY0CKYD5+XnHAYdB9L0lJsGOrSix3DWFLZ7JoZhG/IFwAJqVV8474YUarqfIo6szM= Received: from SN6PR11MB2893.namprd11.prod.outlook.com (20.176.241.151) by SN6PR11MB2717.namprd11.prod.outlook.com (52.135.95.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.23; Sat, 15 Feb 2020 00:11:39 +0000 Received: from SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676]) by SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676%7]) with mapi id 15.20.2707.030; Sat, 15 Feb 2020 00:11:39 +0000 From: "Sukerkar, Amol N" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Gao, Liming" , "Sukerkar, Amol N" Subject: Re: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Topic: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Index: AQHV441vbO4uVRrGh0WnWNfAkYVkNqgbXtlwgAABYxA= Date: Sat, 15 Feb 2020 00:11:38 +0000 Message-ID: References: <20200214232100.11088-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=amol.n.sukerkar@intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 831601d9-afcc-4105-bca9-08d7b1aba0e3 x-ms-traffictypediagnostic: SN6PR11MB2717: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03142412E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(376002)(346002)(366004)(396003)(136003)(199004)(189003)(64756008)(81156014)(66556008)(86362001)(33656002)(110136005)(316002)(81166006)(5660300002)(8676002)(55016002)(9686003)(66946007)(2906002)(66446008)(52536014)(76116006)(66476007)(26005)(7696005)(107886003)(186003)(54906003)(8936002)(4326008)(966005)(53546011)(478600001)(71200400001)(6506007);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR11MB2717;H:SN6PR11MB2893.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZnQudabyAEe2rnttxfYpk8uPwi63rJp0tXcHIVFhjVjOfB5xuuhi08GjZLp7P9plvZYfQyo+mWfQLSEerMiY43VHYJAH1GGM5CHtcJYFqb9g9JxmWcZs1ZGOtllDmgxhRQJ0PmvwZQehaSjI8jvDlltmP0u9BSEqW0GMgABl9tiFAg4qciJOLTp82kUPCq/ao6hKfTf8rnavd1EXZ4lIHF77JVqaPLVqOBEP4Twlrl0nzeDdGkvIJDgHzhX4GLEj6ih2JjYOG9vXWQniJwq07MJ7z5IcBnaFqkGCxNM436U3YGGLOOUdtdwWJMBIpgQARNjpQsBu33+vC0hMt3akuhuJGdoX651ClgnxwvimjZolw+Fx98bEHDjwQy+m59UuJfZkPC4R875WWW4qQCOQwt//S7RD8F2810RkXauELZQBxRnf8v3iAZVHacW8F3WPIRhOC1cAsgPLatmVwbwQWYFe6nuc5Rgox5sqiiejbSyEEdDdJKm6DmxaS2VWeMxdUphURCLi7vnU192nb4EGEA== x-ms-exchange-antispam-messagedata: 6sxtS6qBfQ5Qe6TGc9GVtveWyV4LrURmniUnxY/BUeVvvmpxJmnGBS8X1XUyoJ74NEvAjp5hS4Z89uTA7WFXjdjnF7/99yPH1ZAnEbcdG9mANmietyw0quejs/YhglFs38HNMP8PGdWBmcWfsHyNkg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 831601d9-afcc-4105-bca9-08d7b1aba0e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2020 00:11:38.4812 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aNibIazdMwH9r7WBi1Jf7vP0i3TiWNO/grMDAG6olUjDmXjeEc4WVvII1JCzFNRfu0T9ZsMklTWisNxB9ZjrMhsYzPj+B/6f+OJdKnUzzxo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2717 Return-Path: amol.n.sukerkar@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Although the values were listed in 8-digit hex format, the PCD, PcdHashApi= LibPolicy itself was of type UINT8 earlier that was changed to UINT16. I ag= ree changing the type to UINT32 will align with all the other PCDs implemen= ting TCG spec (and using Tpm20.h defines). Can you confirm my understanding= is accurate? Thanks, Amol -----Original Message----- From: Kinney, Michael D =20 Sent: Friday, February 14, 2020 5:04 PM To: devel@edk2.groups.io; Sukerkar, Amol N ; Ki= nney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Agrawal, Sachin ; Gao, Liming Subject: RE: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to BaseHash= ApiLib Amol, Thanks for the quick update. I see you changed the PCD to type UINT16. I think this was based on Jiewe= n feedback to use a set of TPM specific algorithms defines that were UINT16= . However, the HASH define values being used are 32-bits and everywhere else= that those defines values are used, they are also 32-bits. I recommend we keep the type UINT32, and use 8 digit hex values in all ref= erences to the values and valid value checks. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of=20 > Sukerkar, Amol N > Sent: Friday, February 14, 2020 3:21 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen=20 > ; Wang, Jian J ; Agrawal,= =20 > Sachin ; Gao, Liming > Subject: [edk2-devel] [PATCH v3 0/2] Enhancement and Fixes to=20 > BaseHashApiLib >=20 > This patch implements the fixes and enhancement to BaseHashApiLib in=20 > the following manner: > - Remove reference to MD4 and MD5 hashing algorithms as they are > deprecated; > - Align the enumeration for hashing algorithmswith the one used in > TPM 2.0 implementation defined in > IndustryStandard/Tpm20.h; > - Change the type of PcdHashApiLibPolicy to PcdsFixedAtBuild to > optimize away the unused hashing algorithms for a particular > instance of HashApiLib. >=20 > More information can be found at Bugzilla ticket,=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511. >=20 > Amol N Sukerkar (2): > CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 > Implementation > CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to > FixedAtBuild >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > 121 ++++++-------------- > CryptoPkg/CryptoPkg.dec | > 18 ++- > CryptoPkg/CryptoPkg.uni | > 12 +- > CryptoPkg/Include/Library/HashApiLib.h | > 16 +-- > 4 files changed, 52 insertions(+), 115 deletions(-) >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20