From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.2805.1580756129369751693 for ; Mon, 03 Feb 2020 10:55:29 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=jCtg+1s9; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: amol.n.sukerkar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Feb 2020 10:55:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,398,1574150400"; d="scan'208";a="263549262" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 03 Feb 2020 10:55:28 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 10:55:28 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 3 Feb 2020 10:54:57 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 3 Feb 2020 10:54:57 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 3 Feb 2020 10:54:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mbVRm+AydYK9Rohctb3npoQ031oQ+clek65PjG/Vu0C0UfZ1WXJUEeviI0H2QqiS5kU58WPsiD0V0m+YPcJJx4rl151YxnjSOAdJEyumRra1/h9r14odEuJA/9v2CxfXXSjxSRHiOqFK/9BYca+6OG/FHozve+0iutY0U8fR1dXsAbFHFpGz+2PJQFB1lpvml9uedXju8KHWjHkvCtOQcRCJ3iaGmLwhIbIKBkqVvorzggwVoYzD1HQ5uZC56SoIR3QIN0G5XbQGoITDaAy3IUudE88TRCyc5FU2lz6pDYoDlkGOOP3Engg6kRTYRxRI4FWXt8+OOWyy4ixWbalmgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1EhsHQuOgtM5MkhntJSOxB4BKCFQMjPO7Nv86/6Mq2Y=; b=mqaXXabrniO1U8hBs1b1P9bYRrtMrtBDeSzXmeTtVib34S9pce6ddjVoZ8uBB8rXkyiU+iBU2kbfo1OxAp1w123cv+ZXXMt7QOhcxgSDC8e1u+Q10/guV651IGa9NixRJfSPhky9ec8tu4qoa7yQbUlMBIAILbnaSufiY3NdPm3Pho3UNKiquQGMXSxah1EDKj5fuHKu76BuA7avOAMAk6lFA70LMdipwC1DF6h8yLP1rDj7BfCNTCF5AX/eqA2n9K7x7pU4L1hDGCKvGPL4dVqWrdCV3hbgxTJgHqLThtVOtkI6RWvovM35uTNp9sBZtwYzhIIwwHL8lzROQRwnkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1EhsHQuOgtM5MkhntJSOxB4BKCFQMjPO7Nv86/6Mq2Y=; b=jCtg+1s9ClKWTZ9JxGbDlaeaZX0sZF59o698ngEOYgQJ0+APsa8MBYvLT9HgpPqAzRePI+sjLd4EQyYUMoTBNm3NC21eOJI5XbVv6nr+eTzds3QRH4NF3QN97RIxKvZtfLmQMEiIzwcwytJ+FLbGPWXqvlmgbaeAJI7bw7tVZ1g= Received: from SN6PR11MB2893.namprd11.prod.outlook.com (20.176.241.151) by SN6PR11MB3408.namprd11.prod.outlook.com (52.135.111.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.27; Mon, 3 Feb 2020 18:54:30 +0000 Received: from SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676]) by SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676%7]) with mapi id 15.20.2686.028; Mon, 3 Feb 2020 18:54:30 +0000 From: "Sukerkar, Amol N" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Musti, Srinivas" , "Lakkimsetti, Subash" , "Mathews, John" , "Sukerkar, Amol N" Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Topic: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API Thread-Index: AQHV2r5nQGf04ZUN0kmCVUXzeKjFQ6gJy82QgAAFWpA= Date: Mon, 3 Feb 2020 18:54:30 +0000 Message-ID: References: <20200203181850.17732-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=amol.n.sukerkar@intel.com; x-originating-ip: [192.55.52.202] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 457e2f63-35dd-4765-e4be-08d7a8da8042 x-ms-traffictypediagnostic: SN6PR11MB3408: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0302D4F392 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(189003)(199004)(64756008)(66476007)(66556008)(66946007)(66446008)(186003)(76116006)(9686003)(71200400001)(6506007)(966005)(107886003)(6636002)(81166006)(81156014)(8676002)(26005)(498600001)(8936002)(33656002)(2906002)(4326008)(7696005)(53546011)(5660300002)(52536014)(55016002)(54906003)(110136005)(86362001);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR11MB3408;H:SN6PR11MB2893.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: B0/fUxC0BlUkBCgbNNS9uI9uiphTORM0GFpxF3+67Rth1eLSYWDn/TED1puhm1e9R5oN4SWwscOWgCBZMlysUeJMouPVgYp9tkiXeFtUCJ8Ts6SU0L35l2w0gGGGx7XjYVUsbZEunafSw1gU12WP8acOGQLYoU04gA9cKu9xhnVUXZ7kBvSun7SZAP4rgrstaO0eX57NMuh4L79WbrwrL9GbJLeY2UizRw/8QlozGV43OISW2OhkKgxSBk0Uj03uYcgOXF9IteVoW8uD5Bl4kC+VP96HOqkYc8vMg9FRzuZ5gmBS3/lnNsMXMt8YHGVuQjH76A1FxL4egQiAUZmtrZZW75aJG9WxxIW3SphggxLsiozhSFVitvkO1hja5EqW6JGfkN7liAnw3Jtllzqo/IOSUSOvM5sohoSUrgRa8FPbtrSKVPQ3QSmExoFlffW0vUXPVVeA/OWsF8MeHU80udQ1ottt55mn4HN3uBX6uuqaASYISugRZBJzOFYWRhNtHQF5HjlZN0YS2Dnx2MbQSg== x-ms-exchange-antispam-messagedata: hQfNmgS2+aqIrl3Y3ZS4Pw3HQ0fhV05CSP7bBClSdnIT2CW+VMU0fPBD5Y2VDBTKfrqQfHxW7b0+he0TK44Pr/ey/VOvAtQ7oONlitgk3Ry5AijQb56Fw8BdusPfAsPbM6RDefa5iE4QWEB+WABalg== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 457e2f63-35dd-4765-e4be-08d7a8da8042 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 18:54:30.1980 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X6lgCyT4AeD4KLgbU9GlgEmiIrN613WffQBy2yTWuWF+If0CYoWI+XC1Bd+/V4byXqz+RHzJpAJ69hDSidsIOUsVf0Pwl+aaI7IO0/2CK48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3408 Return-Path: amol.n.sukerkar@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the review, Mike! ~ Amol -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael D K= inney Sent: Monday, February 03, 2020 11:36 AM To: devel@edk2.groups.io; Sukerkar, Amol N ; Ki= nney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Agrawal, Sachin ; Musti, Srinivas ; Lakkimsetti, Subash ; Mathew= s, John Subject: Re: [edk2-devel] [PATCH v9 0/2] CryptoPkg/BaseHashApiLib: Impleme= nt Unified Hash Calculation API Hi Amol, Thanks for the updates. They all look great. Series Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of=20 > Sukerkar, Amol N > Sent: Monday, February 3, 2020 10:19 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen=20 > ; Wang, Jian J ; Agrawal,= =20 > Sachin ; Musti, Srinivas=20 > ; Lakkimsetti, Subash=20 > ; Mathews, John > Subject: [edk2-devel] [PATCH v9 0/2] > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use=20 > hard-coded API to calculate the hash, for instance, sha_256(...), etc.= =20 > Since SHA384 and/or > SM3_256 are being increasingly adopted for robustness, it becomes=20 > cumbersome to modify each driver that calls into hash calculating API. >=20 > To better achieve this, we are proposing a Unified API, which can be=20 > used by UEFI drivers, that provides the drivers with flexibility to=20 > use the desired hashing algorithm based on the required robnustness. >=20 > Alternatively, the design document is also attached to Bugzilla,=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2151. >=20 > Amol N Sukerkar (2): > CryptoPkg: Add CryptoPkg Token Space GUID > CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > 333 ++++++++++++++++++++ > CryptoPkg/CryptoPkg.dec | > 26 +- > CryptoPkg/CryptoPkg.dsc | > 4 +- > CryptoPkg/CryptoPkg.uni | > 18 +- > CryptoPkg/Include/Library/HashApiLib.h | > 122 +++++++ > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf | > 44 +++ > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni | > 17 + > 7 files changed, 561 insertions(+), 3 deletions(-) create mode=20 > 100644 CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c > create mode 100644 > CryptoPkg/Include/Library/HashApiLib.h > create mode 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.inf > create mode 100644 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.uni >=20 > -- > 2.16.2.windows.1 >=20 >=20 >=20