From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web09.3214.1581795575368307639 for ; Sat, 15 Feb 2020 11:39:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Zk9m7I++; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: amol.n.sukerkar@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Feb 2020 11:39:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,445,1574150400"; d="scan'208";a="227688493" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga007.fm.intel.com with ESMTP; 15 Feb 2020 11:39:34 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 15 Feb 2020 11:39:34 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX157.amr.corp.intel.com (10.22.240.23) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 15 Feb 2020 11:39:33 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 15 Feb 2020 11:39:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkvR84kpeEKiKjWmH739JmgLMtBzrBGOLuJZNhv2brYKsczWVhh85r5HHMCgw8eDYjAE/JfIFANhLIN/5nREk7ZWTbrOwNkjW7XyorR3EqG1uCW98kJe6D+abI0R+/TtfH4ZufGfzEkewZfy/E+AiLIG3TCbwTfiSQhlwWXcmdDU/270MzkxUUQP8AWNMkuxVxSP/DdPacSXPoddHdaxalnlZdEuRclESxBnfXU+XztYQV3GyoqlAmn0rXdt+R/2nbnbKSZRDRHPb6QNzF9TlQjSBPErMEzSf4PpMnDXqGd8fCFKZUdbXXCqYlAoVk65YdEG9W+DPAIMSlZT3gmW5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuyaRBwIn5kpnOx6y/hpPc+s4zz8Dc6fu0wz9PtNZFw=; b=i+ZZtkZ33bRtCxP5VYufkHOg7bKn6wmax25oFWTQHUQRndph7aZvzSPdMi+rTyJCYaOaIbuQDUFMFnOsJCwFQ4eT7cNn/dC1OfzUGYHBvBEkK3NHSyLt/rKu2scIiHi3DNbMIG6lxfAcmrZBC5on49zlI+zL3O0TKOmWilPSje295WVwJ4RwnhsukrVpDSUw8oFiIH6fvVdSnYdrd59kTfMU7MrIpMze489Rn/Bl4EhCvQZAdEoptk/MoM+SJKgvS75uWra06gTFZhG9PSapa2YqagojnTv4ScwQxrySnnVpSRdmopsSfVXtgwLHinhr0Nk3CAxuq3MDDzVI/xiSSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuyaRBwIn5kpnOx6y/hpPc+s4zz8Dc6fu0wz9PtNZFw=; b=Zk9m7I++2mjumlUao82dMAe6IPQO5dRJVG3zCJJ82GbiQPE8eG3/KxvV7Zw2/Zdsolm+MRMrgCXMqJrJ8VJA8CAzB/3iEqi+K2ZANFheVdKJUOVB106eIFemIJVn6f+JK+zFRi4LLd6g6jrctZr13xshILJmH6OcrDMjYkwL/fE= Received: from SN6PR11MB2893.namprd11.prod.outlook.com (20.176.241.151) by SN6PR11MB3501.namprd11.prod.outlook.com (52.135.126.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.23; Sat, 15 Feb 2020 19:39:32 +0000 Received: from SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676]) by SN6PR11MB2893.namprd11.prod.outlook.com ([fe80::e59c:2d4b:b97c:9676%7]) with mapi id 15.20.2707.034; Sat, 15 Feb 2020 19:39:32 +0000 From: "Sukerkar, Amol N" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wang, Jian J" , "Agrawal, Sachin" , "Gao, Liming" , "Sukerkar, Amol N" Subject: Re: [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Topic: [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib Thread-Index: AQHV45WQr3UR/dgvxEynctWBfAfr1qgco5oAgAAD1JA= Date: Sat, 15 Feb 2020 19:39:31 +0000 Message-ID: References: <20200215001903.15024-1-amol.n.sukerkar@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=amol.n.sukerkar@intel.com; x-originating-ip: [134.134.136.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7bf55879-43e1-4e66-9ea1-08d7b24ec7a6 x-ms-traffictypediagnostic: SN6PR11MB3501: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 03142412E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(346002)(39860400002)(396003)(136003)(366004)(199004)(189003)(81156014)(81166006)(8676002)(26005)(6506007)(53546011)(8936002)(186003)(2906002)(71200400001)(76116006)(66946007)(33656002)(66446008)(107886003)(86362001)(5660300002)(478600001)(110136005)(55016002)(9686003)(4326008)(316002)(66556008)(7696005)(66476007)(966005)(64756008)(52536014)(54906003);DIR:OUT;SFP:1102;SCL:1;SRVR:SN6PR11MB3501;H:SN6PR11MB2893.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QAhrZ3KCcM9MfJ8+zh7GnsrkpRfuqM00vLVJm4nDDlOodGBa+hq3kkDd9mhToSOviYB9pcUEPXZw/LGmTiagi6RQBCTEXOViWEjyPDXTEEPETx7A+O3mpwOZpuUjREqyH1UFl0ZF/ksp09pVX42ewvH2rVpt6Ka0tj4WXQfgTYOcKwBB2s3MFeEoMwy3sOis2fOmpSV7NEsV7TjoVevixMpcj1cQQh/L4ZxSM3XH8NMqvXkDzQXgpaYd+Glqxt/JsLryVwwWpZQYBCa31ITP9m62lZGUOVG8phs5HSRRhncqlGv8Shts+bFG/O4nbNrxK7+Cy52f0HBNrUW0t5NlMiX306UydJvTNA2WJL0XEZjQuHmPwKbMGFcLBQK+LbwGJ6H94NGsWMmUgTJFB5IE7jL+6fW/X97FvA8uN8eozcgHbKERgUhxos4xntSFGGXChAFm/ZBcJRvXxR1UQTu81qWvLRQFvUKyRT8mfjKlwqTTykm/inEKmMEbyG6EOI016dnqWwzmCZSNI5ONjfChXA== x-ms-exchange-antispam-messagedata: ecl/mIOQyllRhpmkhbcJ3olPYb4bpNsUarwRgIw2zvPRZHLWlqHKTZooBfbOoZLvqQoaWIikcP8w3lF7Q94ZNwW/k2yIkpligNS1PHg4KRAMlh90vc9SFD7ftPbTyKrkTB8wum5/JtLAEWHOEu0u3Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7bf55879-43e1-4e66-9ea1-08d7b24ec7a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2020 19:39:31.7216 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8ZN81HIsJsRC3HpcQLEIDJeQzumlDFQ2FBq4xdauVglUBAzxYYB7XtX4MlONEaDD4xiHk4Vw9Lz7c66CMcOEUleG3PSnRnPE4EGupVl2jUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3501 Return-Path: amol.n.sukerkar@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, Yes, I just noticed and sent the patch with update 1 (build passed and work= ed with PcdGet16). I didn't notice the second change so I will make it as w= ell in version 6. Question: There is a call FixedPcdGet32 as well. Would it be applicable in = BaseHashApiLib? Thanks, Amol -----Original Message----- From: Kinney, Michael D =20 Sent: Saturday, February 15, 2020 12:28 PM To: Sukerkar, Amol N ; devel@edk2.groups.io; Kin= ney, Michael D Cc: Yao, Jiewen ; Wang, Jian J ; Agrawal, Sachin ; Gao, Liming Subject: RE: [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib Hi Amol, Thanks for the updates: There are a couple items remaining: 1) BaseHashApiLib needs to use PcdGet32() instead of PcdGet16() 2) The extra [PcdsFixedAtBuild] line needs to be removed from CryptoPkg.dec Thanks, Mike > -----Original Message----- > From: Sukerkar, Amol N > Sent: Friday, February 14, 2020 4:19 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen=20 > ; Wang, Jian J ; Agrawal,=20 > Sachin ; Gao, Liming > Subject: [PATCH v4 0/2] Enhancement and Fixes to BaseHashApiLib >=20 > This patch implements the fixes and enhancement to BaseHashApiLib in=20 > the following manner: > - Remove reference to MD4 and MD5 hashing algorithms as they are > deprecated; > - Align the enumeration for hashing algorithmswith the one used in > TPM 2.0 implementation defined in > IndustryStandard/Tpm20.h; > - Change the type of PcdHashApiLibPolicy to PcdsFixedAtBuild to > optimize away the unused hashing algorithms for a particular > instance of HashApiLib. >=20 > More information can be found at Bugzilla ticket,=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2511. >=20 > Amol N Sukerkar (2): > CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 > Implementation > CryptoPkg/BaseHashApiLib: Change PcdHashApiLibPolicy type to > FixedAtBuild >=20 > CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | > 121 ++++++-------------- > CryptoPkg/CryptoPkg.dec | > 18 ++- > CryptoPkg/CryptoPkg.uni | > 12 +- > CryptoPkg/Include/Library/HashApiLib.h | > 16 +-- > 4 files changed, 52 insertions(+), 115 deletions(-) >=20 > -- > 2.16.2.windows.1