From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.3296.1590546066083806645 for ; Tue, 26 May 2020 19:21:07 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=a/qaX3qy; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) IronPort-SDR: G8gaOhfpnm935dxGoFNyZjT6xbkTXqc0gYOS5molspTUfgiZ5kEf/SjGzOJSUHCVRiEYpuGlF6 lJEsjwAjj3Iw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 May 2020 19:21:05 -0700 IronPort-SDR: a6TFiOv03VJcYSL3tXZltrJ4vxOuauj+f9XkkX9z3c5NbeBcIe5rqBDLsU9EGvh2lSW+aWr2Fd 1hThoE1huxLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,439,1583222400"; d="scan'208,217";a="468535125" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga005.fm.intel.com with ESMTP; 26 May 2020 19:21:04 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 May 2020 19:21:02 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 May 2020 19:21:02 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 26 May 2020 19:21:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaJCWI6yV3Bmior/WqyjrvIINBuzbeYNwgZtAKlX8fd7nyAQQp4n8SlVtCzl3ph0VkJorVjWJgzWraMy8MREG4fG/1C8NEmwUh6kZuepWvGicMQoH3QWA4bJi/pBzsCTWksP3B/jilid7HFoi5nSgnaiX8dq6tMK1gAaP5jU7i2m29XmmRBhUjUz0ehs5t4A8MCkxL8znLRSlMJskvpj46d1bZELmrvTKHdYd9Z2gdxE21S9MaFspWXPhZR7bhUotXcgvHp7oa0aqQwdMHGSlLDKI4lCIKV9lDI1Ns2Svrzup6/PjvQSQ1xAkdvvMR45UMvD3A0p+p8SOckRtnfEVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNBK3pzI64tFGTBe66YCjWbVRE02C63jZ0l/0m/siiU=; b=NylW6NERALu0dJ9nZKpGJfscBNskh9Ffh2ZMQWmMTlHtymQ56MbQRfMbFiWwCITFn3A4DAKnxbjj5Z3uTRJ/qA50dCwHrMjVOGY06+Rn0gwkCKGonrH/O0CPfXUALoQW7312tmhvXzy+iWFRYU3hR5QJ7XHvwyJbYuy/YI4nSepnxqOhDmW1tPTgpNE7qW07pr4v9u/RZTlzhgc3W5FLYaaIjvp7RZZIV6xy0ugCKU/zLL3pqGVOplQvBbpQTD+cOifN6GBjMECsvkaK3aQnjL98g2MpbMxNY1r95wTfe2+M3LvfVpZKqIgmr2aqkmYppa5zLBRePixeq9QcRlYtHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xNBK3pzI64tFGTBe66YCjWbVRE02C63jZ0l/0m/siiU=; b=a/qaX3qyV1LOjBtU4AGXmOp8g4caVcvXYiS3fl2S9CUqc+/hVPQTP4X80F5UT7p3FrzeAVUzWirwvFnh8Bb6QVz9t6JDAxUU1TU9VNvYppk4SAzTW79eRgdr1/rUfGLUecDvyeNWjtFRA8b10KcQlGQOH6krnhqUd4Rwgi9byBc= Received: from SN6PR11MB3197.namprd11.prod.outlook.com (2603:10b6:805:c5::23) by SN6PR11MB2591.namprd11.prod.outlook.com (2603:10b6:805:60::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3021.23; Wed, 27 May 2020 02:21:01 +0000 Received: from SN6PR11MB3197.namprd11.prod.outlook.com ([fe80::a551:8867:924a:7217]) by SN6PR11MB3197.namprd11.prod.outlook.com ([fe80::a551:8867:924a:7217%5]) with mapi id 15.20.3021.029; Wed, 27 May 2020 02:21:01 +0000 From: "Liming Gao" To: Bret Barkelew , Laszlo Ersek , "devel@edk2.groups.io" , "announce@edk2.groups.io" CC: Leif Lindholm , "afish@apple.com" , "Kinney, Michael D" Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Topic: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable202005 Thread-Index: AQHWM6qvIE615OKNNkq9T3ZoV+/+O6i7M3Kw Date: Wed, 27 May 2020 02:21:00 +0000 Message-ID: References: ,<6cdfa14b-b45f-1c19-0dc3-653ef06c40c4@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-05-26T22:11:26.171Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: microsoft.com; dkim=none (message not signed) header.d=none;microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.52.195] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4cf5df3a-758d-4f0b-e333-08d801e49971 x-ms-traffictypediagnostic: SN6PR11MB2591: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 04163EF38A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MebK7CDU/qFHjic4u3OkXgse2KOiRqRdjTedQStqTjcwkXoYJ188P4KeKm2txAltvq9qYjNgu5tphE6OTn6eXYY322nXxheWTzPfQ/GFbC3v829mDna87KfIIj9xiZpKzegVH81+0GhMa9x2Mwv+vqfSd8GKdIbCzSJyUNtQFkcfmASFxUNFspWEuA49+8skPgsx/OXX5zep8V5P7ltEmVn1LTnTgiQlAmRNj8DhOOta0PdUlJ8K9DRCaI4D+5vSfgkIO3OKc87G9zO98qiun2spupTzi7lRd3AKGg0N5AVangYb40Ot5z/P3OJf6BRtEG4AsbqZR4Bp1OhYhki+lrpfl/W5KniAbb5OuLWwZWgbmFcBHygKH5WJy7i/nB3Fb3OWHz3M5FuvkWO6Usy5Uw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3197.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(396003)(39860400002)(346002)(136003)(366004)(376002)(71200400001)(86362001)(52536014)(166002)(5660300002)(7696005)(83380400001)(186003)(6506007)(33656002)(53546011)(2906002)(26005)(55016002)(76116006)(4326008)(8936002)(8676002)(966005)(66446008)(64756008)(107886003)(54906003)(66946007)(66556008)(478600001)(66476007)(316002)(110136005)(9686003)(45080400002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: xE6cyLoodrkgsuRvNduvgyHyOdoMncf+cYsUFMHBDi7vYEvsIPtKuBtRYhm1+c/X3e4elM0XlOmZxWYkPDbBIX5G+IRO8s7cej0+uWBV/mdmF3r0qn7eMqDwhcS35ycf4gII/P07n73FkX4nVUhqupD/MtYydL1HkpIvi23aEcrVDNlgCt42lCiJKSzXSewLhyPq/ygaQwQh4iGjWFVj/3QK2BSWzGDY4ScZ/SyRQHIeiOJq+/yfb8LkUdkXcY1cPH+hKk24I2cyXD3B0ZmzM623GQ099BPTq10/2NLIAcVh8sHRsh8gxZFVF3+z/QCwLssFX6AQ+BkLlUsZUDTUYJsB+/l3iVZcOGS//OegmZj3E1JOJiH6lEEg6Tonk4rSOl2WqmszmZKY/VmMWRay/CWgkVuTUwUDjJ7W/cKx0fgSg3u1ZNw8vqvwDFkuj3eTr4lZEuU8ZduCe+QLoSfKVbR4MrOh9TYo+wsd37gWLAMp4pwPKTSPcgRDl0AanU7b MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 4cf5df3a-758d-4f0b-e333-08d801e49971 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 May 2020 02:21:01.0065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tCt+zVY96M7vRybC28fJBF3ZYk3MHh7mJ8OTjYEVRwpM0DxkfhGaHDLffm+rAqNmUmr9iT4K3G/M6B9VCNfwIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2591 Return-Path: liming.gao@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN6PR11MB3197295A624E921ACFEEDC5680B10SN6PR11MB3197namp_" --_000_SN6PR11MB3197295A624E921ACFEEDC5680B10SN6PR11MB3197namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I create PR https://github.com/tianocore/edk2/pull/644 for this patch. Thanks Liming From: Bret Barkelew Sent: Wednesday, May 27, 2020 6:11 AM To: Laszlo Ersek ; devel@edk2.groups.io; Gao, Liming ; announce@edk2.groups.io Cc: Leif Lindholm ; afish@apple.com; Kinney, Michael D = Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable= 202005 I just looked into it, and I think that AsciiStrCpyS() was the wrong funct= ion to call in this loop anyway. AsciiStrCpyS() will fail without copying a= ny characters. AsciiStrnCpyS() will perform the string "slicing"/"chunking" that the loop= seems to expect. The bug stands and we should try to get that bug fix into the stable tag. = Thanks! - Bret ________________________________ From: Laszlo Ersek > Sent: Monday, May 25, 2020 10:46 AM To: Bret Barkelew >; devel@edk2.groups.io >; liming.gao >; announce@edk2.groups.io > Cc: Leif Lindholm >; afish@app= le.com >; K= inney, Michael D > Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-stable2020= 05 Hi Bret, On 05/22/20 17:11, Bret Barkelew wrote: > We'd like to ask that this patch be considered for the stable tag: > [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use AsciiSt= rnCpyS() > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugz= illa.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&data=3D02%7C01%7Cbret.bar= kelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141af= 91ab2d7cd011db47%7C1%7C0%7C637260256091133309&sdata=3DMDKQ1CKq9%2B9AfPM= L0JxcND47UIcQUAibUSAVlfW5iZc%3D&reserved=3D0 > > The patch was reviewed prior to the hard freeze date, and is a small cha= nge that affects new(ish) code that is not heavily utilized yet. does the original issue (reported in TianoCore#2721) persist with TianoCore#2054 fixed? My understanding (from TianoCore#2721) is that the original AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error condition in AsciiStrCpyS(). Previously, that would indeed trip an ASSERT(), but AIUI that issue has been resolved generally with TianoCore#2054. If the AsciiStrCpyS() call remains an issue with the ASSERT() removed, then replacing the call with AsciiStrnCpyS() still seems like a bugfix to me, not a "feature", so I think the patch is eligible for merging during the HFF. Mike, can you please merge the patch (if it's still needed)? Thanks Laszlo > > - Bret > > From: Liming Gao via groups.io > Sent: Friday, May 22, 2020 1:01 AM > To: devel@edk2.groups.io>; announce@edk2.groups.io> > Cc: Laszlo Ersek; Leif Lindholm; afish@apple.com; Kinney, Michael D > Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for edk2= -stable202005 > > Hi, all > Today, we enter into Hard Feature Freeze phase until edk2-stable202005= tag is created at 2020-05-29. In this phase, there is no feature to be pus= hed. The critical bug fix is still allowed. > > If the patch is sent after Hard Feature Freeze, and plans to catch thi= s stable tag, please add edk2-stable202005 key words in the patch title and= BZ, and also cc to Tianocore Stewards, then Stewards can give the comments= . > > Below is edk2-stable202005 tag planning. > Date (00:00:00 UTC-8) Description > 2020-03-04 Beginning of development > 2020-05-08 Feature Planning Freeze > 2020-05-15 Soft Feature Freeze > 2020-05-22 Hard Feature Freeze > 2020-05-29 Release > > Thanks > Liming > >=20 > > --_000_SN6PR11MB3197295A624E921ACFEEDC5680B10SN6PR11MB3197namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I create PR https://github.com/tianocore/edk2/pull/644 for this patch. =

 

Thanks

Liming

From: Bret Barkelew <Bret.Barkelew@micros= oft.com>
Sent: Wednesday, May 27, 2020 6:11 AM
To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io; G= ao, Liming <liming.gao@intel.com>; announce@edk2.groups.io
Cc: Leif Lindholm <leif@nuviainc.com>; afish@apple.com; Kinne= y, Michael D <michael.d.kinney@intel.com>
Subject: Re: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2= -stable202005

 

I just= looked into it, and I think that AsciiStrCpyS(= ) was the wrong function to call in this loop anyway. AsciiStrCpyS() will fail without copying any characters.

AsciiStrnCpyS() will perform the st= ring "slicing"/"chunking" that the loop seems to expect= .

&= nbsp;

The bug stands and we should try to= get that bug fix into the stable tag. Thanks!

&= nbsp;

- Bret <= /p>

&= nbsp;

From: Laszlo Ersek <lersek@redhat.com>
Sent: Monday, May 25, 2020 10:46 AM
To: Bret Barkelew <Bret.Barkelew@microsoft.com>; devel@edk2.groups.io <devel@edk2.groups.io>; liming.gao= <liming.gao@intel.com>; announce@edk2.groups.io <= ;announce@edk2.groups.io>=
Cc: Leif Lindholm <leif@nuv= iainc.com>; afish@apple.com <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com><= br> Subject: [EXTERNAL] Re: Hard Feature Freeze starts now for edk2-sta= ble202005

 

Hi Bret,

On 05/22/20 17:11, Bret Barkelew wrote:
> We’d like to ask that this patch be considered for the stable t= ag:
> [PATCH v1 1/1] UnitTestFrameworkPkg/UnitTestResultReportLib: Use Asci= iStrnCpyS()
> https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fbugzil= la.tianocore.org%2Fshow_bug.cgi%3Fid%3D2721&amp;data=3D02%7C01%7Cbret.b= arkelew%40microsoft.com%7C2698d0e553c04b47194c08d800d398b8%7C72f988bf86f141= af91ab2d7cd011db47%7C1%7C0%7C637260256091133309&amp;sdata=3DMDKQ1CKq9%2= B9AfPML0JxcND47UIcQUAibUSAVlfW5iZc%3D&amp;reserved=3D0
>
> The patch was reviewed prior to the hard freeze date, and is a small = change that affects new(ish) code that is not heavily utilized yet.

does the original issue (reported in TianoCore#2721) persist with
TianoCore#2054 fixed?

My understanding (from TianoCore#2721) is that the original
AsciiStrCpyS() call is not buggy, it just triggers a (per spec) error
condition in AsciiStrCpyS(). Previously, that would indeed trip an
ASSERT(), but AIUI that issue has been resolved generally with
TianoCore#2054.

If the AsciiStrCpyS() call remains an issue with the ASSERT() removed,
then replacing the call with AsciiStrnCpyS() still seems like a bugfix
to me, not a "feature", so I think the patch is eligible for mer= ging
during the HFF.

Mike, can you please merge the patch (if it's still needed)?

Thanks
Laszlo


>
> - Bret
>
> From: Liming Gao via groups.io<mailto:liming.gao=3Dintel.com@groups.io>
> Sent: Friday, May 22, 2020 1:01 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; announce@edk2.groups.io<mailto:announce@edk2.groups.io>
> Cc: Laszlo Ersek<mailto:lerse= k@redhat.com>; Leif Lindholm<mailto:leif@nuviainc.com>; afish@apple.com<mailto:afish@apple.com>; Kinney, Michael D<mailto:michael.d.kinne= y@intel.com>
> Subject: [EXTERNAL] [edk2-devel] Hard Feature Freeze starts now for e= dk2-stable202005
>
> Hi, all
>   Today, we enter into Hard Feature Freeze phase until edk2= -stable202005 tag is created at 2020-05-29. In this phase, there is no feat= ure to be pushed. The critical bug fix is still allowed.
>
>   If the patch is sent after Hard Feature Freeze, and plans= to catch this stable tag, please add edk2-stable202005 key words in the pa= tch title and BZ, and also cc to Tianocore Stewards, then Stewards can give= the comments.
>
> Below is edk2-stable202005 tag planning.
> Date (00:00:00 UTC-8) Description
> 2020-03-04      Beginning of development
> 2020-05-08      Feature Planning Freeze
> 2020-05-15      Soft Feature Freeze
> 2020-05-22      Hard Feature Freeze
> 2020-05-29      Release
>
> Thanks
> Liming
>=20 >
>

--_000_SN6PR11MB3197295A624E921ACFEEDC5680B10SN6PR11MB3197namp_--