Re: [PATCH V2 0/2] CryptoPkg: Add MARCO to disable MD5 & SHA1

["Wang, Jian J" <jian.j.wang@intel.com>]

For this patch series,

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: Gao, Zhichao <zhichao.gao@intel.com>
> Sent: Thursday, June 18, 2020 8:42 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH V2 0/2] CryptoPkg: Add MARCO to disable MD5 & SHA1
> 
> REf: https://bugzilla.tianocore.org/show_bug.cgi?id=1682
> 
> V1:
> Add new PCD to disable MD5 & SHA1.
> Using the PCD to remove the decalration and definition of the MD5
> & SHA1 functions.
> 
> V2:
> Using the MARCO as DISABLE_NEW_DEPRECATED_INTERFACES to disable the
> MD5 & SHA1. This MARCO would make the platform able to disable MD5 &
> SHA1 by setting the MARCO at their platform dsc file.
> In the future, if MD5 and SHA1 related functions are removed totally,
> we can remove all the content of MD5 & SHA1.
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Zhichao Gao (2):
>   CryptoPkg/BaseCryptLib: Add MARCO to disable the deprecated MD5
>   CryptoPkg/BaseCryptLib: Add MARCO to disable the deprecated SHA1
> 
>  CryptoPkg/Driver/Crypto.c                     | 320 ++++++++++++++++++
>  CryptoPkg/Include/Library/BaseCryptLib.h      |   4 +
>  .../Library/BaseCryptLib/Hash/CryptMd5.c      |   3 +-
>  .../Library/BaseCryptLib/Hash/CryptSha1.c     |   3 +-
>  .../BaseCryptLibOnProtocolPpi/CryptLib.c      |   4 +
>  5 files changed, 332 insertions(+), 2 deletions(-)
> 
> --
> 2.21.0.windows.1