From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.9719.1592794590945821640 for ; Sun, 21 Jun 2020 19:56:31 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GgiPa39q; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: jian.j.wang@intel.com) IronPort-SDR: cUlZTo+DYVYS2Bqp1AyKYmSk7DStIpI4AwL6TkcEw6U1+1ehGG6OG9dwnGLm2Pk0dIDNfRB7RV nU1MmxG34hvA== X-IronPort-AV: E=McAfee;i="6000,8403,9659"; a="132076169" X-IronPort-AV: E=Sophos;i="5.75,265,1589266800"; d="scan'208";a="132076169" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2020 19:56:29 -0700 IronPort-SDR: 2wht5DJwU8vDOdCbmeXjrYjTm8Hoxb786Kp5KhJKlNgdTNQELb+78Q1VMC5QnOGs8D42XqsTHG r13D+yUMKyJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,265,1589266800"; d="scan'208";a="278462282" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 21 Jun 2020 19:56:29 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jun 2020 19:56:29 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jun 2020 19:56:29 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 21 Jun 2020 19:56:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPnSCDOMa9AB/kmh8ueULsR68qpXgWmEQiTXHcI1ZxTR8Tzzt6xe6Mmvba3d+Bf3kh4k4GYELgDOL34tmbm7EySudk3unrTNPqXYurOybHYKRRmRrfcEjBP6G4x4v8iuvCBjq3Qp8Pr1V8WObk0vdCLuGAT4KAOQSvsvoE0pSQpmFGdopmtQdXzbQWsGku9uUe/Lr2LKysEXm0xdCOhgyj2KcBp4FM0oxt77SurWAFvHNfG733e1QcqmPYM7sGgfC1mZA/eXdEkuX5MycwpALPg1fiwNfbNpSDA7KN7BJEWn8/3un6PCqmFF6Bt2lwKKq1+F0+VxxWD0DiH9Dnip0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4uHcvzn/IgaT2WfYX20JKM+cXE8FmGGE7PKCJv7FSU=; b=MlTA1mmJ+Z5L2CnZ+alV3EOAfLOIHYiyKzoCTAabIu3zpTqSP0NX9zS1GpFi0e/YPDGRi+VmgzoJam7KbQtUiNtVC0WrFJ+trk/BWFaA9tSZ43lIlgUeEZl0P7w3Nf6mbMUNVi6p2jMxrf1VVj9fcc54GA9QOpGeE8zZjHMhYDomoIfHVV8Egy+4k2vOeSR2szEknFdPBy47SXn4lZVVLqAxibQksxOmc8ftwuGaULH477MZTkXR1WpoA8ml+5JtWdTpJ8HMbsEdyXoBqg7BW8eo7VNXP4RvmMbLGQORqzAg2VYlLqTPt9cq95Oi8BvRAsAGgSXfs17868rfl44V6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k4uHcvzn/IgaT2WfYX20JKM+cXE8FmGGE7PKCJv7FSU=; b=GgiPa39qgiEcCAULwiBaraTptRiBDezudQBAb2+LEvfiPWeCsV9MmL8PqTqWGlrqBBg0WIH5Q9dkK/PmeSS4bFkayv8+C9995dyN6+oT8zZH0wWBEifIGmkfyRZBJ4h+MJTfIyEcknst+d4rhM1j+VSeyzLN8O7BWPTuwJWkxII= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21; Mon, 22 Jun 2020 02:56:27 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2%6]) with mapi id 15.20.3109.026; Mon, 22 Jun 2020 02:56:27 +0000 From: "Wang, Jian J" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Lu, XiaoyuX" , "Yao, Jiewen" , "Fu, Siyuan" , "Kinney, Michael D" Subject: Re: [PATCH V2 0/2] CryptoPkg: Add MARCO to disable MD5 & SHA1 Thread-Topic: [PATCH V2 0/2] CryptoPkg: Add MARCO to disable MD5 & SHA1 Thread-Index: AQHWRQlV4dso/1NDG0q1rSxr1WpkK6jj90hQ Date: Mon, 22 Jun 2020 02:56:27 +0000 Message-ID: References: <20200618004137.40276-1-zhichao.gao@intel.com> In-Reply-To: <20200618004137.40276-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08e14410-1d18-40f6-edce-08d81657db8c x-ms-traffictypediagnostic: SN6PR11MB3312: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2803; x-forefront-prvs: 0442E569BC x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Q2h+CNb1Ac6isBs3p0Z5EFFOUpgE7S2hh/V0AHt8YKnucozv0ZGT3dEAcM+P+mu2eKBER53VJ7gJpF51nDPak096+YSaPHVE61HNIx2hQLpaygP8e54WOALsRsle2NrjIvmEXk04amfx1W95VbsEJ0nT0Qm4VzRq7VCaTK9P8P+IgjwFOQUr1SWqkvnJVrHUiOOVTqoHI6ODgXWOnBJ09DHjTaqcHMCrsZ5ao3wb/wMER65XLidmt5LHeEuiHTRgAeSaDzyeVQweTRU/sEtURItTeqnWZq3aGtNoHIwkW+4/Cn4I4n/cbdKlkw2emqckFJhsK0Ic+APv0fjUJpSyJHsS7kKrXv9XUt8zdBHhb1BVzfz5smIUSIBHgZvzP+OJ48SCtE5Un2ifvNdkjg1vLw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(39860400002)(346002)(376002)(366004)(396003)(64756008)(8936002)(54906003)(8676002)(110136005)(86362001)(5660300002)(66556008)(66476007)(83380400001)(66446008)(76116006)(2906002)(66946007)(316002)(19627235002)(7696005)(33656002)(71200400001)(55016002)(6506007)(478600001)(966005)(53546011)(52536014)(9686003)(26005)(186003)(107886003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: 4Sq/rPzPpt+Bo3L6xzUvJQxGecroljdHOoqnSbnwWkFKZsDZeZBf439PL/Zsl+7pizWbezuDjFhuSIjZBvCrtNTrHi/76radc00cynatCuiZEW+JRV5NmvYuX69Ni4fQjqsH7kBfANF+EgyaGI6Xw7EgbDKXGAJp770ayar26DOrS5CxirZ/G6mUS3equ8MVQmSDDA52vywZmiB+U11wGjIWWe2LJ8mzgLunFz0bABmiDY/zDlpQIivjw+N1UkUKfSu/Bw72xpegAfEHWMOsdZR7rWHZPj5OXDMIL451kfp1kdrLwV+wPeTkW1OD16owpv/1yxApUu9NA2PQZoqrfqdb2z+6dYFGjbchpv9W8Do7V2KxJgxz1CjOWauAs3He33TCfFK6juDAjJHr6nvlYG0TXKH3Yxh2DDm6r+tSlUKSoKMIckCSVrqE7gH1JHu8L/cMmESAUsDtl3qt1rK6eepTPbV2JV2/jdIiQmcxNK7SxU9W5ssJYuPWDWoOJs7H MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 08e14410-1d18-40f6-edce-08d81657db8c X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2020 02:56:27.2178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DLv3KsIDqnWU9IH6tHDeUTrpbbrhhyGX25+fFnGHBby5aAzyCYE/ETB1TNltkGW0l20fLkiTdC1b0Ar2cq6edQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3312 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch series, Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, June 18, 2020 8:42 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX ; > Yao, Jiewen ; Fu, Siyuan ; Kin= ney, > Michael D > Subject: [PATCH V2 0/2] CryptoPkg: Add MARCO to disable MD5 & SHA1 >=20 > REf: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1682 >=20 > V1: > Add new PCD to disable MD5 & SHA1. > Using the PCD to remove the decalration and definition of the MD5 > & SHA1 functions. >=20 > V2: > Using the MARCO as DISABLE_NEW_DEPRECATED_INTERFACES to disable the > MD5 & SHA1. This MARCO would make the platform able to disable MD5 & > SHA1 by setting the MARCO at their platform dsc file. > In the future, if MD5 and SHA1 related functions are removed totally, > we can remove all the content of MD5 & SHA1. >=20 > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Jiewen Yao > Cc: Siyuan Fu > Cc: Michael D Kinney > Signed-off-by: Zhichao Gao >=20 > Zhichao Gao (2): > CryptoPkg/BaseCryptLib: Add MARCO to disable the deprecated MD5 > CryptoPkg/BaseCryptLib: Add MARCO to disable the deprecated SHA1 >=20 > CryptoPkg/Driver/Crypto.c | 320 ++++++++++++++++++ > CryptoPkg/Include/Library/BaseCryptLib.h | 4 + > .../Library/BaseCryptLib/Hash/CryptMd5.c | 3 +- > .../Library/BaseCryptLib/Hash/CryptSha1.c | 3 +- > .../BaseCryptLibOnProtocolPpi/CryptLib.c | 4 + > 5 files changed, 332 insertions(+), 2 deletions(-) >=20 > -- > 2.21.0.windows.1