From: "Wang, Jian J" <jian.j.wang@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Tan, Ming" <ming.tan@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data
Date: Wed, 17 Jun 2020 02:46:59 +0000 [thread overview]
Message-ID: <SN6PR11MB3312195BBDC9FC6D4A468E9BB69A0@SN6PR11MB3312.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200615020344.39959-1-ming.tan@intel.com>
Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Regards,
Jian
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Tan, Ming
> Sent: Monday, June 15, 2020 10:04 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do
> not output \n\r for string data
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787
>
> When output string data through serial port, will not ouput \n\r now.
> Caller can output several data in one line, and output \n\r when needed.
>
> Signed-off-by: Ming Tan <ming.tan@intel.com>
> ---
> V2: Make it as a standalone patch.
> .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c | 2 +-
> .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c | 2 +-
> .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> index 2455f8b2a908..3aa5642b64fb 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c
> @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker (
> CharCount = AsciiSPrint (
> Buffer,
> sizeof (Buffer),
> - "%a\n\r",
> + "%a",
> ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
> );
> } else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> index 2dc3ecfff52e..0b98e7ec6315 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode
> Worker.c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
> CharCount = AsciiSPrint (
> Buffer,
> sizeof (Buffer),
> - "%a\n\r",
> + "%a",
> ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
> );
> } else {
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> index c0c907b32f5a..3df0a6712611 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.
> c
> @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker (
> CharCount = AsciiSPrint (
> Buffer,
> sizeof (Buffer),
> - "%a\n\r",
> + "%a",
> ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii
> );
> } else {
> --
> 2.24.0.windows.2
>
>
>
prev parent reply other threads:[~2020-06-17 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 2:03 [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Tan, Ming
2020-06-15 3:25 ` [edk2-devel] " Dong, Eric
2020-06-17 2:46 ` Wang, Jian J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3312195BBDC9FC6D4A468E9BB69A0@SN6PR11MB3312.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox