From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.4167.1592362023711889503 for ; Tue, 16 Jun 2020 19:47:05 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=hUj3Kteh; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: jian.j.wang@intel.com) IronPort-SDR: zbatJGIF3esaeM+VqhQO7hRGaCraVo4MTZSHoOypZ0vFaOckLrSi+yIzzoUedXPftw2koctAm+ wUY2lFdUexNA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 19:47:02 -0700 IronPort-SDR: Wr6aAaU2cfu/OLkf9jVSDl3V35l9TNm9oJkz0FseVnG9fg3Qp7eCQaiLxhPEicbtoFQ0yhJ1IE o6zZ0rjnCoZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,520,1583222400"; d="scan'208";a="277134294" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga006.jf.intel.com with ESMTP; 16 Jun 2020 19:47:02 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 19:47:01 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX161.amr.corp.intel.com (10.22.240.84) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 19:47:02 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 19:47:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HHRh4RXorPMJj9drbXiCTUXUbhjjlZZPnt1SVuKPXdVMyOgOx2rsxZRmBJmjnOkfAZS0tTsiA0KPdINfteMwVOz0Ggzby/pNxsaIkhPMY/kz3JlenVZh4nrTemJNvAWaLPEEOIZLChsnBp0CASqFUIC0Ms9BIgGYxKcT4qr86IR1b45aHqWb11buix/od+snY4O06PoxqSGqeEmbDLxtO7DrJFk11/2UfxUqF7UXrn6uqw5oaw76Q5oKfd2zT8gAbOD0VhPklS7chd/JvZcm8xVuNI15LAF0ZOh2JbjbN+eNNsWLbPLD3CqqHgam6Gw4dh3kvVTN3KlHn1SkcyxEkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GFsmS39r3lEn1RIJQ6TFvXIxzoe48+1Uff4vtaBCkng=; b=YFc0BaZ6Qp3xvtnaY/Jv1MJQoRR4KmvwDcfk0Q+lJllv2rxYB49V2ozuCYiCeFwmKvRr02voXQdxWbBIbvAOdzSczgv4R3qvJKuqRMzxQclBsQnEB9VvZR7hKRkJSjLkck+R8s+hBvqR1sTEWhumTCT/N7CQVoGzk1gGcPBQ1oaYIeQLc5uK27Stqt2G5EoEWyfjM0E92A9ODtN+z3cFExe5Kv9Z+sAWuGY+KWkNG0VYS4Ryb6xAm5aWs3itjmu7RYiJ57cJy1Kg1uYQ2rOUHka3IwzuhxqEzAnwr6akRsxVXBms95yT5UKr3qopW5zt6pQi4+ibBybsOgO7BVUJVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GFsmS39r3lEn1RIJQ6TFvXIxzoe48+1Uff4vtaBCkng=; b=hUj3KtehMdd/0gQsfHAzwJbXK/tAdEB/Q0EsG8uti9JGVV2wXcAHXqefm3aKNe308VaMKdxD9d7eu4DlIWc5udvpoK+OLYcnNqIW0/FP5O692zZlkmee7fvDRC3QvZBut+23449zIbAXKwM22yOEfkifU3AG6O98XAqqtUD8o88= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SN6PR11MB3407.namprd11.prod.outlook.com (2603:10b6:805:bd::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3088.19; Wed, 17 Jun 2020 02:47:00 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2%6]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 02:47:00 +0000 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Tan, Ming" Subject: Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Topic: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data Thread-Index: AQHWQrlrPzGPvMSDs0Cefxf/1bxJeqjcHaLA Date: Wed, 17 Jun 2020 02:46:59 +0000 Message-ID: References: <20200615020344.39959-1-ming.tan@intel.com> In-Reply-To: <20200615020344.39959-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6d6730d4-39e6-4644-1691-08d81268b550 x-ms-traffictypediagnostic: SN6PR11MB3407: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:81; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OFx8J2szL87zt7fG7Iq6upWIKLszEcgkjQFqpUKfyyr7lmg7Dy+ixqpwRCMDdwzHBxrRTZqRQYGtK7v6iHin/uF+kH5jSrlf0zXSikHp2ad9lt50XPvb9eGvqcenWxQOwSNY/8kjhOG2mqvJl8kjmbBpacVytXw7X5Nm/GGTEf3QMuqyhgs81VWoX0GsMtCUCjAC1EZheYRjc29Uiiw5rzic0/uuzhBq49aP//WGDGp17Xe0a+7S06tdLz/s0dUyqSk/AB7YB+e+tO18vTcL+OgY7vOB5UtYatb8qVV26m8NvCJgpSngt0/88e6Hpo6zkNNrdsgRhbQoQLRq63yQo1AQHH9D+Qyt9iswc04EaS7Lt0sNNDE36DMh+5rO7EkBw6R9MgZa+HBsXeKxWnGiRg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(39860400002)(346002)(366004)(376002)(136003)(396003)(66946007)(86362001)(6636002)(64756008)(316002)(110136005)(76116006)(66476007)(71200400001)(83380400001)(66556008)(66446008)(2906002)(33656002)(26005)(8936002)(53546011)(9686003)(6506007)(52536014)(478600001)(966005)(55016002)(186003)(5660300002)(7696005)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: kS/Sbl+kPIwk6Ki2HpHzSG+zaBKApEAn2ZbM5Jd2CPpFjaaY3xtwFNZSCZfZDZaTvLl7GU4cpjgUZ8qruqFCK4NAZ+kXr/JXtVE27v+m8ePz3Lm8BWYrDqnPJiL2lkue6G1OHcOK+DLjolBGyFcGXXRu7n6uC6ixrO6CXNvOUBIV30NoEMofUbsFMrSTm7KaTHVEm1NEuReIY5vGObwxSEGgySCBTKyZDYt0EgTd6ULh4vbWXbrIBQGdjsr1XdcAI3qumJK4msqapJIQWI/wFTTirvL64RgZYc9Znrcln5bky+Tp0BsVX6dNza+YvKEaoYOfN0pld0wIwa5dPU2DgiTiyKG/5Gg19HrxRC877pOuG399P4o8pMnXX/VrdOqAMqjRXo4c95JK9SmPQJVO98rdHPc1s2mhO8zj+oZWleMXr9AJ7erkCqJqHhLJlQoiiLPvbmuUCZE9WkTKCnceQ6W5dCFYl7RkLVzqxLYQa9L+CNswa6CEm/WMLSdkAuMe MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6d6730d4-39e6-4644-1691-08d81268b550 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 02:46:59.8180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: S1UQvA1Ylp8ROX/JCnuCJXXAS4gm81P1njguYXSVYwIfXy3k6jibaKz60yUKnDzSlv+RXE83hr8DOXf3aTSttA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3407 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Tan, Ming > Sent: Monday, June 15, 2020 10:04 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do > not output \n\r for string data >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2787 >=20 > When output string data through serial port, will not ouput \n\r now. > Caller can output several data in one line, and output \n\r when needed. >=20 > Signed-off-by: Ming Tan > --- > V2: Make it as a standalone patch. > .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c | 2 +- > .../StatusCodeHandler/RuntimeDxe/SerialStatusCodeWorker.c | 2 +- > .../Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c > index 2455f8b2a908..3aa5642b64fb 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c > @@ -134,7 +134,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode > Worker.c > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode > Worker.c > index 2dc3ecfff52e..0b98e7ec6315 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode > Worker.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/SerialStatusCode > Worker.c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker. > c > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker. > c > index c0c907b32f5a..3df0a6712611 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker. > c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/SerialStatusCodeWorker. > c > @@ -129,7 +129,7 @@ SerialStatusCodeReportWorker ( > CharCount =3D AsciiSPrint ( > Buffer, > sizeof (Buffer), > - "%a\n\r", > + "%a", > ((EFI_STATUS_CODE_STRING_DATA *) Data)->String.Ascii > ); > } else { > -- > 2.24.0.windows.2 >=20 >=20 >=20