From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.19612.1605670536289229934 for ; Tue, 17 Nov 2020 19:35:36 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QDrCVBaP; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: jian.j.wang@intel.com) IronPort-SDR: ZkhJuJqzpiQmB2n4JmPZBHfYd9sJQgoodv4TnUBreJuDOo+VA8jkuTevv1Pu0WpnVTFcjBrKAs PkE2js23hr1g== X-IronPort-AV: E=McAfee;i="6000,8403,9808"; a="170278081" X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="170278081" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2020 19:35:35 -0800 IronPort-SDR: imUtEObZ/3/4UJ6YnqsyA4INCDR40KAYkOx7Eo/J/EYNuFwfx/GE+eGuzGj7wpXqYkIoHwqt5w 3aGTznq8eugA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,486,1596524400"; d="scan'208";a="359157894" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga004.fm.intel.com with ESMTP; 17 Nov 2020 19:35:35 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 19:35:35 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 17 Nov 2020 19:35:34 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 17 Nov 2020 19:35:34 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 17 Nov 2020 19:35:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRiKktIZ7UcqGwWwhpOdD9W0Zg5xgd+39fFfiZS6wfu5YzmTCPN3fmCBUTqt46dS5WQhYI218MX8BXBgme/pt5yeyt3ciksf45KXsgNHpceeKPUQBdW03Pn10SnfWQ+nINf6w5ajIzCilCb5xlvKr9GIgiYNn2s1i/WYUgcOixj0bBhOdB2VlsMcG8NMWOc9HGsRtW3rhvvtzV6Mw6vRWnlUMW5a46Aa5D0n9z8AibKjZs1G9iw1TsurN1ZCaPExQjNTm/vs9hSbWkt01OroHCKJBuLQTPmrv/a7ckVtDVcXb3T8dGPI2/LjVQiyVyrkC0CaKIj0Ej1F4+SnlAuajg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n610tuHAWD5+XFHafg/EZKLG8TPDOqDOvBux5kvELHI=; b=Q+yZOOv6L30W6pIKpcfhZt+suNFrGKGJdV/DtlRsS+lPrYiKz0v+QMVR0x3L6DSuOZdieObUHGniuZznEK2ZluYxJNVU9Gn9BwQPuOUluPPyXVPcEgayPzx/a5U07JEJd8s89NBJmPy1t7clNM/tfc5NjkRwkirVst7KpqjM4Qx0WA4YQhpuGJWAJ/4x26GQVfd6ec44sO31KxUHaFZBS733bCyvYpac+z6qasDBLEMf5FOh2+Le3kYlhFQbhnFSgEHX9ulhGoulaEnte3lWUl2uWRiCSmZymJ1QIUlAsr8/yMD0B6i4eXTzZm+VjaJrZUBmw+KYCfLwPNiBtVKxYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n610tuHAWD5+XFHafg/EZKLG8TPDOqDOvBux5kvELHI=; b=QDrCVBaPpIv18+eL2D65c8GwI//j+EI0o2ymVJXByzeE+OnYrBlxUsUSZ1KJZg82tZGlZwKmpXgxqZmo99u9jvlkMDPOZ76yLY9uSpnc/9ajRU8snkfqaVz8ARqFRNDZcRnjzSNPIUfKBUXNyy1bVd+4rtJjsEkvyRWQRSnjXGQ= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SN6PR11MB2911.namprd11.prod.outlook.com (2603:10b6:805:d2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Wed, 18 Nov 2020 03:35:09 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::a437:a214:838b:64f8]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::a437:a214:838b:64f8%5]) with mapi id 15.20.3499.034; Wed, 18 Nov 2020 03:35:09 +0000 From: "Wang, Jian J" To: "devel@edk2.groups.io" , "Mistry, Nishant C" Subject: Re: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib Thread-Topic: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib Thread-Index: AQHWuHzmZlCQrDbnTEmuG2uUOQVM/anNRpOQ Date: Wed, 18 Nov 2020 03:35:08 +0000 Message-ID: References: <661e44cf628ae7315fc738b64a52736f6b5b5285.1605047447.git.nishant.c.mistry@intel.com> In-Reply-To: <661e44cf628ae7315fc738b64a52736f6b5b5285.1605047447.git.nishant.c.mistry@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7015e5d-52c9-4e4e-76dc-08d88b72f2e0 x-ms-traffictypediagnostic: SN6PR11MB2911: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UOvU9sX5Kzt1sRhFZZhM9nP1hVhheLC9GDgE7Id+3VWWAfUu0QgI432j+90DD5aSEJqU9gcAMi3FGZ69AmyNSdwteorPs0WEiImJRSrh0RxkFCfD0VCUxd23Hb/oxGCI4g4IDPKYAegc6p4whCG1/hYvYgeUZXAqijWrwT5tpOLMS1skmr+ckEzgCYeXJW2bAi1rNQJIHarSFIQJzWwRHDnxV/fWsZUU2rZFfB0cSYsuo8XwYz0c/LtF9sQoZ0iZwNjc9ECsFqrKHg6LychGoQAFPSDApslNfvkK4rVWxz3ry9WAgzLiRzCXNazwmo0dSwUPgVJCo5RNf9nnk6isoBC4A/O9PcjehkPzuHccKIxjX+1O3HxCQp7IVMc7pgh7TXNs3AHYkUTfHt8Sx59Zng== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(396003)(376002)(39850400004)(136003)(346002)(8936002)(5660300002)(9686003)(55016002)(52536014)(86362001)(110136005)(316002)(2906002)(66946007)(76116006)(66556008)(66476007)(66446008)(64756008)(15650500001)(8676002)(71200400001)(83380400001)(7696005)(6506007)(53546011)(33656002)(186003)(6636002)(966005)(478600001)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: zxRU5MfpcDMO4G69LwplcZuidhzV8fqi1cyS/8zmClBB1UcbJy0QYhuQtt48V5AQ8/ZdeWSb3vM6wn41c9hWJvCsazNKfiXrxpojxayoqouAbiXnaeL2MZg7lM3mQCRi0xz/lP1HUZd1tGO0XzuM/nV74BWWB0gf3dFclPp4KcbZ3mODvgd43j7cRgyDl8P92QhmdrujiGh8YWLCKMtBlRCDBbPAN77miAenNFk+e4a7ag6+/9f8IO/3imMkV5umJWhygJPeFEze+eoWNYQfgYzuEFCQqfxi+axyb+lpOPa+8Qs7stgxDNR5N0EuwCyuuecgQENTbX62/oq9eRwA7Uay6ZchCQE4XtqMCBlJxmDwjz1hUPGJQuh+m8+YO3omvMQ28pSzvTzDmT4UvOuSUo01cx3Plh9YjfMVTZfOS/kjcLqmH6cvXWrkJNYF7sAj6iS7JbBIcfrCSSAKIHelSF71poDPuXK0ltLdM2glSF/0lTVcvpnFlu8Q8SFL/54sAKSwPIxhuzclXoekv75nvkWyZxzJw/mpDZMaC1DanW6DZRlrgigJ/uFZfSX5uZCanG4/fwR/qebuCjsOLFPMxQc49l0Ps4zVKLZt7cHsYDY/QIaUdAfxlix+ZRwMOD5rJKlt7+uJySoLhsPkarPhPQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3312.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7015e5d-52c9-4e4e-76dc-08d88b72f2e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2020 03:35:08.9075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: V5IiBJ/LU0DQCHbTLx3IrfWTfM3xRtxJG4LwIlz6tf//3OWBeAv6sKq3ujLG/Euvtj+UO4znqxlx68qnOOmD0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2911 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nishant > Mistry > Sent: Thursday, November 12, 2020 2:49 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 >=20 > The re-design requires multiple RPMC counter usages. > The consumer will be capable of selecting amongst multiple counters. >=20 > Signed-off-by: Nishant C Mistry > --- > SecurityPkg/Include/Library/RpmcLib.h | 6 +++++- > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +++++- > 2 files changed, 10 insertions(+), 2 deletions(-) >=20 > diff --git a/SecurityPkg/Include/Library/RpmcLib.h > b/SecurityPkg/Include/Library/RpmcLib.h > index 5882bfae2f..3c15bce1ce 100644 > --- a/SecurityPkg/Include/Library/RpmcLib.h > +++ b/SecurityPkg/Include/Library/RpmcLib.h > @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > /** > Requests the monotonic counter from the designated RPMC counter. >=20 > + @param[in] CounterIndex The RPMC index > @param[out] CounterValue A pointer to a buffer to store = the RPMC > value. >=20 > @retval EFI_SUCCESS The operation completed success= fully. > @@ -23,12 +24,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > RequestMonotonicCounter ( > + IN UINT8 CounterIndex, > OUT UINT32 *CounterValue > ); >=20 > /** > Increments the monotonic counter in the SPI flash device by 1. >=20 > + @param[in] CounterIndex The RPMC index > + > @retval EFI_SUCCESS The operation completed success= fully. > @retval EFI_DEVICE_ERROR A device error occurred while a= ttempting > to update the counter. > @retval EFI_UNSUPPORTED The operation is un-supported. > @@ -36,7 +40,7 @@ RequestMonotonicCounter ( > EFI_STATUS > EFIAPI > IncrementMonotonicCounter ( > - VOID > + IN UINT8 CounterIndex > ); >=20 > #endif > diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > index e1dd09eb10..697e493a7c 100644 > --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > @@ -12,6 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > /** > Requests the monotonic counter from the designated RPMC counter. >=20 > + @param[in] CounterIndex The RPMC index > @param[out] CounterValue A pointer to a buffer to store = the RPMC > value. >=20 > @retval EFI_SUCCESS The operation completed success= fully. > @@ -21,6 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > RequestMonotonicCounter ( > + IN UINT8 CounterIndex, > OUT UINT32 *CounterValue > ) > { > @@ -31,6 +33,8 @@ RequestMonotonicCounter ( > /** > Increments the monotonic counter in the SPI flash device by 1. >=20 > + @param[in] CounterIndex The RPMC index > + > @retval EFI_SUCCESS The operation completed success= fully. > @retval EFI_DEVICE_ERROR A device error occurred while a= ttempting > to update the counter. > @retval EFI_UNSUPPORTED The operation is un-supported. > @@ -38,7 +42,7 @@ RequestMonotonicCounter ( > EFI_STATUS > EFIAPI > IncrementMonotonicCounter ( > - VOID > + IN UINT8 CounterIndex > ) > { > ASSERT (FALSE); > -- > 2.16.2.windows.1 >=20 >=20 >=20 >=20 >=20