From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.5790.1594366375854437074 for ; Fri, 10 Jul 2020 00:32:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Cz57mwbS; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jian.j.wang@intel.com) IronPort-SDR: bOvpRglstJ2d8FxCsw3rpmQUXlqT0dU1uAe/sQnOzZ95j6bYFAJoMmsIQooDaxJdWtAZe78cJW CwEHmbsQ87HA== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="135629635" X-IronPort-AV: E=Sophos;i="5.75,334,1589266800"; d="scan'208";a="135629635" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2020 00:32:43 -0700 IronPort-SDR: Qum6+sAmMdSLUCbN1zXjEIU2gI+9ucubn2FC7CxcCbxA3xWCI2keCTHBAD0e3GYyS2CXxVdpDL t7jPTxbldLag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,334,1589266800"; d="scan'208";a="269002481" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 10 Jul 2020 00:32:43 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jul 2020 00:32:43 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jul 2020 00:32:42 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jul 2020 00:32:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lD97ypltcDWo/PfK1Ymf6mu4Q4+rnDZ7537fhK6DnWIe2Yfgkk9DcEge7mBR6I6VuzHHR9hW4hF5FUPmQcjJvdkpBz+2oA+YDBuzKS1RD3r1bhIJA/vGLDqGJQ4oY2JPjbQawfiUo5i3I5QE/B3Mm1eZMWKa9KtPfdIGQGNmxXWmUFNCggS+P8bqPaHaEYtni/1UWipMu09o5xzLmPnGgmWIy5umddNtaH3PLXrbaOSuwulBZY7V6ahddSkzrWc+hd6UUvs1Wn9iLId5r04JeR+92GkjjxBM7uZTQQZ5M3Jwu8kvkYZMOTm8kIJ+DoqY+B1BsvnCxk3bSaAH7M+wgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3sdFenVXDMfCQy6/BOn7wi42+nvmoDhOdld199Cj0yg=; b=ZQUAASOfzS4mLPiznckaag4NeKdWRsbwAZj6Y/Rj0p+mGQV7uv9cVzsewAT2VNs1WdG5UQKCY/uGmTYzJic6WEgF1xycjHVjA8KlvRAxrpNV5sSNS62xeJB+wKE795SWVw8WZqgolhIAy8ciDsBPBm3ky+y7CNfxt7CQnSOwm9ipoESJAquVC5+gxBJO4ntb/PdwoVbSWtf8kh9bk6HwD/zQXEy/UBsawmTcMjsCNK4gLatwhUcCbSQRV2nsRo/chjK6YcZ1OG/KGbe0rOSoSMSfk8dDcSGxi/rQ8mGAMEkucH8qLDg1T6YNCV9qFh7HqV0EbNOzmbih3R+NFj8kRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3sdFenVXDMfCQy6/BOn7wi42+nvmoDhOdld199Cj0yg=; b=Cz57mwbS1BfncqfNUXY+g2JZ709NDZ3xOJsimQV1YSopN/P4T3szkTbrUlUBwqfl1JKCwG7rYCONOj2Sj2Na7+LlorqsMx8cSpMgfnkMabXtqLGwzzGLJZwXbFcV6EA10LZ8VlwX8Xl7KRQ6KzDNspZJo7oxpHGVmJOa6hzQpqE= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SN6PR11MB3311.namprd11.prod.outlook.com (2603:10b6:805:c1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Fri, 10 Jul 2020 07:32:41 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2%6]) with mapi id 15.20.3174.022; Fri, 10 Jul 2020 07:32:41 +0000 From: "Wang, Jian J" To: "Yao, Jiewen" , "devel@edk2.groups.io" Subject: Re: [PATCH 01/14] SecurityPkg/Tcg2Dxe: Add PcdTcgPfpMeasurementRevision in SpecId event. Thread-Topic: [PATCH 01/14] SecurityPkg/Tcg2Dxe: Add PcdTcgPfpMeasurementRevision in SpecId event. Thread-Index: AQHWU0HuBwiyQYTsc0qwXl7erLrNh6kAcgPw Date: Fri, 10 Jul 2020 07:32:41 +0000 Message-ID: References: <20200706030239.1280-1-jiewen.yao@intel.com> In-Reply-To: <20200706030239.1280-1-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjlmNGExNDktYjZjOC00N2E3LTg0YTEtYjc2MGY1OTY5MWUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUHVRcVZzRkwrNDgrWVFkRkk4T0QzNjFXY1ZaTjJuXC9XWUhoc0I1WldBSGNSNk5YMjZ2YlhFVytKMHlPWFdZbmMifQ== dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c5de930-8a08-4bfb-6ec3-08d824a36e05 x-ms-traffictypediagnostic: SN6PR11MB3311: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:466; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pCI3e+QzsLAA4+W+lW1OZkf0bju3oRW4DDcDy3MG1zZqMo8W99SpFRZZSsmaVTkHl3yR1Yjzq7WxRVul4ShTA6jWSun/ZZ8wDuMoozBFYdbYJDTpK555Df+a6fb4bGQ18eKMSsYoZQn+vIfeOFsLXthXV0tYbECk00IPmtsjWrAW3ZdU2MpmkTUaxV6XHib9z2qY2oNFWTQz6K8BkW+Jas1Do5/xhul4dyTgvEHh9bqvk0ukQjwBmVtnwQa27g/XunUKBgiGZBw/mqk/EKDGQQSVZyItlwpfCQIp3MKc3x0je3kw40mJD+bDxfYTat67hwDOTZ4moebVrZN0qXC5YV9XG54kx39mJRzAiJhzvUlnkNDOlemO4s3dF2OBJs9pMmrOAL0c9WOZEym2x9KZEatwS4tk70T01xeHzPmw2uJ1uXT7yyzTs4z2xmkvooDmnMfC2Oytj9d/FOB2Gtfr8Q== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(136003)(396003)(39860400002)(366004)(376002)(346002)(71200400001)(186003)(26005)(19627235002)(9686003)(478600001)(55016002)(5660300002)(6506007)(8936002)(53546011)(15650500001)(7696005)(66946007)(66446008)(64756008)(66556008)(966005)(83380400001)(52536014)(86362001)(110136005)(66476007)(316002)(8676002)(2906002)(76116006)(33656002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: MhPSlGE1G931r+ZAQCYGG0iJm1jEVOUXXM66EGX3BO871Nu5iquFVHGHuvTAoOf3IIrSgkimahxSvMcngs1UFu7sncnEJYMhUCq8iQk+7ni8m2gEN9mlKbyj0PDR6LlDfWoRqzgGUxgp4ZMStIAY8iooLYiA2kgka9JvUjjw8tzSJBoJGc4qAUx5e2Wt5gT5IuO7J7JtYS3OakG6b79ojK3MQMpx3z+II55rV5v9LUolFWFdXoy7AT5K8A2V9F3EZgRQX7IaPnMiyVbqLWa9JqxX7NYGhD9/McglWbPqT0cQGxqZCJ9Fp+QjGdxBo/Uap3su1X40apoUL0i3gzhXI49znV/QxXDQMKxmw/N0tLsmScklNbMuTIX/mhYSDVlu80ElRlzfYGPYXbZlaguhx7dO2jVPO9SqkRiDDDvWTNa69nPhMN7xRziWwEtRV3AfbsT9xa+s4HLqjuxXsMSuuaXdkOhQEptaDSkOmTIcAfnU2GkVRYVQnD5aZIYBXu5I MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3312.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c5de930-8a08-4bfb-6ec3-08d824a36e05 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2020 07:32:41.5874 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c8WHTfzfFSf0GFpzEpmNRwFel23bn7nRLz7aCIGNzoyFaNXZrsw3SdASOdIcUmyjuwVqap/Qs9tq09rGlQBCjw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3311 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Yao, Jiewen > Sent: Monday, July 06, 2020 11:03 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > Subject: [PATCH 01/14] SecurityPkg/Tcg2Dxe: Add > PcdTcgPfpMeasurementRevision in SpecId event. >=20 > From: Jiewen Yao >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2839 >=20 >=20 > Cc: Jian J Wang > Signed-off-by: Jiewen Yao > --- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 2 +- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > index 9a5f987e68..6d17616c1c 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > @@ -1589,7 +1589,7 @@ SetupEventLog ( > TcgEfiSpecIdEventStruct->platformClass =3D PcdGet8 (PcdTpmPlatfo= rmClass); >=20 > TcgEfiSpecIdEventStruct->specVersionMajor =3D > TCG_EfiSpecIDEventStruct_SPEC_VERSION_MAJOR_TPM2; >=20 > TcgEfiSpecIdEventStruct->specVersionMinor =3D > TCG_EfiSpecIDEventStruct_SPEC_VERSION_MINOR_TPM2; >=20 > - TcgEfiSpecIdEventStruct->specErrata =3D > TCG_EfiSpecIDEventStruct_SPEC_ERRATA_TPM2; >=20 > + TcgEfiSpecIdEventStruct->specErrata =3D > (UINT8)PcdGet32(PcdTcgPfpMeasurementRevision); >=20 > TcgEfiSpecIdEventStruct->uintnSize =3D sizeof(UINTN)/sizeof(UINT= 32); >=20 > NumberOfAlgorithms =3D 0; >=20 > DigestSize =3D (TCG_EfiSpecIdEventAlgorithmSize *)((UINT8 > *)TcgEfiSpecIdEventStruct + sizeof(*TcgEfiSpecIdEventStruct) + > sizeof(NumberOfAlgorithms)); >=20 > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > index 576cf80d06..7dc7a2683d 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf > @@ -106,6 +106,7 @@ > gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev = ## > CONSUMES >=20 > gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableLaml = ## > PRODUCES >=20 > gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableLasa = ## > PRODUCES >=20 > + gEfiMdeModulePkgTokenSpaceGuid.PcdTcgPfpMeasurementRevision > ## CONSUMES >=20 >=20 >=20 > [Depex] >=20 > # According to PcdTpm2AcpiTableRev definition in SecurityPkg.dec >=20 > -- > 2.26.2.windows.1