From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.57951.1597714629951104006 for ; Mon, 17 Aug 2020 18:37:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=gx/GXd7x; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: jian.j.wang@intel.com) IronPort-SDR: dBb5CzIqdqqPcDfZTdHB9w9dnLgUYrfEXHAomvk6dlziP4FKfqflbAM2/FAnc36qCBFdla12wZ 5q87vtjuVy2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9716"; a="152455602" X-IronPort-AV: E=Sophos;i="5.76,325,1592895600"; d="scan'208";a="152455602" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2020 18:37:09 -0700 IronPort-SDR: UQ9WwGfEHiFHJbX6UVAP/+h7/X4UWEvNTPEQ0b6nZNdPvVRfOz7r48ijrPBh4vXj004nFT5647 /gq1Y0rifyAA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,325,1592895600"; d="scan'208";a="292610449" Received: from orsmsx601-2.jf.intel.com (HELO ORSMSX601.amr.corp.intel.com) ([10.22.229.81]) by orsmga003.jf.intel.com with ESMTP; 17 Aug 2020 18:37:09 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 17 Aug 2020 18:37:08 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 17 Aug 2020 18:37:08 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 17 Aug 2020 18:37:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwBYYv0xfrE6cPkO3oS3FKqxHF/PNVt30LC+tlBjKDpiDmK2DCht4ZRL+AM1lkHan6izk1T27fEww6pm5z1HU7CrCnHsYS3TXoQ3YF7tdjbnMmYlxy0XnRsbTVsXBNLu+ayx0o+WbpQWh4Yr83M3rQOwm+MqlYsrHs6FABIT4o+FN5PB1nGeuWfbsV4nKTwUYKFDXfIqKrEtck/dCcM3imLttbQHCBpYm5n9tucruIqBwpAv0CmW/aFUUW9mIDUtoIVGP97+LH4w9rnXRwIzuxuuD+3GCkxp9z2Ue+ykZTXUBHBIrMIaZeQ3FhkeCvT2ga0HHrON1Dp5W1VB9+Ni5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UqXGhDjdFtxrOJ9xdzR2A3lZIoLPwfG2Q46gFtZBWE=; b=mS3qtALy99VojDXprxWYzVF4usYmD4/M/F2S6NQklGgACTXIdix2Pk/VOSwHWRI+O1pM3q6M25WUmYbWVMdXCGgfm5ZoJe1t6MhrdFg1djdyojSVni5ulL5nJOPh5RhJoh8RkvNrMMWtzPb2uY8yaBse0J6NEMKtRdDvyK3vbntm9qkO54+4H/kdQDn35nVM4JSqx73mmTf00D+UdSXiv3VWgVqTHX4nxSZDxqk4B2c1XgTSqz94y8+ibJGKvsAyYlQX+0ou7PxcZAy0q8Xxi+vivGP/mADNXzTzq1Q6IRLcaWUJ0q5tfctzWDbZlZUsXp8lNFnxZouX3AKKuH6mLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5UqXGhDjdFtxrOJ9xdzR2A3lZIoLPwfG2Q46gFtZBWE=; b=gx/GXd7xRWBNm1ThaBt2a00n6uB7UlKOqdGvg8vzhGZQpv0sNwyOQDcsVMunmPyyHnc2CVZ4RHa1ikDqK6dd9NpJdVNFZojVY5vEs1KoIUy08F6Qy3CnEFM1qr5cL9iH3v/NsLXhlKPevajxajGUJPgQzFwSPHBkCPmhIxgadyg= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SN6PR11MB3117.namprd11.prod.outlook.com (2603:10b6:805:d7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.18; Tue, 18 Aug 2020 01:37:07 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::bc48:4db0:9666:124e]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::bc48:4db0:9666:124e%7]) with mapi id 15.20.3283.024; Tue, 18 Aug 2020 01:37:07 +0000 From: "Wang, Jian J" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wu, Hao A" , "Chiu, Chasel" , "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [PATCH v3 0/8] Need add a FSP binary measurement Thread-Topic: [PATCH v3 0/8] Need add a FSP binary measurement Thread-Index: AQHWcgSn9tz7Th3kxUKT5jE8I5E9wKk9G+nw Date: Tue, 18 Aug 2020 01:37:06 +0000 Message-ID: References: <20200814063159.2477-1-qi1.zhang@intel.com> In-Reply-To: <20200814063159.2477-1-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2Y3NWI1YzQtNWFhMC00NWFhLWIyNjItNmM2Y2E1OWFmOTYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoic0djZG5tZnE2QmdxUnp0WXRsYXhSV3J3cEVHNHp1UVwvMVFpRFpwOThMNkZoMWVhMWpONGJNa3I2Snl2WVwvRVJVIn0= dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ba59e3b-cf1f-482e-8a86-08d8431737b9 x-ms-traffictypediagnostic: SN6PR11MB3117: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /trvPZ1VlfNyDqKgFHrNuIadHb0FFOSB+a4fTvS/ilv7KPHft8gXq1zwe4cTl21LZ1/Y8RpfwT1VHRHC76mmLC3GhVNLTzUQY2ymho+hzzcwGr1JjZxNQTFQlH7xwRbezBYTe+BSDLUEDATVoSQymk44IrsfrTYKp26eyFX9i6bO3oRPrM7I7m3g4cFyd/0uWZt16YcUHaZ4U0YIuHHwgRhQOvAvpewsvaXPFF5dSJfS0Gm9AXL7AQZHJ2dEPWepJHJB3G488/ERMKR8ELCzltamDqZEz2ySowD2ZSYbr5gt11km1V7wlFx/l/z9zLZSSYHehJw58CdFE9m2chEmd2djwo6o0j72+5ZhQXWCUHsNnddEkPduQ20UeB1Mk2Rt0CzRc4aCdC9irj93Z+znMQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(186003)(478600001)(76116006)(8676002)(8936002)(9686003)(7696005)(316002)(55016002)(26005)(66946007)(54906003)(107886003)(53546011)(71200400001)(86362001)(83380400001)(2906002)(6506007)(4326008)(33656002)(110136005)(5660300002)(66556008)(966005)(64756008)(19627235002)(52536014)(66476007)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: qNJAu5MS5XLQ1BnMtD6Jt076TRTK7PGWGvKExQmtfqFhbzkL258MKZASk3EdtD60FmTyR64cVPDyakdzZ1m7mkKR8CwrnSlBle+4sh/BEF/CAPnEtjonsprmYvzY5P0+ef3W5eRxSCcPVxlVgRKP5fN//DOCABqaFlVpD0J3ypyjDCVXUQ9nrFm1yaLPMDXgq7UKSy3SUCLak+lnJLByLLhRw0e2fU/suJUTSmvAQGXIsb770d01hSY7PYyKvM/YNJ1kb22xZtq3ao6EZik7Xruhep13iXQjLEUfXibxEIgJdMQYpfnqdzNUTyBYD8x7i3rXzxSiytrZA2NGeEBPq0iqDIhNimf/SV6wtkiVsr7lCB4Ge9jF91cq9xj0Argow/f1cNmIoE9pzHCQt67ryyRULGMQsA6ae7d7kp+N0wh8GzPQhwBlsAmbc4YdI0tDudN0QXyOQZKL2VOnvBD4UINQI9UceVJ0y/OaIt7rpayH9AuOMdNjg6QOSrjqhLofyoNwTP4xtLfIMUe7CeXC8HFKEgHWwBNO7VCA2vRJG3HkqCdcIMz166ko4KXTfchMVu7zdNqxoaW1vWHc09csw9YpyRNaWeybP1EMoEQCqCG+YPwecwoAUUm+tbxMOsGV2/Bi/krDs6asqyf5S+jstw== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3312.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ba59e3b-cf1f-482e-8a86-08d8431737b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2020 01:37:07.0211 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AYdo1j1uUfC/JQ5fajTvL4lr1Yw1K7ePmnWHk3I6eHSaFxGjycMYQ+iOuxM6UyFvGojBOaJI7gDSrLHvopc2+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3117 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the whole series,=20 Reviewed-by: Jian J Wang Regards, Jian > -----Original Message----- > From: Zhang, Qi1 > Sent: Friday, August 14, 2020 2:32 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Wu, Hao A ; Chi= u, > Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v3 0/8] Need add a FSP binary measurement >=20 > v3 change: > add a new lib FvEventLogRecordLib for gerneric code. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2376 >=20 > The EDKII BIOS calls FSP API in FSP Wrapper Pkg. > This FSP code need to be measured into TPM. >=20 > We need add a generic module in FSP Wrapper Pkg code to measure: > 1) FSP-T, FSP-M, FSP-S in API mode. > 2) FSP-T in Dispatch-mode. The FSP-M and FSP-S will be reported > as standard FV and they will be measured by TCG-PEI. >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Qi Zhang >=20 > Jiewen Yao (4): > IntelFsp2WrapperPkg/FspMeasurementLib: Add header file. > IntelFsp2WrapperPkg/FspMeasurementLib: Add BaseFspMeasurementLib. > IntelFsp2WraperPkg/Fsp{m|s}WrapperPeim: Add FspBin measurement. > IntelFsp2Wrapper/dsc: Add FspTpmMeasurementLib and > PcdFspMeasurementConfig. >=20 > Qi Zhang (4): > SecurityPkg/FvEventLogRecordLib: add new lib for firmware measurement > SecurityPkg/dsc: add FvEventLogRecordLib > SecurityPkg/Tcg2: handle PRE HASH and LOG ONLY > IntelFsp2WrapperPkg/dsc: add HashLib, Tpm2CommandLib and Tpm2DeviceLib >=20 > .../FspmWrapperPeim/FspmWrapperPeim.c | 90 ++++++- > .../FspmWrapperPeim/FspmWrapperPeim.inf | 20 +- > .../FspsWrapperPeim/FspsWrapperPeim.c | 86 +++++- > .../FspsWrapperPeim/FspsWrapperPeim.inf | 27 +- > .../Include/Library/FspMeasurementLib.h | 39 +++ > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 17 ++ > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 10 +- > .../BaseFspMeasurementLib.inf | 54 ++++ > .../BaseFspMeasurementLib/FspMeasurementLib.c | 248 ++++++++++++++++++ > .../Include/Library/FvEventLogRecordLib.h | 97 +++++++ > SecurityPkg/Include/Ppi/Tcg.h | 5 + > .../FvEventLogRecordLib/FvEventLogRecordLib.c | 197 ++++++++++++++ > .../FvEventLogRecordLib.inf | 40 +++ > .../FvEventLogRecordLib.uni | 17 ++ > SecurityPkg/SecurityPkg.dec | 3 + > SecurityPkg/SecurityPkg.dsc | 2 + > SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 12 +- > 17 files changed, 939 insertions(+), 25 deletions(-) > create mode 100644 > IntelFsp2WrapperPkg/Include/Library/FspMeasurementLib.h > create mode 100644 > IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/BaseFspMeasurementLi > b.inf > create mode 100644 > IntelFsp2WrapperPkg/Library/BaseFspMeasurementLib/FspMeasurementLib.c > create mode 100644 SecurityPkg/Include/Library/FvEventLogRecordLib.h > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.c > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.inf > create mode 100644 > SecurityPkg/Library/FvEventLogRecordLib/FvEventLogRecordLib.uni >=20 > -- > 2.26.2.windows.1