From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.2114.1592376911288317903 for ; Tue, 16 Jun 2020 23:55:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=A2uFCYvq; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: jian.j.wang@intel.com) IronPort-SDR: O2s0se51Ow367ycSHzMQ537bO8DtL3bMZJFZtcxzKxe/kjkBqPNitlMilAQGq35Mg2HXivJUJv B4FZOmGjjFbQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 23:55:09 -0700 IronPort-SDR: YzZKxcptNX8TcKTYLjvxBapXQHHOIqxyFNeRLT9r14HfkV7zkOxM5LuSEnNdrh3rPXM3gkkPBv 0nRmG4cwWdwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,521,1583222400"; d="scan'208";a="262466847" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 16 Jun 2020 23:55:09 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 23:55:09 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 23:55:09 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 16 Jun 2020 23:55:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YZuK4zdWXhNsEDJwgp5dLLdJGmqz6VO4kQBeUGIvyHChyqxzeMI4dKqAsZyv15Sb/bArJ6+TCeQ3WUJnnOX3gTbwG7Wpt2EAszsvbk00kamzkkh40AeZ9mIS3fgNajz4pDBusAJ84T0v0lt77GjgUUTOuirGuNVQPI6ao8JwZaaH0JV5ySCNdY3LUxI1CYn2s6vjjlo8MlKEu495SDHoveCHLxQZER/XwzmaJUToJNtSgXr7ooym9hUAb5IunxufCWDEHSKo09Qt9vuRAznFAJ2ZRkwsNpC46N7UpusAj2DS2si2Bqk6l62XY/wGSwD0JVpIkI7uje9IXyUIfCLrkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHIyKuKW/HyPqjMoXYfXjDOFJc6BJmCGY19CB1OB6uY=; b=kXdiWgRma7HpDqIQcUJBKAi6LG7ufCStkD/v05FaWvI87gzefZJlYFG/pF1i5qKcgGJ4JmtNupTYTpTXdYZoSDd7jZPIYE4aWMn/mbGqofkzHBKq/IrYpcuctP3hrpz6UQlp0T+a99ke2BdNsy6dphZzM2hxGUZ9iojhgptc0PDr18MPfKFl5y+k/bx5z6FvJ6mUn/MkQJlV9U9ZKS9byXQGX3TH39iHWvSP4y2KkMvfot/Od8y/IGe66JG49b8YYx3ozsJCIg+A0TWmerpd4Ytf2P2bQ4Jz+P1SxPANkRhcG1JsL+9oVN0UZD1PVcmY5bUCaj1Hm5nzxbqfYSqZHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHIyKuKW/HyPqjMoXYfXjDOFJc6BJmCGY19CB1OB6uY=; b=A2uFCYvqPHkPoyVRUL5Ve/clirM+EUsitaQ/U50Xn/bd/laWy98o2rdiGAtLFnfpJjhiWYqF3tVYnm6/6LZuoxejrfAhI+2L580SIOYUoCyznF4sHBgqLbRDluyQ6k3affO0Vpo932bnPZSUmW6gPKMpPafDvDeJWH0TXa4pifo= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SA0PR11MB4749.namprd11.prod.outlook.com (2603:10b6:806:9a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.22; Wed, 17 Jun 2020 06:55:06 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::31f6:24c6:99f0:33d2%6]) with mapi id 15.20.3109.021; Wed, 17 Jun 2020 06:55:06 +0000 From: "Wang, Jian J" To: "Tan, Ming" , "devel@edk2.groups.io" CC: "Wu, Hao A" Subject: Re: [PATCH v4 1/4] MdeModulePkg.dec: Change PCDs for status code. Thread-Topic: [PATCH v4 1/4] MdeModulePkg.dec: Change PCDs for status code. Thread-Index: AQHWPtLWwGuWpnCxWESVRxregKbF9qjcalbw Date: Wed, 17 Jun 2020 06:55:06 +0000 Message-ID: References: <20200610025634.21833-1-ming.tan@intel.com> In-Reply-To: <20200610025634.21833-1-ming.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2792dd2c-1cf1-4563-cd5b-08d8128b5e5b x-ms-traffictypediagnostic: SA0PR11MB4749: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 04371797A5 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eedbMR5VhRs+g1mqv91NVwSAke5ALcL+F9132icrm1jk6fZTIw9Ix/UkS1H/MHvPIe7cqy/byCaouovoH8DlMuLTa7a/W18YaT7aMjWPSUOgN7zMLZVXSmbA1sbTlKc/I84RDOjOQtxQc/cUERuPPH4FQf7In/Zb4GrcMrH0J8die7XBIh/cGCrb+eS4WGr2wjS9UWCurfAOrdeeegzq0YviaoZJ0yJwW0EuwbVSI1EmHDXaiiOH090aqH0goN7lNmRtrNB5mWxOl7oJBEX5f8IjxLRxOwiZ+gwwEQ0M6BfDXZcv4X2YjlnDVftzjt8M9Dei4bM0mqxNnfG2xLWR5jKjh9DBvqwiNMQUAoXir8CQObjfnz2/AhDmIQN5g+J8lPR/qt01oR+3cqxMrAVTiA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(316002)(52536014)(5660300002)(26005)(107886003)(83380400001)(2906002)(53546011)(6506007)(478600001)(86362001)(33656002)(8936002)(30864003)(66946007)(7696005)(66574015)(186003)(76116006)(4326008)(966005)(71200400001)(66476007)(110136005)(55016002)(9686003)(66446008)(8676002)(64756008)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: PLIOcxlUrunClkBF7MnSkhdTdfu+3qSS//du+RpkXTglfnjkxFowPC7qzms/CWs0fsMP3uiiLVgP7VkL2UPE8lHEtd2w5MzdlmcanDe801PYVQd2CblfFCilgEzPnbvvMF/BfeavuvdNmgktFLzgyVa9+3iAP1Rpv6Di8Pt8/9Tm1r/QuriRnfM8ZlhoU+a7T1RyYT+VbuUKi+I7wqOGRp9lgxbs9rtXOEsP6fsbDKt4sQbHG/QEVNsGasqub1NLf54cDOr7KKynpVDQ9d4HyQXbMXe3PqvJxk/R/HzQDoyHJvCMNTkqWJJazCNDeQVrpZow9+UEbPrfqhHA4SVWHTn3kllAfIO68VqiXMTYffC35uWjLIUYvcQszAFzVYpXFfgHa83aQoJXpTUFLcdw80cV5i23GjDxFwHGIjbl5YASQ7T78DEwzq91hTms9uZ6L11lA9t7om75XlsgY7TETC6uHIrWA7OpseIFEwrUiy7La57JysRgTeF6qwU7bDNX MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2792dd2c-1cf1-4563-cd5b-08d8128b5e5b X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 06:55:06.4064 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fwNkrXll+V3m1WEfHmaorvhwxUQsmaQyynsAo/+uUfTZ+4OkkXjiyyxfYtAWN5L3uF3pufEhsXMidTabOsA1LA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4749 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ming, I'd suggest to keep the type of FeatureFlag for these two PCDs. So those platforms, which don't want to use dynamic type, have no need to update it's dsc file. Regards, Jian > -----Original Message----- > From: Tan, Ming > Sent: Wednesday, June 10, 2020 10:57 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [PATCH v4 1/4] MdeModulePkg.dec: Change PCDs for status code. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2786 >=20 > In order to support enable/disable report status code through memory > or serial dynamic, change the following PCDs from [PcdsFeatureFlag] to > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]: > PcdStatusCodeUseSerial > PcdStatusCodeUseMemory > The original plaforms can use PcdsFixedAtBuild in .dsc files to save size= . >=20 > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Ming Tan > --- > V4: No change for this 1/4 patch, just modify the 2-4/4 patchs. > V3: Split one patch to several patchs, each Pkg has one patch. > V2: Change the new type from [PcdsDynamic] to [PcdsFixedAtBuild, > PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > And set to PcdsFixedAtBuild in the original platform .dsc files. >=20 > MdeModulePkg/MdeModulePkg.dec | 26 +++++++++---------- > .../Pei/StatusCodeHandlerPei.c | 6 ++--- > .../Pei/StatusCodeHandlerPei.inf | 6 ++--- > .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c | 16 ++++++------ > .../StatusCodeHandlerRuntimeDxe.inf | 6 ++--- > .../Smm/StatusCodeHandlerSmm.c | 10 +++---- > .../Smm/StatusCodeHandlerSmm.inf | 6 ++--- > 7 files changed, 35 insertions(+), 41 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 4f44af694862..843e963ad34b 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -760,19 +760,6 @@ [PcdsFeatureFlag] > # @Prompt Enable PCI bridge IO alignment probe. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdPciBridgeIoAlignmentProbe|FALSE|BOO > LEAN|0x0001004e >=20 > - ## Indicates if StatusCode is reported via Serial port.

> - # TRUE - Reports StatusCode via Serial port.
> - # FALSE - Does not report StatusCode via Serial port.
> - # @Prompt Enable StatusCode via Serial port. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE|BOOLEAN| > 0x00010022 > - > - ## Indicates if StatusCode is stored in memory. > - # The memory is boot time memory in PEI Phase and is runtime memory i= n > DXE Phase.

> - # TRUE - Stores StatusCode in memory.
> - # FALSE - Does not store StatusCode in memory.
> - # @Prompt Enable StatusCode via memory. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE|BOOLEA > N|0x00010023 > - > ## Indicates if PEI phase StatusCode will be replayed in DXE phase.
> # TRUE - Replays PEI phase StatusCode in DXE phased.
> # FALSE - Does not replay PEI phase StatusCode in DXE phase.
> @@ -2001,6 +1988,19 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, > PcdsDynamic, PcdsDynamicEx] > # @Prompt TCG Platform Firmware Profile revision. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdTcgPfpMeasurementRevision|0|UINT3 > 2|0x00010077 >=20 > + ## Indicates if StatusCode is reported via Serial port.

> + # TRUE - Reports StatusCode via Serial port.
> + # FALSE - Does not report StatusCode via Serial port.
> + # @Prompt Enable StatusCode via Serial port. > + > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE|BOOLEAN| > 0x00010022 > + > + ## Indicates if StatusCode is stored in memory. > + # The memory is boot time memory in PEI Phase and is runtime memory i= n > DXE Phase.

> + # TRUE - Stores StatusCode in memory.
> + # FALSE - Does not store StatusCode in memory.
> + # @Prompt Enable StatusCode via memory. > + > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE|BOOLEA > N|0x00010023 > + > [PcdsPatchableInModule] > ## Specify memory size with page number for PEI code when > # Loading Module at Fixed Address feature is enabled. > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.c > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.c > index 1b07f92f3ce8..9b2ea4ee84d9 100644 > --- a/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.c > @@ -2,7 +2,7 @@ > Report Status Code Handler PEIM which produces general handlers and ho= ok > them > onto the PEI status code router. >=20 > - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -45,13 +45,13 @@ StatusCodeHandlerPeiEntry ( > // If enable UseSerial, then initialize serial port. > // if enable UseMemory, then initialize memory status code worker. > // > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > Status =3D SerialPortInitialize(); > ASSERT_EFI_ERROR (Status); > Status =3D RscHandlerPpi->Register (SerialStatusCodeReportWorker); > ASSERT_EFI_ERROR (Status); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > Status =3D MemoryStatusCodeInitializeWorker (); > ASSERT_EFI_ERROR (Status); > Status =3D RscHandlerPpi->Register (MemoryStatusCodeReportWorker); > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf > index 8aef9af34a05..64380ddfaccc 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Pei/StatusCodeHandlerPei.inf > @@ -53,11 +53,9 @@ [Guids] > [Ppis] > gEfiPeiRscHandlerPpiGuid ## CONSUMES >=20 > -[FeaturePcd] > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial ## CONSUMES > - > [Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1|gEfiMdeMod > ulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > SOMETIMES_CONSUMES >=20 > [Depex] > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > index 79cc48fa55a4..a8c0fe5b7149 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.c > @@ -2,7 +2,7 @@ > Status Code Handler Driver which produces general handlers and hook th= em > onto the DXE status code router. >=20 > - Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> + Copyright (c) 2006 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -29,7 +29,7 @@ UnregisterBootTimeHandlers ( > IN VOID *Context > ) > { > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > mRscHandlerProtocol->Unregister (SerialStatusCodeReportWorker); > } > } > @@ -80,14 +80,14 @@ InitializationDispatcherWorker ( > // If enable UseSerial, then initialize serial port. > // if enable UseRuntimeMemory, then initialize runtime memory status c= ode > worker. > // > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > // > // Call Serial Port Lib API to initialize serial port. > // > Status =3D SerialPortInitialize (); > ASSERT_EFI_ERROR (Status); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > Status =3D RtMemoryStatusCodeInitializeWorker (); > ASSERT_EFI_ERROR (Status); > } > @@ -115,7 +115,7 @@ InitializationDispatcherWorker ( > // > // Dispatch records to devices based on feature flag. > // > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > SerialStatusCodeReportWorker ( > Record[Index].CodeType, > Record[Index].Value, > @@ -124,7 +124,7 @@ InitializationDispatcherWorker ( > NULL > ); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > RtMemoryStatusCodeReportWorker ( > Record[Index].CodeType, > Record[Index].Value, > @@ -171,10 +171,10 @@ StatusCodeHandlerRuntimeDxeEntry ( > // > InitializationDispatcherWorker (); >=20 > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > mRscHandlerProtocol->Register (SerialStatusCodeReportWorker, > TPL_HIGH_LEVEL); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > mRscHandlerProtocol->Register (RtMemoryStatusCodeReportWorker, > TPL_HIGH_LEVEL); > } >=20 > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.inf > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.inf > index d74c2a55dcaf..faadfd9578fe 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.inf > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl > erRuntimeDxe.inf > @@ -58,12 +58,10 @@ [Guids] > [Protocols] > gEfiRscHandlerProtocolGuid ## CONSUMES >=20 > -[FeaturePcd] > +[Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeReplayIn ## CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial ## CONSUMES > - > -[Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize |128| > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > SOMETIMES_CONSUMES >=20 > [Depex] > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm. > c > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm. > c > index f54991ed3f67..20271571ded4 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm. > c > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm. > c > @@ -2,7 +2,7 @@ > Status Code Handler Driver which produces general handlers and hook th= em > onto the SMM status code router. >=20 > - Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -28,14 +28,14 @@ InitializationDispatcherWorker ( > // If enable UseSerial, then initialize serial port. > // if enable UseRuntimeMemory, then initialize runtime memory status c= ode > worker. > // > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > // > // Call Serial Port Lib API to initialize serial port. > // > Status =3D SerialPortInitialize (); > ASSERT_EFI_ERROR (Status); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > Status =3D MemoryStatusCodeInitializeWorker (); > ASSERT_EFI_ERROR (Status); > } > @@ -73,10 +73,10 @@ StatusCodeHandlerSmmEntry ( > // > InitializationDispatcherWorker (); >=20 > - if (FeaturePcdGet (PcdStatusCodeUseSerial)) { > + if (PcdGetBool (PcdStatusCodeUseSerial)) { > mRscHandlerProtocol->Register (SerialStatusCodeReportWorker); > } > - if (FeaturePcdGet (PcdStatusCodeUseMemory)) { > + if (PcdGetBool (PcdStatusCodeUseMemory)) { > mRscHandlerProtocol->Register (MemoryStatusCodeReportWorker); > } >=20 > diff --git > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm.i > nf > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm.i > nf > index 47d0545f9591..4e24d87e55d1 100644 > --- > a/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm.i > nf > +++ > b/MdeModulePkg/Universal/StatusCodeHandler/Smm/StatusCodeHandlerSmm.i > nf > @@ -53,11 +53,9 @@ [Guids] > [Protocols] > gEfiSmmRscHandlerProtocolGuid ## CONSUMES >=20 > -[FeaturePcd] > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial ## CONSUMES > - > [Pcd] > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial ## CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > CONSUMES > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize |128| > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory ## > SOMETIMES_CONSUMES >=20 > [Depex] > -- > 2.24.0.windows.2