From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.6158.1597196144383150661 for ; Tue, 11 Aug 2020 18:35:44 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s7+DK0KI; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jian.j.wang@intel.com) IronPort-SDR: ZLEN7+RqVktk015Z9LCt6D2U+lXZw53zvTuVs5wvHFdnR2VphgWZwXp4eqDNDPTd5VkfHMoPDE gmvAAtMRMYqQ== X-IronPort-AV: E=McAfee;i="6000,8403,9710"; a="133916439" X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="133916439" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2020 18:35:43 -0700 IronPort-SDR: V1p9IKXH0QnULeoIHYIoH2FgAyEHUaGpyzBq7xVvS1qG6QAOZNvka1zA4Ms9Uzs/DPlCDL1zEI sFAa2AdteLmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,302,1592895600"; d="scan'208";a="327036647" Received: from orsmsx606-2.jf.intel.com (HELO ORSMSX606.amr.corp.intel.com) ([10.22.229.86]) by fmsmga002.fm.intel.com with ESMTP; 11 Aug 2020 18:35:43 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 11 Aug 2020 18:35:43 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 11 Aug 2020 18:35:43 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX163.amr.corp.intel.com (10.22.240.88) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 18:35:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 11 Aug 2020 18:35:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kaIf403dRlDUr1FM5SqPrfDWH0PBCEMtgugRELWQOkWRK1eGknhwUsXWTrN3HEzsT7I8EQ9N2DAynbAWMSGfoYcxhziDzXd28QlZ3XKD36rx36U8SPZmz8lHiSJXdJNM1VaEa9Xu1eRHk5HT6ogkVc9B7sXznn30uEGB0VXhqDS8G6JmvPD1pZtXWAiVHadJIPIs+unfszT8xAPCul9XE0fx4KJZYxIAZhqBUTlxoIlHYWwheDJaAXJ9oAjd6mNRlNTZ/dmuTjE439BxcOIY7OHhQj7SO7SGpZAHaMxojPZDeFigBdo9FDwt4wfeM0Vcy34w7c+mzidouaaVPDcI/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHoXgZWVG9lRxZLStlHS0xDG+Fvx4Z+AxFrMnz3nzDk=; b=ZxVhLA/KFOepIarEkrXeE5TovD19kghz5w/T7DC2Ox1boJJlk7NL5W16wOFsDilzG3B1GfB31uDkDa9CLRYogsJ2KGg882C38Glu6Xcs2k4Y4Be2xZfGnvIWz2LFjI5JW+wCDueAAQ/nKodwA4aO0Ab73DTH7gqjyfJ31hjTx7+bEj5x0hCE7FskMG5NsP+KZSjkPENsRnFbvb/z5JvCqTmGGAwxXGe1pmxijzZi9gOX9+G+O/13q6W+1YcofiWbe1JpIf8xCs9NcP7/7TQHEgFOZCfICJni4ztyP7Ye+EDJ+DCmBsIkG/RWQrHOfZJlEjIPbEJMmTsSlD2p8f8XFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHoXgZWVG9lRxZLStlHS0xDG+Fvx4Z+AxFrMnz3nzDk=; b=s7+DK0KI52aPGuPCLL5xnPCu5EeEgwnglV+lR6jx1Lt5G/5RFS5o7rCQ9Rjyl3SbUJyZctHmVHN2yhS3MGKGazpDrnUh1EZoY8BLgy4t3ihAwfef8INoH/yA1mMAvaJscJBl7/+YqYQCSboSBGGHHTQqYPPEgFVGiUy9QEyUMCY= Received: from SN6PR11MB3312.namprd11.prod.outlook.com (2603:10b6:805:c8::14) by SA0PR11MB4640.namprd11.prod.outlook.com (2603:10b6:806:9b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3283.15; Wed, 12 Aug 2020 01:35:40 +0000 Received: from SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::bc48:4db0:9666:124e]) by SN6PR11MB3312.namprd11.prod.outlook.com ([fe80::bc48:4db0:9666:124e%7]) with mapi id 15.20.3261.024; Wed, 12 Aug 2020 01:35:40 +0000 From: "Wang, Jian J" To: "Zhang, Qi1" , "devel@edk2.groups.io" CC: "Yao, Jiewen" , "Wu, Hao A" Subject: Re: [PATCH v2 2/9] MdeModulePkg/NullTpmMeasurementLib: Add new API. Thread-Topic: [PATCH v2 2/9] MdeModulePkg/NullTpmMeasurementLib: Add new API. Thread-Index: AQHWa4lKhUDwXTwo7kuGJOY3sXwmLKkzuYgw Date: Wed, 12 Aug 2020 01:35:40 +0000 Message-ID: References: <20200806003342.17866-1-qi1.zhang@intel.com> <20200806003342.17866-3-qi1.zhang@intel.com> In-Reply-To: <20200806003342.17866-3-qi1.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI5M2YwNmQtMjAyNC00MTFhLWJlNTktMDY1NzZiMzFhMjJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiK1dGY0NoN0pmN3lLSHVXVFY5a0VLNkFpS1Rzb2pnZFpJVU52MkRoc3NFMk9WXC9JMmxcL21pcDVRd0FLQUJ0cWQxIn0= dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.203] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f56430be-e2ff-4bc4-524e-08d83e600563 x-ms-traffictypediagnostic: SA0PR11MB4640: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: U0NDDnyiYbRYOI+YRVOPZCeQHkaZSkZllBdzRAc+Du0Czu1EowZtqduJgg8388YpLfUMgHRGji3Xm4fSbV0a3Y+ghXklZg4qaen3Dzrb5EFvRxxE9iBcpxpDHME92IXfdEBQ+zeT8MYUcJPF0PUMmdW5XsnYzKNS3o8/v01PL0Zh68xBIfOW4WPHx9xWX9eEksjKi+P1KIbhwvEKQ9Yn7TlROV9mKsJEI6RjZLTTU8AaAINUTRz+/otttppCd/sVLMzMYvQDI9kTKtH7VQy0B8o/VwjmkHCZYx3YFHR2BNiNwSjQ/E9kB71kr6dau82Ot4KX4kI3sgP4pBf/jbQJSxSmlEeGAbfodh4ZsAI9nVR0zuTMoPex8REP8nrZF/DnpnUdjaoMa3ekIVbS6Zm2Fw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB3312.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(396003)(346002)(376002)(366004)(136003)(7696005)(33656002)(4326008)(966005)(52536014)(5660300002)(110136005)(8936002)(316002)(54906003)(2906002)(186003)(6506007)(478600001)(86362001)(9686003)(53546011)(66446008)(83380400001)(26005)(71200400001)(107886003)(8676002)(66476007)(55016002)(76116006)(64756008)(66946007)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: TYla7cc5flfwBDZz5jjDIaja1M6e6H64jO0VD7V/73i/yidGO6woQS+nRpfevjdnIBbVCXElGAqGlHMK1FYXNGoTp7RWY3rSvUommiLOF9q8/fGl7wUF8FdNC3zAYu0SlZhQ/QqeUEy3qDdv0CrQQmLvyJfhhQo6cRGpZbZckt1Vg4fvG0YZzVSd00JGMFiF5rg+9MtltLPpxlNlkiFds1So1Hyz0pJ0qAWtYNj1UI9JTgdt6Z7MEsCDbb6BzuZOVAZ2FqAibNeTtXSRY6I0xz8S+Hf/6OJEgJoIkrTfkkWxjgxBBfHiB1MoY9o9UWkEjrgdFeA7dMLjxEFXIwbGUmKohKR1gXM5DmV86GKCH93S8b318L9oE7kb6hxolQxWGKukvpdDik+zyIUZzHNtysEKN1L93VsNljzuPVZHON/GPkpsoqfwpIcb1uEG0O6LdDyHRM+0PYPKmbpbn4q0E/2vvEHrleCA8IfSA34EU3Cm7NrenA3txlONbbcobHGNZ/m++BdO0FB+eaXz3JAQFDBU9e1kS89OwnAu/3LPKrspFGiIzQfPfSSRL4hUVExfGQq5PUbifdtxPa2u+tyy4tOGS+0Wek7VRtpFdi3YKPKGZJcKdTyHDZa8Vuj1E1/zkVk+IyLAnf8sds6okX5EqA== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3312.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f56430be-e2ff-4bc4-524e-08d83e600563 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2020 01:35:40.0203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AQx67dKsL0qocjjZDerDN33uieYXZOu5s+O9FOlOZmmTKJNq1MSOWS6ZM3hwQdlgy+T3H7btBA3+wR+bDra8+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4640 Return-Path: jian.j.wang@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Qi, Some typos. See inline comments below. > -----Original Message----- > From: Zhang, Qi1 > Sent: Thursday, August 06, 2020 8:34 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Wu, Hao A ; Zhang, Qi1 > Subject: [PATCH v2 2/9] MdeModulePkg/NullTpmMeasurementLib: Add new API. >=20 > From: Jiewen Yao >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2376 >=20 > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Qi Zhang > Signed-off-by: Jiewen Yao > --- > .../TpmMeasurementLibNull.c | 61 ++++++++++++++++++- > .../TpmMeasurementLibNull.inf | 6 +- > 2 files changed, 63 insertions(+), 4 deletions(-) >=20 > diff --git > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.c > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.c > index b9c5b68de8..2ce38d8258 100644 > --- > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.c > +++ > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.c > @@ -1,11 +1,13 @@ > /** @file >=20 > This library is used by other modules to measure data to TPM. >=20 >=20 >=20 > -Copyright (c) 2015, Intel Corporation. All rights reserved.
>=20 > +Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > **/ >=20 >=20 >=20 > +#include >=20 > + >=20 > /** >=20 > Tpm measure and log data, and extend the measurement result into a spe= cific > PCR. >=20 >=20 >=20 > @@ -37,3 +39,60 @@ TpmMeasureAndLogData ( > // >=20 > return EFI_SUCCESS; >=20 > } >=20 > + >=20 > +/** >=20 > + Mesure a FirmwareBlob. 'Mesure' -> 'Measure' >=20 > + >=20 > + @param[in] Descrption Description for this FirmwareBlob. 'Descrption' -> 'Description' >=20 > + @param[in] FirmwareBlobBase Base address of this FirmwareBlob. >=20 > + @param[in] FirmwareBlobLength Size in bytes of this FirmwareBlob= . >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +*/ >=20 > +EFI_STATUS >=20 > +EFIAPI >=20 > +MeasureFirmwareBlob ( >=20 > + IN UINT32 PcrIndex, >=20 > + IN CHAR8 *Description OPTIONAL, >=20 > + IN EFI_PHYSICAL_ADDRESS FirmwareBlobBase, >=20 > + IN UINT64 FirmwareBlobLength >=20 > + ) >=20 > +{ >=20 > + // >=20 > + // Do nothing, just return EFI_SUCCESS. >=20 > + // >=20 > + return EFI_SUCCESS; >=20 > +} >=20 > + >=20 > +/** >=20 > + Mesure a HandoffTable. 'Mesure' -> 'Measure' >=20 > + >=20 > + @param[in] PcrIndex PcrIndex of the measurment. 'measurment' -> 'measurement' >=20 > + @param[in] Descrption Description for this HandoffTable. 'Descrption' -> 'Description' >=20 > + @param[in] TableGuid GUID of this HandoffTable. >=20 > + @param[in] TableAddress Base address of this HandoffTable. >=20 > + @param[in] TableLength Size in bytes of this HandoffTable= . >=20 > + >=20 > + @retval EFI_SUCCESS Operation completed successfully. >=20 > + @retval EFI_UNSUPPORTED TPM device not available. >=20 > + @retval EFI_OUT_OF_RESOURCES Out of memory. >=20 > + @retval EFI_DEVICE_ERROR The operation was unsuccessful. >=20 > +*/ >=20 > +EFI_STATUS >=20 > +EFIAPI >=20 > +MeasureHandoffTable ( >=20 > + IN UINT32 PcrIndex, >=20 > + IN CHAR8 *Description OPTIONAL, >=20 > + IN EFI_GUID *TableGuid, >=20 > + IN VOID *TableAddress, >=20 > + IN UINTN TableLength >=20 > + ) >=20 > +{ >=20 > + // >=20 > + // Do nothing, just return EFI_SUCCESS. >=20 > + // >=20 > + return EFI_SUCCESS; >=20 > +} >=20 > diff --git > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in > f > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in > f > index 61abcfa2ec..1db2c0d6a7 100644 > --- > a/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in > f > +++ > b/MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.in > f > @@ -1,7 +1,7 @@ > ## @file >=20 > # Provides NULL TPM measurement function. >=20 > # >=20 > -# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.
>=20 > +# Copyright (c) 2015 - 2020, Intel Corporation. All rights reserved.
>=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > ## >=20 > @@ -10,9 +10,9 @@ > INF_VERSION =3D 0x00010005 >=20 > BASE_NAME =3D TpmMeasurementLibNull >=20 > FILE_GUID =3D 6DFD6E9F-9278-48D8-8F45-B6CFF2C2B69= C >=20 > - MODULE_TYPE =3D UEFI_DRIVER >=20 > + MODULE_TYPE =3D BASE >=20 > VERSION_STRING =3D 1.0 >=20 > - LIBRARY_CLASS =3D TpmMeasurementLib|DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER UEFI_APPLICATION UEFI_DRIVER >=20 > + LIBRARY_CLASS =3D TpmMeasurementLib >=20 > MODULE_UNI_FILE =3D TpmMeasurementLibNull.uni >=20 >=20 >=20 > # >=20 > -- > 2.26.2.windows.1