Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security boot modules.

["Wang, Jian J" <jian.j.wang@intel.com>]

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Wednesday, June 03, 2020 11:03 PM
> To: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Xu, Min M <min.m.xu@intel.com>
> Subject: Re: [edk2-devel] [PATCH 2/5] Maintainers.txt: Add reviewer for security
> boot modules.
> 
> On 06/03/20 16:57, Laszlo Ersek wrote:
> > On 06/03/20 05:18, Dong, Eric wrote:
> >> Signed-off-by: Eric Dong <eric.dong@intel.com>
> >> Cc: Jiewen Yao <jiewen.yao@intel.com>
> >> Cc: Jian J Wang <jian.j.wang@intel.com>
> >> Cc: Chao Zhang <chao.b.zhang@intel.com>
> >> Cc: Min Xu <min.m.xu@intel.com>
> >> ---
> >>  Maintainers.txt | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Maintainers.txt b/Maintainers.txt
> >> index 954dc567e0..573084e086 100644
> >> --- a/Maintainers.txt
> >> +++ b/Maintainers.txt
> >> @@ -458,6 +458,12 @@ F: SecurityPkg/Tcg/
> >>  R: Qi Zhang <qi1.zhang@intel.com>
> >>  R: Rahul Kumar <rahul1.kumar@intel.com>
> >>
> >> +SecurityPkg: Secure boot related modules
> >> +F: SecurityPkg/Library/DxeImageVerificationLib/
> >> +F: SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/
> >> +F: SecurityPkg/Library/AuthVariableLib/
> >> +R: Min Xu <min.m.xu@intel.com>
> >> +
> >>  ShellPkg
> >>  F: ShellPkg/
> >>  W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
> >>
> >
> > (1) please replace "security boot" with "secure boot" in the subject.
> >
> > with that fixed:
> >
> > Acked-by: Laszlo Ersek <lersek@redhat.com>
> >
> 
> (2) If I remember correctly, we originally wanted the section headers in
> the Maintainers.txt file to remain alphabetically sorted.
> 
> This patch would create disorder:
> 
> SecurityPkg: Tcg related modules
> SecurityPkg: Secure boot related modules
> 
> Therefore please add the "SecurityPkg: Secure boot related modules"
> section above the "SecurityPkg: Tcg related modules" section.
> 
> With (1) and (2) fixed:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> (Now I do realize there is already some disorder in the Maintainers.txt
> file; I'll post a patch for fixing the OvmfPkg-related ones.)
> 
> Thanks
> Laszlo
> 
> 
>