From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.40]) by mx.groups.io with SMTP id smtpd.web08.15980.1633023589323649074 for ; Thu, 30 Sep 2021 10:39:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=LJBS51/s; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.40, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGa051jfU2pDqk9NRmFEdgnTDmoPm+OH1B/DS539zkgmpL6wEQYtd3AOwy3B79ff7F4+D+3RdPLjr6q8kUNn79xXoItJt9gf8NoZ/WSQruD8TNcFTHzNlarR3l5W/3UFcjlIxzq4Rhwim9QkmFMwidfppdmaVI/xIhzXP26nKg4nexGza+S/TWcaLZccPb9sUTuBlv6mLePv7cn65wHwKOjQO1ExvwoDhdtnop5An404MY5tb8k8QoWdrIz8tgi9gh+YKhLOkaMPyAyymW5+UVGgeWqYFEHu2UQ3g2CwzFYvrJsQR9at2RT1bM5empHLetE8bI1wxgM/NF5uGDKk5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JT+zDMsq51MpHZb9cd4UTGqEyYvFZMBALQnJVi1CNCU=; b=G02MvRkyt+dB1qkZBqsISlWkoWHgMXPNe8ascIU1ffgJ7gK2a1YpySs/5nboHA0ieHHf4Sff89rOMqu2MpuvoQn1a9J7hdl+kLjFeu7VyBB2bo5jmYfwh5WLKzM8YF5xgqUyKVaQYznYhN65LRxjrvI0YJqSUfeMooxzOhIfFXgIVxr2cOsC1rChN2ghPBjLAGBi7oqX3ew/6DO9/kZ5KbKsGvj+zua/iTrODKlrFqIhNecEpBFp7uZEQgIeuDdeDEA+qyv5rS9O2zx9U9Kk993laj7LFYqkUmik4mjsMJe3J/LxD4wQuwGyvOOr/Le+E0GvRijPgKEw5ZQtweXUOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JT+zDMsq51MpHZb9cd4UTGqEyYvFZMBALQnJVi1CNCU=; b=LJBS51/sfP/dUjFiKANizfUlYBfk7u8mhrtsqJK+95kdoYRyDoghK+jpFJKjB4cR5K9i8mx7pDecJr0xP9+VoOxnGu1Spm5IVVpkIKKGcF/LjDZbXnhgBCwSnoai3qToGJ9GtsNAV5zDostsi81vVu1V2pPszVgKguHbuc2aNyM= Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4413.namprd12.prod.outlook.com (2603:10b6:806:9e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.17; Thu, 30 Sep 2021 17:39:47 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 17:39:47 +0000 From: "Brijesh Singh" To: "Xu, Min M" , "devel@edk2.groups.io" , "kraxel@redhat.com" , "Yao, Jiewen" CC: Ard Biesheuvel , "Justen, Jordan L" , Erdem Aktas , James Bottomley , "Lendacky, Thomas" Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Topic: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Thread-Index: AQHXtCNSdB6uiU2vQ0ekJsJiw16Adqu5Dp0AgAB+LVuAAqVtAIAAqOJm Date: Thu, 30 Sep 2021 17:39:47 +0000 Message-ID: References: <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com> <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org> <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=True;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-09-28T15:23:29.4460000Z;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ae4f018-08c0-4765-6004-08d984394c31 x-ms-traffictypediagnostic: SA0PR12MB4413: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VzkRUOgf2QdwEtqWDwiiSZGEKs1dVmhRNDpo8Jg2/JFJcPp7MC7HUMvfdANn4uHYb7DjLGpTDsoHbKKA3bxq2FFwzZ+1HCj7oJ96Aqdd6hs4jypQDPAeksMCxQN9GC0+uHEXmlTHOIm6FJqaOKuax3hSxnUMDyBsrH7MpX1DBpnYGk7NiyZPkC8zX7JTrYYafQw8hsATj5nUO54Z33MM0yfy5DtvF/gCwHP2tlthtnFaJn4RbbLp2WefAHIn/OUUe8b9ZGVuFs70B3dJdEd+2BiuYZdg+51SnY5dwtPXY5p+VWnSm2JACwGjRokB/gIiAr/j8ungoApK48EqhX2UTlDLcfrPX5xEP0ikL0aJyoMiofsq+kUgvjVuuxAMzFlO/8Ld0o97NTMtTQ18TiOxulu1NG3UjIrxpuTsAk4TCHraOpOMr43UCE3bp1h+Fr0W6wkMrx15uDnJ1IE5WFxWHBgORJ+d/I8pHfDj16JuS38jgemR2b9gK3UOuj4+rZHUZcxW4Mrw0RV+5p2yuut1swAUuBtbOyowyEA1aG68XHcl6d9SEYXyjEWqV7HDd7DipPvOsYkMyq2mEUNDyQKpOxkgA3rOOEnfBdNwSQrZnt5ETD+wzCza3frnWhwT+RIuFYGV4CN1C1M9VMaGl7BgV6dgYL98VVQOBSvyLAYv0RqSq7+Gozy5gNpb+4FQJ1se9B8fMiX9BIvct+5G2sXUO5mK9aiZ4FzFQFbnhQz5HcqVQWPOGZE/tSwXcpfDjhraKzaby0ajO8ZjSlGOu1WeyHnSGvDLSyVLfgUiGAzVHmmm8c+nz93xF6Xl59stHSiCmBfegsuCTnq+2YReIWvmwA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66556008)(122000001)(64756008)(66476007)(186003)(66446008)(19627235002)(71200400001)(86362001)(38100700002)(52536014)(45080400002)(38070700005)(508600001)(33656002)(8936002)(55016002)(53546011)(6506007)(966005)(4326008)(2906002)(110136005)(54906003)(9686003)(76236003)(83380400001)(5660300002)(7696005)(66946007)(8676002)(91956017)(76116006)(26005)(316002)(166002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?DCVBqxHB4DqtZPgA6ZbwxkbBU/lQ5ajYARhpCX+7CzYe3s8YiABbY6aA?= =?Windows-1252?Q?rGSp1e13ECfA6YdzX39JVsavxeTo7sRPP1rNeyhDHUuVH6UxJ2snGGKy?= =?Windows-1252?Q?9UUqnKsgPrGT9KBxBMVx58uJHmzW7TtOFxvhG9gO79+Jtqyx0oHxtPrg?= =?Windows-1252?Q?jEhgp2Hz48wLmiNUogMUNWfeKiH9HW0TAlh2KKjDSLIR/6QZNOD/wrSC?= =?Windows-1252?Q?BZw2H4DtC0EDVNhXbxwIFNOlHSUwMzu/oKPqIdYXiTcPZasQdziyFAbI?= =?Windows-1252?Q?9QK9Yn+2UB80PQ66HvVNqNvo5gh1OSzexWzcWflGzXvoYLjHQ7ikhfBw?= =?Windows-1252?Q?Yt/hL6g0ZOcINMmZB/q1UcMPjbWa+Xv/YY/CNh+2K1I1Ny/OT24OHaUN?= =?Windows-1252?Q?fsPlCYnVgg+6hNOnR3gmg4woyMQ8otytUBgJ5cbINImmYlcAYHz34Yx/?= =?Windows-1252?Q?8FrgJ79ji/141RY6yVWZUthySQi4SgW6CBBS8bS3TwOJBH/iWSazxpz0?= =?Windows-1252?Q?sspLzGCGEEj0ZQODN4c6PqXhvGAuaa0Q7I1Jg5sdD+X/bpCMWg9JjYzg?= =?Windows-1252?Q?vpJUPvYZi/0TPFRxHkyHDkE5X1H+uO98pH7pBzqowfk+Z/njDr1ZaIFO?= =?Windows-1252?Q?66rreGDK0vL9tqadLrx6mZ7shPRgPMXLfBetADm7+LHlhfo1BOY0teo8?= =?Windows-1252?Q?4lQIn8w7gUNVEDoKKK2WX4pHDaZyq8TVuW4gbFNRvvxvQgBIZenFP63S?= =?Windows-1252?Q?8po74Hq1d7OJy+PEfoc8mYNn39tHOn5kcpzQMq9IKunpaphsWHFpQTFJ?= =?Windows-1252?Q?FK/DT/oGaJtWwO+jDINN5Fks0yMQLuXGyWEBTxB9S81OC+Yp/ehlE09l?= =?Windows-1252?Q?g07nxgHSzA8vBV3sDASV4jxVDAUvf1ZPiCdfIk0UfkKbKWuuXiH8hhvJ?= =?Windows-1252?Q?pAW3IZCjDNlxok2ecL/+zX2xhq0+71Zq6ikZLiK+SEDysoQ22hCLtTNF?= =?Windows-1252?Q?UIfJ910PvAMJqw1h6SbOHQLZK5wdsclj+ySY2BVc8m8GthAHr2mHNQGh?= =?Windows-1252?Q?cBaYlFWMIt/08YNMxBe9bm7mgzFJfmVR4lJerJ+dDj/Z5bIyGjbtbrH/?= =?Windows-1252?Q?V8/w2lZm1hw5wOTHSxsjt++K84Srydtd4lxBag4SKIDEHBEL57yD3hP3?= =?Windows-1252?Q?KLWWx7rqhmwvE75mUZHjp3oDx6wLUdg1OdObW6angNTgzPG1uCLqQYlz?= =?Windows-1252?Q?XjJIcKdhA4bnRjKHWvm2q5++O0OY0gl1ugzjFLhe9DiMgQ6IKIb1BF4O?= =?Windows-1252?Q?pbd/SHBIJX38gUhZMuy2BoH+NwYpOz1R4rnk681UzDynLREAPhjpl7Ae?= =?Windows-1252?Q?OkTOiqcO9kbff7mnlT4EpfaP9No6w5y0OE7HepoN9Eb7Y9XuzF95f0bn?= =?Windows-1252?Q?+FESCYur0WHgcCQHlzXbtg=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ae4f018-08c0-4765-6004-08d984394c31 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Sep 2021 17:39:47.4733 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eWb9NSDjsL8/ZLhiwKD9dPw0ji+tHteR4oucktvnwqnFaIf4mi4DGfkLKyAanyST08roT/OosTK5vrPPJlAm+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4413 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN6PR12MB2718665E45930671BB3EA5B1E5AA9SN6PR12MB2718namp_" --_000_SN6PR12MB2718665E45930671BB3EA5B1E5AA9SN6PR12MB2718namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only] Yes, I will try to make it work for the unified Metadata. Let's do it indep= ent of SNP and TDX series. You can pick the generic patch from my series an= d add the additional fields we need for the TDX and submit it. Get Outlook for Android ________________________________ From: Xu, Min M Sent: Thursday, September 30, 2021 12:31:56 AM To: devel@edk2.groups.io ; Singh, Brijesh ; kraxel@redhat.com ; Yao, Jiewen Cc: Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] Hi, Brijesh In the current discussion there are 2 options for the metadata, a unified M= etadata and 2 separate Metadata (SEV and TDX metadata). My understanding to your last mail is that you=92re going to use the unifie= d Metadata option, right? As to the offset of metadata, absolute offset is a good idea. I will update= it in my next version. Thanks! Min From: devel@edk2.groups.io On Behalf Of Brijesh Sing= h via groups.io Sent: Tuesday, September 28, 2021 11:24 PM To: Xu, Min M ; devel@edk2.groups.io; kraxel@redhat.com Cc: Yao, Jiewen ; Ard Biesheuvel ; Justen, Jordan L ; Erdem Aktas ; James Bottomley ; Lendacky, Thomas Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector [AMD Official Use Only] May I ask to use the OvmfMetadata instead of the of TdxMetadata for the Gui= ded structure name label (same as what I did in SNP series patch #4). If yo= u can send the metadata introduction as a patch separately then add the TDX= descriptor in TDX series. I can try to make it work for the SNP series and= add SNP specific descriptors. Additionally, I think you want to provide an= absolute offset for the start of the metadata instead relative value so th= at VMM can very easily reach to the start of metadata. e.g +OvmfMetadataOffsetStart: + DD (fourGigabytes - OvmfMetadataGuid - 16) + DW OvmfMetadataOffsetEnd - OvmfMetadataOffsetStart + DB 0x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47 + DB 0x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2 +OvmfMetadataOffsetEnd: For SNP series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM = and will probably add a total of 3 more descriptors. ________________________________ From: Xu, Min M > Sent: Tuesday, September 28, 2021 2:35 AM To: devel@edk2.groups.io >; kraxel@redhat.com= > Cc: Yao, Jiewen >; Ard Bi= esheuvel >; Jus= ten, Jordan L >= ; Singh, Brijesh >; Erd= em Aktas >; James Botto= mley >; Lendacky, Thomas > Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector On September 28, 2021 12:43 PM, Gerd Hoffmann wrote: > Hi, > > > > Can you move the metadata changes to a separate patch please? > > Yes, the metadata changes will be in a separate patch in the next versi= on. > > Can you also add a comment block documenting the format? Not only those > parts which are used for TDVF, but everything? The description in tdx-vi= rtual- > firmware-design-guide-rev-1.pdf seems to be incomplete, specifically the > option to use the table for TD memory allocation (as mentioned by Jiewen)= is > not covered. And possibly there is more which is missing ... Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata. Here is the PR I would send as the next version. https://nam11.safelinks.pr= otection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fp= ull%2F2018&data=3D04%7C01%7Cbrijesh.singh%40amd.com%7Cf49ea5bc7d79474e5= 72108d982529cbd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63768411359027= 3535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik= 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DbGOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FA= D%2Fui3ByVrU%3D&reserved=3D0 You can have a preliminary review if you want. > > thanks, > Gerd > > > > > --_000_SN6PR12MB2718665E45930671BB3EA5B1E5AA9SN6PR12MB2718namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only]


Yes, I will try to make it work for the unified Metadata. Let's do it = indepent of SNP and TDX series. You can pick the generic patch from my seri= es and add the additional fields we need for the TDX and submit it.

From: Xu, Min M <min.m.x= u@intel.com>
Sent: Thursday, September 30, 2021 12:31:56 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Singh, Brijes= h <brijesh.singh@amd.com>; kraxel@redhat.com <kraxel@redhat.com>= ;; Yao, Jiewen <jiewen.yao@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan= L <jordan.l.justen@intel.com>; Erdem Aktas <erdemaktas@google.com= >; James Bottomley <jejb@linux.ibm.com>; Lendacky, Thomas <Thom= as.Lendacky@amd.com>
Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector
 

[AMD Official Use Only]


Hi, Brijesh

In the current discussion there are 2 options for = the metadata, a unified Metadata and 2 separate Metadata (SEV and TDX metad= ata).

My understanding to your last mail is that you=92r= e going to use the unified Metadata option, right?

 

As to the offset of metadata, absolute offset is a= good idea. I will update it in my next version.

 

Thanks!

Min

From: devel@edk2.groups.io <devel@edk2.g= roups.io> On Behalf Of Brijesh Singh via groups.io
Sent: Tuesday, September 28, 2021 11:24 PM
To: Xu, Min M <min.m.xu@intel.com>; devel@edk2.groups.io; krax= el@redhat.com
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ard Biesheuvel <ard= b+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com&= gt;; Erdem Aktas <erdemaktas@google.com>; James Bottomley <jejb@li= nux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

[AMD Official Use Only]

 

May = I ask to use the OvmfMetadata instead of the of TdxMetadata for the Gu= ided structure name label (same as what I did in SNP series patch #4). If y= ou can send the metadata introduction as a patch separately then add the TDX descriptor in TDX series. I can try to= make it work for the SNP series and add SNP specific descriptors. Addition= ally, I think you want to provide an absolute offset for the start of = the metadata instead relative value so that VMM can very easily reach to the start of metadata. 

e.g<= /span>

&nbs= p;

+OvmfMetadataOffsetStart:=
+  DD      (fourGiga= bytes - OvmfMetadataGuid - 16)
+  DW      O= vmfMetadataOffsetEnd - OvmfMetadataOffsetStart
+  DB      0= x35, 0x65, 0x7a, 0xe4, 0x4a, 0x98, 0x98, 0x47
+  DB      0= x86, 0x5e, 0x46, 0x85, 0xa7, 0xbf, 0x8e, 0xc2
+OvmfMetadataOffsetEnd:

&nbs= p;

For = SNP series, I will 3 section types #1 CPUID, # Secrets, and #3 SEC_MEM and = will probably add a total of 3 more descriptors. 

&nbs= p;

From: Xu, Min M <min.m.xu@intel.com>
Sent: Tuesday, September 28, 2021 2:35 AM
To: devel@edk2.groups.io= <devel@edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Yao, Jiewen <jiewen.y= ao@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Justen, Jordan L <jordan.l.justen@intel.com>; Singh, Brijesh <brijesh.singh@= amd.com>; Erdem Aktas <e= rdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com= >
Subject: RE: [edk2-devel] [PATCH V8 3/3] OvmfPkg: Enable TDX in Rese= tVector

 

On September 28, 20= 21 12:43 PM, Gerd Hoffmann wrote:
>   Hi,
>
> > > Can you move the metadata changes to a separate patch please= ?
> > Yes, the metadata changes will be in a separate patch in the next= version.
>
> Can you also add a comment block documenting the format?  Not onl= y those
> parts which are used for TDVF, but everything?  The description i= n tdx-virtual-
> firmware-design-guide-rev-1.pdf seems to be incomplete, specifically t= he
> option to use the table for TD memory allocation (as mentioned by Jiew= en) is
> not covered.  And possibly there is more which is missing ...
Sure. I will add the comment in IntelTdxMetadata.asm to describe the format= of Tdx Metadata.
Here is the PR I would send as the next version. https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Ftianocore%2Fedk2%2Fpull%2F2018&amp;data=3D04%7C01%7Cbrijesh.singh= %40amd.com%7Cf49ea5bc7d79474e572108d982529cbd%7C3dd8961fe4884e608e11a82d994= e183d%7C0%7C0%7C637684113590273535%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3Db= GOxYMIKtHYKhcfk0Wt4qoIgiz3b9DM%2FAD%2Fui3ByVrU%3D&amp;reserved=3D0<= br> You can have a preliminary review if you want.
>
> thanks,
>   Gerd
>
>
>
>
>

--_000_SN6PR12MB2718665E45930671BB3EA5B1E5AA9SN6PR12MB2718namp_--