[AMD Official Use Only] I did ran uncrustify before submitting the patch. I am wondering if CI is reporting for some other issue in that file. I will look at it tomorrow. -Brijesh ________________________________ From: devel@edk2.groups.io on behalf of Rebecca Cran via groups.io Sent: Monday, December 13, 2021 8:41 PM To: devel@edk2.groups.io ; jiewen.yao@intel.com ; Singh, Brijesh Cc: James Bottomley ; Xu, Min M ; Lendacky, Thomas ; Justen, Jordan L ; Ard Biesheuvel ; Aktas, Erdem ; Roth, Michael ; Gerd Hoffmann ; Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning The error is: ERROR - /home/vsts/work/1/s/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned 1 >From what I can see, there's no report of the actual error here, so you have to setup Uncrustify locally to see what changes it wants to make. For instructions on setting up Uncrustify, see https://github.com/makubacki/tianocore.github.io/blob/add_uncrustify_instructions/EDK-II-Code-Formatting.md . Given the change, I expect the indentation of the equals sign is wrong. -- Rebecca Cran On 12/13/21 7:34 PM, Yao, Jiewen wrote: Hey Brijesh CI fails - https://github.com/tianocore/edk2/pull/2301 Would you please take a look? Please remember to submit patch after you run CI next time. -----Original Message----- From: devel@edk2.groups.io On Behalf Of Yao, Jiewen Sent: Tuesday, December 14, 2021 10:11 AM To: Brijesh Singh ; devel@edk2.groups.io Cc: James Bottomley ; Xu, Min M ; Tom Lendacky ; Justen, Jordan L ; Ard Biesheuvel ; Aktas, Erdem ; Michael Roth ; Gerd Hoffmann ; Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Reviewed-by: Jiewen Yao -----Original Message----- From: Brijesh Singh Sent: Tuesday, December 14, 2021 3:39 AM To: devel@edk2.groups.io Cc: James Bottomley ; Xu, Min M ; Yao, Jiewen ; Tom Lendacky ; Justen, Jordan L ; Ard Biesheuvel ; Aktas, Erdem ; Michael Roth ; Gerd Hoffmann ; Brijesh Singh ; Rebecca Cran Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning The XCODE5 reported the below warning OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized use occurs here Compacted ^^^^^^^^^ Initialize the 'Compacted' variable to fix the warning. Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID values) Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Michael Roth Signed-off-by: Brijesh Singh --- OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c index a40a31f7c275..ff367411cc59 100644 --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c @@ -1872,6 +1872,7 @@ GetCpuidFw ( UINT32 XSaveSize; XssMsr.Uint64 = 0; + Compacted = FALSE; if (EcxIn == 1) { /* * The PPR and APM aren't clear on what size should be encoded in -- 2.25.1