From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.64]) by mx.groups.io with SMTP id smtpd.web08.21274.1639452440631623713 for ; Mon, 13 Dec 2021 19:27:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=MZ/5r1p/; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.64, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aoiio3+VYrtZ6HYjFATx6BSLJnUS4M63TsZ5mkq7HtLa40tBcI7xtBxAFpNdVlC41S/mD6QwJbPhBdSmrYi/Thje0mRMmsMinxYWan/7ZlLIF3fMb/v8gE2pk1Vf49t7Vf0BGLCTwFsARQdkPyjOtjUDBeLW2aeDICMUVvYLqFh7Fbhvkwyfg1gZOuRATbnqE+4wnK3BkJN0PtdkaYuOvtta0vs5k0cyvLMgyVcTv81X8EYyKo0R27yKcDPAeC6NEh6ypv7W6JpVYNTQPQTdXSyBsCGlALgKmIFUmd+Puk3JV5MPei5yFz1TlNx+TdUjCu9Sn7xcuMW+TRPIsNUFWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UPXP1yD3h5Cbap2N7MX342d9FUy5JceudvK0seWiRzk=; b=haNX8hhIEpdC+qxLJ2wxm6CwxvKvbcNKVDT/1SSsCHR9tEueEVQTk365omUBPFsuaHkG+yWGCObx5JGqXEw6WOb3j5zwfcPMNZ0OT00MR0/9BcytOOSrUskI0pWIv1xRCtthJ2GGdCmw6CTt0Hs5WWBj7fvpe6aUfWdmRlufBgHAyrglM1XcexDfnpOGeHzZr9nsPi7zBtyo4jv244ewCrOughLxj8HmmeV+KVwdeaMbYZsw6UIAh377DOufBiLZqr59H8MHIxYR2QglWGALaVvAzUiFjxxgkcw6VliGRj7l08uSu87c3IJUFhzKKc1XPFzZRniYO40N8dHL+I/w6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UPXP1yD3h5Cbap2N7MX342d9FUy5JceudvK0seWiRzk=; b=MZ/5r1p/WlD0ykVjc+lEdrkUNF/G1Kn+gNy7CFB0V3gjueYfND2g9kYjMfNItipCHby5qabOOcfhAler4H0+d5zC0Ms8Na3hyubzELpOAcU28AwxpYK1Rfac44qIlxOT2XJ9Y8TcVtAXOLHFr4U1DoUcG3+Rv8HteYvvEipvkI0= Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SN6PR12MB2719.namprd12.prod.outlook.com (2603:10b6:805:6c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 03:27:18 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::35:281:b7f8:ed4c%6]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 03:27:18 +0000 From: "Brijesh Singh" To: "devel@edk2.groups.io" , "jiewen.yao@intel.com" , "rebecca@nuviainc.com" CC: James Bottomley , "Xu, Min M" , "Lendacky, Thomas" , "Justen, Jordan L" , Ard Biesheuvel , "Aktas, Erdem" , "Roth, Michael" , Gerd Hoffmann , Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Thread-Index: AQHX8FkTyxrzHCGO6kSkF69J/XCes6wxPt7ggAAGitCAAAI4gIAADDPx Date: Tue, 14 Dec 2021 03:27:18 +0000 Message-ID: References: <20211213193839.143953-1-brijesh.singh@amd.com> <16C07D237B4BFD37.18377@groups.io> <9bb6e396-5cb2-b143-c526-7ac642dde2d4@nuviainc.com> In-Reply-To: <9bb6e396-5cb2-b143-c526-7ac642dde2d4@nuviainc.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Enabled=True;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_SetDate=2021-12-14T03:27:17.916Z;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Name=AMD Official Use Only;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_ContentBits=0;MSIP_Label_88914ebd-7e6c-4e12-a031-a9906be2db14_Method=Standard; suggested_attachment_session_id: 7286597c-a03b-757a-3288-354fdfbf2077 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a64b301-3ddf-4c21-ec40-08d9beb1a203 x-ms-traffictypediagnostic: SN6PR12MB2719:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:124; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zq3Jm/sKSPNorh4opm/bwKsjfhIiGCBp/S8MLDPifFk4ZtyszI4mM36CreHmglccpG+4OWca9EZulqQLBW4fSL4sx5GJQIL5tUqqqjH3oSV/BZbylfDV6QhPrjYQCiMl8LubYDKmAqDsFJHf3KIaVqjk1X1v0elcs8pJxtY10lebjgnE8IBUTSzbdU6oI9h5teL3y5+7+n4YcPmCQlZ7mwOL7Cc8JWY/kAtpDsleANkd3RRe0SuDsAnW6VFyP5F6sp1JPrcGi6rO2Bwap30XjQvSP8cwWbNZFfRu/DYKi93MxkD0DPY25bhFVrvgLiuJ+7rIkjKjpjI+yQp+CsMZExK033f450XL1kyhlS5URTuvriZ5VX8hXFAd2ZPzwzh4dQT4rTekSR47uOMb5CyHg7OdmLmQ3CWNpGsGKGuhztXpu8+yk3R9SzpLHXVBBdkPdIDKopGeZmHRYSkwgGp5+fhd2KLxKR0cRRqJRnN7GWbiN14ALf6nL4sc+dBB8J9x7LC98vb2mFo4pfN5Hp8Lsx9TAcPX0H5uTDINhXzpWGiJYRngLbZbfahoSDPde+ZHb9uRhGpSEDcIdcJHwnPVxSOPBzotVnC0wW8ipV9wDPT7mawFjul+pEJJrGL2RutM3xqBdD4+BAX3ESLdzhVPn7L4KimCjBzNRDFKyoegCN31MYvyvrgUxS7A4xPbuudENydwcTTJAK/bah2/mRqUJgUbFdNO0M2RsjJVbVa4A5I3ZUJL3scMp+L63NSPvr3gJPXYKEmu/dCgrlinP+Rgz4gAO9ohCvcfCKk+33j8+7ZhhS6cgQ6YaGS5PqMoFDQWUH0OzwQdW58VZatvHw8r2w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(966005)(8676002)(186003)(2906002)(38100700002)(83380400001)(54906003)(9686003)(8936002)(55016003)(122000001)(166002)(5660300002)(316002)(26005)(110136005)(508600001)(71200400001)(33656002)(6506007)(4326008)(64756008)(19627405001)(53546011)(76116006)(52536014)(66946007)(86362001)(7416002)(66556008)(38070700005)(76236003)(7696005)(66446008)(66476007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?GsqepxWz93+9Y4XbvTSY1OqQHn/uevCHMr8op6t7dBQjqQBjQL3ukaEVmM?= =?iso-8859-1?Q?eaBUt3dGEY2teVFm7r00nU88Y4Mc10rCkGoOCT2vpln2YKXkx4JEvf1KP0?= =?iso-8859-1?Q?m5xoFiPvsV2TQRQJUMyrWCyZtzprUqWjrW2zW/jP4UwoWPlWb0ZnhTQ/lr?= =?iso-8859-1?Q?r+/tvkeYc5Kkc/6oVCfPQcf5jLdjNZn1S6QAR0tcHkpOERoNfkWnmQRWEq?= =?iso-8859-1?Q?KVwTbM6+w9defYY5nrzsrdfv2a/xKMassCGNwUIMqCa0go+s29VnPrshc3?= =?iso-8859-1?Q?5Oxp/xMIV3kVuSJ+Zd5tUzkVM86ZxgK/8zI9mcjtAnwl/PIluzQTax9ziu?= =?iso-8859-1?Q?E5F///PcM90dzLRIlWkRKIDu26bTSdHwlmXAJwvT7R7cFvvaRDZ8GxYYZS?= =?iso-8859-1?Q?onjBnJTWTLXoNjWsnqWEDLa3u/RJbzleHy07cXrfpIm3E9DLzM9vT8s1i4?= =?iso-8859-1?Q?aviqTlEEqRzN3DJ57oi/QCLK7hxJ/o1/Rj7xZ3W6mVzVe+PqTgDRQJFmua?= =?iso-8859-1?Q?w3I383lyogLNfpXZz7r+nfHbRkd0oSp3XTwYafhjgQPG0zg2cbks6d3Q+H?= =?iso-8859-1?Q?UH9fz5Mp18/1fQmTtbOQLQc2ldX4+QU0vqadjnuPBsdpG621MG20EG1W24?= =?iso-8859-1?Q?/UWGqCSieCXLXygIRPM3jAmoW1FD9uKd3H46SbRLEINrWoP21QVn4gjKjR?= =?iso-8859-1?Q?sagM+uYxzzNgwu3O/F655pHhIy75cPBB6TmtxRPwLOa00DpVJNL9geOC/2?= =?iso-8859-1?Q?YYO9inGcGviDtuaHorlwO3TNDJuvl+K/EHNWzRQ7wCAKIaVo9iAR5/d82T?= =?iso-8859-1?Q?ACRp0wHtg/ibQg0G0wLpP3U93OedNOzXCDee4NDOk9jFshRYkXjN+tJsUB?= =?iso-8859-1?Q?dm4zyVgg16TuN+7Bcio/cHPK9BW+AteDtA9JGwY+dDmXajZewqlMlNB8qZ?= =?iso-8859-1?Q?gl12MZWd1UuYUsqyLENvLXfMo2jsTqquOzK92waPj9GChjXBcUvMxpG4GD?= =?iso-8859-1?Q?zaxcGjK2EZqktVIceBctP0z5lXmCLEGwLIO4h4shV+9gKFj+TxeTD/qU+0?= =?iso-8859-1?Q?YWhXg9wFIDcFLpEPAIZZ9LEdpY3ov1OcxW20x+2GF353KCWlMDDzvdK3Yj?= =?iso-8859-1?Q?paAxvb3cov5p+2P6hYYj53q1brEwEEbFscJN7tiL9bEJUtxY9uGy6OJ83G?= =?iso-8859-1?Q?8VGKkENkDNsNSuN6aNckGrKiBojZeM2lqtFsgo0ju1EiT2MJ1NcAHExp7P?= =?iso-8859-1?Q?AlSbVbzNzvOwF8bQkSnoTlOtarWBL54aSdXV7xbxPKqCVkCTSfm714hd0u?= =?iso-8859-1?Q?5SGLbhgcy0aRQlT/jkK0jAXE1tkAQpRcZTTEG49giIBTK4wrRlPD4TCK5b?= =?iso-8859-1?Q?xyQVG0uUk8+MLHcD8DGAWH2IOrhk1BYL419T0URZb5+8JV1Qhyv6E5Cjt0?= =?iso-8859-1?Q?2ek0o8UvA3nrXPXrJVI1VgKBGanWG+lL3zGy58zxQC/4nwdCTl7e5VQAI8?= =?iso-8859-1?Q?Ipc9NDRkZ08fkn0ypOu3gDQ8I5Ksof5T0n1IduKUjVLUsMJCm5d1lqUyd8?= =?iso-8859-1?Q?faQSsfEb8UQAc0tJ2I3C50PdHV+MjFvokWmVZUTSmG6Hc8tVssjwzszDc9?= =?iso-8859-1?Q?5fCjqOdbr0Phn3bzL6miuAPhdWpRLFKhE8kfgiPS/uldOJ2ooE1MsQjw?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a64b301-3ddf-4c21-ec40-08d9beb1a203 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2021 03:27:18.5051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JKjaXyNe+4cocq+mxT1nAQEQFP1zHoc+eUIg9y4ZC2NQayeZ8x1OkcFYeqD8mwb0VAe9YHcl5hA8uivDyMVo4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2719 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN6PR12MB271867131D7BBD502D0CF389E5759SN6PR12MB2718namp_" --_000_SN6PR12MB271867131D7BBD502D0CF389E5759SN6PR12MB2718namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only] I did ran uncrustify before submitting the patch. I am wondering if CI is r= eporting for some other issue in that file. I will look at it tomorrow. -Brijesh ________________________________ From: devel@edk2.groups.io on behalf of Rebecca Cran= via groups.io Sent: Monday, December 13, 2021 8:41 PM To: devel@edk2.groups.io ; jiewen.yao@intel.com ; Singh, Brijesh Cc: James Bottomley ; Xu, Min M ; L= endacky, Thomas ; Justen, Jordan L ; Ard Biesheuvel ; Aktas, Erdem ; Roth, Michael ; Gerd Hoffmann ; Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized= variable warning The error is: ERROR - /home/vsts/work/1/s/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned= 1 >>From what I can see, there's no report of the actual error here, so you hav= e to setup Uncrustify locally to see what changes it wants to make. For instructions on setting up Uncrustify, see https://github.com/makubacki= /tianocore.github.io/blob/add_uncrustify_instructions/EDK-II-Code-Formattin= g.md . Given the change, I expect the indentation of the equals sign is wrong. -- Rebecca Cran On 12/13/21 7:34 PM, Yao, Jiewen wrote: Hey Brijesh CI fails - https://github.com/tianocore/edk2/pull/2301 Would you please take a look? Please remember to submit patch after you run CI next time. -----Original Message----- From: devel@edk2.groups.io On Behalf Of Yao, Jiewen Sent: Tuesday, December 14, 2021 10:11 AM To: Brijesh Singh ; de= vel@edk2.groups.io Cc: James Bottomley ; Xu, Mi= n M ; Tom Lendacky ; Jus= ten, Jordan L ; Ard Biesheuv= el ; Aktas, Erdem ; Michael= Roth ; Gerd Hoffmann ; Rebecca Cran Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning Reviewed-by: Jiewen Yao -----Original Message----- From: Brijesh Singh Sent: Tuesday, December 14, 2021 3:39 AM To: devel@edk2.groups.io Cc: James Bottomley ; Xu, Mi= n M ; Yao, Jiewen ; Tom Lendac= ky ; Justen, Jordan L= ; Ard Biesheuvel ; Aktas, Erdem ; Michael Roth ; Gerd Hoffmann ; Brijesh Singh ; Rebecca Cran Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning The XCODE5 reported the below warning OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized use occurs here Compacted ^^^^^^^^^ Initialize the 'Compacted' variable to fix the warning. Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID values) Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Michael Roth Signed-off-by: Brijesh Singh --- OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 + 1 file changed, 1 insertion(+) diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c index a40a31f7c275..ff367411cc59 100644 --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c @@ -1872,6 +1872,7 @@ GetCpuidFw ( UINT32 XSaveSize; XssMsr.Uint64 =3D 0; + Compacted =3D FALSE; if (EcxIn =3D=3D 1) { /* * The PPR and APM aren't clear on what size should be encoded in -- 2.25.1 --_000_SN6PR12MB271867131D7BBD502D0CF389E5759SN6PR12MB2718namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only]


I did ran uncrustify before submitting the patch. I am wondering if CI is r= eporting for some other issue in that file. I will look at it tomorrow.&nbs= p; 

-Brijesh

From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Rebecca Cran via groups.io <re= becca=3Dnuviainc.com@groups.io>
Sent: Monday, December 13, 2021 8:41 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; jiewen.yao@in= tel.com <jiewen.yao@intel.com>; Singh, Brijesh <brijesh.singh@amd.= com>
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.= xu@intel.com>; Lendacky, Thomas <Thomas.Lendacky@amd.com>; Justen,= Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tianoc= ore@kernel.org>; Aktas, Erdem <erdemaktas@google.com>; Roth, Michael <Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com&= gt;; Rebecca Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninit= ialized variable warning
 

The error is:

E= RROR - /home/vsts/work/1/s/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c

ERRO= R - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET returned = 1


From what I can see, there's no report of the actual error here, so you = have to setup Uncrustify locally to see what changes it wants to make.

For instructions on setting up Uncrustify, see https://github.com/makubacki/tianocore.github.io/blob/add_uncrustify_instru= ctions/EDK-II-Code-Formatting.md .


Given the change, I expect the indentation of the equals sign is wrong.<= br>


--
Rebecca Cran


On 12/13/21 7:34 PM, Yao, Jiewen wrote: 
Hey Brijesh

CI fails - https://github=
.com/tianocore/edk2/pull/2301
Would you please take a look?

Please remember to submit patch after you run CI next time.


-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf=
 Of Yao, Jiewen
Sent: Tuesday, December 14, 2021 10:11 AM
To: Brijesh Singh <brijesh.singh@amd.com>; devel@edk2.groups.io=

Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M <min.m.xu@intel.=
com>;
Tom Lendacky <thomas.lendacky@amd.com>; Justen, Jordan L
<jordan.l.justen@intel.com>; Ard Biesheuvel <ardb+tian=
ocore@kernel.org>;
Aktas, Erdem <erdemaktas@google.com>; Michael Roth
&=
lt;Michael.Roth@amd.com>; Gerd Hoffmann <kraxel@redhat.com>; R=
ebecca
Cran <rebecca@bsdio.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized
variable warning

Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>


-----Original Message-----
From: Brijesh Singh <brijesh.singh@amd.com>
Sent: Tuesday, December 14, 2021 3:39 AM
To: devel@edk2.groups.io
Cc: James Bottomley <jejb@linux.ibm.com>; Xu, Min M

<min.m.xu@intel.com>;

Yao, Jiewen <jiewen.yao@intel.com>;=
 Tom Lendacky
<thomas.lendacky@amd.com>; Justen, Jordan L <jordan.l.ju=
sten@intel.com>;
Ard Biesheuvel <ardb+tianocore@kernel.org>; Aktas, Erdem
=
<erdemaktas@google.com>; Michael Roth <Michael.Roth@amd.com>=
; Gerd
Hoffmann <kraxel@redhat.com>; Brijesh Singh <brijesh.singh@amd.com=
>;
Rebecca Cran <rebecca@bsdio.com>
Subject: [PATCH 1/1] OvmfPkg/VmgExitLib: Fix uninitialized variable warning

The XCODE5 reported the below warning

OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note: uninitialized
use occurs here
           Compacted
           ^^^^^^^^^

Initialize the 'Compacted' variable to fix the warning.

Fixes: d2b998fbdca4 (OvmfPkg/VmgExitLib: use SEV-SNP-validated CPUID

values)

Cc: James Bottomley <jejb@linux.ibm.com><=
/a>
Cc: Min Xu <min.m.xu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Erdem Aktas <erdemaktas@google.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael Roth <Michael.Roth@amd.com>
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
---
 OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
index a40a31f7c275..ff367411cc59 100644
--- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
+++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
@@ -1872,6 +1872,7 @@ GetCpuidFw (
     UINT32                 XSaveSize;

     XssMsr.Uint64 =3D 0;
+    Compacted =3D FALSE;
     if (EcxIn =3D=3D 1) {
       /*
        * The PPR and APM aren't clear on what size should be encoded in
--
2.25.1
--_000_SN6PR12MB271867131D7BBD502D0CF389E5759SN6PR12MB2718namp_--