From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (NAM04-BN3-obe.outbound.protection.outlook.com [40.107.68.64]) by mx.groups.io with SMTP id smtpd.web08.43.1612805813385753426 for ; Mon, 08 Feb 2021 09:36:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=KyUTvOuT; spf=pass (domain: vmware.com, ip: 40.107.68.64, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FcJ/6X/7pTcWJ9nUdpge9hqE2qNPxK4o03/SqECVI7Gfc5EsRphsbl7Dg/V8D4LDd5YKKNjU65wnYde9RbDU2/V/GDYS+dkhEMB/uPhPvDq54KLKrhW8MjprJ43KxOrg8zaUbvqem+YJOip3tj9FthPaSqUKqaTBaxcmD5PKzB46OMqB/E2oDRQ9lxzZStbm+W+8kllodUgUqWm+2kFF5uKjgH9/22X2H9yMG0dgmxzrRSlkJUXwJjk2EU5VqZrUbyQrrftvm3+EHGQNUY/c1jUAnewKgatPDTx9iMXf21+NhRSGrvmYq3J3FY00KNdI1K07rlRlv4QhiJuhqEJypw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MD9GGHYXqP9O1V/+A7eKN6oyh5yJBQqT+LIVcm1EI4=; b=iry/zgQAJ0pj/wFuctLbA9DpPu8WZB5L8jFY+2MVzvhGzfJ102nYDRMm/9ToEHDZlyvO1ptbGFXogIsqRNgs1BuflzFXcrmWjet1zk48vu7WA1kRG/QqTXs2JKKcvqCu6V3ghhG54oigg/ME3OMjSJuEgFFYrTtzfXNnJCWwRloAPvCsB4BoDQPw6epdMhDrzubqBq9jnZyWHmCJbTJQ0h85Si0WD07d3/Kba/0ObgwJK8pp5sWj6iUDXETcAxwcinz99nxajN+Oa0wIDWpwNlimmy8vf49nuXOX7sYJLNFNBMbaDBbhythDISgCAZFZ7uy7+b3T4JaSKFH9W69F3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0MD9GGHYXqP9O1V/+A7eKN6oyh5yJBQqT+LIVcm1EI4=; b=KyUTvOuTYOcN65GMruzfemDUogA5dNBE6QUCPI0IeFQA5r8FBltqAd06YaTuXY4AtbEt9JsWJcXPsZRI130BCAymnnV+x10gJs3QCMk1JkS+qVi5kpsofiYZZ9hnAAWxLlvhnoxgiDK9SwvZYA7vKUEq+i5iu6r25uHBC9NNAAo= Received: from (2603:10b6:806:f7::16) by SA1PR05MB8126.namprd05.prod.outlook.com (2603:10b6:806:187::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.11; Mon, 8 Feb 2021 17:36:51 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb%4]) with mapi id 15.20.3846.025; Mon, 8 Feb 2021 17:36:51 +0000 From: "Andrei Warkentin" To: "devel@edk2.groups.io" , "jeremy.linton@arm.com" CC: "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" , "leif@nuviainc.com" , "ard.biesheuvel@arm.com" Subject: Re: [edk2-devel] [BUG/PATCH] Platform/RaspberryPi: Only enable IORT when 3G limit is disabled. Thread-Topic: [edk2-devel] [BUG/PATCH] Platform/RaspberryPi: Only enable IORT when 3G limit is disabled. Thread-Index: AQHW+OvVmdnnkRytVUWSzmNQDOAAfapOjdLi Date: Mon, 8 Feb 2021 17:36:51 +0000 Message-ID: References: <20210201224437.2001658-1-jeremy.linton@arm.com> In-Reply-To: <20210201224437.2001658-1-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 01f412ad-3e60-4ee9-bccf-08d8cc581ea7 x-ms-traffictypediagnostic: SA1PR05MB8126: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: moDGUe5oA2ccm8A/Uj+TN7l0frSp1R//wR2Zol9SHsxe/JBEmZw++HD3ppv3o6LNM9Alp3BWjIHiqAWA2AKpQFNb/hGEi6gudfRGPfvDgvsGvR6f16BiaeSjPoHjv3RnZthLQVfGFpxRSQ/bRU46sFXoUZfRJHUejjHn+s3x83eG6tq8P20cnlzbnzR4Op39ivB1RB1hsyf0tiqVf2KKQVruc3y3ZKa8Zym4qxP2mxsZZbTu8rGGPAU76S1Q5PayDlC3v62Ol3yb9YsC49Ut09Ac6VWQLCWjl2mVo7TJYskXUughy7XxAbFyypu6NqxzciBV55AGxvoSC8iFEvHK95sZ+tX2b06qBlxQeWJNeg82DEw07laLioaNI+qFPA16Cuv81Hmm4BBYAkY5cHEdFxSRXrm7xgXlF4kjaPdhKbk48AaT0zzy/a1jsK1f0Dduk8lP7BaszV9qsnoGwhwddh5NiS8umqCF9f/qqX4mubBUql0hMjgZTjkvUx99Appn4xW3Y70o8aCTwKP6JDTxtLssLA0shdk/p8yMLj7wqTshodHMcdrJeQstsl+uA3NJAGxszHAg0xY4XJWK4QFW7FjL/4x8gUEvxlw9XrX6b00= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(26005)(5660300002)(52536014)(8676002)(2906002)(53546011)(45080400002)(6506007)(166002)(66446008)(316002)(83380400001)(66946007)(966005)(66556008)(76116006)(7696005)(110136005)(33656002)(55016002)(8936002)(71200400001)(19627405001)(4326008)(64756008)(86362001)(186003)(478600001)(66476007)(54906003)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?NzgXN6FE+gwWGAOujupSCxVw/x2JTBnkhF2SW07z5SBlrBFJZoI+CER5w7SL?= =?us-ascii?Q?Wm5Fr6xofTgxyPwjmLpZhyUeBaU/z///a77ogQ1Bwyv2ILsiEXTYQBYVKDge?= =?us-ascii?Q?WRy+ZQKzbJfjqcHyBXCXG1URq5pINdR3/R4piw2Y9Z7PqkvXWTolxLCmiIph?= =?us-ascii?Q?7ves8XQ66Yvv84+UIFwh8pdcODKA6YyBqxGJ7WP7LOHl3qoJSFPLLbFcd/2Y?= =?us-ascii?Q?oUfri6VZ7MwzYm0+QDyXZhUKFbjw0LMYyaIbf0VkmpOF2IFtlmIyDGmpKvlB?= =?us-ascii?Q?xDOvLuf6d+F6vOKI28AJ3bZl15kIItYWlirYjVhMxpXCwJvbJ/CpT9BfuHPu?= =?us-ascii?Q?xZwSJRHDpSCS3LXfRIF7jmMNKMyp3xnTLhWp/6/C/z0SZa4WM4lHbe1jh9BI?= =?us-ascii?Q?cgHQhhgKDfiDhXMjQZQFRliiY8JHReqrFbbAoY7jyWAqHiv7lM6ALknQt7mp?= =?us-ascii?Q?Xz2gApqlBwxyVItrHBTW1gJATk3eWrQopvcZlko7VH20ScSoLK5XkdkmM4fG?= =?us-ascii?Q?Wq4zjvQ1eMday+sOBbwpoyPhVJfOpzzR8eOqxNtAc3Ow9fFFMllyEAZ2QM23?= =?us-ascii?Q?B4UK814V0oVVvGrhgnkwI3kljXSAXMOyx090cZlkeUZLAVYlvaeln6cwjwv6?= =?us-ascii?Q?eG4Vf608xJGTFs1K0HW83JadqEARxIzKXyiiLGTbDfswshWMO+CZ31SRa5Sl?= =?us-ascii?Q?CZJk1MNCp7uNQb7B3eDGUKQzhkLa3BrZw/9t3nTPPZuWXHnL5nsgXZPgOmFL?= =?us-ascii?Q?a58bo2KjLYpgZvfnSgcTYE9euApLSomqXYnC8WZ+mAc7rJzngVm95STuqSzq?= =?us-ascii?Q?jpbdB8QlNsIMnjBb3aTX0EEOCr7Juc53FyWhd12mllogB/10qrutrUD0t4S6?= =?us-ascii?Q?Kw7E1Mvad6mA8FDb6aZe9YUBjey1mD/HroliR0XHpwogcuWUXa7B6NqO8pdx?= =?us-ascii?Q?PocIN3M8O6WRebNYQGSKhfn6gTYj2d29P3PbPTfIMYN2Ql/GPwuFCU5x5f5r?= =?us-ascii?Q?pf6q6oC6xX+OXRviOB9AK4ONCwFsKeG+hGlxPR/ik/43NlX5caeLLnElO9ow?= =?us-ascii?Q?eMFR/9h784irffBxmBOwc/YU+rZP2R/PHrVDlwpPeHCa/FX5wCluTGcJg2ol?= =?us-ascii?Q?8dK5YZJJjy0uyQYsjcqrTivJSDcWkvG8iQpUPRUY4elPj+FA9PlQwkUYoHg1?= =?us-ascii?Q?a8DdYNLOD+vIOtOuNPvJ+VnRH24kelNam+tDkAiLR/Z0k0D39hrfS10S8wsb?= =?us-ascii?Q?mzHmkrDBe5Z3+FuKITvaTqS5BOfPcQpVgWnMne4IfzRchiulhgN+0epozhSl?= =?us-ascii?Q?oYM=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01f412ad-3e60-4ee9-bccf-08d8cc581ea7 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2021 17:36:51.5317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n+5TPHyiZYOdqEI1MDbfkkwVhtixVolT+caOjMIPRpRLzLP3bc5RnyWQZpF5t/M3bGGTHmk/G0mVUc1P8LB5Ew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR05MB8126 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB758202C4F9B2599F0E8F0DE4B98F9SN7PR05MB7582namp_" --_000_SN7PR05MB758202C4F9B2599F0E8F0DE4B98F9SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I'd rather we not set the PcdRamMoreThan3GB on a device with 1 or 2GB. I re= cognise you're using this to choose behavior for an old Linux version, but = it's still non-sensical to the end user and it becomes a maintenance burden= since the logic is no longer clear, so you might as well add a boot option= to disable the IORT (and document as being for older Linux kernels) or jus= t not install it if you explicitly being booted on a system with less RAM. = I.e. if (PcdGet32 (PcdRamLimitTo3GB) || mModelInstalledMB < 2 * 1024) { return FALSE; } ________________________________ From: devel@edk2.groups.io on behalf of Jeremy Linto= n via groups.io Sent: Monday, February 1, 2021 4:44 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; Andrei Warkentin ; = samer.el-haj-mahmoud@arm.com ; leif@nuviainc.= com ; ard.biesheuvel@arm.com ; J= eremy Linton Subject: [edk2-devel] [BUG/PATCH] Platform/RaspberryPi: Only enable IORT wh= en 3G limit is disabled. The 3G limit, and the 2G IORT are intended to solve the same linux problem, and limit PCI DMA operations to the first 3G of RAM. Older linux kernels, as used with RHEL/Centos, trigger an assertion* when a DMA operation starts that doesn't fit within the 2G range specified by the IORT. The simple solution is to only enable the IORT when the 3G flag is disabled. * https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fpftf%2FRPi4%2Fissues%2F123&data=3D04%7C01%7Cawarkentin%40vmware= .com%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%= 7C0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DdKbis45PDc6= ciBMWvSime3ZhQJGOwYLN0OHTnhMSvvU%3D&reserved=3D0 Fixes: dac891da5cf3 ("Platform/RaspberryPi/AcpiTables: add a IORT ACPI tabl= e to limit XHCI DMA") Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++++++++++++++-= ---- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 19ef950f10..9581bc41e1 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -217,13 +217,23 @@ SetupVariables ( ASSERT_EFI_ERROR (Status); } - if (mModelFamily >=3D 4 && mModelInstalledMB > 3 * 1024) { + if (mModelFamily >=3D 4) { + if (mModelInstalledMB > 3 * 1024) { + /* + * This allows changing PcdRamLimitTo3GB in forms. + */ + Status =3D PcdSet32S (PcdRamMoreThan3GB, 1); + ASSERT_EFI_ERROR (Status); + } else { + Status =3D PcdSet32S (PcdRamMoreThan3GB, 0); + ASSERT_EFI_ERROR (Status); + } + /* - * This allows changing PcdRamLimitTo3GB in forms. + * Enable the "3G ram limit" on 2GB device because we + * are going to utlize that limit as a new/old kernel + * flag and also disable the IORT if the 3G limit is set. */ - Status =3D PcdSet32S (PcdRamMoreThan3GB, 1); - ASSERT_EFI_ERROR (Status); - Size =3D sizeof (UINT32); Status =3D gRT->GetVariable (L"RamLimitTo3GB", &gConfigDxeFormSetGuid, @@ -755,6 +765,12 @@ HandleDynamicNamespace ( DEBUG ((DEBUG_ERROR, "Found namespace table not in table list.\n")); return FALSE; + case SIGNATURE_32 ('I', 'O', 'R', 'T'): + // only enable the IORT on machines with >3G and no limit + // to avoid problems with rhel/centos + if (PcdGet32 (PcdRamLimitTo3GB)) { + return FALSE; + } } return TRUE; -- 2.13.7 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71032): https://nam04.safelinks.protection.outlook.com/= ?url=3Dhttps%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F71032&data= =3D04%7C01%7Cawarkentin%40vmware.com%7C92f310e07997434a267408d8c702f698%7Cb= 39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637478162838925480%7CUnknown%7CTW= FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3= D%7C1000&sdata=3DasFWjKVaiPH31M3SCUx8TQtzDoucFNTf8TqcYW%2Bo0uY%3D&r= eserved=3D0 Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttp= s%3A%2F%2Fgroups.io%2Fmt%2F80300339%2F4387333&data=3D04%7C01%7Cawarkent= in%40vmware.com%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd= 83d9dd62f0%7C0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4= wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D= Njvni%2BMK0z38Xi3rw2xwPNiMBmesole6evqVHwZB87c%3D&reserved=3D0 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A= %2F%2Fedk2.groups.io%2Fg%2Fdevel%2Funsub&data=3D04%7C01%7Cawarkentin%40= vmware.com%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9d= d62f0%7C0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw= MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DDaNks= 8FMX0pgeoEOY3xITNK46wbvbahKWAPnIe5kaRk%3D&reserved=3D0 [awarkentin@vmwa= re.com] -=3D-=3D-=3D-=3D-=3D-=3D --_000_SN7PR05MB758202C4F9B2599F0E8F0DE4B98F9SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I'd rather we not set the PcdRamMoreThan3GB on a device with 1 or 2GB. I recognise you're using this to choose behavio= r for an old Linux version, but it's still non-sensical to the end user and= it becomes a maintenance burden since the logic is no longer clear, so you= might as well add a boot option to disable the IORT (and document as being for older Linux kernels) or jus= t not install it if you explicitly being booted on a system with less RAM. = I.e.

=  if (PcdGet32 (PcdRamLimitTo3GB) || mModelInstalledMB < 2 * 1024) {

      return FALSE;

    }
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of Jeremy Linton via groups.io <j= eremy.linton=3Darm.com@groups.io>
Sent: Monday, February 1, 2021 4:44 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; Andrei Warkentin <awarkent= in@vmware.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@ar= m.com>; leif@nuviainc.com <leif@nuviainc.com>; ard.biesheuvel@arm.= com <ard.biesheuvel@arm.com>; Jeremy Linton <jeremy.linton@arm.com= >
Subject: [edk2-devel] [BUG/PATCH] Platform/RaspberryPi: Only enable = IORT when 3G limit is disabled.
 
The 3G limit, and the 2G IORT are intended to solv= e
the same linux problem, and limit PCI DMA operations
to the first 3G of RAM. Older linux kernels, as
used with RHEL/Centos, trigger an assertion*
when a DMA operation starts that doesn't fit within
the 2G range specified by the IORT.

The simple solution is to only enable the IORT
when the 3G flag is disabled.

* https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fpftf%2FRPi4%2Fissues%2F123&amp;data=3D04%7C01%7Cawarkentin%40vmwa= re.com%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9dd62f= 0%7C0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi= LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DdKbis= 45PDc6ciBMWvSime3ZhQJGOwYLN0OHTnhMSvvU%3D&amp;reserved=3D0

Fixes: dac891da5cf3 ("Platform/RaspberryPi/AcpiTables: add a IORT ACPI= table to limit XHCI DMA")
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 26 +++++++++++++= ++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
index 19ef950f10..9581bc41e1 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
@@ -217,13 +217,23 @@ SetupVariables (
     ASSERT_EFI_ERROR (Status);

   }

 

-  if (mModelFamily >=3D 4 && mModelInstalledMB > 3 * 10= 24) {

+  if (mModelFamily >=3D 4) {

+    if (mModelInstalledMB > 3 * 1024) {

+      /*

+       * This allows changing PcdRamLimitTo3= GB in forms.

+       */

+      Status =3D PcdSet32S (PcdRamMoreThan3GB, 1)= ;

+      ASSERT_EFI_ERROR (Status);

+    } else {

+      Status =3D PcdSet32S (PcdRamMoreThan3GB, 0)= ;

+      ASSERT_EFI_ERROR (Status);

+    }

+

     /*

-     * This allows changing PcdRamLimitTo3GB in forms.=

+     * Enable the "3G ram limit" on 2GB devi= ce because we

+     * are going to utlize that limit as a new/old ker= nel

+     * flag and also disable the IORT if the 3G limit = is set.

      */

-    Status =3D PcdSet32S (PcdRamMoreThan3GB, 1);

-    ASSERT_EFI_ERROR (Status);

-

     Size =3D sizeof (UINT32);

     Status =3D gRT->GetVariable (L"RamLimitTo3= GB",

            &nb= sp;            =        &gConfigDxeFormSetGuid,

@@ -755,6 +765,12 @@ HandleDynamicNamespace (
     DEBUG ((DEBUG_ERROR, "Found namespace table n= ot in table list.\n"));

 

     return FALSE;

+  case SIGNATURE_32 ('I', 'O', 'R', 'T'):

+    // only enable the IORT on machines with >3G and no = limit

+    // to avoid problems with rhel/centos

+    if (PcdGet32 (PcdRamLimitTo3GB)) {

+      return FALSE;

+    }

   }

 

   return TRUE;

--
2.13.7



-=3D-=3D-=3D-=3D-=3D-=3D
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71032): https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Fmessage%2F71032&amp;data=3D04%7C01%7Cawarkentin%4= 0vmware.com%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9= dd62f0%7C0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA= wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D= asFWjKVaiPH31M3SCUx8TQtzDoucFNTf8TqcYW%2Bo0uY%3D&amp;reserved=3D0 Mute This Topic: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgroups.= io%2Fmt%2F80300339%2F4387333&amp;data=3D04%7C01%7Cawarkentin%40vmware.c= om%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C= 0%7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQ= IjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DNjvni%2BM= K0z38Xi3rw2xwPNiMBmesole6evqVHwZB87c%3D&amp;reserved=3D0
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fedk2.gr= oups.io%2Fg%2Fdevel%2Funsub&amp;data=3D04%7C01%7Cawarkentin%40vmware.co= m%7C92f310e07997434a267408d8c702f698%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0= %7C0%7C637478162838925480%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQI= joiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3DDaNks8FMX0= pgeoEOY3xITNK46wbvbahKWAPnIe5kaRk%3D&amp;reserved=3D0 [awarkentin@vmware.com]
-=3D-=3D-=3D-=3D-=3D-=3D


--_000_SN7PR05MB758202C4F9B2599F0E8F0DE4B98F9SN7PR05MB7582namp_--