public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Andrei Warkentin" <awarkentin@vmware.com>
To: Jeremy Linton <jeremy.linton@arm.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>,
	"leif@nuviainc.com" <leif@nuviainc.com>,
	"pete@akeo.ie" <pete@akeo.ie>,
	"samer.el-haj-mahmoud@arm.com" <samer.el-haj-mahmoud@arm.com>
Subject: Re: [PATCH 0/3] SD+USB perf/DMA fixes
Date: Thu, 8 Apr 2021 14:24:40 +0000	[thread overview]
Message-ID: <SN7PR05MB75820F00C618F1C4E16386D4B9749@SN7PR05MB7582.namprd05.prod.outlook.com> (raw)
In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com>

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

I think Linux's behavior needs to be reconciled with the ACPI spec, which uses _DMA with ResourceConsumer, not ResourceProducer.

A
________________________________
From: Jeremy Linton <jeremy.linton@arm.com>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuviainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Andrei Warkentin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com>
Subject: [PATCH 0/3] SD+USB perf/DMA fixes

A large part of why the emmc & dwc2 usb
controllers haven't been working properly is
because the "bus" _DMA was incorrectly tagged
as a consumer, when it needs to be a producer.

That is why linux has been dropping the
translation value portions of _DMA().

Since the emmc2 dma (with the old B0 SoC), and the
dwc2 is expected to work, lets add matching 30 bit
IORT entries for them.

Finally, in the shuffle the high speed cap bit override
was dropped from the linux patches, and I failed
to add it back to the firmware values, this caused
the wifi perf to be lower than it should have been.

Jeremy Linton (3):
  Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode
  Platform/RaspberryPi/AcpiTables: Add further named components
  Platform/RaspberryPi/AcpiTables: Correct _DMA consumer

 Platform/RaspberryPi/AcpiTables/Dsdt.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Emmc.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++++++++++-
 Platform/RaspberryPi/AcpiTables/Sdhc.asl  |  2 +-
 4 files changed, 46 insertions(+), 4 deletions(-)

--
2.13.7


[-- Attachment #2: Type: text/html, Size: 2898 bytes --]

  parent reply	other threads:[~2021-04-08 14:24 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08  5:58 [PATCH 0/3] SD+USB perf/DMA fixes Jeremy Linton
2021-04-08  5:58 ` [PATCH 1/3] Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Jeremy Linton
2021-04-08  9:48   ` Pete Batard
2021-04-08 14:17     ` Andrei Warkentin
2021-05-10 16:41       ` Samer El-Haj-Mahmoud
2021-05-10 16:41     ` Samer El-Haj-Mahmoud
2021-05-10 16:41   ` Samer El-Haj-Mahmoud
2021-04-08  5:58 ` [PATCH 2/3] Platform/RaspberryPi/AcpiTables: Add further named components Jeremy Linton
2021-04-08  9:48   ` Pete Batard
2021-05-10 16:41     ` Samer El-Haj-Mahmoud
2021-04-08 14:17   ` Andrei Warkentin
2021-05-10 16:42     ` Samer El-Haj-Mahmoud
2021-05-10 16:41   ` Samer El-Haj-Mahmoud
2021-04-08  5:58 ` [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Jeremy Linton
2021-04-08  9:48   ` Pete Batard
2021-05-10 16:43     ` Samer El-Haj-Mahmoud
2021-04-08 14:23   ` Andrei Warkentin
2021-04-13 16:44     ` Samer El-Haj-Mahmoud
     [not found]     ` <167578A6C978A75F.9301@groups.io>
2021-04-29 14:02       ` [edk2-devel] " Samer El-Haj-Mahmoud
     [not found]       ` <167A591C4A42BD1B.6294@groups.io>
2021-04-30 18:05         ` Samer El-Haj-Mahmoud
2021-05-10 16:42           ` Samer El-Haj-Mahmoud
2021-05-10 16:43   ` Samer El-Haj-Mahmoud
2021-04-08 14:24 ` Andrei Warkentin [this message]
2021-04-30 18:28   ` [PATCH 0/3] SD+USB perf/DMA fixes Samer El-Haj-Mahmoud
     [not found]   ` <167AB62D787B8F90.7155@groups.io>
2021-05-10 16:40     ` [edk2-devel] " Samer El-Haj-Mahmoud
2021-04-30 20:30 ` Andrei Warkentin
2021-05-10 16:39   ` [edk2-devel] " Samer El-Haj-Mahmoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR05MB75820F00C618F1C4E16386D4B9749@SN7PR05MB7582.namprd05.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox