From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.55]) by mx.groups.io with SMTP id smtpd.web12.9079.1617891882387858728 for ; Thu, 08 Apr 2021 07:24:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=wXV0EM7O; spf=pass (domain: vmware.com, ip: 40.107.244.55, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0466ijHMO8fCSVtKZJfCTYvElAW/9R14ojCpx6Nk4z0n924V4AGcjn5wv+Z1VuzNmgaobAQruNEXeFA+JFokD2sFvqJAex6WfDxgzqr70AAMiYDf0wnLol+EZ/bGHap6p5ywvPafe/O8LZiESMHEaCkj/KnXVY+kEL53VUAms0X83f4W4sGSw1QPe2cgBOxxdRSxshJ0ZHKZsS5IVVU7u25853/eRenoBrba289Ot8Y26skX9K8S3GOoFleGkf4suP/++0Sx+kHvVifyeMemACVOkxXYNLnbNXwGsjtRALHd9+9vrrTWD2fubQES9f4lcM9V1RJvCb8Zv3hgKZ90g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNQTUFWFRC8rmAGEaff2oXVbNhyVPwp99mQvVrKt7zQ=; b=aGArTYDpTlhddZnWZ6DHVk9ZqkMMuQaxf8frvk87OfKhs+uNKdbHxEYeYZfRYhXj1UqTOkAEploLaiLLNpTfaxC4QFj32brjb/C6ifggwPekUf+XO9UtnrG4UI1QwGoO5/cp/sBgY6EFNpKEQyRBJygXOUxJgxhu0bBrSSAI1m9w2qUU3tLE84iIiNkPrawjYhkbJylDjsQWaPMySnH8Hwlzmy5lZyUC8Yh1T8bXlpq/UOjV9txE1SaWvqzw9gT7lC5IYigOks2CN6SARAZ8muz6D8ZU3qN1pzTd5FYjaj/Uz39MBWUM88fIESW9LyYHtSZJaFKNLZqiXmR/wcgEaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NNQTUFWFRC8rmAGEaff2oXVbNhyVPwp99mQvVrKt7zQ=; b=wXV0EM7OkeSaj59vbAKlh8lWxXZHNpte1Z6QJ2C2URTMYz4WNqPVKpAmrOnma8Q8BEBbekFshqq5/3T6L0/34Nwe8MgjBujJ+C4qGhWzme7gFlXkGhKYLvHKN0akj1banSdjxPx3UoGkL0akwOBXDmPJrVc9iLhuD/qSyJ105U8= Received: from SN7PR05MB7582.namprd05.prod.outlook.com (2603:10b6:806:f7::16) by SN6PR05MB5822.namprd05.prod.outlook.com (2603:10b6:805:104::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.8; Thu, 8 Apr 2021 14:24:40 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e%7]) with mapi id 15.20.4020.016; Thu, 8 Apr 2021 14:24:40 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "ard.biesheuvel@arm.com" , "leif@nuviainc.com" , "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH 0/3] SD+USB perf/DMA fixes Thread-Topic: [PATCH 0/3] SD+USB perf/DMA fixes Thread-Index: AQHXLDxDbM1KpyU+qUayU+dCRqLfjaqqrRj+ Date: Thu, 8 Apr 2021 14:24:40 +0000 Message-ID: References: <20210408055843.2883563-1-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 18a936af-4065-43c4-2b41-08d8fa9a0c02 x-ms-traffictypediagnostic: SN6PR05MB5822: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: J/ae0c2sWowWLFDHtPW6VPk41+4M2lhFGaNuMbwz5/xmDlQvB12azuNA/G5bMQT/pBCGJgYnnCb3DMzH+ifK/s6WelKvq2SysQj9dATl7msFa8IRWcmWGDOJIeZqzlcn6DMFmBS5rtif1tF18T13jy1rLvz3b9dTuO897Apt8iy6DPRZtRlFybqXlYcWU1U9w6JR70mN4UbYQGl9ZTP3wDImaj3ZqUQYTwy5ITlpjPNNjwd+/mlav6ivk8sdEmtC3VJ+gu4y0uMzmS2dracrXabiaDRHqAMKG6Z5/UZpoed8vqQ40sPlhL92SP/OwkqMd3iLmiATaR+XaHPlpzjMjtTmmER3gOfd8Nt+aueKL3CHZPDF3PBUPXjCppCDP7R2sRkUjSBo6QUStEIMM/P64Fy0ybIaCFZIMYBwMcfeHqoWm4p6IHQVeqXEm9+w6KzVohmZYUmphug1cXCXcVoBgCBFa9Fho34fIHrqgAXjhsC6gn9JsbpWCxNQfVJzg4gF9ZPt5Zhlqr2adkpDTa87eTzHjU/aUT16icFYeNkVIvAB54xGx7Bpg1hVIvPohr8rD9GaK7yZGlVVCgzMyTxyYM0UBhvPsTNW3CsKxtvjcm4mpgGWxVmuGb/zDjLSW/Li7//4tCiDsilQsjvzC9bCw4OcTncM+3Azyu0ISwoezqE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(396003)(366004)(39860400002)(376002)(346002)(33656002)(86362001)(66946007)(38100700001)(52536014)(478600001)(4326008)(83380400001)(5660300002)(66446008)(2906002)(66476007)(8936002)(54906003)(76116006)(8676002)(91956017)(71200400001)(6506007)(53546011)(64756008)(186003)(66556008)(55016002)(26005)(19627405001)(316002)(110136005)(7696005)(9686003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?zU5gIESulbWEjN8WE0hvjqiSRsu2HJ2BkaxovzpTpWTsxJmXw7FRxIphvkld?= =?us-ascii?Q?smehyYKhZ76CqWwbcwvLFR4KtiUW88VGL6Iel+OnUQqPZ0IuIfL2+CHWikc+?= =?us-ascii?Q?JG8uaQUMS8fxF/XqKgVmBBIuT4+mkvvE/v32HiDmH4dFpRHJVArBmcdbQUwA?= =?us-ascii?Q?YOAQ3Nh4TkO7a90h1OMUwylpj9ZMmbWRRQOUzgGv4Qzn7WvVBZ7tUgqUlH7o?= =?us-ascii?Q?JD++WWebFn8p4vg9d0+kD28XBMb0k9ghF7z67g2U2MniyAG9dKGnVKZQd2Li?= =?us-ascii?Q?VJ+LFAmfGshSNtY9sqTgCmeEFHH0Uts8GxEjpIVSiWdgiiYPW2qgYwRhtsxo?= =?us-ascii?Q?F6drhKCR/RAkI1MfiiVzT3VUP3BojxCNOEV+LOxTS0EwB9yrFCxM2GX9QESd?= =?us-ascii?Q?kp0P1Nshr2Di+jVsTEo3pWYzzbhPTU0MX/CGuvUPJz3Z16F95JOcpYU72+HP?= =?us-ascii?Q?5BJt6E91yvxuNGvroTUFX0UB67/1aZ1bqAtnnjRiUPNCBmi1JCLtlUHbKuBS?= =?us-ascii?Q?PCg9mbwYx27rylwZx78mnarrwgD488lhV+zwT3/MscLOGaOVeA8Ci62wclcj?= =?us-ascii?Q?JpoSBWQJvvX2EfJ8zxLshWceXWL+8vObP/++AR0aR3R3ihSGow4psAddZMAj?= =?us-ascii?Q?4cWmlu+JHmey4Fzej/SyU20u2WQ8hKQqdUwqiSisJ4APSUh13DUZvwuJtAyn?= =?us-ascii?Q?aQm0ZPgPhfKhRUfA8YjLAYKLbNfVo6Zv6pGrxqrug21If4MLlJY4UPIAfbxn?= =?us-ascii?Q?aO1kShd4TVfvW5EZL2OAhJ7UDFLJcFtjch4LbUkYbSyGf+zaScCBp+B89cqN?= =?us-ascii?Q?yTF+zZ0myPBXg6A8LUfqNcUR+PaRkcSnPk1YDl2n5pA6r7uexPFRyzL7uKVP?= =?us-ascii?Q?xnHW8dP7wfPFYzgkPH8kEBwH7Q5CLX0Bn7GjIo/l1yYbsxRcmlMmEddtbxIk?= =?us-ascii?Q?rS5kl8Qrq1OD3ZbRzMzsrP3naotb5o+mFMXcj4k9Wu8JZ4dswtVKI+af/Wbi?= =?us-ascii?Q?tQ5C3yAg4VV+lgn2/sarQS6FPy9XVFFI4EAPvq4uGugL8cW/u25ZydXEXzy1?= =?us-ascii?Q?tFFAljmBNK0bK75Aj20W/gZvh1Oqx+QANuHao0CgKIQteNpfQW57CuPq+3cf?= =?us-ascii?Q?ohIm0U8NnzwRn48WbQ/Kwd7CQ+i8Cu6rtr447cZg+rpVuMv6g8VMnybpgTTZ?= =?us-ascii?Q?GaSan5yQcDhGtUhYwhyIme8h4iaxWYs9wxnTU7q8OMEh0V4ZXOytbUss9hxy?= =?us-ascii?Q?38lAP8nmsutOz+7/bwTcOhruf5tdO3J0reywG47CVDE+l2DFMGvdiTlFBLDo?= =?us-ascii?Q?zxwSW9UF8EG8ZDXWEx85fau8?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a936af-4065-43c4-2b41-08d8fa9a0c02 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 14:24:40.5385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /zkRkYGeg5RO1C+D8nh3zjGnW5enegSgazO7zF/CnUvohKi07pGjqGFuw3RYzU074J8t/jPfmBgzbrLbuL9hcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5822 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB75820F00C618F1C4E16386D4B9749SN7PR05MB7582namp_" --_000_SN7PR05MB75820F00C618F1C4E16386D4B9749SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I think Linux's behavior needs to be reconciled with the ACPI spec, which u= ses _DMA with ResourceConsumer, not ResourceProducer. A ________________________________ From: Jeremy Linton Sent: Thursday, April 8, 2021 12:58 AM To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com ; leif@nuviainc.com ; pete@akeo.ie ; samer.el-haj-mahmoud@arm.com = ; Andrei Warkentin ; J= eremy Linton Subject: [PATCH 0/3] SD+USB perf/DMA fixes A large part of why the emmc & dwc2 usb controllers haven't been working properly is because the "bus" _DMA was incorrectly tagged as a consumer, when it needs to be a producer. That is why linux has been dropping the translation value portions of _DMA(). Since the emmc2 dma (with the old B0 SoC), and the dwc2 is expected to work, lets add matching 30 bit IORT entries for them. Finally, in the shuffle the high speed cap bit override was dropped from the linux patches, and I failed to add it back to the firmware values, this caused the wifi perf to be lower than it should have been. Jeremy Linton (3): Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Platform/RaspberryPi/AcpiTables: Add further named components Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 +++++++++++++++++++++++++++= +++- Platform/RaspberryPi/AcpiTables/Sdhc.asl | 2 +- 4 files changed, 46 insertions(+), 4 deletions(-) -- 2.13.7 --_000_SN7PR05MB75820F00C618F1C4E16386D4B9749SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I think Linux's behavior needs to be reconciled with the ACPI spec, which u= ses _DMA with ResourceConsumer, not ResourceProducer.

A
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuvi= ainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; same= r.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Andrei Warke= ntin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com= >
Subject: [PATCH 0/3] SD+USB perf/DMA fixes
 
A large part of why the emmc & dwc2 usb
controllers haven't been working properly is
because the "bus" _DMA was incorrectly tagged
as a consumer, when it needs to be a producer.

That is why linux has been dropping the
translation value portions of _DMA().

Since the emmc2 dma (with the old B0 SoC), and the
dwc2 is expected to work, lets add matching 30 bit
IORT entries for them.

Finally, in the shuffle the high speed cap bit override
was dropped from the linux patches, and I failed
to add it back to the firmware values, this caused
the wifi perf to be lower than it should have been.

Jeremy Linton (3):
  Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode
  Platform/RaspberryPi/AcpiTables: Add further named components
  Platform/RaspberryPi/AcpiTables: Correct _DMA consumer

 Platform/RaspberryPi/AcpiTables/Dsdt.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Emmc.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++= ++++++++-
 Platform/RaspberryPi/AcpiTables/Sdhc.asl  |  2 +-
 4 files changed, 46 insertions(+), 4 deletions(-)

--
2.13.7

--_000_SN7PR05MB75820F00C618F1C4E16386D4B9749SN7PR05MB7582namp_--