From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.65]) by mx.groups.io with SMTP id smtpd.web11.8909.1617891816461236175 for ; Thu, 08 Apr 2021 07:23:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=R4rtXewv; spf=pass (domain: vmware.com, ip: 40.107.93.65, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TPhuYtGERhUdX/QTzXj3FgRNqt9pDyVIRtMJv7Tcu6aFNAMlkOc3ZLQUBztpOl22xi8jqisNFhs6FwQ9O7GFhfMKw4y0DUMd448SfnspUr26pi/DNZaN/e2c7O3UMKJQAtvvj8n+QCxq5hj5I+NEd00ObBvOehNN1UexL/jhhbAcwZS4C8YYHtU6WYEBRT/5QoNAxSJPm5plKiArhvdHM6gB3I0P0LGc2SIhG7l5MCtjv7/0/2aLKWrdAX9+mA4tgHgv7ecXpNeRDIsl6nqN/fLJ+7OhrrvfnqHhCSxswylHkjqHS2FVe8vdbAxZqbA+SGXghg/UPRifWEoZapZXrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dd5n3LpECoar6ogUbCDFV4XhlMvvz9sUWDmbpg1Dxws=; b=iE1TWU1ZqnS4epE09E63W0BzUfJOzqnnWO2YMbz3e+PA/weN2Nu9V6oTSP0i/LIOENsmayrDTV8GPmMUkVMQgvl3NW5SvhgHduKgW2kqEhF2SimmSccrsScHNmHHFb2jHhR+8oMijqza4LuP8CF6/0lk5GLWpR0H2YsJXiAP4LOvynL+tJDR8yVwDuBW4u3zLJ86icpALWAnAG99SpEyX+UA9e1WVmfcGv2Fg2QVGWcG1UkgcZOk+lnwVvhU+cKtDx8MGti4CbBna6tvYPW/RU4jtgjExBovwldfb8TiF9hfmTsdWATV8nkE/uLxyZ8YGS/vGQ9fP80Egwexh052QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dd5n3LpECoar6ogUbCDFV4XhlMvvz9sUWDmbpg1Dxws=; b=R4rtXewvaRcPPPEyYmLz9duYboPV4/i/4wWBSwkC5q8nthiYCCLi/7j3wRLyqxZo7GTbxr+5T+xInjh1ODJhz3o0C043IQDz2LF0m+QhIeMyfTLi2NLI9poc5GZ13Zw+pl6MfeNgykIMC2o1Xf/4SUh9uXOg3zxt7LswSbw+AqE= Received: from SN7PR05MB7582.namprd05.prod.outlook.com (2603:10b6:806:f7::16) by SN7PR05MB7773.namprd05.prod.outlook.com (2603:10b6:806:10b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.9; Thu, 8 Apr 2021 14:23:35 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e%7]) with mapi id 15.20.4020.016; Thu, 8 Apr 2021 14:23:35 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "ard.biesheuvel@arm.com" , "leif@nuviainc.com" , "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Thread-Topic: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Thread-Index: AQHXLDxG2f/60zHcFk+V5VFsWQlyiaqqrKmX Date: Thu, 8 Apr 2021 14:23:35 +0000 Message-ID: References: <20210408055843.2883563-1-jeremy.linton@arm.com>,<20210408055843.2883563-4-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-4-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 38f7317c-411b-498b-ed2a-08d8fa99e506 x-ms-traffictypediagnostic: SN7PR05MB7773: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3383; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cgX7Z0KoJIFjre7ffswPHI2YYul3rrL2y8fAzrcsDyeqj3oWrXrRKqyrqJ4EGCdpnt5TNKp9QMF0aLSGgsQ109YLGRiVocil/bJmNBUmFwWeSFqWfI6Qb7mUYhEgnA+XY6mo+UCQ7XG/2buHKB96cCBeNwtN1+S9IBVP1GDewyx1coihCy9Qh30Unswuo2qOMPWZ4dSrnIy1X/LPq4AfDOs35kF08lnjJhbciWJAcO5urQ2lr04jb0miakKi6AwY4+ZfgpQ0Kpf5TG5dAJ20/A3NxEwCyfE1JVTBiE37cY+YKH01YAhq1vVYCy/N4u1lG6MyxHs4hEEZV60/ljOGGCXGaXOyxmxkYnIrbG9d0ea1xjgHQ/dfgFpaFkaxVhIiJVARwdf7MYXGLYIILWtFLJQNvA3TjeiCFlTeZKrposXpQbP/i/0Wy9Jf1U6wTzeftdvzZy7taSeGkOJG/m0Fgvkq84siRcgDTURxam7t3Z2oS9059jZ7Rpzr2fggZHh8Jp65U1RrEgJCEzpTC+sz0iFy+J0aJV+6zhmLiO0MLNpf6XwE/CVUg83tPaa9I9twbWE9Nrhg/tGYo5yJVNhoIzdfto3f/kdz6QYYQifQScm3w0ZWZwwUuD/WoKVFlgwOtuqrD9F2tw1095Xkr0SgFw4p9L9tG7QwHHzn7UBVbkvp4DSp8/G+psBChOumV62zb0mmwHeWr1lXL9SRwhEy6FDKHwvI56h8vbybK2j5AKE7hzLtYebwVE3IpbZ/YF// x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(366004)(396003)(39860400002)(346002)(478600001)(316002)(110136005)(5660300002)(966005)(19627405001)(54906003)(53546011)(186003)(8676002)(76116006)(33656002)(91956017)(4326008)(52536014)(66446008)(64756008)(66556008)(66476007)(38100700001)(6506007)(8936002)(2906002)(7696005)(66946007)(55016002)(86362001)(26005)(71200400001)(83380400001)(9686003)(166002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/UxAPrR8BUNrlqE1DMHCFrCOcy6fnmho744hnr/6Teq2eOWQn8j03NGwQQTk?= =?us-ascii?Q?IkDe1C0U5Cm/7u8pG2ZbXCFQSewUOKlpArcC100P9qFBdd0bD3vlNKPDX9PT?= =?us-ascii?Q?PzaFwJoy1MxvM50GYTzM/jzYF+oKYbnyL200M+JXFJF6U63q8V37uz9/CFDs?= =?us-ascii?Q?2+5eitNP4kGh4b5xzSxHMzzhk+4QBypzwp/L7syz8qy7pgoFdQNjYgZ1Uzem?= =?us-ascii?Q?7gvHX+zuY1yhXJMa30GmSFwhP6NRNU1UFp6t/FTT02QdoEk+kmU53/sl+lcP?= =?us-ascii?Q?SEkRQXZZ02DAlnXaPHGKpq2aqtIOpNaQTSHIQuztlDul8mYtS2iwAJIMl1Ps?= =?us-ascii?Q?7uDkk1jQFwooj/Zk7/YNG4aUCmhpVPQzh+jCOiN6uzFOOzYwyLrZUGWfqrnM?= =?us-ascii?Q?rpqqbV+KxHKPgbZp5Px775nyZEOjHlcsHAiv9mUiOjGMDh6mpB+NvsULsZpz?= =?us-ascii?Q?0jFwXXdih4NGuFW3NiMEU+Czywggrd1Xjg6yWUyxx8RSWhDUERhUatuTNcW9?= =?us-ascii?Q?V8LpBuqc4AhHbmi8lEQAFfTPFT35aypHhpEsiGOlYY/gXO1PHCGcr02TeBVM?= =?us-ascii?Q?Z8pik+JFa5oNMV6E7Nj8VyPJu5ZBeZRi21xiqZhblUREqQ7enc2ZMqq3gOaZ?= =?us-ascii?Q?emM/UKumof2DOfH4u4xb+YsF0zbyJndNJf1T38WMiztMIZ03EL4cXxCgZNKP?= =?us-ascii?Q?PkygSlHy2BzXyn/DR2LE9fpD+SY6i/g3A1zG4Bp1HT5hTmGu7BSDxDef4jlD?= =?us-ascii?Q?0R5BmZ0hWtViFhMkO9q60FEue3t/nHO2iradjgEx6CGG2DLg0LhXxP5mNEqY?= =?us-ascii?Q?6z0Gl4BfjFK388PKzTvf7A9ELBlbQNaVbcXZrPlKZ5kcvoeXJby5MIkoRlk8?= =?us-ascii?Q?rolvYL60RDHzIA402dheApaDlWvfpiRpFwMBsuq+P5tbj8VJQU3HJUDFOExW?= =?us-ascii?Q?ikwK7zaAcCJYXC9HK8LVR6u53hhdCKysZN7EQRyUHxW/kjw3u5YQzTpvl1s0?= =?us-ascii?Q?Ev4PFK7G5OQlCDVsbfQ5zcvoWarnZBSpA2FbbXv+oQfJG0s9P5dwy9XVMFiy?= =?us-ascii?Q?n6jNxNG4vGxntmSsDrsXjxH6D6rh1/eOsnkFOlAncggS6Bq2Ee5gHaxfStRI?= =?us-ascii?Q?0h7Foy68GBr2zbiUT5SPY+TTvdHOGhsCpJDiPB8OOxlMDt+gadBiIJenob13?= =?us-ascii?Q?bGjaSRd2kb6E19SSkFib1UAxwdd3hRSif4W4HSZQmIXi17UVVZ7qVcoL+IMP?= =?us-ascii?Q?Eq5IbwjXp6JVPvtxA2I5t/AqgWYpdF/LrNlDQBMgkX9b6F1CM3L3BbfqqLYB?= =?us-ascii?Q?iZCwXdhVVx2vyTPdMfEg1PMk?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38f7317c-411b-498b-ed2a-08d8fa99e506 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2021 14:23:35.1565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lLmW9iK42RZwsoz/4k10pkno8Y8dXKFO7mK+C8Q4asBOwY18xul/5FpIIAqd2f1MQ0KVggPtlLf2mIfDLJ8LBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR05MB7773 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB75823D7838BA61C71D10C8BBB9749SN7PR05MB7582namp_" --_000_SN7PR05MB75823D7838BA61C71D10C8BBB9749SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I don't know... the ACPI spec is weird. https://uefi.org/specs/ACPI/6.4/06_Device_Configuration/Device_Configuratio= n.html#dma-direct-memory-access ...lists ResourceConsumer for _DMA. A ________________________________ From: Jeremy Linton Sent: Thursday, April 8, 2021 12:58 AM To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com ; leif@nuviainc.com ; pete@akeo.ie ; samer.el-haj-mahmoud@arm.com = ; Andrei Warkentin ; J= eremy Linton Subject: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Bridge devices should be marked as producers so that their children can consume the resources. In linux if this isn't true then the translation gets ignored and the DMA values are incorrect. This fixes DMA on all the devices that need a translation. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryP= i/AcpiTables/Dsdt.asl index d116f965e1..32cd5fc9f9 100644 --- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl +++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl @@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT", 5, "RPIFDN", "RPI"= , 2) // Only the first GB is available. // Bus 0xC0000000 -> CPU 0x00000000. // - QWordMemory (ResourceConsumer, + QWordMemory (ResourceProducer, , MinFixed, MaxFixed, diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryP= i/AcpiTables/Emmc.asl index 179dd3ecdb..0fbc2a79ea 100644 --- a/Platform/RaspberryPi/AcpiTables/Emmc.asl +++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl @@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4EMMC= ", 2) } Name (_DMA, ResourceTemplate() { - QWordMemory (ResourceConsumer, + QWordMemory (ResourceProducer, , MinFixed, MaxFixed, -- 2.13.7 --_000_SN7PR05MB75823D7838BA61C71D10C8BBB9749SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I don't know... the ACPI spec is weird.


...lists ResourceConsumer for _DMA.

A

From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuvi= ainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; same= r.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Andrei Warke= ntin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com= >
Subject: [PATCH 3/3] Platform/RaspberryPi/AcpiTables: Correct _DMA c= onsumer
 
Bridge devices should be marked as producers so th= at their
children can consume the resources. In linux if this isn't
true then the translation gets ignored and the DMA values
are incorrect. This fixes DMA on all the devices that
need a translation.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +-
 Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/AcpiTables/Dsdt.asl b/Platform/RaspberryP= i/AcpiTables/Dsdt.asl
index d116f965e1..32cd5fc9f9 100644
--- a/Platform/RaspberryPi/AcpiTables/Dsdt.asl
+++ b/Platform/RaspberryPi/AcpiTables/Dsdt.asl
@@ -205,7 +205,7 @@ DefinitionBlock ("Dsdt.aml", "DSDT"= , 5, "RPIFDN", "RPI", 2)
         // Only the first GB is av= ailable.

         // Bus 0xC0000000 -> CP= U 0x00000000.

         //

-        QWordMemory (ResourceConsumer,<= br>
+        QWordMemory (ResourceProducer,<= br>
           ,

           MinFixed,

           MaxFixed,

diff --git a/Platform/RaspberryPi/AcpiTables/Emmc.asl b/Platform/RaspberryP= i/AcpiTables/Emmc.asl
index 179dd3ecdb..0fbc2a79ea 100644
--- a/Platform/RaspberryPi/AcpiTables/Emmc.asl
+++ b/Platform/RaspberryPi/AcpiTables/Emmc.asl
@@ -32,7 +32,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPI= FDN", "RPI4EMMC", 2)
       }

 

       Name (_DMA, ResourceTemplate() {

-        QWordMemory (ResourceConsumer,<= br>
+        QWordMemory (ResourceProducer,<= br>
           ,

           MinFixed,

           MaxFixed,

--
2.13.7

--_000_SN7PR05MB75823D7838BA61C71D10C8BBB9749SN7PR05MB7582namp_--