From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.67]) by mx.groups.io with SMTP id smtpd.web09.3688.1619814610224615593 for ; Fri, 30 Apr 2021 13:30:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=a79go6ro; spf=pass (domain: vmware.com, ip: 40.107.220.67, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OeswHDf5/3AJ2eQkJW0FZ1+LCqjdWQWQZ0hF6use2IppfGyyXh4tZN83XEHndXeCJ88FGvd9O5IL3xX+wfgJbMWd2dNs77ThGOlF6Fz+YJi3EaNh/OnLeyk0WcwuH8QWxZ1oAQZ4qyS2VFcT1YAxB6vcHkuv/ieQGnPu9s9QXlylGKs6gNpkO0su5mhLtmE0zlSClKa0hUMx/bTe7SN4Yqso/mahQhANUo9O9nRsntAeZNN1JDbmwfaM6SxvR59jRySOF/d6ism9J/5rhm/QzBxEnmbvqd2gLe6jwscnJhnob1zzcEtypCN2gt66UQTCgk9qwSD38A6pW0VoeDlWuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZrQdAgZXdXuFyXdd70MdxQfG/NU1ztMyZ+8Maa2VQr4=; b=Jl8/cSENnYt5l0oJJY/Nsrdw187/XowEza8bVfD1HVjzbczKvipK137ltaOUoi+kgzFDU6rS6cOGmbX5e3XVCWYSrIfSxZUnE0cpR231FcAUnM0mI3cCZstY/++XlFlh8JTmpTFoI0ybAHskwWhOXu/0zTJDdtWh+FPBmpZtblAIsI/ik+qUs2Wo+hTDYBZj/n2uys1gj8iVqHB9GNdOE/cv4v7rg+rGf2IhtfaY8n187lQPG5pyI2RlIQi4zW2ijUB0eY6KkY0X3DE3gE0+03I2lKjv4kP/v5FNo0cWuxzEx6xf5xGgr4iK2lR0kG9i09MHMzn96N2p/n7Ko1wYuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZrQdAgZXdXuFyXdd70MdxQfG/NU1ztMyZ+8Maa2VQr4=; b=a79go6roZ7NQZOSkMB1ejIKcsIkaxnjnHbn6lCuymdtgXu48w2z+sAcSrtRnKlz25KcnCLPqfvhTiVi8+fIdmKOR/xHZe1cZjswxZvQvgpGO1E9OB+rbKD5VhKfaSwkhdOyZ9jXwuL5YVNzac+zmj5ib97TFDZ/eonRUHkvh6wY= Received: from SN7PR05MB7582.namprd05.prod.outlook.com (2603:10b6:806:f7::16) by SA1PR05MB8063.namprd05.prod.outlook.com (2603:10b6:806:1a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.11; Fri, 30 Apr 2021 20:30:08 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::a199:b8b:c31a:cd0e%7]) with mapi id 15.20.4087.021; Fri, 30 Apr 2021 20:30:08 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "ard.biesheuvel@arm.com" , "leif@nuviainc.com" , "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" Subject: Re: [PATCH 0/3] SD+USB perf/DMA fixes Thread-Topic: [PATCH 0/3] SD+USB perf/DMA fixes Thread-Index: AQHXLDxDbM1KpyU+qUayU+dCRqLfjarNpq11 Date: Fri, 30 Apr 2021 20:30:08 +0000 Message-ID: References: <20210408055843.2883563-1-jeremy.linton@arm.com> In-Reply-To: <20210408055843.2883563-1-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2045ba17-6472-45b1-9d47-08d90c16bf2b x-ms-traffictypediagnostic: SA1PR05MB8063: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yPOZqZAz3QL9WiVaSV/PHrTFCwY8azYZl9kkFx2T9uVz+qtJ34xe3+Oo+VzLEDdxmIfoJ0auiJ1/oKoZdoqn3zJ6sdfgRVGVhhWRD3yK6Q1Bzjj/wHZ7Oj+1GnEpQ2dSbqCR7aXZXSJFS/hytw1JBVES5Fo/YibmBwxe4cZwn8p0n/5rsZJj53Bht2cd4/o1I/yo3Nm1YmEnhdiiFNfTwbTGfXTC8dHsHa4aflhQEVkXrv6RYrhpAu6DklY8x/durgOi4kPXQ4oJB9/PNYOGecgYwGuuNfBFHbph8IoIrhYGsfIL57uUNdoMffMffXjrCsvSLvMIEu/qkd3GE8Vdd0s+nDx8DFUu6cohQZHBxgkmD08hzLJhO8fGq+azHf25YedFCmPwomsbwHvYOJzSJyJOy6dRGqHxi2zCU4sgXh64WlXIPueSOegdtr5r7cosQD9sGS2s+EiAJVne7WvnbOUENYx6TK7qWwH60JB+Mcbu3O2AomGd8Q+UNPWGFWKJxoaFm9dTzMGge0dWk469jrPBPGclEv4Mmu3YVi4ZA2xD3uR1Vs6VvFz2ZNbSAELFoTsIs4E2JFfVgB8PDFlYrwhy1c/4XO9+A36scoL6uUk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(52536014)(54906003)(76116006)(66476007)(5660300002)(33656002)(4326008)(19627405001)(55016002)(316002)(66446008)(8936002)(86362001)(66946007)(9686003)(66556008)(110136005)(64756008)(8676002)(38100700002)(71200400001)(478600001)(186003)(122000001)(2906002)(6506007)(53546011)(7696005)(26005)(83380400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?GDREE0g0WTN8NhQAU3xADvM9NkUpxANhQlflv7EZ5UZfmh3DXuwtpElOV5EW?= =?us-ascii?Q?52uFIpjyVYOyqxA1nMEj+wbYQwuYLAuxtmKi0BuIy9MHJfVFoGRKlQmYRPg+?= =?us-ascii?Q?BJQ2Z6/OjelB0sXwPldIRtMF2o8X/UQuzDL/b/QDrFu356uPiKdr4L9/h9Wv?= =?us-ascii?Q?188jh8YgqU02jxVpTPRu7dTHvtSaSERj8KG1fOqCELZ9SEs/kKPxJ/GzqV7H?= =?us-ascii?Q?Cx0M+zYgnflfPEg6CU719ks9PMs89rOGx5ZzEBI6N7TkmAwYqpjmb4bdMIIj?= =?us-ascii?Q?SOz3bb6HjU0z8LA9z6r7djOa/F4CBQ4oWHPDzwRtbNg78aeqbAUceHlIX9iY?= =?us-ascii?Q?K5Sfp0pudOPb1P+tGKzWoptWJDz9PXk7GiXz1Nes1MJ6Ae4aI1vukXndsq+t?= =?us-ascii?Q?zPA5x8JCt/MskX9Qw5quYsCu6SvrI/qE8hAYoKFORYDKfzJhIgfjZ320S6Bt?= =?us-ascii?Q?Fj54MgxfkE4k/1QH/hIGN0YeUC8bokZxXnttPoyLuf3gMqQeJ93+ie3cZbWa?= =?us-ascii?Q?nZ7yOlsVod4xeWNpimMFN4PZgUxMjXEGKf5CydnuxTvpow1YTVy9QaKzVRYJ?= =?us-ascii?Q?OiDt1p9/2Aqm4z6jsuv+TSzrPoGPIUDmvgWKPanaUdcccWJrUykduXbbHrEK?= =?us-ascii?Q?t1kFA9HBqxXIdDNQhKkfIo96vaSGBgdJsjqZh33SJVWLkuWhG9oG6dnYIAcf?= =?us-ascii?Q?tH9DDMj1wK4vmAlVx1ICtFGUtGG5JxLCZZeH4NWZ5u5mBcsNJkbp3PwBwoy7?= =?us-ascii?Q?4lCtP8Zf3zv7qY4j35q4kpra2NuuZCY9FtGdBfEzhV32qxwH/B3Th13tB2Sc?= =?us-ascii?Q?B+cDRYm6cGL1iA+4PvmHvuc/X0OY9kPvAWyxfXScppGsbCnJqoYnXPtuE+iE?= =?us-ascii?Q?qZOTSpz8mjBS3glh7X5WUZIj1N/1w+NtitOiO6YtCeIgtB/aFTXRDRZZFI8l?= =?us-ascii?Q?bMAstmDW5olCOpBrLpITjtmv6AjNIjErpv4/dun9U1ql7wRS3tyyB9f6qQJX?= =?us-ascii?Q?ihihAYFE/08MkzXYNXSmDIirSMXwpY9bSKpinDcmcQ3MPRM+IR6NpJLzLLsq?= =?us-ascii?Q?oeCN+BVATwTnYmXnvEpRn1np0PYo15HDVMQcpGVO7rlsOf5wbuTrGgIBrk/t?= =?us-ascii?Q?6rb+Im85qIZv56aHtc61hUjjWtd1B6ZOIfCa15PKBvHHorO+4KHw6RDBZdtw?= =?us-ascii?Q?O2w5GLXJ6GtrNCm2+ddfYuIfjGOACP+iTvHh0qGD7ptxv3M7nfKSUP32yLmb?= =?us-ascii?Q?AqBLF4RVVGc8yLzj/gcpf31qWRcXxJM07QQW7DU0fZf+kTTjBnYWATfHKnrP?= =?us-ascii?Q?4TpG6hbTDcWjrn4Uq61lFI2Q?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2045ba17-6472-45b1-9d47-08d90c16bf2b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2021 20:30:08.4561 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wCtVR8rTsuO+q3ZaC4Q2TXRqLIgeNjBso0Eh2XxUENfTX+SXYkN8pbS4K6karES1ZWpTNNouOEeMdsZ8FX0yHw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR05MB8063 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB7582721D060BD78A93D12D5BB95E9SN7PR05MB7582namp_" --_000_SN7PR05MB7582721D060BD78A93D12D5BB95E9SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable LGTM Reviewed-by: Andrei Warkentin ________________________________ From: Jeremy Linton Sent: Thursday, April 8, 2021 12:58 AM To: devel@edk2.groups.io Cc: ard.biesheuvel@arm.com ; leif@nuviainc.com ; pete@akeo.ie ; samer.el-haj-mahmoud@arm.com = ; Andrei Warkentin ; J= eremy Linton Subject: [PATCH 0/3] SD+USB perf/DMA fixes A large part of why the emmc & dwc2 usb controllers haven't been working properly is because the "bus" _DMA was incorrectly tagged as a consumer, when it needs to be a producer. That is why linux has been dropping the translation value portions of _DMA(). Since the emmc2 dma (with the old B0 SoC), and the dwc2 is expected to work, lets add matching 30 bit IORT entries for them. Finally, in the shuffle the high speed cap bit override was dropped from the linux patches, and I failed to add it back to the firmware values, this caused the wifi perf to be lower than it should have been. Jeremy Linton (3): Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode Platform/RaspberryPi/AcpiTables: Add further named components Platform/RaspberryPi/AcpiTables: Correct _DMA consumer Platform/RaspberryPi/AcpiTables/Dsdt.asl | 2 +- Platform/RaspberryPi/AcpiTables/Emmc.asl | 2 +- Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 +++++++++++++++++++++++++++= +++- Platform/RaspberryPi/AcpiTables/Sdhc.asl | 2 +- 4 files changed, 46 insertions(+), 4 deletions(-) -- 2.13.7 --_000_SN7PR05MB7582721D060BD78A93D12D5BB95E9SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
LGTM 

Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Thursday, April 8, 2021 12:58 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: ard.biesheuvel@arm.com <ard.biesheuvel@arm.com>; leif@nuvi= ainc.com <leif@nuviainc.com>; pete@akeo.ie <pete@akeo.ie>; same= r.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@arm.com>; Andrei Warke= ntin <awarkentin@vmware.com>; Jeremy Linton <jeremy.linton@arm.com= >
Subject: [PATCH 0/3] SD+USB perf/DMA fixes
 
A large part of why the emmc & dwc2 usb
controllers haven't been working properly is
because the "bus" _DMA was incorrectly tagged
as a consumer, when it needs to be a producer.

That is why linux has been dropping the
translation value portions of _DMA().

Since the emmc2 dma (with the old B0 SoC), and the
dwc2 is expected to work, lets add matching 30 bit
IORT entries for them.

Finally, in the shuffle the high speed cap bit override
was dropped from the linux patches, and I failed
to add it back to the firmware values, this caused
the wifi perf to be lower than it should have been.

Jeremy Linton (3):
  Platform/RaspberryPi/Acpitables: Enable Arasan hispeed mode
  Platform/RaspberryPi/AcpiTables: Add further named components
  Platform/RaspberryPi/AcpiTables: Correct _DMA consumer

 Platform/RaspberryPi/AcpiTables/Dsdt.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Emmc.asl  |  2 +-
 Platform/RaspberryPi/AcpiTables/Iort.aslc | 44 ++++++++++++++++++++++= ++++++++-
 Platform/RaspberryPi/AcpiTables/Sdhc.asl  |  2 +-
 4 files changed, 46 insertions(+), 4 deletions(-)

--
2.13.7

--_000_SN7PR05MB7582721D060BD78A93D12D5BB95E9SN7PR05MB7582namp_--