From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.43]) by mx.groups.io with SMTP id smtpd.web09.4241.1613542961440121507 for ; Tue, 16 Feb 2021 22:22:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=hHrx7qYf; spf=pass (domain: vmware.com, ip: 40.107.92.43, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OcuFcYrpR3vs3O5g0m7VEwPT5tsgXZLlFbCiOgc0seiyp1E3/TGsYJanP7HAiC5iAomXA+RPQi7fmOzTKfs6mdA1RrXf/P4sCXCz3YpTtfPpfp4s2enSccYPCqBdZdJVUgYnl6AA/jONs3UMjlwpyHs0TDxExQSSaxFQogvmGtwCapVMFl1y8sXP/YkvsIFuHo4TGuLk+GOASxlDvqreYxh0qKP7mhzjM5cia9zYPNeDdYhc6zQoO60EzhFXj/AKre09YNoMrmRD/wTYTPLhQjER6v8mbOujkLlyQY3vZWdKAb2xLwc1OlTs8hiwuBEG5PezLAr3AdWXO07Mj6XttA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5Be33psOd9ssQHyb8F7cLFO054qrLgCRiwbIqPgvro=; b=Ut1Uol8xcjcHE5BKKNZ5WSoC3y1UobjhobGwyLEW7GYMHa6bLmxt87Q7NJ6ZApl9rxQcSeRH/6Arz56vHjRKDCqyloco7XK6p3f/3tdwMvZWXdEZT2WVxMmJLIoYpxpFU+zTLfUCOelp9lQJAr2h+Gc3dWksxsZKbq9BF/7VIgvUpi0ZpqbS01QdJuL09PkpPOfCeH2OYnLWVN0SNCxdQhD5sUYJaFnyGs5WkBPqrrgNOfbgCULBm60rBJjHovYa+K5SuI5YlL8b45Xg9y02GDhfhn+f1JbOgNbOXO8ljDN5sLk58/bKl/AuhBynVs12F18dr6BZ9iYqihqeDpPTSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p5Be33psOd9ssQHyb8F7cLFO054qrLgCRiwbIqPgvro=; b=hHrx7qYfnOa7u/+UlvFsC4t3okzYmhr//kQnaWwW2rdFLkpV3/pMLCEXgrWC+dbm1l+c3T2yZoSaCBaYu1/ge1nvfYqRJTEEdNdmLhFJSPgdIcLnfBPwqfRmLQZvToTXDmUwA+9JBdGDz4sGLJfFhVVTu7wrjUAdTsARgXz9w5Q= Received: from SN7PR05MB7582.namprd05.prod.outlook.com (2603:10b6:806:f7::16) by SN6PR05MB5088.namprd05.prod.outlook.com (2603:10b6:805:e6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.12; Wed, 17 Feb 2021 06:22:39 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb%4]) with mapi id 15.20.3868.027; Wed, 17 Feb 2021 06:22:39 +0000 From: "Andrei Warkentin" To: jlinton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Jeremy Linton Subject: Re: [PATCH v2] Platform/RaspberryPi: Only enable IORT when 3G limit is disabled. Thread-Topic: [PATCH v2] Platform/RaspberryPi: Only enable IORT when 3G limit is disabled. Thread-Index: AQHXBPM/Dj8K4+G4M0ayRT4Rm5ik3Kpb4JrU Date: Wed, 17 Feb 2021 06:22:38 +0000 Message-ID: References: <20210217060744.307354-1-lintonrjeremy@gmail.com> In-Reply-To: <20210217060744.307354-1-lintonrjeremy@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c6a96b68-1d16-4454-3246-08d8d30c6ced x-ms-traffictypediagnostic: SN6PR05MB5088: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3er27O5OBQa6HpJ7Hm9tOPFWSsIOvW6d1GR7LEdGJSZBwYTFfsiEnbs3bh7FjRfaw+UlB/JmU8T3jaXbFYAr8oyxfXaizu2WG4Q7qVT6Bz7qzf5Li6gTF8ksOqTw3ZyxtiFloEvry4rCgDZgxt2KGJ2YLZjKQJw1Rs/xTxLaQ7wlp42tQvI18bgY/QdxpuV3zCzoHml5SpOYa6ApwPDVw9mrKSeuwbgX+qT7o7DYlRcFnSjV9anD6yDFcdUASrCR8fiILeuzBUc/4fzsV230X53kU/FZ8N598/JwIgE2UYJimgmHLIxUB2Xq0hZ7bgHZVhlkqimVx82c1tkndoTemDUV520wQDtzowO2FQqTDKZNx4jhIiRbRVmOPtbPuKeE5cYXsNu760U2cWVqLWyNtkvJz8VRAmOSdk70l0vCU+gxHA3fkP68kNhOOsbwyHyWj2pTos81yS3aM1adNaAZVEgb4e8yE37/hvFm4Yml0KdhvRrb1afLqWhugENlJ1DcH6AXIJmhXXBp1d7UO+3UrfqQQ+DP1LvArXyC9u76Qfw/lb/iiO25I8f0LFkUxJrCRh6dU+BVkOD0Zr1rTyiYXFTw4M0nq6IKU5p40k3Km/I= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(396003)(376002)(39860400002)(136003)(6506007)(54906003)(2906002)(53546011)(186003)(8936002)(19627405001)(66556008)(83380400001)(478600001)(66476007)(66446008)(7696005)(86362001)(76116006)(66946007)(91956017)(166002)(5660300002)(9686003)(110136005)(316002)(4326008)(52536014)(64756008)(45080400002)(8676002)(55016002)(33656002)(966005)(71200400001)(26005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6b+3xwf6bXf8Mr/t6YeDL7mMNO7XxUyPpJh0F047Yrtm03gV4k8dTS4YJDQI?= =?us-ascii?Q?4uib2yx8tjJpOsIictez+Q3yCIKZbNpeltqDo5QeVZeKqdyuSr4IEk26BMcI?= =?us-ascii?Q?90Bzx4h3hvcvpFoJe+ki76gt1uCsA03V5HbOD0NuAf21kbJv8U0FnS+Kdprn?= =?us-ascii?Q?PfAoWcsq8r+n7EYPkbQYp9YVxnZ3IF2r5NIxF9ykIguOKLkcmd7gx4uvTHra?= =?us-ascii?Q?WBkZfVnMj+4jUTZk1KC0OYDpXdju7trhp04mhiMBUycJ4QOtN781oZlXz6KK?= =?us-ascii?Q?hj5kvpKtb8nrMgitabiJWiHM0urYQnvvNnOZrzGpAPVqupLn/BakXsfL8rcL?= =?us-ascii?Q?sZw2WBfAPuK5fJiu3cluqNt7BFXJoSxpv0jCmSKrwcMvMXDEuusuG84IRHga?= =?us-ascii?Q?w2l5LXgqg2o9UQzD7/Q7VL9mSCLt0Tb19QlQ7lPanVQ+KXGjvIfVZrRZ0C/w?= =?us-ascii?Q?Ge5goTnzrkTYhvTAsiZ6fUGwePmEizTsVs3AAE8Bxg2oBkuC3gKsQTfu2BZ7?= =?us-ascii?Q?snh53qVmhzd84MxKtsOLkkV02ZzKMCdZA+mgtVMrRUXipkTRWmPxhOz5HrrM?= =?us-ascii?Q?Ca+sZGfxqQ+ZSyJmeX3XDCu1aHBZPGX+NCGbMRoxFYOL/gWidmDWN05BQzkz?= =?us-ascii?Q?x4TlThUjRmqlZjYm4DnAcY5zTtN4ZX5M4bbl9X8cObzScTt15K/hT4oXQI6N?= =?us-ascii?Q?q6auBVJEpU/qbiVT3sNjk/bPxRHDLgWMsjRHoQa0yTGli78J7WN1SLi2kOvf?= =?us-ascii?Q?a5lkNJWi2Ognem0FH+35Fh+gTydsUcGLK76LGfB3BUZZ+nFdrMZtTzaJ57Qt?= =?us-ascii?Q?dIZW0Niktb3YHxChQ2nMGaIwGdNmPR4q4XmMFdHL8qMx3MkpfSvvrr/4fB47?= =?us-ascii?Q?DCwxoNLnpNVoOVFHXZVlmwNfCwA9TU1LT7nI6KssdLW4BAQIPmSBjirZCTgp?= =?us-ascii?Q?CdKegdLi3kx+C4vj+BT1oPMLyxPPXGIPtKxWsPAQluirbHhGeeuT37eYcVBL?= =?us-ascii?Q?GjSfuZS1STBrVaqOhvvyDD7T6/vGZuGISUUSyqZC7s3TVZuXGnGKMqEjtMdJ?= =?us-ascii?Q?Ja1hjXGu81pFYPaNGC8mFVNtzpSpyLyCq416n+pJ75wFSyS0KRjsz0qzy044?= =?us-ascii?Q?AsYXchEsNHzLPJ55wBswLd2UjLBtSAK2ToeNZ7ZWEmJnG/MoMLELpiiEP1gH?= =?us-ascii?Q?h6ch8Gh0XExcgB8DBTzaRrwlZ3kjDgsKFFehJ4/rHv2GHvkqlqUzgUCO85o9?= =?us-ascii?Q?sufmcCFvhU1iwtfZKN1Otnwv+K8idJiTwxemq9/ybKP4cuZtpoL+uZmVSOS9?= =?us-ascii?Q?XhSgIPq4BlsfX/KygUe5r6wN?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6a96b68-1d16-4454-3246-08d8d30c6ced X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2021 06:22:38.8240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QeW610ceXCyKF7i7liVNcXyaEiKQP3Yvy4H7hIZ3PNm0PUeep51I+FfeWKKazl9rd8IgsR4QGaX0nkvsalMxyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB5088 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB7582C2D71F82686D404C407EB9869SN7PR05MB7582namp_" --_000_SN7PR05MB7582C2D71F82686D404C407EB9869SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: jlinton Sent: Wednesday, February 17, 2021 12:07 AM To: devel@edk2.groups.io Cc: pete@akeo.ie ; Andrei Warkentin ; = samer.el-haj-mahmoud@arm.com ; leif@nuviainc.= com ; ardb+tianocore@kernel.org ; Jeremy Linton Subject: [PATCH v2] Platform/RaspberryPi: Only enable IORT when 3G limit is= disabled. From: Jeremy Linton The 3G limit, and the 2G IORT are intended to solve the same linux problem. They limit PCI DMA operations to the first 3G of RAM. Older linux kernels, as used with RHEL/Centos, trigger an assertion* when a DMA operation starts at a range that doesn't fit within the 2G range specified by the IORT. The simple solution is to only enable the IORT when the 3G flag is disabled and there is more than 3G installed. * https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu= b.com%2Fpftf%2FRPi4%2Fissues%2F123&data=3D04%7C01%7Cawarkentin%40vmware= .com%7C0c1dc1458ac14a84867b08d8d30a613a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%= 7C0%7C1%7C637491388819273969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC= JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3DVlStuFf%2F5= bvIAMarB%2F2djY64J7GDa1zEVMB61%2Fwjgn8%3D&reserved=3D0 Fixes: dac891da5cf3 ("Platform/RaspberryPi/AcpiTables: add a IORT ACPI tabl= e to limit XHCI DMA") Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c index 19ef950f10..578f5ead8f 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c @@ -755,6 +755,12 @@ HandleDynamicNamespace ( DEBUG ((DEBUG_ERROR, "Found namespace table not in table list.\n")); return FALSE; + case SIGNATURE_32 ('I', 'O', 'R', 'T'): + // only enable the IORT on machines with >3G and no limit + // to avoid problems with rhel/centos and other older OSs + if (PcdGet32 (PcdRamLimitTo3GB) || !PcdGet32 (PcdRamMoreThan3GB)) { + return FALSE; + } } return TRUE; -- 2.13.7 --_000_SN7PR05MB7582C2D71F82686D404C407EB9869SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: jlinton <lintonrje= remy@gmail.com>
Sent: Wednesday, February 17, 2021 12:07 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; Andrei Warkentin <awarkent= in@vmware.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@ar= m.com>; leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@kern= el.org <ardb+tianocore@kernel.org>; Jeremy Linton <jeremy.linton@a= rm.com>
Subject: [PATCH v2] Platform/RaspberryPi: Only enable IORT when 3G l= imit is disabled.
 
From: Jeremy Linton <jeremy.linton@arm.com><= br>
The 3G limit, and the 2G IORT are intended to solve
the same linux problem. They limit PCI DMA operations
to the first 3G of RAM. Older linux kernels, as
used with RHEL/Centos, trigger an assertion*
when a DMA operation starts at a range that
doesn't fit within the 2G range specified by the IORT.

The simple solution is to only enable the IORT
when the 3G flag is disabled and there is more
than 3G installed.

* https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.= com%2Fpftf%2FRPi4%2Fissues%2F123&amp;data=3D04%7C01%7Cawarkentin%40vmwa= re.com%7C0c1dc1458ac14a84867b08d8d30a613a%7Cb39138ca3cee4b4aa4d6cd83d9dd62f= 0%7C0%7C1%7C637491388819273969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi= LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=3DVlStu= Ff%2F5bvIAMarB%2F2djY64J7GDa1zEVMB61%2Fwjgn8%3D&amp;reserved=3D0
Fixes: dac891da5cf3 ("Platform/RaspberryPi/AcpiTables: add a IORT ACPI= table to limit XHCI DMA")
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c b/Platform/= RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
index 19ef950f10..578f5ead8f 100644
--- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
+++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
@@ -755,6 +755,12 @@ HandleDynamicNamespace (
     DEBUG ((DEBUG_ERROR, "Found namespace table n= ot in table list.\n"));

 

     return FALSE;

+  case SIGNATURE_32 ('I', 'O', 'R', 'T'):

+    // only enable the IORT on machines with >3G and no = limit

+    // to avoid problems with rhel/centos and other older O= Ss

+    if (PcdGet32 (PcdRamLimitTo3GB) || !PcdGet32 (PcdRamMor= eThan3GB)) {

+      return FALSE;

+    }

   }

 

   return TRUE;

--
2.13.7

--_000_SN7PR05MB7582C2D71F82686D404C407EB9869SN7PR05MB7582namp_--