From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web09.485.1612805194972010257 for ; Mon, 08 Feb 2021 09:26:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@vmware.com header.s=selector2 header.b=TA3ZMLPd; spf=pass (domain: vmware.com, ip: 40.107.236.41, mailfrom: awarkentin@vmware.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UWcR75Dl/2iuKYwpcjjQHumy1KK4ZfOSIGEjDQ35Rvh1akEGmhFOHr/t6ki5d8ER720/wIypFyGnbFqvcCXpz7CE4OrDHVHCgQAcuggWByTes01myqFTk+DqTwySndyig/ftV9hIcrdneQPLh5bXxJVpkmhOsvMqJ72ty+J3ghoepIUIsf6dcsGJ1vPSI02kjvPF9qUCh9QCM5J24xFByTE8SMUDjqIWhr8Dap5pB8Vz3cDnZk9Z8Wuyh5rDEUmrFhxwQAcYQk66/c2CJBpOdbdBn97oG1ucw5fYw3CI0mPB5ccf51eGQXtKH12lHwdl/ssjbiRVCRBhfXQoMhNvrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BU4Rdd3uB0theaZe//e7mebT+gJjXNAYXd2DKBXt6LQ=; b=J6+RMwKCCS+6UNJummAvvFdAq7wSlB5GmaR3+J9LTptUYNbpYWsQqvEgqo6iGhKvaHXN9PG3ZFRnyYRO3L4DN423v2m0y80QhXfiu9ocVG14JmwoMlo17+FIctrbmuO+tP2YVVLD451BN2gMMD0FlMKs/M01oAO4umK79LJlP8O42xgpIL+HDzCSmRcjR5yivC8v3pm0248sLZ7C63JFkVr6pxkld3FaKb9RHA5QHPhtM1FAzBL5n8GHOpqLz+8FSStr+fp/N4Ha9RiANMBXycUh2EfUpMq+YD9XudAfhqzI6mKKjh9Qu4g/A0L7SPaStdCnQwmDvgDalFkU3sX2ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BU4Rdd3uB0theaZe//e7mebT+gJjXNAYXd2DKBXt6LQ=; b=TA3ZMLPd4yiA70hFsQQl63ChS45A31MPVbWNeGT/zbJ/84ACuEFWex4ixa2cx4Le+P9b8ZoaflNbwp/Gm/2AZJT4iheDSK5SlyY8y9amF8kgj5KrjsB23XjrGajzczqMJPmlM8uzGxyHTF5LIzFXj7HBxdyPCOadqpfz+QatQIM= Received: from (2603:10b6:806:f7::16) by SN6PR05MB4352.namprd05.prod.outlook.com (2603:10b6:805:3a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.10; Mon, 8 Feb 2021 17:26:32 +0000 Received: from SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb]) by SN7PR05MB7582.namprd05.prod.outlook.com ([fe80::d1f7:9f0e:9655:eadb%4]) with mapi id 15.20.3846.025; Mon, 8 Feb 2021 17:26:32 +0000 From: "Andrei Warkentin" To: Jeremy Linton , "devel@edk2.groups.io" CC: "pete@akeo.ie" , "samer.el-haj-mahmoud@arm.com" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" Subject: Re: [PATCH v2 4/4] Platform/RaspberryPi: Invert default Arasan, Emmc2 routing Thread-Topic: [PATCH v2 4/4] Platform/RaspberryPi: Invert default Arasan, Emmc2 routing Thread-Index: AQHW+O0cFVQUggjOtUuq/nvdXaV/pqpOjTko Date: Mon, 8 Feb 2021 17:26:32 +0000 Message-ID: References: <20210201225343.2001835-1-jeremy.linton@arm.com>,<20210201225343.2001835-5-jeremy.linton@arm.com> In-Reply-To: <20210201225343.2001835-5-jeremy.linton@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=vmware.com; x-originating-ip: [69.174.145.79] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac7e7c5b-e53f-42c0-bb50-08d8cc56addf x-ms-traffictypediagnostic: SN6PR05MB4352: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vDubDsTEgaB5eptmXJyGoe+VxvVOwAedAz2r0bOihumHo40R8AnkjcG+7r75V0DY+HsFpmgN/bGR1C5HmTSdmi4Q+zStlssXpAF/mn6bLKHbggqH8D7+WhVZGgyjSgWfZXXXgqFq6ORTj7qLtCHEOeGNta3jAKoADxBcvAYOv9MjINln+I7rOoAltdzcMT5Ji2CGT1uLdkOIFXsRU5+Yb/s+cUgVuTlqrcAMkpt2xR7Z3ly7DtSP66jRH3BR874WNR9S5EeComVt5aZKJd+zXTMfj0C0d//39n48PhRP/cuPYWU2FhnxLTCKVQtB3mhgUP2mM0+vIq0Q3XPZ2jNkOS4AOmusG0gv8k/+K/SlQZGWSJVpJd7HsRKsjVrVdJxJzE0Vyix91UhtFAD7NTeNc+8nL07npJcD800R+rgaF8guA9oDiwNIlMGax/ZuMQxjaZ26SYgw0Fh7oTynlvJMVcFBZQTC5xBGM8SrS/7GzNboY4Hh12rc3arTu7kfv4iGjAtm1Q9NxsBIIS6Tm+KoVg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR05MB7582.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(376002)(346002)(396003)(366004)(39860400002)(2906002)(19627235002)(71200400001)(66476007)(54906003)(6506007)(316002)(83380400001)(186003)(53546011)(478600001)(8936002)(8676002)(5660300002)(26005)(4326008)(52536014)(86362001)(7696005)(9686003)(76116006)(66946007)(110136005)(55016002)(33656002)(66446008)(19627405001)(64756008)(66556008);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XKpVg0odK2qeoJOLt7xbrDkQkoo9IbANgJNFrwGhX82m/6XzW4bXZNbk4QJl?= =?us-ascii?Q?DmTSAeLaEtPk9msuU9CInF3YfknNgl3yj6hkXUJOXTBIBD6UsTXjbvyarr79?= =?us-ascii?Q?1r4EnpMbIWjDgP5PjrDdnkZuUJi06wlEdC2LiEza/NLz4XhfMNRDhWWOygav?= =?us-ascii?Q?Vwpn61ZfFQ36bjxr8Kuh82G6f7iYCmNwLlZRXIUe1VwWrCWRTKipWJCdCKr2?= =?us-ascii?Q?wQn274rN5hFINg5qW5MSdfE/qaGviJwDsPyPAyZe8QRTRUNkW1oRqwCQA3iJ?= =?us-ascii?Q?aIlIIhc5D5jivXP3745vEsrrV2bJdeeW0Xff7lfKQH6Q+XJtkSxIzBWSmpzs?= =?us-ascii?Q?uL2sXAqzUWg1gbmyJhssimllARnBtuRdBxSyyQRP/pWsiWwNMXeAX/OF7+mI?= =?us-ascii?Q?1UPqSiBsUhajEUTAwHXXUPKd4W+i37INA5v7BITsfxy1E3rCq85A01oVOjCq?= =?us-ascii?Q?rrVkKtk0TUBjb0/ZQkVY+Mh47q8Cpo2IxQAk6u2hJqGJ9YNy8Z/PMGWBw+zf?= =?us-ascii?Q?xOj90TMvqhVAYUItnUcp6HC+/5tQMh1kyEqFsXJOAZETgjHr0Lue2RmSZjBJ?= =?us-ascii?Q?42RFaJWb8tNcKEEGeCGqQmzwKo+reQvHh2PCd3kUY52pVaJZ18CC8ISTqVXZ?= =?us-ascii?Q?nPbsdrqF3Zbzqu49nqH5x7tKi/rUBVh22AnpQ6cZWPAOdiitxxquugugWNev?= =?us-ascii?Q?Fhf08RBTn3O0RYHseAv9sdtX4PbD7AqUqnfvb/HtLWky8rmOXVxY09Qnf+3d?= =?us-ascii?Q?oMaJTvLmVAk31ehaEqpfcmr39R+zgoUefyuDFJpW+4sWn7inm2V2vHy4GjDq?= =?us-ascii?Q?tUXbO7nBAjgmn+Wimz6DXLjHhl11GbeC93leQekT/Gq323eb/olh5NfyxyCW?= =?us-ascii?Q?rVNUm07Bmap+tVjknnD0JcH0b3zN2BD0KsQgxZSuCNUoTD/5HJ/IELN5C4hz?= =?us-ascii?Q?YVitgFuBasa42MfcIIi6pQ7d7BLGrIoxOu9hte9kyI7RNiobWrZzdcppJiBu?= =?us-ascii?Q?FlzvyK6oDbMgZnO83SzZmxs74A6LHden2DwpWuc5n6xxJPO69giYbbZU2J3T?= =?us-ascii?Q?in4RGSNjHmJ2kAOjf821/kp4h1tVvC6PoBp3EhJfHrGnaB1t/UIP4/r3UVuR?= =?us-ascii?Q?l/Z3GXs2K2y+XUnUZz68EGLiydHjyQ8Aw0bwbOHd7wUwDDOGjwlHw/Pp33Hb?= =?us-ascii?Q?acpouesBgyl74xxeSbqJeD0El5+gI5jnmcEyKy+GDzCmlokbFxtcubsIY3Ck?= =?us-ascii?Q?6Igxqr5Mi3yhcoXoP9htUU/iJqhn278CzBbI1NEcvsQac/brGu4mOiQ3toJI?= =?us-ascii?Q?ldI=3D?= x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR05MB7582.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac7e7c5b-e53f-42c0-bb50-08d8cc56addf X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2021 17:26:32.7666 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lz1OWT8VFTHtiKcTimnAToFte1WNT64RRRji/isqiigr/c6Iinjds4WvIqKU91pacnm3weSfYyBNIlpOsyJlrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR05MB4352 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_SN7PR05MB7582F015B9FBDD246EB5D98AB98F9SN7PR05MB7582namp_" --_000_SN7PR05MB7582F015B9FBDD246EB5D98AB98F9SN7PR05MB7582namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Andrei Warkentin ________________________________ From: Jeremy Linton Sent: Monday, February 1, 2021 4:53 PM To: devel@edk2.groups.io Cc: pete@akeo.ie ; Andrei Warkentin ; = samer.el-haj-mahmoud@arm.com ; leif@nuviainc.= com ; ardb+tianocore@kernel.org ; Jeremy Linton Subject: [PATCH v2 4/4] Platform/RaspberryPi: Invert default Arasan, Emmc2 = routing In order for the wifi to work, and the SD to run at full speed we need to bind the sd slot to the eMMC2 controller. Since we now have a driver for the eMMC2 controller there isn't any reason to leave the SD card bound to the older Arasan controller. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- Platform/RaspberryPi/RPi4/Readme.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 9962df0076..e0fad6f744 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -475,7 +475,7 @@ # SD-related. # - gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gConfigDxeFormSet= Guid|0x0|1 + gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gConfigDxeFormSet= Guid|0x0|0 gRaspberryPiTokenSpaceGuid.PcdMmcForce1Bit|L"MmcForce1Bit"|gConfigDxeFor= mSetGuid|0x0|0 gRaspberryPiTokenSpaceGuid.PcdMmcForceDefaultSpeed|L"MmcForceDefaultSpee= d"|gConfigDxeFormSetGuid|0x0|0 gRaspberryPiTokenSpaceGuid.PcdMmcSdDefaultSpeedMHz|L"MmcSdDefaultSpeedMH= z"|gConfigDxeFormSetGuid|0x0|25 diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi= 4/Readme.md index 3b2ed44e3c..80899f4ca4 100644 --- a/Platform/RaspberryPi/RPi4/Readme.md +++ b/Platform/RaspberryPi/RPi4/Readme.md @@ -181,7 +181,7 @@ Limit RAM to 3 GB | `RamLimitTo3GB` | Disabl= e =3D `0x00000000`
Ena System Table Selection | `SystemTableMode`| ACPI =3D `0x00000000` (d= efault)
ACPI + Devicetree =3D `0x00000001`
Devicetree =3D `0x00000= 002` Asset Tag | `AssetTag` | String, 32 characters or less = (e.g. `L"ABCD123"`)
(default `L""`) **SD/MMC Configuration** | -uSD/eMMC Routing | `SdIsArasan` | Arasan SDHC =3D `0x00000001`= (default)
eMMC2 SDHCI =3D `0x00000000` +uSD/eMMC Routing | `SdIsArasan` | Arasan SDHC =3D `0x00000001`=
eMMC2 SDHCI =3D `0x00000000` (default) Multi-Block Support | `MmcDisableMulti` | Multi-block transfers = =3D `0x00000000` (default)
Single block transfers =3D `0x00000001` uSD Max Bus Width | `MmcForce1Bit` | 4-bit Mode =3D `0x00000000= ` (default)
1-bit Mode =3D `0x00000001` uSD Force Default Speed | `MmcForceDefaultSpeed` | Allow High Speed = =3D `0x00000000` (default)
Force Default Speed =3D `0x00000001` -- 2.13.7 --_000_SN7PR05MB7582F015B9FBDD246EB5D98AB98F9SN7PR05MB7582namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Andrei Warkentin <awarkentin@vmware.com>
From: Jeremy Linton <jer= emy.linton@arm.com>
Sent: Monday, February 1, 2021 4:53 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: pete@akeo.ie <pete@akeo.ie>; Andrei Warkentin <awarkent= in@vmware.com>; samer.el-haj-mahmoud@arm.com <samer.el-haj-mahmoud@ar= m.com>; leif@nuviainc.com <leif@nuviainc.com>; ardb+tianocore@kern= el.org <ardb+tianocore@kernel.org>; Jeremy Linton <jeremy.linton@a= rm.com>
Subject: [PATCH v2 4/4] Platform/RaspberryPi: Invert default Arasan,= Emmc2 routing
 
In order for the wifi to work, and the SD to run a= t full
speed we need to bind the sd slot to the eMMC2 controller.

Since we now have a driver for the eMMC2 controller
there isn't any reason to leave the SD card bound
to the older Arasan controller.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
---
 Platform/RaspberryPi/RPi4/RPi4.dsc  | 2 +-
 Platform/RaspberryPi/RPi4/Readme.md | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc
index 9962df0076..e0fad6f744 100644
--- a/Platform/RaspberryPi/RPi4/RPi4.dsc
+++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
@@ -475,7 +475,7 @@
   # SD-related.

   #

 

-  gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gC= onfigDxeFormSetGuid|0x0|1

+  gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gC= onfigDxeFormSetGuid|0x0|0

   gRaspberryPiTokenSpaceGuid.PcdMmcForce1Bit|L"MmcForce1Bit= "|gConfigDxeFormSetGuid|0x0|0

   gRaspberryPiTokenSpaceGuid.PcdMmcForceDefaultSpeed|L"MmcF= orceDefaultSpeed"|gConfigDxeFormSetGuid|0x0|0

   gRaspberryPiTokenSpaceGuid.PcdMmcSdDefaultSpeedMHz|L"MmcS= dDefaultSpeedMHz"|gConfigDxeFormSetGuid|0x0|25

diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi= 4/Readme.md
index 3b2ed44e3c..80899f4ca4 100644
--- a/Platform/RaspberryPi/RPi4/Readme.md
+++ b/Platform/RaspberryPi/RPi4/Readme.md
@@ -181,7 +181,7 @@ Limit RAM to 3 GB      &n= bsp;     | `RamLimitTo3GB` | Disable =3D `0x00000000` &= lt;br> Ena
 System Table Selection       | `SystemT= ableMode`| ACPI =3D `0x00000000` (default)<br> ACPI + Devicetree =3D = `0x00000001` <br> Devicetree =3D `0x00000002`

 Asset Tag          =           | `AssetTag` | Strin= g, 32 characters or less (e.g. `L"ABCD123"`)<br> (default `= L""`)

 **SD/MMC Configuration**     |

-uSD/eMMC Routing         &nbs= p;   | `SdIsArasan` | Arasan SDHC =3D `0x00000001` (default) <= br> eMMC2 SDHCI =3D `0x00000000`

+uSD/eMMC Routing         &nbs= p;   | `SdIsArasan` | Arasan SDHC =3D `0x00000001` <br> eMM= C2 SDHCI =3D `0x00000000` (default)

 Multi-Block Support        &n= bsp; | `MmcDisableMulti` | Multi-block transfers =3D `0x00000000` (default)= <br> Single block transfers =3D `0x00000001`

 uSD Max Bus Width        &nbs= p;   | `MmcForce1Bit` | 4-bit Mode =3D `0x00000000`  (defaul= t)<br> 1-bit Mode =3D `0x00000001`

 uSD Force Default Speed      | `MmcForceDefa= ultSpeed` | Allow High Speed =3D `0x00000000` (default)<br> Force Def= ault Speed =3D `0x00000001`

--
2.13.7

--_000_SN7PR05MB7582F015B9FBDD246EB5D98AB98F9SN7PR05MB7582namp_--