From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 51C25941D6C for ; Tue, 21 May 2024 21:11:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KALb16Zy1F8KBP1PjXKX8xVPHdkRl8YYp5Zjx+0Wuw8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1716325914; v=1; b=ohkixo94nscKa6l2x+77NlxkKvlllOO20NlbWL8GBtZjgm/smx+kDOijsNfzseCCDYFoyUOi kkdMBVpCD/gfrI5IRAqMfutI1Fi3ujHHJ3r6T0IuPBeYmDz6twXvLIHBrQvmk2UdenFP+o9tJVl VdUgfxVylRWOmN8MY26omqThW7bLoxl6OarzWucc/qgHp0e/CT7LZIZ6kLWNDzyM/SNTzuC3Xzc 6m9up/wOYKKhNRhuZGmgEOKkKUV7POaQlnc2g4HQUbwutUrQRqxlUYl1ssZVJ5iCx9bmFpzKt+4 aj0M1gC+c6IIFV+vt/B7DrDeNRFqyklOJWuzcUsxsq2Ew== X-Received: by 127.0.0.2 with SMTP id 2mNkYY7687511xUAvYjRBQlu; Tue, 21 May 2024 14:11:54 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by mx.groups.io with SMTP id smtpd.web11.35.1716325913600501229 for ; Tue, 21 May 2024 14:11:53 -0700 X-CSE-ConnectionGUID: v3CiJE0YRQ6moAwfYV1CYg== X-CSE-MsgGUID: RN1k3JVnRF6bKU27tKO3cQ== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="12336440" X-IronPort-AV: E=Sophos;i="6.08,178,1712646000"; d="scan'208";a="12336440" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2024 14:11:53 -0700 X-CSE-ConnectionGUID: nebYPTBOTw6P4hHKGJCIVg== X-CSE-MsgGUID: bizLyyFaRumGOeczGhL9Bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,178,1712646000"; d="scan'208";a="33038425" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 May 2024 14:11:50 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 May 2024 14:11:49 -0700 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 21 May 2024 14:11:49 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 21 May 2024 14:11:49 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 21 May 2024 14:11:48 -0700 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) by PH0PR11MB4854.namprd11.prod.outlook.com (2603:10b6:510:35::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Tue, 21 May 2024 21:11:46 +0000 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85]) by SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85%5]) with mapi id 15.20.7587.030; Tue, 21 May 2024 21:11:46 +0000 From: "Saloni Kasbekar" To: "devel@edk2.groups.io" , "santhoshkumarv@ami.com" CC: Sivaraman Nainar , Raj V Akilan , "Clark-williams, Zachary" Subject: Re: [edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Topic: [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Index: AQHaq4kcBxAuVZ3FGEaED9FKJAxwb7GiLbUw Date: Tue, 21 May 2024 21:11:46 +0000 Message-ID: References: <20240521141349.1213-1-santhoshkumarv@ami.com> In-Reply-To: <20240521141349.1213-1-santhoshkumarv@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB8281:EE_|PH0PR11MB4854:EE_ x-ms-office365-filtering-correlation-id: 8d61b2cf-a44d-4e01-3d70-08dc79da9f96 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?3BwaQzizn6Fwu5ilO0S+qeoXH4tU6+tc0ENLUdpLNaFpqg3r9LjO/rqcSMCh?= =?us-ascii?Q?gKsGuQJuCG9K264EdW0WNCkOWq7cJQIG0zO5eK3xs8YB+pK+fIHeWeoZX3HN?= =?us-ascii?Q?e0zUe8AStvBjaKZeSk0QlduuN8Q7ZGjgDcfiY8RF7pINXE1z4cGTXsMKuoxU?= =?us-ascii?Q?12irP48zYNM7AszgfVY1wLvDgJzDtlUR/SKc16MYuLLb5JiWAJjGcW9d1Spq?= =?us-ascii?Q?pKmlJ9Ekk/7Uow5sd65Kva56H9K7JoNFao5o4bsI+kFuNpM40o86lTOs+Ia6?= =?us-ascii?Q?OAqUZHgmNTmepfIeEbgHeuH4PMkyFxAqCI0iHDrm74/oLK4OB3lWJP2pByaJ?= =?us-ascii?Q?TqMP+kkupIXD+GCN9LsXloNhO0Yr+gOLBH0C3+nd1QKBEM2SbNGmnE68pviz?= =?us-ascii?Q?BdNYYZOZakEJMZLWirE3YO66hNL4979PED3wTvCIhGlcVlD1HpZfdeLfeG9W?= =?us-ascii?Q?uxHjxuq7qi0iW3ZZmr36m3KZGpnRFw6fOR6VBOR8hq9o8Kdo5qPOj/4BHYbu?= =?us-ascii?Q?2/lfFeehELCqgOGsws/dbXyK/jSfn0f0D0g+cfg8/xOyFDeZKo6jdBFf8fsK?= =?us-ascii?Q?JsiEEhTSwAD9eR7dUK03opxxPoqxnxsIQbn7dqPRl51JBbtP2vIE84yJEofm?= =?us-ascii?Q?uD3fcbzxNlZ5mgLHuwAOt59UAbphj7ukQiYnWnlWOLnXGGNnNxfJaVH40o/h?= =?us-ascii?Q?tRnuOEah+2c7e4wgMK7qA4ZWv4zG7+6zgen12SaQgZ5ZIeUrLay72k4JBfy3?= =?us-ascii?Q?q70FPeQJteBlHr9pwCHIB1yvbi9l0o4kFXjcpkH9+iS/yUcLS1JnCWJz7OPr?= =?us-ascii?Q?v68v2wXgNyFpZBjpfTeGOLvnCv1gUvr7mtEviyCuLjimv57R4O6vYo5MUmMD?= =?us-ascii?Q?N0M+uCTpypmUOwxuogk99yNkNdb/e1xS/QOJl9qOKhF+4HomOgf1GRDwF6UT?= =?us-ascii?Q?JAyZl4W8PtKOQyhPVPYyVmg5UMWIxv4TiQyR+K+74aNoZSn5EEKXRt+k/BMm?= =?us-ascii?Q?dxpTx1794FqV/Ud58xtPW+PZbJmdc61kV2a1fv3hhsl6iFcSkeba4UVlZ/cP?= =?us-ascii?Q?1lRLLomj0BHXnRqhEUstPHv+8YBJ5qhZN23vfV+5vBayj5blmYU9b4KoqsUn?= =?us-ascii?Q?jsD99O9WyHvtY2U8fVmmEOBQicdUn/fXk4t4h23FXU/FLnKFdNKn2i8NC/q3?= =?us-ascii?Q?22h/OLiVFtPnIbpkfzR6RYr936AdQgSS0GvkyUaIiX1HhBILOY56Ddnu9KTk?= =?us-ascii?Q?VKGcO4RkjDaaOWfzKrp1hUmWPEMfqB3KZxuzlw1vb1RE6HiDDwrDpoEjfvJF?= =?us-ascii?Q?31I=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ST273kN4gTO2+SR4zFI3+D8940byCFc5kxouB10ejKc6V/sO5t2ybEfpim+f?= =?us-ascii?Q?qzIGtQufZwlq1pOahIJgVulZXSlyoSQ02N9+RzEBTUbi2Npk0o2ufHg2pg0S?= =?us-ascii?Q?YQ5nRm3xNCPdCUBgstnc/1YjlFqsmRsmtpezk6Ffo8x2RdxltBNc2DKXW8Kt?= =?us-ascii?Q?4WreD/tTNUoc1QIC2b+Ku5pPg8l68WKgqtXowD0o35FfvJyEGhQAL7jazDE1?= =?us-ascii?Q?4rQKYUTOKO/MjfNKaAxkJt8Gv8Rxb2sEUwxMBXQ0adia8WKf9+jPmio4RUXQ?= =?us-ascii?Q?N9BpAHXFrLXl1PA9ptrr2+/IDWnVWIVy9cU1ahI+hMqMxbKUua4DIof1lMXg?= =?us-ascii?Q?mDLNRsCJdsgjIsRunbjcOqpPmxPM0P1clxo21vZj3UOvbvJTLxXa5FQEdnFn?= =?us-ascii?Q?xCaaztnSuBh0dxN2zUs6ex1v33fzumhHLtjBgawq/YzVddhax5n1F4aHXzbc?= =?us-ascii?Q?ewpBD1IYjXr6Ig8/5LQe0czBIsBz81EXJYXkyz4WHTd75DfZVaicUfPI/S5l?= =?us-ascii?Q?sqmqK5mi8tDvKg26JuBVKczszLP1bmQHrf+U0Gbe5cAW2X5Fdm4MRgyOmaEt?= =?us-ascii?Q?JEgCJiCum9SeOX74tnJwEXpCi1k3H4CZ0ZcmOpicXiRv9eVRG3XbhkVrbMXI?= =?us-ascii?Q?cx2EbXoc8AUHqeHp+Fjxrr1YaH+YeijYAHeQyGeFyP7QKAacoBXFJxEJbe/z?= =?us-ascii?Q?p2StJpggTdUcvhv8S3lehVey3GUVF2PJEvKiVN+yRbSY0CE0JRfWJ7fVq2kw?= =?us-ascii?Q?8wPPY/NDWupxam0nA+mkr04skheTx6Hz8m1wtOJ5p3MFvcsIVJuCbxQxf947?= =?us-ascii?Q?/6kRZgdgAix4cw8mq7PWTSPA+b4cW9PnIzwLOR/3otw85WtoTdUnLo9RCM2Y?= =?us-ascii?Q?wARnomb4Pjv2FolYNZlSHUpHq44uHuWFMLlshs/pLftZ8mHes/8MbiGtTOEA?= =?us-ascii?Q?ZAqUwWBbQ1qpVvc0dn/L95bCvF/vfiQx2OlrNiIkcDE39j3zgxS5zsDRviou?= =?us-ascii?Q?knHGUKeCpYoNPJEEJZqgMMYzC+F9lSM5T7smXg99ZUCdYtFSiJoAC2gqyjL9?= =?us-ascii?Q?jCq/FRb4zHtaPVJEZF3Hre0CJHsNDi1FAkuh4IkHcsnwWt3ywWTnCGootqVz?= =?us-ascii?Q?uQWhQUmOK8UsplqlFYDQ3KtQZSIHxlfiYTIoTZV9zpmi6HBwoYM2PJyBokX3?= =?us-ascii?Q?Y380KvEgWiw3xKRqWrx5g9YCwOz6nDhkxMR1vXrP3sqkibEEKYLPkdsUu7w2?= =?us-ascii?Q?dMtbofjKvkLuSrOUrfq0dvLhQ4zcFVvbIdEx4PzXhoYxsQeP4YT16UflIwGo?= =?us-ascii?Q?gAe0IFUnp11xlsS7efsP90/v/LSTe+wn4302uueFP4/0TVztADWF7EpaxEUa?= =?us-ascii?Q?xrm2QZG+nRD/Wunm29ZeW33VFoWgZqA8FWDXRO328eM3TLXkYzqYyJMJoXNh?= =?us-ascii?Q?1xMMqD6iIug7C46/JWYLqRNgWtbflpA+yICmvTHHC1bVRXdJ5qYMCA35g/Yq?= =?us-ascii?Q?ycGYW5Dh9on5z2wKvEYpbjMgPkeXwnzBcOk4liw3XfZEMgwF3jj+NhC6Y9qv?= =?us-ascii?Q?3Vozd355cwDu91JipyeddOYysgnSaO65ZkjbDA5C?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB8281.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d61b2cf-a44d-4e01-3d70-08dc79da9f96 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 May 2024 21:11:46.6927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ad2NtK5UlLawz3N5HmMBlEL9erVuGJPWWfeFvY1JKBN1ZJMqMr2lidSH8lE704lWgHjQfJr1XZejPXakEoVjFsF4upQ93LV0Eh5RF7Ak+zU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4854 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 21 May 2024 14:11:53 -0700 Resent-From: saloni.kasbekar@intel.com Reply-To: devel@edk2.groups.io,saloni.kasbekar@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PEb6S2DZPATCSpSTsMChPOa2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ohkixo94; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Could you please update the commit message for the patch below? Also, all y= our patches seem to result in an error after applying them. Could you help = resend them with the fix? warning: quoted CRLF detected error: corrupt patch at line 19 Thanks, Saloni -----Original Message----- From: devel@edk2.groups.io On Behalf Of Santhosh Kum= ar V via groups.io Sent: Tuesday, May 21, 2024 7:14 AM To: devel@edk2.groups.io; Santhosh Kumar V Cc: Sivaraman Nainar ; Raj V Akilan ; Ka= sbekar, Saloni ; Clark-williams, Zachary Subject: [edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues Both the cases have ASSERTs checking that the value is greater than 0. Move= the checks to the same location as the ASSERT. I'd also prefer if we retur= n with a failure instead of forcing continuation of the function with an in= valid value. Thanks, Saloni Addressed above comments and made changes, please review the latest changes= below and kindly review coverity changes for other modules too. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: SanthoshKumarV --- NetworkPkg/MnpDxe/MnpConfig.c | 3 +++ NetworkPkg/MnpDxe/MnpIo.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/NetworkPkg/MnpDxe/MnpConfig.c b/NetworkPkg/MnpDxe/MnpConfig.c = index 93587d53aa..12fc80ad0c 100644 --- a/NetworkPkg/MnpDxe/MnpConfig.c +++ b/NetworkPkg/MnpDxe/MnpConfig.c @@ -1304,6 +1304,9 @@ MnpStop ( NET_CHECK_SIGNATURE (MnpServiceData, MNP_SERVICE_DATA_SIGNATURE); MnpDeviceData =3D MnpServiceData->MnpDeviceData; ASSERT (MnpDeviceData->ConfiguredChildrenNumber > 0); + + if (MnpDeviceData->ConfiguredChildrenNumber <=3D 0) + return EFI_OUT_OF_RESOURCES; // // Configure the receive filters. diff --git a/NetworkPkg/MnpDxe/MnpIo.c b/NetworkPkg/MnpDxe/MnpIo.c index 08= 7c879c46..24dfad10fa 100644 --- a/NetworkPkg/MnpDxe/MnpIo.c +++ b/NetworkPkg/MnpDxe/MnpIo.c @@ -326,6 +326,9 @@ MnpInstanceDeliverPacket ( ASSERT (Instance->RcvdPacketQueueSize !=3D 0); + if (Instance->RcvdPacketQueueSize =3D=3D 0) + return EFI_OUT_OF_RESOURCES; + RxDataWrap =3D NET_LIST_HEAD (&Instance->RcvdPacketQueue, MNP_RXDATA_WRA= P, WrapEntry); if (RxDataWrap->Nbuf->RefCnt > 2) { // -- 2.42.0.windows.2 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119107): https://edk2.groups.io/g/devel/message/119107 Mute This Topic: https://groups.io/mt/106223813/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-