From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5E285AC1711 for ; Fri, 17 May 2024 20:56:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CEs57cVB/pRXQnMBz6SnJtKhx5pLCTw3axVGMUPqI4Q=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1715979403; v=1; b=rvYevk/9KPVCXrqGnrb4fNSglsrRJ8QCEvC4yKIqPIdrpAL0tnNqTJX+z3U8Sug2pIbwAAqm YKVqLjick4ZrmtNWM71BX3N1F2awfMVCJI47y46xtLJtgB4mcaGWxCA1mDAEiyXfrDt4du9lZxj Jim3Noo5fMAzp/gvQldC9TAFKuHESg8OS2RyYKwlcZRoAAFveH4e6nE7B/T2FJjUR2XqU2DrMYP LUFj9FDYlHxZmtMolo75PABvpRJEQwQS6E2uTNAa+ZBIARu1xZwV02Pk2eJvD22MUvAdyk7lC2H C4V2LnYlEWae/1IOUqnTnzxb7XKBmUhZsJkocbsLatH8A== X-Received: by 127.0.0.2 with SMTP id 72iUYY7687511x3CRW8OEEFx; Fri, 17 May 2024 13:56:43 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web11.6463.1715979398151298299 for ; Fri, 17 May 2024 13:56:38 -0700 X-CSE-ConnectionGUID: gVq2dOJqRPyyM9inkP9ZYQ== X-CSE-MsgGUID: bYDO+/M4R3eTw6sAYSw13A== X-IronPort-AV: E=McAfee;i="6600,9927,11075"; a="29688581" X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="29688581" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 13:56:38 -0700 X-CSE-ConnectionGUID: /f7DDnUcRtStxOavgfqVUw== X-CSE-MsgGUID: MWTHeZFiScWfvR3plCW3WA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,168,1712646000"; d="scan'208";a="31923730" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 May 2024 13:56:37 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 17 May 2024 13:56:37 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 17 May 2024 13:56:36 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 17 May 2024 13:56:36 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 17 May 2024 13:56:36 -0700 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) by SA0PR11MB4767.namprd11.prod.outlook.com (2603:10b6:806:97::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Fri, 17 May 2024 20:56:34 +0000 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85]) by SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e4c6:587d:ede3:2f85%5]) with mapi id 15.20.7544.052; Fri, 17 May 2024 20:56:34 +0000 From: "Saloni Kasbekar" To: Santhosh Kumar V , "devel@edk2.groups.io" CC: Sivaraman Nainar , Raj V Akilan , "Clark-williams, Zachary" Subject: Re: [edk2-devel] [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Topic: [PATCH] NetworkPkg:MnpDxe:CoverityIssues Thread-Index: AQHaosF6dF9KeaYLLE2LvRKopCER37Gb8lFw Date: Fri, 17 May 2024 20:56:34 +0000 Message-ID: References: <20240510100440.1351-1-santhoshkumarv@ami.com> In-Reply-To: <20240510100440.1351-1-santhoshkumarv@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB8281:EE_|SA0PR11MB4767:EE_ x-ms-office365-filtering-correlation-id: 8c95e3d2-f890-45fe-bce5-08dc76b3d604 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?7QDUJmwWLbgjb0vEzGBtO8kPmR26/sdTcC/1R8uB5f1PBkN5BpgF7dk6CEEg?= =?us-ascii?Q?9lRy8usF5Z8bioI6+ob3JJP+E+KSHBwvlHcGXHEJLBEZ1RAApuYwdu4x2xzd?= =?us-ascii?Q?f35ltP+aKPsVeQRxKG0rAVF92s+zQI4m255X91wicVxbVmx9OGnyUsUoh78e?= =?us-ascii?Q?+uzUMu6UXO9x7uZxQWL9CNhqu3hkBxiItIxfF44HzdOPumJALWh77LjNrQQb?= =?us-ascii?Q?UQyYvQDKNA3J2SiEpwkbdLGRnWdmfjUXiOFfHLn+4vFi1U/5rw83zIBzOwUd?= =?us-ascii?Q?rFSwk9RB2pAbFMY4sFNieWSZQtt9cUySNSYUIOTvmHPcp5rifbUrCcu7EW4Q?= =?us-ascii?Q?PEspXPecjENSN7hQleNJsexWUP3q6tkccIlvqwqXoye+FDA1OrWE2SeR5OND?= =?us-ascii?Q?YalqNqhe+n/B1fJiGSaR4BEKn+md7htXnAd5V7Sjbc5L4vLgk1dld3V3EI0r?= =?us-ascii?Q?cpjiG6qhuTG4edI63eoUrMjgFjXt3eO343BDKgaIrwG4aqhi01/iDkiUzSYw?= =?us-ascii?Q?8VU9o4qHSPeaRMfCyaHIRKrWPByxFcIuu/WLWmOAlenkOa4pvBYDBPHE9ap4?= =?us-ascii?Q?qCnrFCsr8p1NkANL8BAWkR40PapbALL6UBWptVR/YfLshpD2HAaL7nWivxc3?= =?us-ascii?Q?mX2N7PprlofzBTSo2VDwrRo9JVaCq8+TH5zDMHN8lqZpQCzfkIn7BF3bs5GP?= =?us-ascii?Q?N8OeQds7kAnehG6Vtl6XxpiVaBfyBFAYy6ZwadBewgTrs2+Vw2Fc3rC11EDl?= =?us-ascii?Q?xIsAVr23irOkkM5y+HDagcVpkTYogysV4D2Rf/Eq0F9w9j8cDcO7wIteKays?= =?us-ascii?Q?sO4Bxl+3qqaU3jn9vqMrlpb3dbHIxUcGBB2FWjGJzbOTygXo6eIVH/ThWJpS?= =?us-ascii?Q?py9LeHamE0rgF/1ke76+IEpnTPh4Nz44+HznNL0bk/RxecM4TQG5fEfIu1vq?= =?us-ascii?Q?C4KAyNgGYxBF7xk5tHclBVbDFd5W+2cgu2zpT8sKsmJksfBHIBp2C1VeZq8D?= =?us-ascii?Q?TnDw1gOIAw3ApN2Co4/hz7YZMCowifSXgZll5JY4c+bnoQN9igBHNEKB/+EL?= =?us-ascii?Q?4OWw3wk5k+cxHYXwuBJw0aR3DKAL8MZ49oJcuId/S45/LKrmJfvnmyvIruQG?= =?us-ascii?Q?5Fz8r1APxjEj8xbMR1qNq5TQ3imJWZj2JGJBrhVMhuxy5nQcYFwRUhCCjBGe?= =?us-ascii?Q?ISXPK3bAWHZ8XTnDLbb5AYvV4YqsjvqcUjhcmyShoAbNlXju7OgYorxwvdp8?= =?us-ascii?Q?W8GKwlYhhPdN+SliuLaIirm4GvE3Q77Vi66jgqDnsQsueKiZclndXaQ34L0S?= =?us-ascii?Q?9pfIb4QYA+dmZ056/YMCUUFzxqgbd/xtN9kimgyf4qM1EQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?s0320V5fmvAmrIfXZOpRGuKf86mtFAB5fSYzui0dKmtbmLpkyjBKfJg4YjHY?= =?us-ascii?Q?9cC4CTMFaFmTwA1J3sGBj4Et9DfOl0Y5HEobSXuh6VtaBwL1MOwisO5r7tn5?= =?us-ascii?Q?Uak8q8cfocj+Uw6tG4q9T/OR2FBFMTJJPd17lrl5e1s1ISY/WDlHSM19MEr5?= =?us-ascii?Q?tzT5mmjDfjWiiD+snAvdpD9hxDwAtNaD5WZtqVvJyNxVvsO/mmZZI9Vi4qZX?= =?us-ascii?Q?shZHaIwNhxGM1atoLSPIuLptk9KTSzH4rfYMa5ZPdI54TjIU/tAlRtzRa1My?= =?us-ascii?Q?1cOFbht0ISXFEdt2H2HrkCFjfxidO+PoHhDt1xML0I6Ps549wHOIrxdykDeN?= =?us-ascii?Q?16T8y9VrK7T2LZhDzU2kcXn/inoPVHLRUYqLB+rtmFk1wRVCxJs7jPr6NtaD?= =?us-ascii?Q?6qaKftQyT+b3yxA57WvnxzCJ2A+zmb/k74ls4VGxiB/cQNDk8/dZMLNSmKX0?= =?us-ascii?Q?eqid/WuNA1JB4HUUEscNALKS4xD18JuDmQFkoO6pgbrMkqBzYlEj2hUjTXKh?= =?us-ascii?Q?RVsGGNolC5glj5QjnDxOK2pU0xjBpS1kmbAG1q38ZJxI2AtTmbt5Rh9PkDBY?= =?us-ascii?Q?XVLvULSC+YOWW6PLSxUjB8ANM+dTSMK8Gu/4Cs5sAc2durGnazftjd6D6yaE?= =?us-ascii?Q?RGBxeOPDY+LMCgxY0O+hE3OmhJ3UCPkLTPy58F9eLauMsVEROmEYrAOeeuXC?= =?us-ascii?Q?NlmBYI0UWZJ5JlWUQW0rKpyV4uPJPTX27t8YmpZqfUp50DV8FnIg9f/SmhOA?= =?us-ascii?Q?hPVbrASs18qho5Y2hiw9vQ5SDsaKxY1mL41XZpXE5w03cLDWRQPDZbaaONUu?= =?us-ascii?Q?L9jIsb54EkohFifIxzpw2vFRoAyDscf5XOtb4FW31z4S+lNTJtlcE8GfpZrW?= =?us-ascii?Q?lI0Um4PH0ackY8+E8RMg9MScR3PvzGO6jraBwm3y8PE7l0X3UdFz1i9ONWii?= =?us-ascii?Q?9RXBOzW5zsiFuu+G99bKPO93H0QtEo9Ke93ytwdiLuUJopOCeM8DJ6ror4Un?= =?us-ascii?Q?aRqAottluX+u4k30TqWz3gSDHoqAfypz/BpNMVcwshok2sVRWfoRhWe2qrMm?= =?us-ascii?Q?2mmwaHrIdLcwvTUpCA0iYYbkUewViedUyzXxjj82s8MWYzWJkJj0atKLz6zZ?= =?us-ascii?Q?vQPMEMXzQ5uXnOTGhaGSDwOgjI0YM9oMU/EaJjiw0AHe9HSrillgYO6nGnXR?= =?us-ascii?Q?PxvdJjHB6dpMmZr1ankDKnkVRnXi+TEw1R7xVqu/NGzwlKCfoIp1R5v7WqHm?= =?us-ascii?Q?+yJV0NNAVwqGsXt4C/WqmgC3Ip0EdOjwetVzRlDDgvB0RuA6ukZo6Z88frqa?= =?us-ascii?Q?3eZ5AmU6wPWe2m7h3ygcK5iB7zsBT2CxdcaCKCLuaDJQs79NGQxw3bzhN89E?= =?us-ascii?Q?lQiuaHba78mi3f2D1qLzXQYHolVU5zSgl80RXT4SodaPiZWG4aO2Mb9wdB38?= =?us-ascii?Q?i+H/H/HULbbDAO9O/ml3RJaoJwBAuicEMkDi95+sAtFkg0Lyi+4Cft7JVglM?= =?us-ascii?Q?+sEIhW2ZWOJo2gWWItaT995W/b63orrvwjptn2CCDf0/JH98/8voZOMdR3x8?= =?us-ascii?Q?Wv0HmxC1QyHkULe4fetwDwiTlNPcl9k6YxUH4qvg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB8281.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c95e3d2-f890-45fe-bce5-08dc76b3d604 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2024 20:56:34.1088 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PXwedZqcErkIXQB4CmuMqXBD58u/YfKAo3Y/5R/krW7+l3qRZRkDqEVi5oXGxxKPwQM4ZvjXyfLVAKWCnUhO0T5SvVbxCr5Py4BzWS1Kb3c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4767 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 17 May 2024 13:56:38 -0700 Resent-From: saloni.kasbekar@intel.com Reply-To: devel@edk2.groups.io,saloni.kasbekar@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: orvM1RBJkgfyVFPCXs2TracJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="rvYevk/9"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Both the cases have ASSERTs checking that the value is greater than 0. Move= the checks to the same location as the ASSERT. I'd also prefer if we retur= n with a failure instead of forcing continuation of the function with an in= valid value. Thanks, Saloni -----Original Message----- From: Santhosh Kumar V =20 Sent: Friday, May 10, 2024 3:05 AM To: devel@edk2.groups.io; Santhosh Kumar V Cc: Sivaraman Nainar ; Raj V Akilan ; Ka= sbekar, Saloni ; Clark-williams, Zachary Subject: [PATCH] NetworkPkg:MnpDxe:CoverityIssues Resolved INTEGER_OVERFLOW Coverity Issues in MNP Dxe 1.MnpStop,MnpInstanceD= eliverPacket Expression "MnpDeviceData->ConfiguredChildrenNumber--" and Instance->RcvdPa= cketQueueSize-- where Both variables are known to be equal to 0, underflow= s the type that receives it. Cc: Saloni Kasbekar Cc: Zachary Clark-williams Signed-off-by: SanthoshKumarV --- NetworkPkg/MnpDxe/MnpConfig.c | 3 ++- NetworkPkg/MnpDxe/MnpIo.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/MnpDxe/MnpConfig.c b/NetworkPkg/MnpDxe/MnpConfig.c = index 93587d53aa..80253e88de 100644 --- a/NetworkPkg/MnpDxe/MnpConfig.c +++ b/NetworkPkg/MnpDxe/MnpConfig.c @@ -1313,7 +1313,8 @@ MnpStop ( // // Decrease the children number. // - MnpDeviceData->ConfiguredChildrenNumber--; + if (MnpDeviceData->ConfiguredChildrenNumber > 0) + MnpDeviceData->ConfiguredChildrenNumber--; if (MnpDeviceData->ConfiguredChildrenNumber > 0) { // diff --git a/NetworkPkg/MnpDxe/MnpIo.c b/NetworkPkg/MnpDxe/MnpIo.c index 08= 7c879c46..492edd9b66 100644 --- a/NetworkPkg/MnpDxe/MnpIo.c +++ b/NetworkPkg/MnpDxe/MnpIo.c @@ -351,7 +351,8 @@ MnpInstanceDeliverPacket ( // All resources are OK, remove the packet from the queue. // NetListRemoveHead (&Instance->RcvdPacketQueue); - Instance->RcvdPacketQueueSize--; + if (Instance->RcvdPacketQueueSize !=3D 0) + Instance->RcvdPacketQueueSize--; RxData =3D &RxDataWrap->RxData; SnpMode =3D MnpDeviceData->Snp->Mode; -- 2.42.0.windows.2 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119057): https://edk2.groups.io/g/devel/message/119057 Mute This Topic: https://groups.io/mt/106018089/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-