From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B0F9F780091 for ; Fri, 22 Mar 2024 22:03:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Qjs4INCKfJyXAygGsBEj38OovzQWZSe2+pldGOxC0NM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1711145017; v=1; b=0pNrwayJqkgWhOpabp3eK05qZxD3tZYNdyh/LMHGg2yJ2Y2X+nUtDgk2kqm7pbGjezFpWZwc HasT3BEiZycbyLmrXmpJjhwBBW+J7/2DQ+winUgF0RNLfjGpuq9Kv3T1QHrJ3HZiR4n5XBFFAty 1wdltb67jUk66KO5vLtUYM1JqRAaIvgy+MAPpVe7+gWy7gYhjHMmliYUWOBs1rOVjRnp60o+XD8 aWIhsigsJmkFo8FBeembGDtROsY3ThzYt5iGseOvErGgrHGfDwsFKsQcngceNVZ6YHv7D+mzY23 48keg/pLca6UCRO0HT2LyTOU3eOlUW16ne8NnHdhgNLkg== X-Received: by 127.0.0.2 with SMTP id rU65YY7687511xRJma1uRjDy; Fri, 22 Mar 2024 15:03:37 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by mx.groups.io with SMTP id smtpd.web10.7948.1711145016218002453 for ; Fri, 22 Mar 2024 15:03:36 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11021"; a="6077545" X-IronPort-AV: E=Sophos;i="6.07,147,1708416000"; d="scan'208";a="6077545" X-Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2024 15:03:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,147,1708416000"; d="scan'208";a="15142141" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Mar 2024 15:03:29 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Mar 2024 15:03:28 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 22 Mar 2024 15:03:28 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 22 Mar 2024 15:03:28 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 22 Mar 2024 15:03:27 -0700 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) by DS0PR11MB7998.namprd11.prod.outlook.com (2603:10b6:8:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Fri, 22 Mar 2024 22:03:25 +0000 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e9fe:4a17:7d16:492f]) by SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e9fe:4a17:7d16:492f%6]) with mapi id 15.20.7386.015; Fri, 22 Mar 2024 22:03:25 +0000 From: "Saloni Kasbekar" To: Sivaraman Nainar , "devel@edk2.groups.io" , Laszlo Ersek , Santhosh Kumar V , "Clark-williams, Zachary" CC: Raj V Akilan , Soundharia R Subject: Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue Thread-Topic: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutive Pxe-Http Boot Issue Thread-Index: AQHaZOmcTV48E41v9E6Ol22UcMz6DLEVdjGAgAAlbkCABtgbEIAipIrAgAVnJQA= Date: Fri, 22 Mar 2024 22:03:25 +0000 Message-ID: References: <20240221171347.1343-1-santhoshkumarv@ami.com> <21b2d17d-5de5-5f08-ef6b-a0a285b05917@redhat.com> <17B60D00FAC661AD.27859@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB8281:EE_|DS0PR11MB7998:EE_ x-ms-office365-filtering-correlation-id: ab326b89-04e2-4d56-8ef9-08dc4abbe5cf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: MvfxdywrgDH5yCjFTqwg5s1+bw1iDU2bONf486ki4DLquxlo2EvMJXB60A3EvD9pn8jQuWRcTN1Rsxq+rjVbkzdCvLOPHRIQyStalahgMds9+EqZohs/GtuMRKZ5BdSlziGBIBo1+994jyEUyAzPZqVhPfD5iOJrmYUlkTs5UXu4IxCwYA/qKf+UOTO7vrOaEZCrsXWtRy5aFrp4q2WPwz+AZyAXQFC+hJ2c+TeVZkp6OAlZ6eYDaS7WK6P13mpS2RmLgq2xGoU4qFRd3Djv1x/VA7pI0zc9lU9jDHEZXiPPr5kaJS75yxBIEakpJYPEctIrafkLumWyNne2HeK1rNLc8DwuoLF+qTy8aKetPLhFhizEMndbMCKu5IxMHdCUuB5Lh18XbGSqo49q9L0qFrNdyDuLnQeLGUVwp5jDCGJ2FdxuSAP83RLKSbEG1ENnGXqUFuxAW87t2vUwwavTHxZelRIGagv8+imRd7gWDsIYi7m5vmYtooLMm2c5cx7YvOtbtqPyx95J/ldKgnh2jHriMm42cCvtbR65BzF815n4sQxfgV9n0eRSb4GMwgsoOcIEgLBEyVMqYZHE/OGltKZ1dZXC9ceaKWtaxLkUPE9xOrgXugSZqf4PWie4wPT9zz3ZMV+qcwUNouqf87d3I7sto3qs5esPIhKiBnsISUxfcNH3XPn/ZN6wki4bI8wb x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aFJL0Zh16I0Qy8RtZy9WeiREceoMeiHqDejAgqqUBFYOCh9HZkVfyScf4Swh?= =?us-ascii?Q?+AWWo8lJsrhDSUeeMVe2q1mLwF6RSaliuru4xJmhMtkhYqjaNa9n+avXRM/U?= =?us-ascii?Q?4lE9QhX8XVHup2wBhYEjTU5PPI5CHc/5sy2ZFSfoUIPkNSxdsaFixiaNCm9v?= =?us-ascii?Q?tavahZLH2f6C1Xz1hsV+FO3cbchPp86tzwGjyXmP9Lph8Ez1UuA6BXC+jxVl?= =?us-ascii?Q?4RXUnWZllVfiVPQRQabWv1JTD7q9vt7NeTxwTcg7p/rZAKI6tB/v0aCdPDGw?= =?us-ascii?Q?7O2bW2Iz6u9fCjn4Ql3/FmeNmR04h5lAJuC/x+LPoDOdtgNbs8Hws0fwE64e?= =?us-ascii?Q?DDUqSROTbtlyao8A8snS4DpBnnf+4ljQ7O8i/Gym4V3jHZSlyIj8EJMl3h/9?= =?us-ascii?Q?p7G72oxUlhbHHvxp7n/k8KlmBSn6bSqcvuF4XR/sYFH6p0QvtS13j3TDa5a6?= =?us-ascii?Q?luIUFusPZUKg2UHMSCTsBSw3WK6hAXwtKmoS3oLT0dSzlZITSyDFfYNs1HPq?= =?us-ascii?Q?28vcCqb/sPt7jkDHkojZyoj3kWnbnXfxUQUpjEfRRsa3mrJQTOVchSnQpfNm?= =?us-ascii?Q?1lw74zpeykgJqNbltRHocw5pkHiGQ6qumaq+VLPcpeLn6DwmWPPETro2gle7?= =?us-ascii?Q?kP1epg9WhnXkVeQY+12EASlKJSy97XvkCok1N2EU6auDC6/5oBM9+yVQ8e6b?= =?us-ascii?Q?Gglm7qudXCTrBrnKy0+l8ZPI0zdsEwbIo6VgspKutCmpg7ZNeekLWR/eF0sm?= =?us-ascii?Q?l3WtdP5+UdXiuNROJy4+I/IvAp5kVPVYXB0Su/IWbv/AawxtHBHHaAWjrqTm?= =?us-ascii?Q?TKe045n7kDlDE9J5uJdxRCJIIJ5eNnrtq23oT+qmub5ws0ONFwa/DCecKDNT?= =?us-ascii?Q?vAAc00bPpTDj8cnlE1eGIA4RtJJcqvTh/2GgyOztEY+g3M/8IUzql8QN3ltS?= =?us-ascii?Q?8zhU/57yp6zCoTnz5hEEcCTbUW5fyPyRdo+ykv/oJOEs02IZjQ102HZy4wOk?= =?us-ascii?Q?moL+5D/CAZcerRytjt8JxlTnlg7RyTpUHZfKc4d9zs4aqsG2c9HDWTu/ZPLQ?= =?us-ascii?Q?FDq5EbZAecgldHFb71Amscx4NnN9oFBylTNKyWPp/vDTd5RDdJUTWo1lekCy?= =?us-ascii?Q?cRDQKhZdrRq7J+1CkSIf6MEw6mlVjRaIxNStrmSE53SFMfXtSXWoMXOOx3kc?= =?us-ascii?Q?ihK3jgRi71VC8dtk97eaKH73xsSFC7B6eWbfnDaCDU2lj7sy0V0FRFKalRKF?= =?us-ascii?Q?czwk+pUNPEAEPEH19Z/c72s7M8GfrYSpjn2F4lxXBPv7OcpLSzR8tS0Wg5sS?= =?us-ascii?Q?0T/44S6w9708RMLrNvXhbOjyZoeSCabRZJpPzeofrp4KVlMlgKZgYFjqtyws?= =?us-ascii?Q?NuT73y6KPkJq+9eg/xwad8F+TM7MCPFGJX1Ihq4ghRDXthPI/zcqWobBtv6t?= =?us-ascii?Q?3O3zCLZ/jWBtpTxGvrLmLhs45QyNX+Vn0+hciWJxrEe2ONzEoQKl+bPGaGCt?= =?us-ascii?Q?OML4lmR1PDQs3rdQBJF34NDGksD6Pdj0xAzwxOq0lmrS4XZxG/5mpocLeTtO?= =?us-ascii?Q?jEgaEyMJlWhuA+XWd8EEW/8imUJmIm/V6ubbx2xq?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB8281.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab326b89-04e2-4d56-8ef9-08dc4abbe5cf X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 22:03:25.4168 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5BWBl/4xHlLLtKrIGqCwmPbVfSg+UFSVZR8U9qOnyTxEfmqsHD1yrIoQUhz4OrtJ04UMuANiAYX28jVYtQMeX+ODuD9t7XAJyT+bvWfmH1k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7998 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 22 Mar 2024 15:03:36 -0700 Reply-To: devel@edk2.groups.io,saloni.kasbekar@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9JKprCmiN81JfUvjJv40squ2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=0pNrwayJ; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Siva, Have you looked into getting this fixed in grub as Laszlo suggested? What's= the expected timeline for this workaround? Thanks, Saloni -----Original Message----- From: Sivaraman Nainar =20 Sent: Tuesday, March 19, 2024 4:32 AM To: devel@edk2.groups.io; Laszlo Ersek ; Santhosh Kumar = V ; Kasbekar, Saloni ; C= lark-williams, Zachary Cc: Raj V Akilan ; Soundharia R Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consec= utive Pxe-Http Boot Issue @Saloni Kasbekar, Can you please comment on the changes? Thanks Siva -----Original Message----- From: Sivaraman Nainar Sent: Monday, February 26, 2024 4:01 PM To: devel@edk2.groups.io; Sivaraman Nainar ; Laszlo Ers= ek ; Santhosh Kumar V ; Saloni K= asbekar ; Zachary Clark-williams Cc: Raj V Akilan ; Soundharia R Subject: RE: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consec= utive Pxe-Http Boot Issue @Saloni Kasbekar, @Zachary Clark-williams, Could you please add your feedback on the changes proposed? Thanks Siva -----Original Message----- From: devel@edk2.groups.io On Behalf Of Sivaraman Na= inar via groups.io Sent: Thursday, February 22, 2024 7:33 AM To: Laszlo Ersek ; devel@edk2.groups.io; Santhosh Kumar = V ; Saloni Kasbekar ; Za= chary Clark-williams Cc: Raj V Akilan ; Soundharia R Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutiv= e Pxe-Http Boot Issue **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** Laszlo: Thanks for the detailed feedback on the changes for this issue. Since we ar= e not sure if this change are valid / violate some purpose of SNP driver, i= t mentioned as Workaround. @Saloni Kasbekar and @Clark-williams, Zachary can add more on these changes= . As you recommended, we can have PCD which controls these changes till the c= hanges are addressed in grub. @Santhosh Kumar V is this issue can be seen only in SLES 15 or it can be fo= und in any OS having Grub 2.x? Thanks Siva -----Original Message----- From: Laszlo Ersek Sent: Thursday, February 22, 2024 5:15 AM To: devel@edk2.groups.io; Santhosh Kumar V Cc: Sivaraman Nainar ; Raj V Akilan ; So= undharia R ; Saloni Kasbekar ; Zachary Clark-williams Subject: [EXTERNAL] Re: [edk2-devel] [PATCH] NetworkPkg:Resolved Consecutiv= e Pxe-Http Boot Issue **CAUTION: The e-mail below is from an external source. Please exercise cau= tion before opening attachments, clicking links, or following guidance.** On 2/21/24 18:15, Santhosh Kumar V via groups.io wrote: > The customer has a server environment where PXE and HTTP service run in s= ame Linux Server. In this environment a SUT trying to boot to SLES 15 OS vi= a PXE from the Boot Menu. After PXE Boot file downloaded and grub Loaded wi= thout continuing for installation Exit is pressed and control back to Setup= . > Now the HTTP boot to SLES 15 OS tried in the same environment and failed = to download the file. If there is a reconnect -r performed before this HTTP= Boot then boot file download and installation is getting success. > Root cause of the issue is, when Exit from grub performed, boot Loader St= ops the SNP Driver and starts the same. This sentence feels like the key one. Are you saying that grub calls Snp->Start() just before it exits? If so, am I right to suspect that that's a grub bug? It sounds like a resou= rce leak, after all. Can you perhaps include a grub source code location / pointer in the commit= message? > During this process SNP is in Initialized State. When HTTP boot is perfor= med immediately after PXE Failure, the MNP configure method initiates the S= NP Start again. Since the SNP already started by grub it returns EFI_ALREAD= Y_STARTED and none of the upper Layer drivers are getting started. > As a work around in MNPConfigure(), if the SNP Start failed with Already = Started and in Initialized state we can return success so that rest of the = drivers can be loaded and HTTP boot can work. > > > Cc: Saloni Kasbekar > Cc: Zachary Clark-williams > > Signed-off-by: SanthoshKumar > --- > NetworkPkg/MnpDxe/MnpConfig.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/NetworkPkg/MnpDxe/MnpConfig.c=20 > b/NetworkPkg/MnpDxe/MnpConfig.c index 93587d53aa..0f2df28d73 100644 > --- a/NetworkPkg/MnpDxe/MnpConfig.c > +++ b/NetworkPkg/MnpDxe/MnpConfig.c > @@ -1120,7 +1120,9 @@ MnpStartSnp ( > // Start the simple network. > > // > > Status =3D Snp->Start (Snp); > > - > > + if ((Status =3D=3D EFI_ALREADY_STARTED ) && (Snp->Mode->State =3D=3D > + EfiSimpleNetworkInitialized)) { > > + return EFI_SUCCESS; > > + } > > if (!EFI_ERROR (Status)) { > > // > > // Initialize the simple network. > The commit message does say this is a workaround, and I don't immediately a= ny see why this workaround (in the code) would be problematic in practice, = but it still leaves a bad taste in my mouth. Consider: the call path is the following: MnpConfigure() [NetworkPkg/MnpDxe/MnpConfig.c] -- public .Configu= re() protocol member function MnpConfigureInstance() [NetworkPkg/MnpDxe/MnpConfig.c] MnpStart() [NetworkPkg/MnpDxe/MnpConfig.c] // see notes! MnpStartSnp() [NetworkPkg/MnpDxe/MnpConfig.c] Notes: the MnpStartSnp() call in MnpStart() is conditional on two circumsta= nces (at the same time): - "If it's not a configuration update, increase the configured children num= ber." - "It's the first configured child, start the simple network." In other words, the MNP driver has just bound SNP "BY_DRIVER" (i.e., exclus= ively), installed the MNP service binding protocol for each vlan (IIUC), an= d one of those SB instances is now being used to create the first MNP insta= nce. I think that under these circumstances, it is reasonable for the MNP d= river to expect that the underlying SNP be in stopped state. :/ How long would NetworkPkg have to carry this workaround? (I.e., how long be= fore the grub issue is fixed, and the buggy version deprecated?) I'd prefer at least a comment in the code that the return path is a workaro= und for (I feel) an earlier SNP usage violation. A FeaturePCD to disable the workaround could be reasonable too (but the Net= workPkg maintainers could disagree about that). BTW, the commit message should be wrapped at 75 characters. These long line= s (in the body) will pass PatchCheck, but generate warnings. Those warnings= are tolerable for log quotes, URLs, etc, but for normal English text, wrap= ping is much preferred. Another comment on the commit message: the subject line should state someth= ing like NetworkPkg/MnpDxe: work aroung SNP state leak in grub Laszlo -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117064): https://edk2.groups.io/g/devel/message/117064 Mute This Topic: https://groups.io/mt/104498511/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-