From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 59EFA74003E for ; Mon, 22 Apr 2024 17:46:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/ZGhJOpPWNsQx0BMSFKAGOSLQz4HKlobuLqA8kJ1g80=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1713807962; v=1; b=tpaDOOI73c3pTT56LLnCPBUwU7uAWaUlRU5yZ2df/nPvxOrRlZPRxqEeEur+sor5iSOVsK8B 6B/jLvEjVRrRqAqNro4B7RMMP7CsWpFhmAIWUEQmX2UaeoihNAo7X+QFwtLFgpf5vFn8ukTNg4r pDeAEhQBO0XDiJoQ+yv+WVU89qvgc0vm09gW5gA2m6whJiuTt5JqbEuufEpfXNlIsHpVS00jEPY PBQjM0mp/kgTjb7+nL8hQL1wiPw5D8z7X3+ZY5Jsczt5ybwT7K0vlFtt4OIJg9xxbVeBbl0Ibpx xmEI9HNRVdYuSRJKanG9GImwbzhKayBEcXcodKJBgTrCA== X-Received: by 127.0.0.2 with SMTP id nKhpYY7687511xTFjGkiZmWk; Mon, 22 Apr 2024 10:46:02 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.2623.1713807961760324046 for ; Mon, 22 Apr 2024 10:46:02 -0700 X-CSE-ConnectionGUID: jk2MCA3kRpiy5rMJ5O+9EQ== X-CSE-MsgGUID: WCcqRY/vRh2p9xfsczv+SA== X-IronPort-AV: E=McAfee;i="6600,9927,11052"; a="20783899" X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="20783899" X-Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2024 10:45:41 -0700 X-CSE-ConnectionGUID: h1cgy6bxQhuAlRml9uaejA== X-CSE-MsgGUID: 3KjbxgoCRL2ZBRlJ4F0UKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,221,1708416000"; d="scan'208";a="28760974" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Apr 2024 10:45:41 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Apr 2024 10:45:40 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 22 Apr 2024 10:45:40 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 22 Apr 2024 10:45:40 -0700 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com (2603:10b6:806:26b::20) by MW4PR11MB6714.namprd11.prod.outlook.com (2603:10b6:303:20f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.20; Mon, 22 Apr 2024 17:45:37 +0000 X-Received: from SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e9fe:4a17:7d16:492f]) by SN7PR11MB8281.namprd11.prod.outlook.com ([fe80::e9fe:4a17:7d16:492f%6]) with mapi id 15.20.7519.018; Mon, 22 Apr 2024 17:45:36 +0000 From: "Saloni Kasbekar" To: "Hsueh, DoraX" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chuang, Rosen" , "Tang, Haoyu" , "Desimone, Nathaniel L" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Topic: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Index: AQHalJC+QrDx/NVnpUaH2xArXJtBvbF0kGiw Date: Mon, 22 Apr 2024 17:45:36 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN7PR11MB8281:EE_|MW4PR11MB6714:EE_ x-ms-office365-filtering-correlation-id: de1e9c74-4d0b-4a10-dbdd-08dc62f4048d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?qIGzKUfrnChlYH+wTmZMb+f/lRkbIBr7s0Eqs5QsPMuIUBmtStDivnn/DYHa?= =?us-ascii?Q?MHUA6LyCecephj643MycnURPxX0i6MYwDrm0GtWDBxS3iz6tIESFzUdzHQy8?= =?us-ascii?Q?Ymy0EhPjmJpG25fhQUnncom1TCOH/6+mNJyW6opeaewe/uhQ3lh79fJlkoMW?= =?us-ascii?Q?sTcAVgyxCSV9q4MxAXsnRa98tBWOsjAQ4zIGMbTQFG6Cvl5izmJklMV1Fo2V?= =?us-ascii?Q?7yAhR8AQY9FwJtDF6oZ72YHWOKWyrGI3BrncdOu9Nw2Tr0m0ie+zhEsElnME?= =?us-ascii?Q?YpWw/7VHqaMoSMctVnIR+F5k+3iji/bmIwOnVHE7iIbFxM2FexDdW7NJprAX?= =?us-ascii?Q?AhuvTnbEpLuuYMV1bq4OPTDqP48Xy4B3P7vtQfpTrzSScW3cb6UgGtTkg9z2?= =?us-ascii?Q?AeGOhQZoimhOP9hygvOAdppjFOxZHHB6xfr6a5CKWmKr1IXBWhQiyBVG00TR?= =?us-ascii?Q?8BXdqDgF3SjMIlAipNiwe9lyoP/0EmuBvWfikRFD9X81z4NqYjNH1t7KjEIy?= =?us-ascii?Q?xl8JPt7LmRTiV8G6IHEnz7g0d96jjRk+2IQxs59ZF45cM2JlVohakWdEuDsq?= =?us-ascii?Q?4+3KVKSBmYlyMFz83+B4h8wqHF4sogXtYnTUzg3RF0g/9r+lusDw/4CHTLzg?= =?us-ascii?Q?poKIClteqUme+nz8lDbNCQN1+1fKBIRPRPR0c38mSlc1ynbFSwaMLjMucOZ+?= =?us-ascii?Q?Obz+Njw1QDlA5pOCQmZqtHG5kbO88bobLlwsiZjwM/LxO0qgcENVjHDOysUG?= =?us-ascii?Q?8558DnnSprP9tB4dnH8Dwr74nJ6JppciEOzZ1OsEISFA/b48OzuJET2EhAeh?= =?us-ascii?Q?MrAOv3PGHRz6c9q0J3Clf+hkjzP2vAXK3/EbJ5YDrAp96ExaLsDBA4FnUsyw?= =?us-ascii?Q?tkGJ5zVCXq/7Z2SVBF2MKd/5BdXZgTzMPbW9stUinm/9EsLoSaRDT3kAy+95?= =?us-ascii?Q?aDCZ5ai2VfEvgJEduYbpg4Vau2/G8eBAvg7mh/ab1MQBM10cj9gjvhzhG9MX?= =?us-ascii?Q?wC5geo8zwbln0r4SHbgeAUAnwdXCSdzkXyN/q2lHbBFeA5HqVREoZHi+UPgi?= =?us-ascii?Q?uONqNQ+ERpE0q3o5EjGR/pasuKuaqXkQhGh0rr6s4GinVpzpYUphM2dLpz/s?= =?us-ascii?Q?kMaI2ZXTizru9c0P/BGjpEyQ3yISseQXwyalhKUX1XNyDl+M1UCuueRyYY6E?= =?us-ascii?Q?jINmS+PXe6QBy0sTxm16w1tD1hy/+l7BtTXtwgH2KMvYszNW9In7O3O6jIXO?= =?us-ascii?Q?F9eHij2H+ufFhT34cGICtW/N+qYRLHHtf2owUk505Q=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lhz6Y5+GqthTGn1r0pJyPpMlit75QUEQugAZiI8n3hd+mJZn5eG32LTtr7kt?= =?us-ascii?Q?y2/H4LTu8rKRv5yc8YBZJFUIHjMvwFG/7AdQ04IN+uU3erphkRm3qxQolxZZ?= =?us-ascii?Q?wZBMQxn09ybTJW/YgfmZ68DoXQkMgNDJJIpkjeBMUWN8q8Jtfow8+pBRpv7e?= =?us-ascii?Q?oUsRjA6LYiVIrAp+QR7HPtt8zTG46wf1PAh3vxonDyX8pUomhC0V/dufyWw4?= =?us-ascii?Q?+C1LuT3i5odk9ifbkVZAWvDkK7HCeeJ1j7hdpVy36aeAqrWXLRysgtlwutAP?= =?us-ascii?Q?oxrSllEiQydePWYFLfJcTQ7S9nyKi7Fpv8kKbCt8+VTKXOqjJsbfI1i7YOtp?= =?us-ascii?Q?jA1n6pvMNk5E875hLlP8ytsqalXOykzbLzm726XOXG5uodmMnUnvHmeaMGcB?= =?us-ascii?Q?3MiYjVrB96SCy9GdqiEkxa/xri1mZsUivILRcqr3E2mEX/1eAGZpgO+08az+?= =?us-ascii?Q?sSSJ95j5yqgSqKBGwXM4OmHHa0k08EUcdYU4JkjBtD1m+UFeNooD49HqwOmX?= =?us-ascii?Q?MO7yZtyfcd4ZFk653wnlyWaJIHLPinXEzyZ8qOzCtz0M6QghEqINcIgREvO2?= =?us-ascii?Q?r37LGkVDOwZ3urk4ao0GIimLOCaqRxupY3EcYX6L5LTLyIMB6W8GF05g57ZU?= =?us-ascii?Q?4iyNXsRKZSgASVVwkNRoYyrNoV5My/BIZo6HkiRYfKYNOTqLmhmSBQHLA5L3?= =?us-ascii?Q?uc62Xs0gJxYBV6Mpp7QGqk4lmy4kgyCkOrBxWRrqYkQa7mWYYZ3jOAUiPWE4?= =?us-ascii?Q?E+ELY2NcK52X8A/16xVfgo/QamvXPyj4coUfSFqmQLY1Gy56Kt5ppd7yNcqL?= =?us-ascii?Q?zeseTn30pmTTa24WaSRai4WmsISGfAq1XOVh8oK/uWTNYcuLq7pUCeSynE5F?= =?us-ascii?Q?deTZ/Y1U3STHr6y1jOE1jbTagRhefaem+Iept/oKwcu+VmIfGxxzgVuuxvQa?= =?us-ascii?Q?MoXIfVdHfNisMrco1+qIqOk730CkZ1j4Wwm2irNQK3OGKjAFuwnUAidqJvju?= =?us-ascii?Q?zNl0pOST1wnydwWwFFwF00YE3TGEWTODr6TdJS405yb6xWukP9XhdCttjpSL?= =?us-ascii?Q?no9saQ7FVFFnaWUH2+Tp72dDIRCaRnbLueeJNV87cM4qnkd7K/kQPcmRfXBd?= =?us-ascii?Q?BXB7viqDpqaxe0CE2jKBF0O0+jmuOWk5TBHq2RPlauEyE6iyc0NVJi+EjODc?= =?us-ascii?Q?WxBS97w8yY/siecilq80fDtWGmtIELp2n/4/ZM4hZeWC5xjMAhgtgbwTiKQ9?= =?us-ascii?Q?kym88/DTb+u3kfsk12Zk7OpKBysVkNpeQNlUymUrCAJZX/84Wued8aDwy2oz?= =?us-ascii?Q?UCLnlWszMOqcelj1scdtcd5FiREA3gDTjjAYLf6G7w80ooQjDGpKgzAG0341?= =?us-ascii?Q?XJx2vHx4iX/IKIj0r+jabwHGohBPzTXSLBF8bPfdyY9YB/X1xgTwzMjisaBZ?= =?us-ascii?Q?qdC1MkyA5wQXuwyj0bDU0C1+LE1Cqq0qnAS275LyFVTGHkC9Y45Pd4UQxE80?= =?us-ascii?Q?5VlsM0EDPmnuRqvDGbr/J22EwY1XVsppQCaPMe/9AjnsalXGHFQdkaJSL2jj?= =?us-ascii?Q?VMKLQhkOYCfrUul5hho/yiUI7wDKtucQDvUvTtih?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB8281.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: de1e9c74-4d0b-4a10-dbdd-08dc62f4048d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2024 17:45:36.7597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AId786JXyA/dXD8UjnjYGSAkcVgITtte9z8pEi9u34k24JXpL3t+EIOhdquG/lbiTJGwh9ZbIGrEahfXsOyFZCfOycVO/SpmUptQ0kYQyYI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6714 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 22 Apr 2024 10:46:02 -0700 Resent-From: saloni.kasbekar@intel.com Reply-To: devel@edk2.groups.io,saloni.kasbekar@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AIF0VxDeFF9ZVFt4i9IsAFHQx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=tpaDOOI7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Kasbekar, Saloni -----Original Message----- From: Hsueh, DoraX =20 Sent: Monday, April 22, 2024 1:40 AM To: devel@edk2.groups.io Cc: Hsueh, DoraX ; Chaganty, Rangasai V ; Chuang, Rosen ; Kasbekar, Salo= ni ; Tang, Haoyu ; Desimon= e, Nathaniel L ; Chiu, Chasel Subject: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. From: DoraX Hsueh https://bugzilla.tianocore.org/show_bug.cgi?id=3D4761 Halt the TCO timer to fix release mode hang. Cc: Sai Chaganty Cc: Rosen Chuang Cc: Saloni Kasbekar Cc: Haoyu Tang Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: DoraX Hsueh --- .../AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc | 3 ++- .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++++ .../SecFspWrapperPlatformSecLib.inf | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPk= g.dsc b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc index 59350f06..ea92ec75 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc @@ -233,8 +233,9 @@ =20 [LibraryClasses.X64.DXE_SMM_DRIVER] =20 -!if $(TARGET) =3D=3D DEBUG SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFla= shCommonLib.inf + +!if $(TARGET) =3D=3D DEBUG TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Smm= TestPointCheckLib.inf TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull= /TestPointCheckLibNull.inf !endif diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFsp= WrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/AlderlakeOpenBoardPkg= /FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c index f7ec4f9e..e930c9c7 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/PlatformInit.c @@ -12,6 +12,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include +#include +#include =20 /** Platform initialization. @@ -28,6 +30,12 @@ PlatformInit ( IN VOID *EndOfRange ) { + + /// + /// Halt the TCO timer as early as possible + /// + IoWrite16 (PcdGet16 (PcdTcoBaseAddress) + R_TCO_IO_TCO1_CNT, B_TCO_IO_TC= O1_CNT_TMR_HLT); + // // Platform initialization // Enable Serial port here diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFsp= WrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/Alde= rlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWrap= perPlatformSecLib.inf index 3e51cb36..abc84057 100644 --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/SecFspWrapperPlatformSecLib.inf +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapper= PlatformSecLib/SecFspWrapperPlatformSecLib.inf @@ -89,6 +89,7 @@ gIntelFsp2WrapperTokenSpaceGuid.PcdFsptBaseAddress ## C= ONSUMES gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ## C= ONSUMES gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable ## C= ONSUMES + gSiPkgTokenSpaceGuid.PcdTcoBaseAddress ## C= ONSUMES =20 [FixedPcd] gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase ## C= ONSUMES --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118099): https://edk2.groups.io/g/devel/message/118099 Mute This Topic: https://groups.io/mt/105665490/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-