From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.12980.1587914799171583343 for ; Sun, 26 Apr 2020 08:26:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=03859c2cac=abner.chang@hpe.com) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03QFG3nl004752; Sun, 26 Apr 2020 15:26:38 GMT Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 30mhp8nnrn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 26 Apr 2020 15:26:38 +0000 Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 79AC663; Sun, 26 Apr 2020 15:26:37 +0000 (UTC) Received: from G4W9332.americas.hpqcorp.net (16.208.32.118) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 26 Apr 2020 15:26:37 +0000 Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W9332.americas.hpqcorp.net (2002:10d0:2076::10d0:2076) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 26 Apr 2020 15:26:36 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.11) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Sun, 26 Apr 2020 15:26:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ja3/kTfqRZ9Q21Hy/FJEiEMXdXP3WgsREt7R1Dc6UO1LaoSO65jcorlFKOLwu5jHZW42HpVw/9+I36ZHp4WpB1kTIl7HFRShn+5T0BC+yDvmYHtD5IJ5p1El+87EPcHGZ4AiqzfK6QNIYXPG0p6FbkFuIiyYumWu0fDSjpZw+7AycX1Vzl1yapK8aWOcIFh+gIe8UHK5oFqj64qCddjeB0nsv9PQBWY7EHchd9/kmfz5WONRMPLkhh/Hix7Caf3SEZRtRu1nZlhel+oLeMPq1LIgLqe7ZYEXRyrI9pSMksZbnrLJhsYg4TLk/AJDY/I/0aYpwJ5VczTPSlDZSXyrVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z6j4jR1v7qgg22JQR/0eXi1eFz49dE121QYsRod5YP8=; b=Cfm2A/6gkpuGp0PpeXbnTEI68eDB9scwaW5Xus09jSVDuDGfvidtarHBt5UbqhDkC90fNQKsHIqnUgjCY5OrHuX9nQ0XbVbo8pmNf3iZP3Aezdk4vNPY+EcZPS4u7fUHDJyR4eTeP04VJGR37ulLHIZB4kiKCx6mS5g4/BjDgXerIQaKbdcJNUmJt3oHnbbdcX2QlKovlVp0XAthPp+3n3q8BStn5lh02blVhF7V2/+sniiu7NnJNDYextKTk3MxZbkgbyCS71wgv31if3LUYZY/HoVlL3fogSRVgAZ3O32d17SXSntl9XvDAXB2fz/TNoSvDsaNLANOSl7yx1perQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770a::14) by TU4PR8401MB0990.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Sun, 26 Apr 2020 15:26:34 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::38ba:b525:f979:8411]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::38ba:b525:f979:8411%11]) with mapi id 15.20.2937.023; Sun, 26 Apr 2020 15:26:34 +0000 From: "Abner Chang" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Chen, Gilbert" , Leif Lindholm , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/DxeIplPeim : RISC-V platform level DxeIPL Thread-Topic: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/DxeIplPeim : RISC-V platform level DxeIPL Thread-Index: AQHWDw6ZmUNPJuS/NEmma6KKyPsMwKiLlCSAgAAJv3A= Date: Sun, 26 Apr 2020 15:26:34 +0000 Message-ID: References: <20200410072555.7444-1-abner.chang@hpe.com> <20200410072555.7444-4-abner.chang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40DD59D0@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40DD59D0@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 1b835e74-4412-4562-9be4-08d7e9f63440 x-ms-traffictypediagnostic: TU4PR8401MB0990: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:88; x-forefront-prvs: 03853D523D x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(396003)(346002)(39860400002)(366004)(376002)(136003)(478600001)(33656002)(8676002)(9686003)(186003)(2906002)(55016002)(53546011)(6506007)(71200400001)(5660300002)(66946007)(316002)(76116006)(54906003)(966005)(110136005)(4326008)(81156014)(86362001)(64756008)(66476007)(8936002)(66446008)(66556008)(26005)(19627235002)(7696005)(52536014);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Nvq6HDzqLucyiUW4Rt2cug7JLcAW81X1xR4mHKbON2VYW4btIGI222n6RWc0QDKyCkNSpK/yPK/UJqe0WZCOhsObHjyMPlTmTDja5ejyoJqfSTYLkSGKqrsh4zeE3cX5eu3yUqDsMhu7qHSLhRIUfV4Fk5KG3bUFX0FLX85r3UofnDRQQ/ESCgRW/a8HX45KlklREOzQjR5TE7uetXUr32C5vjmN7Wz9My11C3tTSYm9RG3zCL7Uqa9x1xfFXZzdzNyeeZ/ZLT74fI0hsHQ4UCKmgvi+OOH9RBfqLQB0KjR7BkH80dSFDIJPPBrnli7X2G7b2msPd4LegcCCuMWcZlj4bGtuhOVL6buygAx/mdHO21JMj9Fu5o7ShnmUX5PMWta5yk5PS63Zk6aYMKs0lY3bJMjx/M/7qOcKtE4pJQIpxzmu90PZCNasqxg05IBghV0SvTxeedHPYwbGX/geZeOpfsqMZBkv/BNjX82NhEpNGqkkGhJ8CBurlzciKbGZPJRRNTEYcP9dwYS9bT+8Ag== x-ms-exchange-antispam-messagedata: 4C3AWJIjMc1Capv0Vo7xtlPDVMNYN42WNOo0q7E7qAG7rbnpXr3COUF5ZRauh9nMbtzaSy+AebXyxIFRTbcKbKEncjpf6GlG14VB/WG1r+qQVFgmISmSOAAwxr0Dcd9cL1TQCXSHhwePzwMsY80NDom3eErqa2ubBZQWZzuj+XYeQGQdxjnN+PeNVxZOVrUVe9deTcEG35GAHimPn7P2f6rA/zDUJIBHexqEeoHc2pzDM61zjWa5H/jLB2ykt2ACTIeCjdTzAYpSdVvl7X1JWB5grHu3iV7nRpjCBdQSs50LbZ6du4r175/BXtbt4j2itVO1X59ue5s+YdnZZTnrmXfBv7MBGUb/ym+Ct+T6TeGb2rG4RBClTSyEM5eNHu6S1Sl97p18Ea9FyS++jFxwInAYsaWlI5VIoj+t0A3v6/1WDSrsODcqevH0E9MbieyxAp91weiEYzcHe13179M00hFKfumRpYog8n4B/sDJAzcZdO1AbZQ/qlVRfyZyW9MUwR8DJzrFKMmCRFQ0OYy5xpgyDnfQBrQNERmRwpEciF+tYRXpf3zw9cnKbeAE0pOjd3YbfHJpzBGVpCcfxwRT8TynvqvTs5CFW/LzqF3w332KCMOw5QWo4+sPfPH6MzIDHmF6uSJtX+rdEtzzX8KT5A/YeJnQM4ywgYryZggVpgxtOZbzkocNNlxXQlgjaeRpQBiTcoOjbDY002VAIEIv9LxrKXU3WQqyq+KZqXtAp+N2RN5ojaIC4Qz9wluMMWKI8VZBYXsN8YPTV0LLJI3yMEEfUSU3P+5TYUGEcGP9hZM= X-MS-Exchange-CrossTenant-Network-Message-Id: 1b835e74-4412-4562-9be4-08d7e9f63440 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2020 15:26:34.3171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GXkOFVvMLNpSNtPpd/KZCOsDvtMX70bEU9s3WSX+xiQXTIpnipezbvCil4NtyZChRT6/EAifX/8LMCXI5ra5sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0990 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-26_06:2020-04-24,2020-04-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 mlxscore=0 phishscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004260142 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Bi, Dandan [mailto:dandan.bi@intel.com] > Sent: Sunday, April 26, 2020 10:44 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert ; Leif Lindholm > ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/DxeIplPeim : RISC- > V platform level DxeIPL >=20 > Hi Abner, >=20 > 1. What's following definition for? It seems not be used. > typedef > VOID* > (EFIAPI *DXEENTRYPOINT) ( > IN VOID *HobStart > ); [Abner] Hmm.. this is never used. Already removed this in another patch set. >=20 > 2. When reviewing this patch, found the RSIC-V switchstack related code a= re > not in BaseLib in MdePkg. > But then noticed that you have covered them in another patch set. > So here I may suggest that maybe you can make the patches which have > dependency in one patch set and then CC all reviewers, then it can avoid > such confusion and also can make the patches submit in right dependency > order. [Abner] Thanks for the advice. Sure, will follow this if the change depende= ncy is across patch sets next time. > Since now these patches are in different patch series, please pay attenti= on to > the submit order to avoid any build break in this way. [Abner] Currently the commit of BaseLib is prior to the commit of DxeIpl c= hange. It should be no problem. Thanks. >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Friday, April 10, 2020 3:26 PM > > To: devel@edk2.groups.io > > Cc: abner.chang@hpe.com; Gilbert Chen ; Leif > > Lindholm ; Bi, Dandan ; > > Gao, Liming > > Subject: [edk2-devel] [PATCH v1 3/3] MdeModulePkg/DxeIplPeim : RISC-V > > platform level DxeIPL > > > > Implementation of RISC-V DxeIPL. > > > > Signed-off-by: Abner Chang > > Co-authored-by: Gilbert Chen > > Reviewed-by: Leif Lindholm > > > > Cc: Dandan Bi > > Cc: Liming Gao > > Cc: Leif Lindholm > > Cc: Gilbert Chen > > --- > > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 6 +- > > .../Core/DxeIplPeim/RiscV64/DxeLoadFunc.c | 80 > +++++++++++++++++++ > > 2 files changed, 85 insertions(+), 1 deletion(-) create mode 100644 > > MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c > > > > diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > index 98bc17fc9d..3f17028546 100644 > > --- a/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > +++ b/MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf > > @@ -7,6 +7,7 @@ > > # # Copyright (c) 2006 - 2019, Intel Corporation. All rights > > reserved.
# Copyright (c) 2017, AMD Incorporated. All rights > > reserved.
+# Copyright > > (c) 2020, Hewlett Packard Enterprise Development LP. All rights > > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ > > -25,7 +26,7 @@ # # The following information is for reference only and= not > required by the > > build tools. #-# VALID_ARCHITECTURES =3D IA32 X64 EBC (EBC i= s for > build > > only) AARCH64+# VALID_ARCHITECTURES =3D IA32 X64 EBC (EBC is= for > > build only) AARCH64 RISCV64 # [Sources]@@ -49,6 +50,9 @@ > > [Sources.ARM, Sources.AARCH64] Arm/DxeLoadFunc.c > > +[Sources.RISCV64]+ RiscV64/DxeLoadFunc.c+ [Packages] > > MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.decdiff --git > > a/MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c > > b/MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c > > new file mode 100644 > > index 0000000000..051d11de25 > > --- /dev/null > > +++ b/MdeModulePkg/Core/DxeIplPeim/RiscV64/DxeLoadFunc.c > > @@ -0,0 +1,80 @@ > > +/** @file+ RISC-V specific functionality for DxeLoad.++ Copyright > > +(c) 2020, > > Hewlett Packard Enterprise Development LP. All rights reserved.
++ > > SPDX-License-Identifier: BSD-2-Clause-Patent++**/++#include > > "DxeIpl.h"++typedef+VOID*+(EFIAPI *DXEENTRYPOINT) (+ IN VOID > > *HobStart+ );++/**+ Transfers control to DxeCore.++ This function > > performs a CPU architecture specific operations to execute+ the entry > point > > of DxeCore with the parameters of HobList.+ It also installs > > EFI_END_OF_PEI_PPI to signal the end of PEI phase.++ @param > > DxeCoreEntryPoint The entry point of DxeCore.+ @param HobList > > The start of HobList passed to DxeCore.++**/+VOID+HandOffToDxeCore > (+ > > IN EFI_PHYSICAL_ADDRESS DxeCoreEntryPoint,+ IN > > EFI_PEI_HOB_POINTERS HobList+ )+{+ VOID > *BaseOfStack;+ > > VOID *TopOfStack;+ EFI_STATUS = Status;+ //+ //+ > > // Allocate 128KB for the Stack+ //+ BaseOfStack =3D AllocatePages > > (EFI_SIZE_TO_PAGES (STACK_SIZE));+ if (BaseOfStack =3D=3D NULL) {+ > > DEBUG((DEBUG_ERROR, "%a: Can't allocate memory for stack.", > > __FUNCTION__));+ ASSERT(FALSE);+ }++ //+ // Compute the top of the > > stack we were allocated. Pre-allocate a UINTN+ // for safety.+ //+ > > TopOfStack =3D (VOID *)((UINTN) BaseOfStack + EFI_SIZE_TO_PAGES > > (STACK_SIZE) * EFI_PAGE_SIZE - CPU_STACK_ALIGNMENT);+ TopOfStack > =3D > > ALIGN_POINTER (TopOfStack, CPU_STACK_ALIGNMENT);++ //+ // End of > PEI > > phase signal+ //+ Status =3D PeiServicesInstallPpi (&gEndOfPeiSignalP= pi);+ > > if (EFI_ERROR (Status)) {+ DEBUG((DEBUG_ERROR, "%a: Fail to signal E= nd > of > > PEI event.", __FUNCTION__));+ ASSERT(FALSE);+ }+ //+ // Update the > > contents of BSP stack HOB to reflect the real stack info passed to > > DxeCore.+ //+ UpdateStackHob ((EFI_PHYSICAL_ADDRESS)(UINTN) > > BaseOfStack, STACK_SIZE);++ DEBUG ((DEBUG_INFO, "DXE Core new stack > > at %x, stack pointer at %x\n", BaseOfStack, TopOfStack));++ //+ // > > Transfer the control to the entry point of DxeCore.+ //+ SwitchStack > > (+ (SWITCH_STACK_ENTRY_POINT)(UINTN)DxeCoreEntryPoint,+ > > HobList.Raw,+ NULL,+ TopOfStack+ );+}+-- > > 2.25.0 > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > > > View/Reply Online (#57204): > > INVALID URI REMOVED > 3A__edk2.groups.io_g_ > > > devel_message_57204&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN > 6FZBN4Vgi4U > > lkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQGY2A- > 8sGgSVd_INCRAJPHdRdr_xoMzfE4YRhp > > mX6CY&s=3D1N-Li2mpWifnPTqrKvwjo7wyYMjkx-4cAoxLFInuC4M&e=3D > > Mute This Topic: > > INVALID URI REMOVED > 3A__groups.io_mt_7291 > > > 6401_1768738&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4V > gi4Ulkskz6q > > U3NYRO03nHp9P7Z5q59A3E&m=3DQGY2A- > 8sGgSVd_INCRAJPHdRdr_xoMzfE4YRhpmX6CY&s > > =3DYKduAw4Fr1boRP5t5Cj5riGFc2hnbJ2MR4HbUXYzjj4&e=3D > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: INVALID URI REMOVED > 3A__edk2.groups.io_g_devel_unsub&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2 > LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DQGY2A- > 8sGgSVd_INCRAJPHdRdr_xoMzfE4YRhpmX6CY&s=3DXqFAUAs7rAwTwZEF2BRk > du-v99ckpjMajhfL6d3liqw&e=3D [dandan.bi@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D