From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.425.1581352806942475138 for ; Mon, 10 Feb 2020 08:40:07 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=03092301c4=abner.chang@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01AGZ3gP014135; Mon, 10 Feb 2020 16:40:05 GMT Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0a-002e3701.pphosted.com with ESMTP id 2y39u8rp17-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Feb 2020 16:40:05 +0000 Received: from G4W9119.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 95DB7E6; Mon, 10 Feb 2020 16:40:04 +0000 (UTC) Received: from G1W8108.americas.hpqcorp.net (2002:10c1:483c::10c1:483c) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 10 Feb 2020 16:39:37 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.241.52.10) by G1W8108.americas.hpqcorp.net (16.193.72.60) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 10 Feb 2020 16:39:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KiFqVuPwVKE3Mo4vrwvHKJH1csKJYE01Ws/hB2fWzSIhjNPhzufueAX/7xHrwPLNT77DOJ1z7Ybvw5lxwB0ZwCOSp1AmAvak03RDxby/qQ23HicsX1mw9ZhjX2pUKcLwIayI2G4ndwxtaYtmvH1QpCJRp6vdpHi79Zj1Me7e6K9NJcLF9YJd2dZ3Yvr92+qNWM64ksc83ECYHBTMGKjUbY215IDZNAxrN8xr/LJRSuGysJblRhv028OvuQ7LqVdBZMEy+Sl++M13MGpP7B2CuQd1jfjXVC7FL4DlWPqtkQVQ0x3ZvFY37ehKfuob+UIezpsa3bnF/RgKoxyiSEeefw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n1WLYTTID7bMBJlwYZfbyfnCa71ABUWbTlqqymyjB8Y=; b=Ui8/TQP9oWj5uXVz3wWNzQND9CyQD8le+UPrpkAJ49mSMKgpuoGhirevvh7lSnqsf8QY7p4uORCC2FfWAohfYmu78YLZT23/Yf+RWkoSPOmVKyKpMo1RBqfivevKxJufsHD65UnT1CBygcrJMBT3pQ7mUPrlHsE2/oE2r02XOokkOFRlw/TrXFpBYdQensTVDZDi4vFwoglEhssYuvawn8rhhqZVALhcFroy20tyoL0Gwd52+imAOwNf3DyvJvGrE8kb1M3q4YVlZUACfcTcTO2ChyYtB8jkdDZiG1jbLZe/HCIlBjKW8hPcwwoUeCgWhKw5800A15kBrcFUzN6h/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (10.169.43.14) by TU4PR8401MB0543.NAMPRD84.PROD.OUTLOOK.COM (10.169.44.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Mon, 10 Feb 2020 16:39:36 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402%6]) with mapi id 15.20.2707.030; Mon, 10 Feb 2020 16:39:35 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "rebecca@bsdio.com" , "Schaefer, Daniel Helmut (DualStudy)" CC: "Chen, Gilbert" Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Topic: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Index: AQHV33xBwg7AF7RV9USeT6WkQ0yE2agTjjQAgAAZP3CAAOHHUoAAFOoAgAADumA= Date: Mon, 10 Feb 2020 16:39:35 +0000 Message-ID: References: <28f9f325-3106-1f3a-096d-d3aebc6fcc85@bsdio.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [1.34.113.40] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 18dea59f-5e71-4a92-b2df-08d7ae47d07a x-ms-traffictypediagnostic: TU4PR8401MB0543: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:605; x-forefront-prvs: 03094A4065 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(81166006)(81156014)(8676002)(186003)(316002)(19627235002)(53546011)(4326008)(71200400001)(55016002)(86362001)(33656002)(9686003)(6506007)(8936002)(52536014)(6636002)(5660300002)(110136005)(478600001)(66556008)(66946007)(76116006)(966005)(66476007)(7696005)(66446008)(2906002)(26005)(64756008);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB0543;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wi+sJOYbZtv6TxTufDBp4Zp750zoUv0C9+5vNqnkEfps18ZjHJJTL2kx36mcMXLlHrwHf6dyb72UANvxNlHj6RFkbiXjOzoVG8O1mi/54+X9cJG1gY5Qxo1VN+TX5RdXW4OfLVFf4pp5998P4oqYLJWiqNfOvsbw7D9f+/uxOh4CGmF/+V9wnS2vexXlQiQPl7eJ5sMjUiotMxTNK1lbEPwGVrqfytEwwpgN3JoJ6qWk5DTJp5PYncoVgJ7Dlh1MkJUF2/fF5AbGoEv9IgRWvr4BE7oXlklpB9jbO5c1zCDGYgxK39LFJpDzrYaIaG1+X1NTlQGJOKdBl0G06n2RE6FwVCcVUpLrL7Vt+fuIDL1dl0xqDDF72S2ZUcQ/qZ+bxyp+mKZKeeT/vH0eqfDaoX6LQ4WjKe3zMtqmti5Vvtt0PEu0iFxZ7Oih279egeKqVMnnnlvVZPF/VSTfN4M2wCOYCmdDumEqzpUozDpLvTdi3wyygW0+U9lGm7wuenSKvdqZAvWDHyixAQTo8rDvAA== x-ms-exchange-antispam-messagedata: 2BCC4TQd2HIrXIadTivY9kMNUemPPqq6jOCQVcxzucvRAWf942ME3n/N7zjG07GDzB5JEu2OlI1Lr7OmpChOW+cPgwdzzWwove4fhCcPsK7hra2YzYVN1i7RLHaE8y3iqAFxmAaZ8ALDF3twLTQj2A== X-MS-Exchange-CrossTenant-Network-Message-Id: 18dea59f-5e71-4a92-b2df-08d7ae47d07a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2020 16:39:35.7698 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LqBDV05F7ZzrM895q09V5dFokgFZjUVNiWTpO/6632CZN8LLCgqgbqDgHq+hpJCZ80K7HNgRnyT3DOkylne2Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0543 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 6 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-10_05:2020-02-10,2020-02-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002100123 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Thanks Rebecca. Yes, the readme.md is still used. I will check your patch. -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Rebe= cca Cran Sent: Tuesday, February 11, 2020 12:24 AM To: Schaefer, Daniel Helmut (DualStudy) Cc: Chang, Abner (HPS SW/FW Technologist) ; Chen, Gil= bert ; devel@edk2.groups.io Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submod= ule to get sbi_hfence.S etc. On 2020-02-10 08:13, Schaefer, Daniel Helmut (DualStudy) wrote: > if you want to update to opensbi master, please apply this patch. > Since opensbi 0.6 hasn't been released yet, we haven't pushed the=20 > fixes yet. > Atish said it will be out soon. Thanks! That worked, with a couple of changes. It seems commit ec29e1cf73ffe96a646daa7c2b288aa280e4be37 isn't in the opensbi repo, and th= e latest master code requires the following patch (I'm assuming 64-bit MMIO= _is_ supported!): diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Open= sbiPlatformLib/Platform.c b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Open= sbiPlatformLib/Platform.c index 3b3637995d..f72122b21b 100644 --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Open= sbiPlatformLib/Platform.c +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Open= sbiPlatformLib/Platform.c @@ -168,7 +168,7 @@ static int U540_timer_init(bool cold_boot) =A0 =A0=A0=A0=A0 if (cold_boot) { =A0=A0=A0=A0=A0=A0=A0=A0 rc =3D clint_cold_timer_init(CLINT_REG_BASE_ADDR, -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540_H= ART_COUNT); +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540_H= ART_COUNT, TRUE);^M =A0=A0=A0=A0=A0=A0=A0=A0 if (rc) =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return rc; =A0=A0=A0=A0 } I don't know if Platform/SiFive/U5SeriesPkg/Readme.md is still used, but I= noticed it's a bit out-of-date, and I believe the following patch fixes so= me issues including typos: diff --git a/Platform/SiFive/U5SeriesPkg/Readme.md b/Platform/SiFive/U5SeriesPkg/Readme.md index 535fa9d430..d6db7c9150 100644 --- a/Platform/SiFive/U5SeriesPkg/Readme.md +++ b/Platform/SiFive/U5SeriesPkg/Readme.md @@ -4,8 +4,8 @@ U5 series core platforms. Currently the supported platform= s are Freedom =A0U500 VC707 platform and Freedom U540 HiFive Unleashed platform. =A0 =A0Both platforms are built with below common packages, -- **U5SeriesPkg**, edk2 platform branch -=A0 (Currently is in edk2-platforms/devel-riscv-v2-PATCHv5 branch) +- **U5SeriesPkg**, edk2-platforms master branch^M +=A0 (Currently is in edk2-platforms/devel-riscvplatforms branch)^M =A0- **RiscVPlatformPkg**, edk2 master branch =A0=A0 (Currently is in edk2-staging/RISC-V-V2 branch) =A0- **RiscVPkg**, edk2 master branch @@ -17,11 +17,11 @@ VC707 FPGA Dev Kit, please refer to "SiFive Freedom U500 VC707 FPGA Getting =A0Started Guide" on https://www.sifive.com/documentation . =A0 =A0## U540 Platform -This is a sample RISC-V EDK2 platform package used agaist SiFive Freedom = U540 +This is a sample RISC-V EDK2 platform package used against SiFive Freedom U540^M =A0HiFive Unleashed development board, please refer to "SiFive Freedom U540-C000 =A0Manual" on https://www.sifive.com . -The binary built from Platform/SiFive/FreedomU540HiFiveUnleashedBoard can run -on main stream [QEMU](https://git.qemu.org/?p=3Dqemu.git;a=3Dsummary ) +The binary built from Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/^M +can run on main stream=20 +[QEMU](INVALID URI REMOVED +g_-3Fp-3Dqemu.git-3Ba-3Dsummary-29-255EM&d=3DDwIF-g&c=3DC5b8zRQO1miGmBeVZ= 2L +FWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DHxXHuY_9jAKWxvrHT= bm +2zuUZlHhjTs5V4lDto0Lzipk&s=3DYPUqX3i3iQnU2UwGUb8-AL-IZ5-Uszd6E0r9qL5jo_0& +e=3D =A0using qemu-system-riscv64 under riscv64-softmmu. Launch the binary with =A0 =A0``` @@ -33,8 +33,7 @@ using qemu-system-riscv64 under riscv64-softmmu. Launch the binary with =A0git clone https://github.com/tianocore/edk2-staging.git =A0# Checkout RISC-V-V2 branch =A0git clone https://github.com/tianocore/edk2-platforms.git -# Checkout devel-riscv-v2-PATCHv5 branch -git clone https://github.com/ti= anocore/edk2-non-osi.git +# Checkout devel-riscvplatforms branch^M =A0``` =A0 =A0## Platform Owners @@ -47,7 +46,7 @@ FPGA to EFI shell with console in/out enabled. =A0 =A0## Linux Build Instructions =A0You can build the RISC-V platform using below script, -`build -a RISCV6= 4=A0 -t GCC5 -p Platform/SiFive/FreedomU500VC707Board/U500.dsc` +`build -a RISCV64 -t GCC5 -p Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc`^M =A0 =A0## Supported Operating Systems =A0Only support to boot to EFI Shell so far. @@ -68,18 +67,18 @@ RISC-V related SMBIOS records to support the unified b= oot loader and OS image. =A0This library leverage the silicon libraries provided in Silicon/SiFive. =A0 =A0### RiscVPlatformTimerLib -This is common U5 series=A0 platform timer library which has the +This is common U5 series platform timer library which has the^M =A0platform-specific timer implementation. =A0 =A0### TimerDxe -This is U5 series=A0 platform timer DXE driver whcih has the platform-spe= cific +This is U5 series platform timer DXE driver which has the platform-specific^M =A0timer implementation. =A0 =A0## U500 Platform Libraries and Drivers -### RiscVOpnesbiPlatformLib +### RiscVOpensbiPlatformLib^M =A0In order to reduce the dependencies with RISC-V OpenSBI project -(https://github.com/riscv/opensbi) and less burdens to EDK2 build process= , the -implementation of RISC-V EDK2 platform is leverage platform source c= ode from +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build process, the^M +implementation of RISC-V EDK2 platform is leveraging platform source code from^M =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is cloned = from =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 bui= ld =A0environment. @@ -89,10 +88,10 @@ This is the platform-implementation specific library w= hich is executed in early =A0PEI phase for U500 platform initialization. =A0 =A0## U540 Platform Libraries and Drivers -### RiscVOpnesbiPlatformLib +### RiscVOpensbiPlatformLib^M =A0In order to reduce the dependencies with RISC-V OpenSBI project -(https://github.com/riscv/opensbi) and less burdens to EDK2 build process= , the -implementation of RISC-V EDK2 platform is leverage platform source c= ode from +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build process, the^M +implementation of RISC-V EDK2 platform is leveraging platform source code from^M =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is cloned = from =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 bui= ld =A0environment.