From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.4817.1587457324911491909 for ; Tue, 21 Apr 2020 01:22:05 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=0380a9ba4c=abner.chang@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03L8M35A011946; Tue, 21 Apr 2020 08:22:04 GMT Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 30hquj200e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Apr 2020 08:22:04 +0000 Received: from G4W9121.americas.hpqcorp.net (g4w9121.houston.hp.com [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 837E151; Tue, 21 Apr 2020 08:22:03 +0000 (UTC) Received: from G4W9120.americas.hpqcorp.net (2002:10d2:150f::10d2:150f) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 21 Apr 2020 08:22:03 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.11) by G4W9120.americas.hpqcorp.net (16.210.21.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 21 Apr 2020 08:22:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XS9mBie4oiNXnLrMudcLR6CBgKEMoonCP3ODGXgFJSxh3AJnn2XuzOml6JA6KJA9L40kFPAcBZFv42s/OfKHzA3VIVSXBD/NLnNA7lcdH1SZmTZx5tOVnNg/dAiw0Ae96ojTvEvWk35IO76gm30DnWwcFg796NCqxh9Su9MqoVuYlzNk2jR9wMuiFANEGHEyhbv/lc6DVqatlKTaR7GdsDfjGEpdE9PSTNLbnVIfTGgee+rRRtzpmcTQjBX2Aix5jIELWBrMkHPmToxYgjyf//8Kbp4+ppxGtNASVl9avcfsKF6iDqgAjagiY+6eP/BNNbaJblIZZQjJoZO0eDeJ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZR9F7OwlIbCZ4bpeXbbQnn+M/xw+UQ31rfME6SWThR0=; b=l9t7xTQr2ySE8XtDYddERloBEA0JjpR/Evv4WHHmpkm1bGvjIrSqiwSGoa1pMpWWXjhqK5QbHhhdvpOU1/1BSBMdQkEAaZfYCE/Lkn6uD/7nPaV7dp95R55yx710v8ZpQENWdrdbbyvQ6lVvryhO1bjDCv2eurPoy5U/4kB/+H3KhmqLZzudAY7G1dIN7m/vbrzkIITWkcFKGcgo91l8NpPuZr/kFEkDtnNficpKeguH0aoGJ5pY7W5FBQi10C2JGAknfb7jNyZsMlUNx5F7yKGI+3W4XPahJ0ZAcPw/iKlb+rLm6FlyK9+Lojyxtu1+4AUFGRu+JviCpmrYZOMwLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770a::14) by TU4PR8401MB0782.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 08:22:00 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::38ba:b525:f979:8411]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::38ba:b525:f979:8411%11]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 08:22:00 +0000 From: "Abner Chang" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Chen, Gilbert" , Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=>IoLibNoIo.c Thread-Topic: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename IoLibArm.c=>IoLibNoIo.c Thread-Index: AQHWDw3wHSF7shmXW0mvXfeUa5CIRqiDMDIAgAAdM3A= Date: Tue, 21 Apr 2020 08:21:59 +0000 Message-ID: References: <20200410072112.7310-1-abner.chang@hpe.com> <20200410072112.7310-6-abner.chang@hpe.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9a0b1fe4-2b73-457d-5216-08d7e5cd1061 x-ms-traffictypediagnostic: TU4PR8401MB0782: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1443; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(6029001)(366004)(396003)(376002)(39860400002)(136003)(346002)(54906003)(966005)(9686003)(6506007)(52536014)(8936002)(53546011)(110136005)(86362001)(33656002)(186003)(71200400001)(7696005)(66556008)(64756008)(66446008)(66946007)(66476007)(4326008)(26005)(76116006)(55016002)(2906002)(81156014)(8676002)(478600001)(5660300002)(19627235002)(316002);DIR:OUT;SFP:1102; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Iw00JOKTv08wtd61cxhpD5XntKKHitnQTBfyXaTdpnW9w8q5FnA0TcWtZFPZNkfhN0oKQSvFtfRwmOB7t96uYIS17hcofNrUME3TdO18gF0FT8rF9+1oq3PQl5g4xInUIqr5x1w1LbfDN/xH+x3X6YONBE84zrjW9oDOx02yYDjLUyK4Wl+DHbBwzAenqfzA19UZ3ujZQZMEtiMg0ft9ql/hBOM0Yvtprq849fEso4hL5xlMPWcPT+J8ag7ocyQ9zenKKFQW9Xgn9FccwURDmw1lt/o9//WOvXfuI46DwvojkaOmPPYysO/F3XG4w7p8Fl4GwwObHqyEYgTSeNs3lAGMrBoqPac/n4yTooX44BxAvrNxS53JsJN9fj7GmYs/tNa+Di87FYrJNqhmRgnt0eHFb1Uz+JotIqShkZ6l2xsehb6dJqsK+vmlQrN4vW13PH/Rd+vaP5RD38Tar940q+6tBa489vn3HhDzN9I3+gLAmPl/uS8gjqIIOvsmT7NlwkpDRUqG2OzwhMeCd5v7dw== x-ms-exchange-antispam-messagedata: xNbGS1yNUFBXqDR3vPxNsVnO4rjsSjEyXYRfmoMXOGGl+4RqPbtQuiKFBr6baBDqaQ38X/IrGKk4S1ph8sQZ79BlEASqxHWsEBbc02DV8f1/t+RBKsvsRQXvBLsiNd1ezXKLtfq2+BX0A0ilwgQDbQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 9a0b1fe4-2b73-457d-5216-08d7e5cd1061 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 08:22:00.0924 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5fZQSUWM6dIFanGHtK93DmxfTIsdaZ5RfXR0gu6qz/ogQEqbQKOpWxBoIOwxgLbB4QARv3fWqvFX9YSOg2g4HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0782 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-21_02:2020-04-20,2020-04-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 bulkscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=981 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004210070 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sure, the patch sent. > -----Original Message----- > From: Liu, Zhiguang [mailto:zhiguang.liu@intel.com] > Sent: Tuesday, April 21, 2020 2:36 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert ; Leif Lindholm > ; Kinney, Michael D > ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: > Rename IoLibArm.c=3D>IoLibNoIo.c >=20 > Hi Abner, >=20 > In BaseIoLibIntrinsic.inf, you add the line "This I/O library only provid= es non > I/O read and write." > I supposed this is a description for ARM and RISC-V but not for other arc= h. If > so, please specify it because this is an inf files all arch are using. >=20 > Thanks > Zhiguang >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Friday, April 10, 2020 3:21 PM > To: devel@edk2.groups.io > Cc: abner.chang@hpe.com; Gilbert Chen ; Leif > Lindholm ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2-devel] [PATCH v1 5/9] MdePkg/BaseIoLibIntrinsic: Rename > IoLibArm.c=3D>IoLibNoIo.c >=20 > RISC-V MMIO library instance. > IoLibArm.c in fact implements a generic Mmio-only (and ANSI C compliant), > so rename it to better reflect this. >=20 > Signed-off-by: Abner Chang > Co-authored-by: Gilbert Chen > Reviewed-by: Leif Lindholm >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Leif Lindholm > Cc: Gilbert Chen > --- > .../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 12 ++++++++---- > .../BaseIoLibIntrinsic/{IoLibArm.c =3D> IoLibNoIo.c} | 4 +++- > 2 files changed, 11 insertions(+), 5 deletions(-) rename > MdePkg/Library/BaseIoLibIntrinsic/{IoLibArm.c =3D> IoLibNoIo.c} (94%) >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > index 457cce9378..cc23b6b227 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > +++ b/MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf > @@ -4,11 +4,12 @@ > # I/O Library that uses compiler intrinsics to perform IN and OUT instr= uctions >=20 > # for IA-32 and x64. On IPF, I/O port requests are translated into MMIO > requests. >=20 > # MMIO requests are forwarded directly to memory. For EBC, I/O port > requests >=20 > -# ASSERT(). >=20 > +# ASSERT(). This I/O library only provides non I/O read and write. >=20 > # >=20 > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
>=20 > # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved. >=20 > # Copyright (c) 2017, AMD Incorporated. All rights reserved.
>=20 > +# Portions Copyright (c) 2020, Hewlett Packard Enterprise Development > +LP. All rights reserved.
>=20 > # >=20 > # SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > # >=20 > @@ -25,7 +26,7 @@ >=20 >=20 >=20 >=20 > # >=20 > -# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 >=20 > +# VALID_ARCHITECTURES =3D IA32 X64 EBC ARM AARCH64 RISCV64 >=20 > # >=20 >=20 >=20 > [Sources] >=20 > @@ -50,10 +51,13 @@ > IoLib.c >=20 >=20 >=20 > [Sources.ARM] >=20 > - IoLibArm.c >=20 > + IoLibNoIo.c >=20 >=20 >=20 > [Sources.AARCH64] >=20 > - IoLibArm.c >=20 > + IoLibNoIo.c >=20 > + >=20 > +[Sources.RISCV64] >=20 > + IoLibNoIo.c >=20 >=20 >=20 > [Packages] >=20 > MdePkg/MdePkg.dec >=20 > diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c > b/MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c > similarity index 94% > rename from MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c > rename to MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c > index c6b822461d..a107136a74 100644 > --- a/MdePkg/Library/BaseIoLibIntrinsic/IoLibArm.c > +++ b/MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c > @@ -1,9 +1,11 @@ > /** @file >=20 > - I/O Library for ARM. >=20 > + I/O library for non I/O read and write access (memory map I/O read > + and >=20 > + write only) architecture, such as ARM and RISC-V processor. >=20 >=20 >=20 > Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
>=20 > Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
>=20 > Copyright (c) 2017, AMD Incorporated. All rights reserved.
>=20 > + Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > + rights reserved.
>=20 >=20 >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 >=20 > -- > 2.25.0 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#57196): > INVALID URI REMOVED > 3A__edk2.groups.io_g_devel_message_57196&d=3DDwIFAg&c=3DC5b8zRQO1mi > GmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3D > rVdRjG1eBpmch18toKBbAIlRU4fAwHIsbtEYLYFhwUE&s=3DpXz- > X2DE2r73AHeQBAwm_1RBEn4M1sUO2xEdist-lPc&e=3D > Mute This Topic: INVALID URI REMOVED > 3A__groups.io_mt_72916363_1779286&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeV > Z2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DrVdRjG > 1eBpmch18toKBbAIlRU4fAwHIsbtEYLYFhwUE&s=3DFkqJ3_oaBXUSqJnn0oSAlYn > JyzfWrjAtjcTikwfmdF8&e=3D > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: INVALID URI REMOVED > 3A__edk2.groups.io_g_devel_unsub&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2 > LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DrVdRjG1e > Bpmch18toKBbAIlRU4fAwHIsbtEYLYFhwUE&s=3DedTt4syYvJQgTughhd_lU6FCY > a1INKJvH-5llF4LAg0&e=3D [zhiguang.liu@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D