From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.60033.1584325010060326098 for ; Sun, 15 Mar 2020 19:16:50 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=034405edd7=abner.chang@hpe.com) Received: from pps.filterd (m0134425.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02G2GKXf006653; Mon, 16 Mar 2020 02:16:49 GMT Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0b-002e3701.pphosted.com with ESMTP id 2yrsvea25k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2020 02:16:49 +0000 Received: from G4W10205.americas.hpqcorp.net (g4w10205.houston.hpecorp.net [16.207.82.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id D016559; Mon, 16 Mar 2020 02:16:47 +0000 (UTC) Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G4W10205.americas.hpqcorp.net (2002:10cf:520f::10cf:520f) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 16 Mar 2020 02:16:47 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.12) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 16 Mar 2020 02:16:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T26BExBKTCQKDRgfOt6n54KsQyjQ9KnF/etOOqxHK8Pq7l8KxHqnIvbe1Gvlpn3g/qQ0jFlq61nQhC6/XwjVu3KxUYrICt9maEzt1PC8ffE/gb9jFgJoCApGobD+PfCwykpwlT3EACZ5z8M5IR9BPzslJSY0KGGKWok1c7wncwEwUbicQM56oF/fD52mRRXqAHWNLc4sVkSFCxj+9tNpO3i1AabALReQduDlx89ySiZJihymyArZgaA/7ogD5PBpI23rHxm6+MlEl8TwP9lTXH+8e0u0z5jBg+Wi6obl6nt7KHb6lcqbgu3FB2R9sNpQ11Fu+vvZt1gd38wRToEy0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FKM7CW+AItFAkmGEk2FoUAAkeaefwKTCEq4F5G0IuYg=; b=LZgfpP5nFTzUT88wRKloxdrWn5akCpsqGW9Ef/ndnN0ck3er5GmayqSRsP7rUfFqxrvvNPQmSgcWNxwsg/zUy94pNeTPsiLD18Qn0hoUNHCdw8qMTyXEn9qvXvSXcMv7lebn32J1Vw6nybBWTRCpzkvuXAuRYnr+rK19c7zMoHZPdc+fzNrzCgltOgO0T6hIimvEwMkoC1BcubxysdRNSquhlbluCm23ObTbF8+PdtxCTKTr/AOMBx0jTvkrAviviqFQK7uPcFP+cjw76nh1NMWkuvwyucF1803LjuD0CdoQcxoFcHoV4fiUESOnPxUd+F7lcKIEmADJXXkTzqC3gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770a::14) by TU4PR8401MB1118.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7714::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.14; Mon, 16 Mar 2020 02:16:39 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402%6]) with mapi id 15.20.2814.021; Mon, 16 Mar 2020 02:16:39 +0000 From: "Abner Chang" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" , "Ard Biesheuvel" , Laszlo Ersek , "Schaefer, Daniel (DualStudy)" , "Chen, Gilbert" Subject: Re: [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl Thread-Topic: [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl Thread-Index: AQHV9gKNTZUt57D7iEiSzh6XMbFAVqhKeSQAgAAEGtA= Date: Mon, 16 Mar 2020 02:16:39 +0000 Message-ID: References: <20200309102740.8591-1-abner.chang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D7A9FA@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40D7A9FA@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5cb73b3e-a17d-4669-ba70-08d7c9500faa x-ms-traffictypediagnostic: TU4PR8401MB1118: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 03449D5DD1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(376002)(39860400002)(136003)(346002)(199004)(7696005)(478600001)(4326008)(8936002)(8676002)(26005)(64756008)(2906002)(66556008)(66446008)(86362001)(5660300002)(76116006)(19627235002)(9686003)(53546011)(71200400001)(52536014)(66946007)(6506007)(33656002)(316002)(110136005)(66476007)(81156014)(966005)(55016002)(81166006)(54906003)(186003)(213903007);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1118;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nKOjMWEbiwxTSvwj00W4lSPGyUNjdGnONG9Cy+1xIUyT1qrnsiCLA5S0xOkSBwB9SGUTruQYuFyor9v3rLGGSbb7UPS2C3K9FBCcNaJFjx/lI3HHeIboeWRmR+N/3klv96dq44zRDkcWViqRZFLz/A7uw4ORiuLMuwSmFxnMEdwK3tAaX1lzoPEEML1APwOfY0AtVnGueJPd1us8988i7QN3rpb3dkg1U/Ylw+ujiEc1H8qWnmmCnzvGXrGZvrGdJymm65r8uNTwGt2leu/0aNPMYar28ARLeU1fOc9pXdHXFpRY6BKJzAoGTmXDJrprKTl5HUBYXZWn1zA2EPqb6cGJel7POKeeykm3z1g+3LS8BWtchYsbyHLYRbxzm/XRM4KtOO9arOT9FgcZQnL7UaksVPM20jU/cQIfZ8imTRoNTWRFgYCstKN9eM3kLrijkbbVjWiRq8Ofu1cc7OFJeSgYNCwitX6VS2YP1ak2GBsPFm3Ly7f14m7HNpvqPVt8BovhX3zYd0kZWrycLS0fiIE/MaHZjpvv11G6QtyewuL6suk5I6zUDLgZsjP6lSj8h3LQH+40XH9zzjzsNd/wxw== x-ms-exchange-antispam-messagedata: PQM2tqqoPBVnqprkEoOpmQQLhKzwYutGeELAndoMqF7TFJ6eEpNn8lsNXnkgM0PNHCfwuvStr0jEUxbgDL4JWQfhpBhyGOLojY++01GP8BXZ+QODmH+28xWOBtZD3tNOVOpk5Gm7whh2yVljvTuKpQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb73b3e-a17d-4669-ba70-08d7c9500faa X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2020 02:16:39.1799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WW1tTXJKCAoHUTUe/4UJjRcdlPc0R5wOWKKbCPvMt+XCty+t0tJTlhTCx6Y7vYQKoyawSQRZm7m9aenuF6BbeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1118 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-15_05:2020-03-12,2020-03-15 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 mlxscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160009 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Bi, Dandan [mailto:dandan.bi@intel.com] > Sent: Monday, March 16, 2020 9:31 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > ; Gao, Liming ; Ard > Biesheuvel ; Laszlo Ersek ; > Schaefer, Daniel (DualStudy) ; Chen, Gilbert > > Subject: RE: [edk2/master PATCH DxeIplHandoffLib v1] > MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl >=20 > Hi Abner, >=20 > Some comments as below. >=20 > 1. For the patch itself > a) it introduces a new library class, so besides the instance, we also n= eed to > add the header file (public interface definitions) in the include/library > directory and define the library class in dec file. > b) EFIAPI keyword should be added with the public API definition > ( HandOffToDxeCore). Ok. Will resend the patch. >=20 > 2. This path is just to add an empty instance for now. > Abner, will you also add other instances for other Archs and update DxeIp= l to > consume the new library? The purpose of this change is to abstract arch from DxeIpl module under Mde= ModulePkg and remove the dependencies with arch package from MdeModulePkg.c= i.yaml.=20 Yes, I already added an instance for RISC-V and revised DxeIpl to consume n= ew lib *only* for RISCV64 arch, this change will be in the set of RISC-V e= dk2 patches. The patch you are reviewing now is the prerequisite for RISC-V= edk2 port. > And for platform, it's incompatible change to use new added library insta= nce. > So it's better review it in TianoCore Design Meeting firstly. It will stay the same for X86, ARM may have to use this NULL instance and r= emove the dependencies from MdeModulePkg.ci.yaml as well. However, I can't = speak for ARM because the dependence with ARM package in MdeModulePkg has b= een in MdeModulePkg.ci.yaml when edk2 CI was introduced (my guess, not sure= the history). RISCV64 is a new arch and was requested to be decoupled from= MdeModulePkg. This change don't bring incompatible issue though. ARM arch= can still stay the same as it is in edk2 now. >=20 >=20 >=20 > Thanks, > Dandan > > -----Original Message----- > > From: Abner Chang [mailto:abner.chang@hpe.com] > > Sent: Monday, March 9, 2020 6:28 PM > > To: devel@edk2.groups.io > > Cc: abner.chang@hpe.com; Leif Lindholm ; Kinney, > > Michael D ; Gao, Liming > > ; Ard Biesheuvel ; > > Laszlo Ersek ; Bi, Dandan ; > > Daniel Schaefer ; Gilbert Chen > > > > Subject: [edk2/master PATCH DxeIplHandoffLib v1] > > MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl > > > > BZ:2583: > > INVALID URI REMOVED > > e.org_show-5Fbug.cgi-3Fid- > 3D2583&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_ > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DYQR7NX_kxz4BPRET > p5nNLWWOK > > > NOimkostEzdrvyvPkA&s=3D7wyyAOitp2IvMKv19tlpbJxt2m0bn_ZsR4R7llYI19c& > e=3D > > > > Current DxeIpl has bindings for different processor architectures, > > this results in MdeModulePkg has the dependence with processor > > architecture packages such as ArmPkg or RiscVPkg. This also leads CI > > testing to error during package dependency check. Provide a default > > DxeIplHandoff library to abstract processor architecture from DxeIpl > > driver, platform can provide its own library instance for the processor > architecture- specific implementation. > > > > Signed-off-by: Abner Chang > > > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Ard Biesheuvel > > Cc: Laszlo Ersek > > Cc: Dandan Bi > > Cc: Daniel Schaefer > > Cc: Gilbert Chen > > --- > > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > > .../DxeIplHandoffLibNull.inf | 30 +++++++++++++++++ > > .../DxeIplHandoffLibNull.c | 33 +++++++++++++++++++ > > .../DxeIplHandoffLibNull.uni | 14 ++++++++ > > 4 files changed, 79 insertions(+) > > create mode 100644 > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > create mode 100644 > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > create mode 100644 > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc index f7dbb27ce2..6eb922dfaa > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -3,6 +3,7 @@ > > # # (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> > # Copyright (c) 2007 - 2019, Intel Corporation. All rights > > reserved.
+# Copyright (c) 2020, Hewlett Packard Enterprise > Development LP. All rights > > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ - > > 321,6 +322,7 @@ > > MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf > > > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateP > > rogressLibGraphics.inf > > > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr > > essLibText.inf+ > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp > > p.infdiff --git > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > new file mode 100644 > > index 0000000000..b7210656b7 > > --- /dev/null > > +++ > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > @@ -0,0 +1,30 @@ > > +## @file+# Null DXE IPL handoff to DXE Core Library instance.+#+# > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > rights reserved.
+#+# SPDX-License-Identifier: BSD-2-Clause- > > Patent+#+##++[Defines]+ INF_VERSION =3D 0x0001001b+ > > BASE_NAME =3D DxeIplHandoffLibNull+ MODULE_UNI_FI= LE > > =3D DxeIplHandoffLibNull.uni+ FILE_GUID =3D 5c188= 12d-3684-4093- > > bc75-fc846a595353+ MODULE_TYPE =3D BASE+ VERSION_S= TRING > > =3D 1.0+ LIBRARY_CLASS =3D DxeIplHandoffLib++#+# The = following > > information is for reference only and not required by the build tools.+= #+# > > VALID_ARCHITECTURES =3D RISCV64+#++[Sources]+ > > DxeIplHandoffLibNull.c++[Packages]+ MdePkg/MdePkg.dec+diff --git > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > new file mode 100644 > > index 0000000000..c83922cb6e > > --- /dev/null > > +++ > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > @@ -0,0 +1,33 @@ > > +/** @file+ NULL instance of DXE IPL handoff to DXE Core Library.++ > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > rights reserved.
++ SPDX-License-Identifier: BSD-2-Clause- > > Patent++**/++#include +#include ++/**+ > > Transfers control to DxeCore.++ This function performs a CPU architec= ture > > specific operations to execute+ the entry point of DxeCore with the > > parameters of HobList.+ It also installs EFI_END_OF_PEI_PPI to signal= the > > end of PEI phase.++ @param DxeCoreEntryPoint The entry point = of > > DxeCore.+ @param HobList The start of HobList passe= d to > > DxeCore.++**/+VOID+HandOffToDxeCore (+ IN EFI_PHYSICAL_ADDRESS > > DxeCoreEntryPoint,+ IN EFI_PEI_HOB_POINTERS HobList+ )+{+ DEBUG > > ((DEBUG_INFO, "No implementation of DXE IPL handoff to DXE Core > > library.\r\n"));+ ASSERT (FALSE);+}+diff --git > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > new file mode 100644 > > index 0000000000..5a8973d6e5 > > --- /dev/null > > +++ > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > @@ -0,0 +1,14 @@ > > +// /** @file+// Null DXE IPL handoff to DXE Core Library > > +instance.+//+// > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > rights reserved.
+//+// SPDX-License-Identifier: BSD-2-Clause- > Patent+//+// > > **/+++#string STR_MODULE_ABSTRACT #language en-US "Null DXE > > IPL handoff to DXE Core Library instance."++#string > > STR_MODULE_DESCRIPTION #language en-US "Null DXE IPL handoff to > > DXE Core Library instance."+-- > > 2.25.0