From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.4454.1583992839837859459 for ; Wed, 11 Mar 2020 23:00:39 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=034068b444=abner.chang@hpe.com) Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02C5wOf2023639; Thu, 12 Mar 2020 06:00:39 GMT Received: from g9t5008.houston.hpe.com (g9t5008.houston.hpe.com [15.241.48.72]) by mx0a-002e3701.pphosted.com with ESMTP id 2yq4ahv910-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Mar 2020 06:00:39 +0000 Received: from G1W8107.americas.hpqcorp.net (g1w8107.austin.hp.com [16.193.72.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5008.houston.hpe.com (Postfix) with ESMTPS id 6C03553; Thu, 12 Mar 2020 06:00:38 +0000 (UTC) Received: from G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) by G1W8107.americas.hpqcorp.net (2002:10c1:483b::10c1:483b) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 12 Mar 2020 06:00:38 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (15.241.52.12) by G4W9119.americas.hpqcorp.net (16.210.20.214) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 12 Mar 2020 06:00:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aA7mJfuWG3gUEbF3a8bxS048xtEh4nxNRCXDmD3pODM6Yox/9PZKYBNA/3w6eD75ATz10HqbKDR+I5IYf7wLO/dupZ5w7i/9Y5R/rRf8dXDKL50uub1CjC24Za8Q4DhvIqemLLH951DS80uiqviysD/vCJaXY/pnUZ9CxiLtcDmj9EZq9XSXSp2klweyy5a3OKif4eunNQVmn0GXIjQ86vobtXokStIne0+mDq06+3MmvEKDp8s5k1mIOI2Vy41kvvPQPZ5SMNuWK9qOB87s4QdvB94MkZLoqi78KS6/Y4FBwd+yP17o5Q5gCDY6KkzFk2lCuI2j37xH9B1JbO1aeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JidQp7lfcMK4BcfXa7OAG9JjgAnWYdoNBcmRBgRDpXY=; b=UxjN/XICexulA8RrnmmcmO66NJ5DQSEmNPAx4NlQpLsMSsAo5qRPSeO8hIr6FhliQJldVKGr5lMsGHmpjo1N1QfopgW/lH3Cr6o1YwXyumOeW6LziHparu4KfAD13dnGFxA/o0qW5jrqgoV7hlk+CJ+s5tmtKociwClIdH1+GxKHBtO+6R/pwyLXw85HejdBIEZxgq7A7GWx78CmU9H+SGZuuda8jD1A4TXB/rV/AlrL0ibqQtedhSRz1QTyRcU2tIO2P7oYYANUo1+qlXN6O9AJmLSigT6fOlvuMo3kCW2FtBE3wNALh8kRkmQfj97iXecszPeDZ8UGeyZonPrVew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770a::14) by TU4PR8401MB1181.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7716::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.20; Thu, 12 Mar 2020 06:00:36 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402%6]) with mapi id 15.20.2793.018; Thu, 12 Mar 2020 06:00:36 +0000 From: "Abner Chang" To: "Wang, Jian J" , "devel@edk2.groups.io" , "Bi, Dandan" , "Schaefer, Daniel (DualStudy)" CC: "Chen, Gilbert" , Leif Lindholm , "Dong, Eric" Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Thread-Topic: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Thread-Index: AQHV8H3y8ONhWG4a20uPbA3rSjizB6g5LCkAgAtZP4CAAAB2xA== Date: Thu, 12 Mar 2020 06:00:36 +0000 Message-ID: References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-4-daniel.schaefer@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D6BDA4@SHSMSX104.ccr.corp.intel.com>, In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [223.137.77.203] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ac637cf6-37de-48da-dbe6-08d7c64aaf36 x-ms-traffictypediagnostic: TU4PR8401MB1181: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:18; x-forefront-prvs: 0340850FCD x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(136003)(346002)(376002)(396003)(39860400002)(199004)(6636002)(2906002)(966005)(8936002)(86362001)(316002)(478600001)(81166006)(81156014)(8676002)(26005)(110136005)(54906003)(186003)(71200400001)(9686003)(91956017)(4326008)(66556008)(66476007)(52536014)(45080400002)(6506007)(53546011)(66946007)(7696005)(33656002)(5660300002)(55016002)(66446008)(64756008)(76116006);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1181;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: T61ARaeWAqDqu/xeGRWkcGBj4Q/itI1hniiI8UKWlf8Q+tqA4Bx3GU7bWN2lIX5poWpyhIOLZkVdN8oUrstXDP3/W0WVYXbjj6A/wZztqIx6jg8dBxWTKNZ9EcjjHkUv4/KUnhMTCnlGZYAaZiTpOK4gCWljUENjpEddFCJhd1oT+VkuQkHsbIMUBW2aVXYfNrQ0VCaWGslS5qJpRkJ7FKg33Qd8IboVAlzUaDhMrEBY38FqUscmerQJDgXjci1uxPpmkIfLoDfoalsY/Kn4xjK/i29ROPHyC8qz5thAh/NQ8PW5kVR7IfiRTelN9DiL4R7NojT9LFr7X28KoMGV5HjKIOkH7/Jl/qtO6Ef6jzFzQU/yBABmvG+67cjBXpYjC+VALOOQ6vndN9oj2H4szTe5RG1hvg/Li6RzbCrASYr3u+auxcVoXO9QOcw+aSAMmjypeogae8WGp0sFgOkFrO1C/3Shy3Jkq1M8gS/HJ8jQbYl9HCmUqX6m4KjietfMGz5noCOlEhltPrnG3+mxoA== x-ms-exchange-antispam-messagedata: 406kjieJ/L9aKyAh+1oyvbj9s4Fz2ErCvhJht9NVjiKIWJHEa7XVTOl5WGxoYNB4qUWaQl8pq8shNj63HFhiaGy0XUKvC3pnNyTRZyk+TQf7ZvfSX3YFslpjDbMiWARTt/XC1jAfwXempYal5auhxw== X-MS-Exchange-CrossTenant-Network-Message-Id: ac637cf6-37de-48da-dbe6-08d7c64aaf36 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2020 06:00:36.4072 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hFiNwqsY6uU52lPY+t4IM9qbH72yl5HGTmj81WDOJcOffRSTp/RtZJZFvIcFqJdaykpJ4NxvkpBpozKNe1L+dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1181 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 10 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-11_15:2020-03-11,2020-03-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120031 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_TU4PR8401MB0429596EB6D595B3E570527AFFFD0TU4PR8401MB0429_" --_000_TU4PR8401MB0429596EB6D595B3E570527AFFFD0TU4PR8401MB0429_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Appreciated, Jian J. Get Outlook for Android ________________________________ From: Wang, Jian J Sent: Thursday, March 12, 2020 1:58:05 PM To: devel@edk2.groups.io ; Bi, Dandan ; Schaefer, Daniel (DualStudy) Cc: Chang, Abner (HPS SW/FW Technologist) ; Chen, Gil= bert ; Leif Lindholm ; Dong, Eric = Subject: RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead= of GUID assignment Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680 Regards, Jian > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Thursday, March 05, 2020 8:40 AM > To: Daniel Schaefer ; devel@edk2.groups.io > Cc: Abner Chang ; Gilbert Chen > ; Leif Lindholm ; Dong, Eric > > Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem > instead of GUID assignment > > Reviewed-by: Dandan Bi > > > Thanks, > Dandan > > -----Original Message----- > > From: Daniel Schaefer [mailto:daniel.schaefer@hpe.com] > > Sent: Monday, March 2, 2020 6:33 PM > > To: devel@edk2.groups.io > > Cc: Abner Chang ; Gilbert Chen > > ; Leif Lindholm ; Bi, Dandan > > ; Dong, Eric > > Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID > > assignment > > > > GCC translates a simple assignment to memcpy, which EDKII doesn't prov= ide. > > See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.htm= l > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547 > > > > Signed-off-by: Daniel Schaefer > > Cc: Abner Chang > > Cc: Gilbert Chen > > Cc: Leif Lindholm > > Cc: Dandan Bi > > Cc: Eric Dong > > --- > > > > Notes: > > v2: > > - Use CopyMem instead of CopyGuid [Dandan] > > > > MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > index 5cc527679a78..0540e6fa8a44 100644 > > --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > @@ -619,7 +619,7 @@ CreateDeviceManagerForm( > > TokenHelp =3D HiiSetString (HiiHandle, 0, String, NULL); > > > > FreePool (String); > > > > > > > > - FormSetGuid =3D ((EFI_IFR_FORM_SET *)Ptr)->Guid; > > > > + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, siz= eof > > (EFI_GUID)); > > > > > > > > // > > > > // Network device process > > > > -- > > 2.25.0 > > >=20 --_000_TU4PR8401MB0429596EB6D595B3E570527AFFFD0TU4PR8401MB0429_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Appreciated, Jian J.
From: Wang, Jian J <jia= n.j.wang@intel.com>
Sent: Thursday, March 12, 2020 1:58:05 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>; Bi, Dandan &= lt;dandan.bi@intel.com>; Schaefer, Daniel (DualStudy) <daniel.schaefe= r@hpe.com>
Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com&g= t;; Chen, Gilbert <gilbert.chen@hpe.com>; Leif Lindholm <leif@nuvi= ainc.com>; Dong, Eric <eric.dong@intel.com>
Subject: RE: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem = instead of GUID assignment
 
Pushed @ 64a228f5f89320fd632bb6c55e154961f2410680=

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of = Dandan Bi
> Sent: Thursday, March 05, 2020 8:40 AM
> To: Daniel Schaefer <daniel.schaefer@hpe.com>; devel@edk2.group= s.io
> Cc: Abner Chang <abner.chang@hpe.com>; Gilbert Chen
> <gilbert.chen@hpe.com>; Leif Lindholm <leif@nuviainc.com>= ; Dong, Eric
> <eric.dong@intel.com>
> Subject: Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem > instead of GUID assignment
>
> Reviewed-by: Dandan Bi <dandan.bi@intel.com>
>
>
> Thanks,
> Dandan
> > -----Original Message-----
> > From: Daniel Schaefer [mailto:daniel.schaefer@hpe.com]
> > Sent: Monday, March 2, 2020 6:33 PM
> > To: devel@edk2.groups.io
> > Cc: Abner Chang <abner.chang@hpe.com>; Gilbert Chen
> > <gilbert.chen@hpe.com>; Leif Lindholm <leif@nuviainc.co= m>; Bi, Dandan
> > <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com&= gt;
> > Subject: [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUI= D
> > assignment
> >
> > GCC translates a simple assignment to memcpy, which EDKII doesn'= t provide.
> > See: https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__www.mail-2Darchive.= com_edk2-2Ddevel-40lists.01.org_msg11928.html&d=3DDwIFAg&c=3DC5b8zR= QO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m= =3DqsK4hsWLOpM-1nZt2HfGb1E4kXmVxp4jkftrFuHTN28&s=3DZonntN3tqpPe93R8wS9= 7gWaVOO-PKkJxBK02ksvSU6Y&e=3D
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547
> >
> > Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com> > > Cc: Abner Chang <abner.chang@hpe.com>
> > Cc: Gilbert Chen <gilbert.chen@hpe.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Dandan Bi <dandan.bi@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > ---
> >
> > Notes:
> >     v2:
> >       - Use CopyMem instead of Cop= yGuid [Dandan]
> >
> >  MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | = 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManag= er.c
> > b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c
> > index 5cc527679a78..0540e6fa8a44 100644
> > --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c > > +++ b/MdeModulePkg/Library/DeviceManagerUiLib/Device= Manager.c
> > @@ -619,7 +619,7 @@ CreateDeviceManagerForm(
> >          TokenHelp = = =3D HiiSetString (HiiHandle, 0, String, NULL);
> >
> >          FreePool (= String);
> >
> >
> >
> > -        FormSetGuid =3D ((EF= I_IFR_FORM_SET *)Ptr)->Guid;
> >
> > +        CopyMem (&Fo= rmSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, sizeof
> > (EFI_GUID));
> >
> >
> >
> >          //
> >
> >          // Network= device process
> >
> > --
> > 2.25.0
>
>
>

--_000_TU4PR8401MB0429596EB6D595B3E570527AFFFD0TU4PR8401MB0429_--