From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.28424.1585185162237152449 for ; Wed, 25 Mar 2020 18:12:42 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=035412e884=abner.chang@hpe.com) Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02Q10deF027575; Thu, 26 Mar 2020 01:12:41 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2yyfwyenck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 Mar 2020 01:12:41 +0000 Received: from G4W9119.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 8AB4C88; Thu, 26 Mar 2020 01:12:40 +0000 (UTC) Received: from G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 26 Mar 2020 01:12:40 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (15.241.52.13) by G4W9121.americas.hpqcorp.net (16.210.21.16) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 26 Mar 2020 01:12:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UakKSioNZlaAzAERzXRrKeDofCFDnPQaBZO7bDTyRfhz8t6aC7Rj6KK4SiH2tT7YORHU9SgHcjSTU1eh4JRs1yMiZ4h2iXD7rWH3v5fHgJE/WAqfMxhV0hH0xZ5ZC3hH72Xpbn2pfzwDoYfJww8NiHAxl2MuIhSNnkLbUaPf5R0oWO43cF4pScjZZ8orM62eCl6ZdA4txB+RqeOA/lwxnJyRC00J7hj5hwugog1szxLTEEo0GEqwe28SnWibgm3fc3LIBNQGTevD2DBesUv6KLpxwFOcOibgMkUi1C9z0KVlsU4xuWvsI7HDcX8zReSx76mufeWlay15QqYzJXFu6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oNCSLrTkCVJvuApLcJneMQPn04jp4FgVqb9ppYBXT0I=; b=XvDHD0k1F8BiBkuYyu2gQ+qbBYGXYC3vgU9zIaAvwIlmEGAMovYroWSaQHGu8W8/ztHIgXPz7oZ73rHAZQJR9LDagrM+drGfK2yYi8gClLRGsm3YGx36b8grw00f9p3tr+k2HfZwZ6vFm67sgD8BJJQJBY2AQLmuOgI7py2AHFP2zoSMkueXsX/Vo9P6VQl/OBFKge9HSHyfcwW2SjiAJSIwe6sJ0jdPU03SbdT5+pKJYv0EB0n0VYvj2AW6PqLP5xSSd/WwUuE+pRwfMbo22LWRfSHw4A+SB53WelnnK9ijldb6E0CKSXGuz7Cf3Qr+gJU59F77P6HXVHWLvx3+aA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:770a::14) by TU4PR8401MB1087.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.22; Thu, 26 Mar 2020 01:12:38 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402%6]) with mapi id 15.20.2835.023; Thu, 26 Mar 2020 01:12:38 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "Chang, Abner (HPS SW/FW Technologist)" , "Bi, Dandan" CC: Leif Lindholm , "Kinney, Michael D" , "Gao, Liming" , "Ard Biesheuvel" , Laszlo Ersek , "Schaefer, Daniel (DualStudy)" , "Chen, Gilbert" Subject: Re: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl Thread-Topic: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl Thread-Index: AQHV+zj5bczUrmzZb0e3ScTV1sNhPahaIC1w Date: Thu, 26 Mar 2020 01:12:38 +0000 Message-ID: References: <20200309102740.8591-1-abner.chang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D7A9FA@SHSMSX104.ccr.corp.intel.com> <15FCA733F3A77F98.14939@groups.io> In-Reply-To: <15FCA733F3A77F98.14939@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9e243bd8-5068-4ab5-8878-08d7d122c666 x-ms-traffictypediagnostic: TU4PR8401MB1087: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1079; x-forefront-prvs: 0354B4BED2 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(366004)(396003)(376002)(346002)(136003)(39860400002)(4326008)(26005)(55016002)(186003)(81156014)(66556008)(66476007)(66946007)(19627235002)(2906002)(66446008)(64756008)(81166006)(33656002)(8676002)(8936002)(9686003)(30864003)(52536014)(5660300002)(478600001)(53546011)(6506007)(316002)(7696005)(54906003)(110136005)(71200400001)(966005)(76116006)(86362001)(213903007)(473944003);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB1087;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eOjVb70H/0TFShVaULnt/0FsDyYVETJHPPqEdIre/OmIgqIr7Fhb7pjtHNqddU2bgIfy2NzASoFZ+qV6xzFqAjEWxLLa5kP1ZM0NPIBGfGW98B9VdkaHdCOCQqKgBD9qu9BiOhgU61BOeqEySAhGc5noeBzMuU/5FDheFkuFUFz+ZAABm9AJ7RjEBLgx7Fx8pQYC5gQ8mMxxMEU4J7VpwPdA+66BOZioJGmrksnf3BdU5skqJJOtglT9BHh2cdAGnJ6VSLlWZfdKv36bBJqQFVDcT6iNh1X2ok3peSVgSHQNuM3i/U7ZjBrG2gByuEYgziULkf8gMMNmEvEuf800zxL+ZVQfqAbwlPvB3bnhb43khgYz7S0vOuu8bLCzWVktX4bqyqyfrU1mCiOFu/TLSZnnjhHmt3c57hQ4JQRVrDhLgjVD/ehduCGX4pIJwWfamwUaYaI0VdJ/5ieGcyEjs0/B/o0BVeDWqoGVkvAT3GjSBgxKEtpGktO3gvPSKyGYVfJ1/LOJvATVBJFa+4wT9fnxEZBQMJ7IF7XWygNLDmFo5W+9wreEZhrIQBfOVUcib5RTOFH4lU848o4+iE/2xvKCWTRqAVexE1AfeH5dPrQ= x-ms-exchange-antispam-messagedata: qejWcJiJASMnLmxvAbCK3yO9ik+RAYotNcbF2+J/E/8gYXDF301P+oEwvmZd8kQe3CfMtiDglU8J3V+h5hRVY6FuCTltZjhdKM8lcPcFY8ALLf5nk8LPc07oc4FnBB8SSIoL+GpPtb6/e3VkYedmlA== X-MS-Exchange-CrossTenant-Network-Message-Id: 9e243bd8-5068-4ab5-8878-08d7d122c666 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2020 01:12:38.2606 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n+659B4O0My6nu4urrSUIuWz9zm0YTcMVdUDHrIb+FcEQg78cMg+OXxwG+EluL5V07ODr0IToPCfjNJsyXey+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1087 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.645 definitions=2020-03-25_13:2020-03-24,2020-03-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260005 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Dandan, We can just halt this patch for now, we are looking for the alternative. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Monday, March 16, 2020 10:17 AM > To: Bi, Dandan ; devel@edk2.groups.io > Cc: Leif Lindholm ; Kinney, Michael D > ; Gao, Liming ; Ard > Biesheuvel ; Laszlo Ersek = ; > Schaefer, Daniel (DualStudy) ; Chen, Gilbert > > Subject: Re: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] > MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl >=20 >=20 >=20 > > -----Original Message----- > > From: Bi, Dandan [mailto:dandan.bi@intel.com] > > Sent: Monday, March 16, 2020 9:31 AM > > To: Chang, Abner (HPS SW/FW Technologist) ; > > devel@edk2.groups.io > > Cc: Leif Lindholm ; Kinney, Michael D > > ; Gao, Liming ; Ard > > Biesheuvel ; Laszlo Ersek > > ; Schaefer, Daniel (DualStudy) > > ; Chen, Gilbert > > Subject: RE: [edk2/master PATCH DxeIplHandoffLib v1] > > MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl > > > > Hi Abner, > > > > Some comments as below. > > > > 1. For the patch itself > > a) it introduces a new library class, so besides the instance, we > > also need to add the header file (public interface definitions) in the > > include/library directory and define the library class in dec file. > > b) EFIAPI keyword should be added with the public API definition ( > > HandOffToDxeCore). > Ok. Will resend the patch. >=20 > > > > 2. This path is just to add an empty instance for now. > > Abner, will you also add other instances for other Archs and update > > DxeIpl to consume the new library? > The purpose of this change is to abstract arch from DxeIpl module under > MdeModulePkg and remove the dependencies with arch package from > MdeModulePkg.ci.yaml. > Yes, I already added an instance for RISC-V and revised DxeIpl to consum= e > new lib *only* for RISCV64 arch, this change will be in the set of RISC= -V edk2 > patches. The patch you are reviewing now is the prerequisite for RISC-V = edk2 > port. >=20 > > And for platform, it's incompatible change to use new added library > instance. > > So it's better review it in TianoCore Design Meeting firstly. > It will stay the same for X86, ARM may have to use this NULL instance an= d > remove the dependencies from MdeModulePkg.ci.yaml as well. However, I > can't speak for ARM because the dependence with ARM package in > MdeModulePkg has been in MdeModulePkg.ci.yaml when edk2 CI was > introduced (my guess, not sure the history). RISCV64 is a new arch and w= as > requested to be decoupled from MdeModulePkg. This change don't bring > incompatible issue though. ARM arch can still stay the same as it is in = edk2 > now. >=20 > > > > > > > > Thanks, > > Dandan > > > -----Original Message----- > > > From: Abner Chang [mailto:abner.chang@hpe.com] > > > Sent: Monday, March 9, 2020 6:28 PM > > > To: devel@edk2.groups.io > > > Cc: abner.chang@hpe.com; Leif Lindholm ; Kinney, > > > Michael D ; Gao, Liming > > > ; Ard Biesheuvel ; > > > Laszlo Ersek ; Bi, Dandan ; > > > Daniel Schaefer ; Gilbert Chen > > > > > > Subject: [edk2/master PATCH DxeIplHandoffLib v1] > > > MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl > > > > > > BZ:2583: > > > INVALID URI REMOVED > > > e.org_show-5Fbug.cgi-3Fid- > > 3D2583&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_ > > > > > > SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DYQR7NX_kxz4BPRET > > p5nNLWWOK > > > > > > NOimkostEzdrvyvPkA&s=3D7wyyAOitp2IvMKv19tlpbJxt2m0bn_ZsR4R7llYI19c& > > e=3D > > > > > > Current DxeIpl has bindings for different processor architectures, > > > this results in MdeModulePkg has the dependence with processor > > > architecture packages such as ArmPkg or RiscVPkg. This also leads CI > > > testing to error during package dependency check. Provide a default > > > DxeIplHandoff library to abstract processor architecture from DxeIpl > > > driver, platform can provide its own library instance for the > > > processor > > architecture- specific implementation. > > > > > > Signed-off-by: Abner Chang > > > > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Cc: Ard Biesheuvel > > > Cc: Laszlo Ersek > > > Cc: Dandan Bi > > > Cc: Daniel Schaefer > > > Cc: Gilbert Chen > > > --- > > > MdeModulePkg/MdeModulePkg.dsc | 2 ++ > > > .../DxeIplHandoffLibNull.inf | 30 ++++++++++++++++= + > > > .../DxeIplHandoffLibNull.c | 33 ++++++++++++++++= +++ > > > .../DxeIplHandoffLibNull.uni | 14 ++++++++ > > > 4 files changed, 79 insertions(+) > > > create mode 100644 > > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > > create mode 100644 > > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > > create mode 100644 > > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > > b/MdeModulePkg/MdeModulePkg.dsc index f7dbb27ce2..6eb922dfaa > > > 100644 > > > --- a/MdeModulePkg/MdeModulePkg.dsc > > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > > @@ -3,6 +3,7 @@ > > > # # (C) Copyright 2014 Hewlett-Packard Development Company, > > > L.P.
# Copyright (c) 2007 - 2019, Intel Corporation. All rights > > > reserved.
+# Copyright (c) 2020, Hewlett Packard Enterprise > > Development LP. All rights > > > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@= @ - > > > 321,6 +322,7 @@ > > > MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf > > > > > > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateP > > > rogressLibGraphics.inf > > > > > > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr > > > essLibText.inf+ > > > MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > > > > > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp > > > p.infdiff --git > > > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > > new file mode 100644 > > > index 0000000000..b7210656b7 > > > --- /dev/null > > > +++ > > > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.inf > > > @@ -0,0 +1,30 @@ > > > +## @file+# Null DXE IPL handoff to DXE Core Library instance.+#+# > > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > > rights reserved.
+#+# SPDX-License-Identifier: BSD-2-Clause- > > > Patent+#+##++[Defines]+ INF_VERSION =3D 0x000100= 1b+ > > > BASE_NAME =3D DxeIplHandoffLibNull+ MODULE_UNI= _FILE > > > =3D DxeIplHandoffLibNull.uni+ FILE_GUID =3D 5c= 18812d-3684-4093- > > > bc75-fc846a595353+ MODULE_TYPE =3D BASE+ VERSIO= N_STRING > > > =3D 1.0+ LIBRARY_CLASS =3D DxeIplHandoffLib++#+# T= he following > > > information is for reference only and not required by the build tool= s.+#+# > > > VALID_ARCHITECTURES =3D RISCV64+#++[Sources]+ > > > DxeIplHandoffLibNull.c++[Packages]+ MdePkg/MdePkg.dec+diff --git > > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > > new file mode 100644 > > > index 0000000000..c83922cb6e > > > --- /dev/null > > > +++ > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.c > > > @@ -0,0 +1,33 @@ > > > +/** @file+ NULL instance of DXE IPL handoff to DXE Core Library.++ > > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > > rights reserved.
++ SPDX-License-Identifier: BSD-2-Clause- > > > Patent++**/++#include +#include > ++/**+ > > > Transfers control to DxeCore.++ This function performs a CPU > architecture > > > specific operations to execute+ the entry point of DxeCore with th= e > > > parameters of HobList.+ It also installs EFI_END_OF_PEI_PPI to sig= nal the > > > end of PEI phase.++ @param DxeCoreEntryPoint The entry poi= nt of > > > DxeCore.+ @param HobList The start of HobList pa= ssed to > > > DxeCore.++**/+VOID+HandOffToDxeCore (+ IN > EFI_PHYSICAL_ADDRESS > > > DxeCoreEntryPoint,+ IN EFI_PEI_HOB_POINTERS HobList+ )+{+ DEBUG > > > ((DEBUG_INFO, "No implementation of DXE IPL handoff to DXE Core > > > library.\r\n"));+ ASSERT (FALSE);+}+diff --git > > > > a/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > > new file mode 100644 > > > index 0000000000..5a8973d6e5 > > > --- /dev/null > > > +++ > > > > b/MdeModulePkg/Library/DxeIplHandoffLibNull/DxeIplHandoffLibNull.uni > > > @@ -0,0 +1,14 @@ > > > +// /** @file+// Null DXE IPL handoff to DXE Core Library > > > +instance.+//+// > > > Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > > > rights reserved.
+//+// SPDX-License-Identifier: BSD-2-Clause- > > Patent+//+// > > > **/+++#string STR_MODULE_ABSTRACT #language en-US "Null > DXE > > > IPL handoff to DXE Core Library instance."++#string > > > STR_MODULE_DESCRIPTION #language en-US "Null DXE IPL handof= f > to > > > DXE Core Library instance."+-- > > > 2.25.0 >=20 >=20 >=20