From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.244.1581557960231674009 for ; Wed, 12 Feb 2020 17:39:20 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.147.86, mailfrom: prvs=0312f50326=abner.chang@hpe.com) Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01D1crV8016403; Thu, 13 Feb 2020 01:39:12 GMT Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 2y4scu9dty-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Feb 2020 01:39:12 +0000 Received: from G2W6310.americas.hpqcorp.net (g2w6310.austin.hp.com [16.197.64.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 540CEA1; Thu, 13 Feb 2020 01:39:11 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G2W6310.americas.hpqcorp.net (2002:10c5:4034::10c5:4034) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Thu, 13 Feb 2020 01:39:03 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Thu, 13 Feb 2020 01:39:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cywxxGrLZUthIA2fB8xqoszqLruzNY5XYrQ6twvu76kVNcWFO4sQWvVAaSqsKWwAfv2kiIwfrUeC6XqsQeetQ/v0vyEC5PJycGjJVg9TKQfXhIQs+nUz/O+b/SsUNF7A5M87RggybKq4KNRE7THpW+OC7BMnr4VFyRUu0V3VYCCIBp/tF2ULp5oxhfD8XDFk48BPKGo9ejtRUHnBDjJ8iuKABalzHWXikhAVyNK+dfikoGP/PHqVbVP6f4cCjuICng+Xbknw4HeHQYDgle+2uQEUyFshX+r4NlSjQDDeq0Xr6jCXsLiCn8gZFsYXKsaIK/UXsupr9I38HkqNYRHP6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ixy7dU2LAN18aIDbq/DbzXFhotQqE+xqSTRha66hHPs=; b=Y5gjfQ97Jt0+bIUN1kQklQm4yDWTGRYA+VrVwh1++sw3Ly6Kwdaqtw5SYHEnIED38ESr9CzaRciPTDeSliMpPuTiK7XRt7is9ajIQbNtL7y2X2E1bE1nIGVIh8pHi5Iy+X+XoQdU/WFAyn2tX7Y2+/rlAL1rJiBx46FtNB59C4zzkN/CqE5VDS0QiNjDHleQytuyc4xG5l1rx733z3YIPdCSpVEwgmTEP9dd4h8d6Ik443CUvQ813p3JwHqdXtP07Djj195pCzDdzGWj1J7E6od/+diNhPU2dqkG8qtm5+9CLYOh133K5A4AxGLHqmReoH9BkozNeipAEQqCcMqX5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM (10.169.43.14) by TU4PR8401MB0781.NAMPRD84.PROD.OUTLOOK.COM (10.169.45.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.24; Thu, 13 Feb 2020 01:39:02 +0000 Received: from TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402]) by TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b0b5:c067:8f22:a402%6]) with mapi id 15.20.2707.030; Thu, 13 Feb 2020 01:39:02 +0000 From: "Abner Chang" To: "devel@edk2.groups.io" , "rebecca@bsdio.com" , "Schaefer, Daniel Helmut (DualStudy)" CC: "Chen, Gilbert" Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Topic: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. Thread-Index: AQHV33xBwg7AF7RV9USeT6WkQ0yE2agTjjQAgAAZP3CAAOHHUoAAFOoAgAO9m3A= Date: Thu, 13 Feb 2020 01:39:02 +0000 Message-ID: References: <28f9f325-3106-1f3a-096d-d3aebc6fcc85@bsdio.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.131] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 25985554-83f6-4c36-190c-08d7b0258127 x-ms-traffictypediagnostic: TU4PR8401MB0781: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:843; x-forefront-prvs: 031257FE13 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(136003)(376002)(366004)(396003)(346002)(189003)(199004)(7696005)(66556008)(66476007)(64756008)(71200400001)(66446008)(19627235002)(33656002)(76116006)(478600001)(66946007)(9686003)(86362001)(316002)(53546011)(6506007)(4326008)(110136005)(81156014)(186003)(966005)(52536014)(8676002)(2906002)(55016002)(26005)(81166006)(8936002)(5660300002)(6636002);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB0781;H:TU4PR8401MB0429.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j9hbsYXVs3kFd396VeCzSD/kDYWueOrek6pGi2wwLvIhZjJ8Q+FZkWP82yS0XAfQyjYOilGMM3nVlFRPplqLfvhCax8q120OI7RgmfO3aZi/GFPat49KFDqNW5xQ5knAYJ8+fZhQ+zdWhXo1aP0qElZWruBgmrMnF1ZVTXBitBOAgNQgZJ/TNTchLFLB5bMrg11vibc45NKWGWqc/TVUSfE05TZudwOzNns9g/MWy2cyC2OWCkBi5nxQcBge3Srq4dxducbzEPMiA7/aaZ+u8u2DeX1j5cbhaohEPD7RsT+V6PxmbBcD57wo4BsDNERzh+3KCPhn+Qshpoh/Ls+fBJiLfdYhn7utEFogZ+T81w9izvEmOZ61SYplU3yNqAHc4GjT3kwfMEZI7KPHDXhU2b1NY+MvamFBXudyOkPhmRzKiOmslnUaz0K9fSZhWJUyx1P32CVs4gUjTy8IySgcEn0dP/HnTi0WpUBXHNlXKmEenFpZH5qQR5F5jPK54+yhar+JEsjexCxJrH5H7piptg== x-ms-exchange-antispam-messagedata: 9DPojW55YBXrOI5geX+/2OnhGa4dACdMPiL96ekTcMlTyrndRljxEqA/GhXa7MUur8XvGtQVNxEqmLk5YAOSgyJ5X6vvYIrAk9QG9rg6n/uzAS9I9IXbPCJpD48jFTvdg+XvHDB2VVOg7I2E08cXBQ== X-MS-Exchange-CrossTenant-Network-Message-Id: 25985554-83f6-4c36-190c-08d7b0258127 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2020 01:39:02.2286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9HrAKuSWBgz7XSqxSoyCOVajFtA0QKrLfoZvL1CbKQptw+QIBKxlrHOKG7C34Rxt1ykCCNJoF3/zwentDQex+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0781 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-02-12_10:2020-02-12,2020-02-12 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2002130012 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Rebecca, We fixed the build errors in order to incorporate with latest OpenSBI lib.= Both changes were on RISC-V-V2 and devel-riscvplatorms branches which are = same as before. However, we rebased and force updated it in order to keep t= he commits clear. We may keep doing this until we get those branches into m= ain stream. Also, as we confirm with OpenSBI guys, they mentioned that the stable tag = may be released couple weeks later. That means you will have to update Open= SBI to the latest by manually due to we don't have tag for it. Regards, Abner > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Rebecca Cran > Sent: Tuesday, February 11, 2020 12:24 AM > To: Schaefer, Daniel Helmut (DualStudy) > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Chen, Gilbert ; devel@edk2.groups.io > Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi > submodule to get sbi_hfence.S etc. >=20 > On 2020-02-10 08:13, Schaefer, Daniel Helmut (DualStudy) wrote: > > if you want to update to opensbi master, please apply this patch. > > Since opensbi 0.6 hasn't been released yet, we haven't pushed the > > fixes yet. > > Atish said it will be out soon. >=20 >=20 > Thanks! That worked, with a couple of changes. It seems commit > ec29e1cf73ffe96a646daa7c2b288aa280e4be37 isn't in the opensbi repo, and > the latest master code requires the following patch (I'm assuming 64-bit > MMIO _is_ supported!): >=20 >=20 > diff --git > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library > /OpensbiPlatformLib/Platform.c > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library > /OpensbiPlatformLib/Platform.c > index 3b3637995d..f72122b21b 100644 > --- > a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library > /OpensbiPlatformLib/Platform.c > +++ > b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library > /OpensbiPlatformLib/Platform.c > @@ -168,7 +168,7 @@ static int U540_timer_init(bool cold_boot) >=20 > =A0=A0=A0=A0 if (cold_boot) { > =A0=A0=A0=A0=A0=A0=A0=A0 rc =3D clint_cold_timer_init(CLINT_REG_BASE_ADD= R, > -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540= _HART_COUNT); > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540= _HART_COUNT, TRUE);^M > =A0=A0=A0=A0=A0=A0=A0=A0 if (rc) > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return rc; > =A0=A0=A0=A0 } >=20 >=20 >=20 > I don't know if Platform/SiFive/U5SeriesPkg/Readme.md is still used, but= I > noticed it's a bit out-of-date, and I believe the following patch fixes = some > issues including typos: >=20 >=20 > diff --git a/Platform/SiFive/U5SeriesPkg/Readme.md > b/Platform/SiFive/U5SeriesPkg/Readme.md > index 535fa9d430..d6db7c9150 100644 > --- a/Platform/SiFive/U5SeriesPkg/Readme.md > +++ b/Platform/SiFive/U5SeriesPkg/Readme.md > @@ -4,8 +4,8 @@ U5 series core platforms. Currently the supported > platforms are Freedom > =A0U500 VC707 platform and Freedom U540 HiFive Unleashed platform. >=20 > =A0Both platforms are built with below common packages, > -- **U5SeriesPkg**, edk2 platform branch > -=A0 (Currently is in edk2-platforms/devel-riscv-v2-PATCHv5 branch) > +- **U5SeriesPkg**, edk2-platforms master branch^M > +=A0 (Currently is in edk2-platforms/devel-riscvplatforms branch)^M > =A0- **RiscVPlatformPkg**, edk2 master branch > =A0=A0 (Currently is in edk2-staging/RISC-V-V2 branch) > =A0- **RiscVPkg**, edk2 master branch > @@ -17,11 +17,11 @@ VC707 FPGA Dev Kit, please refer to "SiFive Freedom > U500 VC707 FPGA Getting > =A0Started Guide" on INVALID URI REMOVED > 3A__www.sifive.com_documentation&d=3DDwIF- > g&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nH > p9P7Z5q59A3E&m=3DHxXHuY_9jAKWxvrHTbm2zuUZlHhjTs5V4lDto0Lzipk&s=3D54 > 3BZ6IUkXHI39_LU_12CPm-_kVRueQxvUPbDvP1Y2Y&e=3D . >=20 > =A0## U540 Platform > -This is a sample RISC-V EDK2 platform package used agaist SiFive Freedo= m > U540 > +This is a sample RISC-V EDK2 platform package used against SiFive > Freedom U540^M > =A0HiFive Unleashed development board, please refer to "SiFive Freedom > U540-C000 > =A0Manual" on INVALID URI REMOVED > 3A__www.sifive.com&d=3DDwIF- > g&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nH > p9P7Z5q59A3E&m=3DHxXHuY_9jAKWxvrHTbm2zuUZlHhjTs5V4lDto0Lzipk&s=3Dku > LOpyvDGMRUPou_2CAMCV7_gfkLNsuSfAPyf4nH4lI&e=3D . > -The binary built from Platform/SiFive/FreedomU540HiFiveUnleashedBoard > can run > -on main stream > [QEMU](INVALID URI REMOVED > 3A__git.qemu.org_-3Fp-3Dqemu.git-3Ba-3Dsummary&d=3DDwIF- > g&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nH > p9P7Z5q59A3E&m=3DHxXHuY_9jAKWxvrHTbm2zuUZlHhjTs5V4lDto0Lzipk&s=3DA > wqoWN_XfmU4GzhfY_hb_7EW9vT0hyYGhx_XugGgL8g&e=3D ) > +The binary built from > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/^M > +can run on main stream > +[QEMU](INVALID URI REMOVED > 3A__git.qemu.or > +g_-3Fp-3Dqemu.git-3Ba-3Dsummary-29-255EM&d=3DDwIF- > g&c=3DC5b8zRQO1miGmBeVZ2L > +FWg&r=3D_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DHxXHuY_ > 9jAKWxvrHTbm > +2zuUZlHhjTs5V4lDto0Lzipk&s=3DYPUqX3i3iQnU2UwGUb8-AL-IZ5- > Uszd6E0r9qL5jo_0& > +e=3D > =A0using qemu-system-riscv64 under riscv64-softmmu. Launch the binary wi= th >=20 > =A0``` > @@ -33,8 +33,7 @@ using qemu-system-riscv64 under riscv64-softmmu. > Launch the binary with > =A0git clone https://github.com/tianocore/edk2-staging.git > =A0# Checkout RISC-V-V2 branch > =A0git clone https://github.com/tianocore/edk2-platforms.git > -# Checkout devel-riscv-v2-PATCHv5 branch -git clone > https://github.com/tianocore/edk2-non-osi.git > +# Checkout devel-riscvplatforms branch^M > =A0``` >=20 > =A0## Platform Owners > @@ -47,7 +46,7 @@ FPGA to EFI shell with console in/out enabled. >=20 > =A0## Linux Build Instructions > =A0You can build the RISC-V platform using below script, -`build -a RISC= V64=A0 -t > GCC5 -p Platform/SiFive/FreedomU500VC707Board/U500.dsc` > +`build -a RISCV64 -t GCC5 -p > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc`^M >=20 > =A0## Supported Operating Systems > =A0Only support to boot to EFI Shell so far. > @@ -68,18 +67,18 @@ RISC-V related SMBIOS records to support the unified > boot loader and OS image. > =A0This library leverage the silicon libraries provided in Silicon/SiFiv= e. >=20 > =A0### RiscVPlatformTimerLib > -This is common U5 series=A0 platform timer library which has the > +This is common U5 series platform timer library which has the^M > =A0platform-specific timer implementation. >=20 > =A0### TimerDxe > -This is U5 series=A0 platform timer DXE driver whcih has the platform-s= pecific > +This is U5 series platform timer DXE driver which has the > platform-specific^M > =A0timer implementation. >=20 > =A0## U500 Platform Libraries and Drivers > -### RiscVOpnesbiPlatformLib > +### RiscVOpensbiPlatformLib^M > =A0In order to reduce the dependencies with RISC-V OpenSBI project > -(https://github.com/riscv/opensbi) and less burdens to EDK2 build proce= ss, > the -implementation of RISC-V EDK2 platform is leverage platform source > code from > +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build > process, the^M > +implementation of RISC-V EDK2 platform is leveraging platform source > code from^M > =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is clone= d > from > =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 b= uild > =A0environment. > @@ -89,10 +88,10 @@ This is the platform-implementation specific library > which is executed in early > =A0PEI phase for U500 platform initialization. >=20 > =A0## U540 Platform Libraries and Drivers > -### RiscVOpnesbiPlatformLib > +### RiscVOpensbiPlatformLib^M > =A0In order to reduce the dependencies with RISC-V OpenSBI project > -(https://github.com/riscv/opensbi) and less burdens to EDK2 build proce= ss, > the -implementation of RISC-V EDK2 platform is leverage platform source > code from > +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build > process, the^M > +implementation of RISC-V EDK2 platform is leveraging platform source > code from^M > =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is clone= d > from > =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 b= uild > =A0environment. >=20 >=20 >=20 >=20