Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 6/6] .pytool: Add RISC-V architecture on RISC-V EDK2 CI.

["Abner Chang" <abner.chang@hpe.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1212 bytes --]

Sean, the RISC-V edk2 port patches against to ek2-stating were reviewed. The submodule one attached FYR.

We have three sets of RISC-V edk2 port patches,

1.  Patches for RISC-V EDK2  CI enablement (This is what you are reviewing now).

2.  Patches for edk2 modules other than RISC-V ones, which fix the issues for building  packages respectively on RISC-V arch.

3 . RISC-V edk2 port

Patch of submodule is belong to #3 set.

We will have to make #1 and #2 to get in edk2 master and then submit #3 against to edk2/master, pull request to trigger CI as well.



Thanks

Abner


From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sean via Groups.Io
Sent: Sunday, March 8, 2020 6:09 AM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 6/6] .pytool: Add RISC-V architecture on RISC-V EDK2 CI.

I never saw a patch in the series that actually added the submodule to the .gitmodules file but maybe i missed that.  If that is approved then the changes to this file look ok.  I have no idea why all the line endings are shown but the substantial changes here look fine to me.


[-- Attachment #1.2: Type: text/html, Size: 6162 bytes --]

[-- Attachment #2: Type: message/rfc822, Size: 9766 bytes --]

From: Leif Lindholm <leif.lindholm@linaro.org>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>
Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 27/29] edk2-staging/RISC-V-V2: Add submodule
Date: Thu, 26 Sep 2019 22:24:28 +0000
Message-ID: <20190926222428.GB25504@bivouac.eciton.net>

On Mon, Sep 23, 2019 at 08:31:53AM +0800, Abner Chang wrote:
> Add submodule opensbi under RiscVPkg. The current supported opensbi
> version for RISC-V edk2 port is commit ID:ce228ee (tags/v0.4).
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> ---
>  .gitmodules      | 16 ++++++++++------
>  RiscVPkg/opensbi |  1 +
>  2 files changed, 11 insertions(+), 6 deletions(-)
>  create mode 160000 RiscVPkg/opensbi
>
> diff --git a/.gitmodules b/.gitmodules
> index 508f0c1..6d3e28c 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,6 +1,10 @@
> -[submodule "CryptoPkg/Library/OpensslLib/openssl"]
> -     path = CryptoPkg/Library/OpensslLib/openssl
> -     url = https://github.com/openssl/openssl
> -[submodule "SoftFloat"]
> -     path = ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> -     url = https://github.com/ucb-bar/berkeley-softfloat-3.git
> +[submodule "CryptoPkg/Library/OpensslLib/openssl"]
> +     path = CryptoPkg/Library/OpensslLib/openssl
> +     url = https://github.com/openssl/openssl
> +[submodule "SoftFloat"]
> +     path = ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3
> +     url = https://github.com/ucb-bar/berkeley-softfloat-3.git

Can you investigate why the pre-existing modules are deleted and
re-added as part of this patch?

Other than that, this is all good.

/
    Leif

> +[submodule "RiscVPkg/opensbi"]
> +     path = RiscVPkg/opensbi
> +     url = https://github.com/riscv/opensbi.git
> +
> diff --git a/RiscVPkg/opensbi b/RiscVPkg/opensbi
> new file mode 160000
> index 0000000..ce228ee
> --- /dev/null
> +++ b/RiscVPkg/opensbi
> @@ -0,0 +1 @@
> +Subproject commit ce228ee0919deb9957192d723eecc8aaae2697c6
> --
> 2.7.4
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#47778): https://urldefense.proofpoint.com/v2/url?u=https-3A__edk2.groups.io_g_devel_message_47778&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=6tMVtUEYMd1aiHIQGqO4hhS9Nt4Bov2cLqaAnF51P-8&s=ucbkT25eE8wRzFJYBCaXCY7xiWFhE-C8De4ARHmojKE&e=
> Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__groups.io_mt_34258225_1774251&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=6tMVtUEYMd1aiHIQGqO4hhS9Nt4Bov2cLqaAnF51P-8&s=bslBsUDGzA9YhI5irZ7uzRHMEoPsDzXnPGzF0xg8BAk&e=
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__edk2.groups.io_g_devel_unsub&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=6tMVtUEYMd1aiHIQGqO4hhS9Nt4Bov2cLqaAnF51P-8&s=TIfVOjFHcFQOdVpM1IflfMqV2BWjqu8KhKQ37BABNAg&e=   [leif.lindholm@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>