From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=148.163.143.35; helo=mx0b-002e3701.pphosted.com; envelope-from=derek.lin2@hpe.com; receiver=edk2-devel@lists.01.org Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 027012119FF37 for ; Tue, 18 Dec 2018 17:55:38 -0800 (PST) Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBJ1pEkF014155 for ; Wed, 19 Dec 2018 01:55:37 GMT Received: from g2t2354.austin.hpe.com (g2t2354.austin.hpe.com [15.233.44.27]) by mx0b-002e3701.pphosted.com with ESMTP id 2pf9rvskkv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 19 Dec 2018 01:55:37 +0000 Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2354.austin.hpe.com (Postfix) with ESMTPS id 7B47CC8 for ; Wed, 19 Dec 2018 01:55:36 +0000 (UTC) Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 19 Dec 2018 01:55:25 +0000 Received: from G9W9209.americas.hpqcorp.net (2002:10dc:429c::10dc:429c) by G4W9336.americas.hpqcorp.net (2002:10d0:2156::10d0:2156) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 19 Dec 2018 01:55:24 +0000 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (15.241.52.11) by G9W9209.americas.hpqcorp.net (16.220.66.156) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 19 Dec 2018 01:55:24 +0000 Received: from TU4PR8401MB0656.NAMPRD84.PROD.OUTLOOK.COM (10.169.44.150) by TU4PR8401MB1184.NAMPRD84.PROD.OUTLOOK.COM (10.169.48.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.17; Wed, 19 Dec 2018 01:55:22 +0000 Received: from TU4PR8401MB0656.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c5fd:216a:9df4:1a9]) by TU4PR8401MB0656.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c5fd:216a:9df4:1a9%4]) with mapi id 15.20.1425.024; Wed, 19 Dec 2018 01:55:22 +0000 From: "Lin, Derek (HPS SW)" To: "Feng, Bob C" , "edk2-devel@lists.01.org" , "Zhao, ZhiqiangX" Thread-Topic: [PATCH] BaseTools: Fix GenFds error doesn't break build. Thread-Index: AQHUlq6uy5KIEx9u0kSsDzJ8WgMcBaWEMBNQgAEElKCAABiJUA== Date: Wed, 19 Dec 2018 01:55:22 +0000 Message-ID: References: <20181218084936.2472-1-derek.lin2@hpe.com> <08650203BA1BD64D8AD9B6D5D74A85D160030829@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D160030829@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [16.242.247.138] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR8401MB1184; 6:dpbVS5zPMrhg+pIDAv/Hj3q7NIc6JUVEs3grYBR9PVV9qDhPpJtVxfygyB195Pk59Paokzbs49MtJnTOcJ93CnoxQRcQCgtz2waHv9IX4arY+DUf71s0FHjbUHU1vuUQYVEcAd+Ibo5E5BHrtcFta9K2Tc3yWgxbRVepw0PPlaGf84juVgYERp14qdDCColg/qUwXfdwSB/GivUQKWyfBAuvyH68n2Vj2UEEjoaRFYvI+CQYdFsP3LUg7AnqKKkc+oXPcoM9hQ7macqSRNL2Rp1vAD1g1RNTU5XjmWnwyqNUmuA/lPiMgCnuOmHQAfTUFAwqDJHhmQ7gkPh6CW74xzjbzlQfQDavp6ndjF1g+ZNq1wuAsCpDcADIUCjFxtovJ5WakleistSbsha9k00vKGqjb4MuHX+0NXmzEi7G2L/bF4cO1GcHDXkzUllTFMCf6UUxuWzxPPCiK8aAWM5MBw==; 5:uOT4R2GLqse5t4Zjwd8hW879/wCpQY83IYiKqYLxaWcBwfrXjRgFeHoV6ecriJj/wdDLomX7tDg70XiB/ZjPylmzqT59FnIz/pk6sEjzoNEJipwfoUiZ9DBFPkrKF94+wZS2gzdmvvPUsWH0qPS/9csTWCbJq6fqXuqONpCqQqo=; 7:YQOSF/ze9xj7j4HShBlyskjP7MoMEDYoN08W4POe7y+nDoqbirMQNuzfJDnX1lEZZkauUxRWMhkW9AytV64CwsHIjPbWiqoEB80Ly1Tk5EvYHpmoNW1O6RcczK5De5KNmVSpFAqSf2prg7TVH7UjvA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d99cb9f3-14d7-4e57-6f9b-08d665550982 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(49563074)(7193020); SRVR:TU4PR8401MB1184; x-ms-traffictypediagnostic: TU4PR8401MB1184: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(102415395)(6040522)(2401047)(5005006)(8121501046)(3231475)(944501520)(4983020)(52105112)(93006095)(93001095)(3002001)(10201501046)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:TU4PR8401MB1184; BCL:0; PCL:0; RULEID:; SRVR:TU4PR8401MB1184; x-forefront-prvs: 0891BC3F3D x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(396003)(366004)(39860400002)(376002)(136003)(199004)(189003)(13464003)(71200400001)(86362001)(575784001)(71190400001)(7736002)(6436002)(55016002)(6116002)(3846002)(229853002)(486006)(476003)(446003)(11346002)(105586002)(106356001)(5660300001)(478600001)(33656002)(66066001)(316002)(25786009)(99286004)(14454004)(68736007)(14444005)(110136005)(8676002)(5024004)(256004)(81156014)(81166006)(97736004)(53546011)(305945005)(6506007)(6246003)(76176011)(53936002)(99936001)(9686003)(7696005)(8936002)(74316002)(26005)(2501003)(2906002)(186003)(102836004); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR8401MB1184; H:TU4PR8401MB0656.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 0D3wlInDZkQ0ymFfiP2D8Hm/swLxuekrFQ6iS4UKoTsyOhAECYwk4gOLKtwo+ZzqEuEzCzw3RYFpGdFBqUohsOccmnRVdc9DM8EE3sOWOvL2vvGEkJxLkDIrDrMPLnMrxvd9g3rssQFzU7jZ5B9kaiCEmbSuW9YSnq3eKP2PnWVVchzY0NdbW22tTuPiExm9ALe46p/EQzLhRcxH+UHitC35EO/ZuyPIUXLWRClIAJipNvQs8h/Krf4hqYvKORyQsuZOIr4PouYxYh4gCrhVnI7Loac8BAsT0Wpu79ohsbUN7NvMB8WBhoBtefi05Kje spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d99cb9f3-14d7-4e57-6f9b-08d665550982 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2018 01:55:22.4321 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1184 X-OriginatorOrg: hpe.com X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-19_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812190014 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] BaseTools: Fix GenFds error doesn't break build. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 01:55:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Bob,=20 Please try attached patch. Based on today's master. Thanks, Derek -----Original Message----- From: Feng, Bob C [mailto:bob.c.feng@intel.com]=20 Sent: Wednesday, December 19, 2018 8:25 AM To: Lin, Derek (HPS SW) ; edk2-devel@lists.01.org; Zhao= , ZhiqiangX Subject: RE: [PATCH] BaseTools: Fix GenFds error doesn't break build. Hi Derek, This patch looks good to me. But I failed to apply this patch on master. Co= uld you update this patch? Thanks, Bob -----Original Message----- From: Lin, Derek (HPS SW) [mailto:derek.lin2@hpe.com]=20 Sent: Tuesday, December 18, 2018 4:52 PM To: edk2-devel@lists.01.org; Feng, Bob C ; Zhao, Zhiq= iangX Cc: Lin, Derek (HPS SW) Subject: [PATCH] BaseTools: Fix GenFds error doesn't break build. Fix a bug because of b3497bad1221704a5dbc5da0b10f42625f1ad2ed. Before the patch, when GenFds fail, the build continue and return success. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Derek Lin --- BaseTools/Source/Python/build/build.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index cbbb291b2c..97271e634e 100644 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -3,6 +3,7 @@ # # Copyright (c) 2014, Hewlett-Packard Development Company, L.P.
# C= opyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+# Copyright (c) 2018, Hewlett Packard Enterprise Development, L.P.
# # This program and the accompanying materials # are licensed and made a= vailable under the terms and conditions of the BSD License @@ -1384,7 +1385= ,8 @@ class Build(): =20 # genfds if Target =3D=3D 'fds': - GenFdsApi(AutoGenObject.GenFdsCommandDict, self.Db) + if GenFdsApi(AutoGenObject.GenFdsCommandDict, self.Db): + EdkLogger.error("build", COMMAND_FAILURE) return True =20 # run @@ -2122,7 +2124,8 @@ class Build(): # Generate FD image if there's a FDF file found # GenFdsStart =3D time.time() - GenFdsApi(Wa.GenFdsCommandDict, self.Db) + if GenFdsApi(Wa.GenFdsCommandDict, self.Db): + EdkLogger.error("build", COMMAND_FAILURE) =20 # # Create MAP file for all platform FVs after GenFd= s. -- 2.17.0.windows.1