From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.18238.1583170613388796049 for ; Mon, 02 Mar 2020 09:36:53 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=033048287c=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022HZtOQ005455; Mon, 2 Mar 2020 17:36:52 GMT Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2yh3epjdk1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 17:36:52 +0000 Received: from G9W8454.americas.hpqcorp.net (g9w8454.houston.hp.com [16.216.161.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id EE8FF7B; Mon, 2 Mar 2020 17:36:51 +0000 (UTC) Received: from G9W8455.americas.hpqcorp.net (2002:10d8:a15e::10d8:a15e) by G9W8454.americas.hpqcorp.net (2002:10d8:a104::10d8:a104) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 17:36:51 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.11) by G9W8455.americas.hpqcorp.net (16.216.161.94) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 17:36:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7o3tQLEJyMr1LZ2KJ6qu/ohGUdNt0iJmM5SPTcOEQAnrdZsX7Zo1FUI8l8k1NduiOgWKgSVwrtCd6sbJFj/axNvi1PpzHNrNt3qd4qhicBN/jwFw0zv8ppdoTgODTHVMgPiKu9fjB9tRHWeirzO3kmafFVWY6WvEwya1kGAColaGedt2SkJsXG79nu87nHHZCFATzMX6c8Sa4MRQ/cwxLkEqordVpXVn/BP4YAj8QDNnh30+wZ8F0U/4kqnTB+W9Tr2JbFE/ivpRFQTaEqCxOcz0aqvpvnFOHtGXGM6vFL6LaF2swB+FR6ctxoVrKvNA7RGxaJv+66r/5y42ZvkTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAMa+oFLBi1w6uFVCgyg/GmdM7vwKwrsBDoTWGWnUlc=; b=APyXuaKcyqFJRHR/TtrISojoD+opqVoaCeGfBg5+5Cv3tpeF36QWZSxO1NRdZD/NSqVX256thxM8R5kbvXQCMQ6+luGqZ8D8EiuE0zh3ajElFO8enMkfGyHFAWzUigVArhyTN/8On8SweWCAbHtT3pUjKYNs2cFdQNXhcwTnjge+3vAtz2i4pmcm5FYUMCp1a8C5/RoiZGr3P5KsvAwgK9CouS6qualvk3/AB+X9JAgHRY2AyS0p2ATWTTNwFac3QhBHk6P3lMuVFbV+3zz5gfAbGiX15EzOlnxgKp1TVHYaPmWljPMINgD78iIREdy/6MQy5mUhravOvWAicsz+fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB0990.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15; Mon, 2 Mar 2020 17:36:49 +0000 Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 17:36:49 +0000 From: "Daniel Schaefer" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Chang, Abner (HPS SW/FW Technologist)" , "Chen, Gilbert" , Leif Lindholm , "Bi, Dandan" Subject: Re: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Thread-Topic: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Thread-Index: AQHV8H3xX5jrAIi+GkectAuqa/KnVKg1SYGAgAA9txg= Date: Mon, 2 Mar 2020 17:36:49 +0000 Message-ID: References: <20200302103238.25726-1-daniel.schaefer@hpe.com> <20200302103238.25726-3-daniel.schaefer@hpe.com>,<7c392d26e5a0498e9bfb2b694b4f7d9c@intel.com> In-Reply-To: <7c392d26e5a0498e9bfb2b694b4f7d9c@intel.com> Accept-Language: en-US, de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [84.58.209.92] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f4f7ed8d-5186-46fe-25b8-08d7bed049c5 x-ms-traffictypediagnostic: TU4PR8401MB0990: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 033054F29A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6029001)(396003)(376002)(39860400002)(346002)(136003)(366004)(199004)(189003)(55016002)(9686003)(26005)(81166006)(81156014)(4326008)(186003)(478600001)(5660300002)(52536014)(71200400001)(110136005)(316002)(54906003)(64756008)(2906002)(91956017)(76116006)(66476007)(6506007)(53546011)(8936002)(66946007)(66446008)(86362001)(19627405001)(7696005)(8676002)(33656002)(66556008);DIR:OUT;SFP:1102;SCL:1;SRVR:TU4PR8401MB0990;H:TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JKyJ0ZMaZjVlg3bx6Jo92zuUB7cwivbtS/MrFpvaYO4QF1tsy3TNDJnWwJp1aAz7DM9XF5qSiT/Ioc2Vz/OA5AVlp45GZEQ2dTbe4rlKp8wrtZMGPRdTxte5aG1aDTok5tkqmwZFlvl05njhGFV3TnaVLzu++lJ4bhtnY/kIILbCe90c78zriIzu/87HRzidJJqJpjRlpPXj4Bccn/UUpSyQO0EWowUzBgattA6MU1Uk/PoBRO7H1EYRHtHICSQBpho4a7F6SpdKoFIpeW1/yTmvNILk6eRrfZErZs4w3RA0LIWDGRt+GEtqu1/UQNYWh9FnSu9bK0AbqYulX124ec90M0JAD6Ha1jFbwBD6Asd8EXplZjcWx9e69to1/DACeK0HN0Gb5XJWicE0Txzqrvy/CqzFKZi45f79/4lgW7dKOlFzLdc2rzWLB2+WetuR9hUfbhdPs1JSCiXAgohUwP0mbeU/eDliQAYcRQpPJWqaqod5sMFogZssLsNR6opOWTn4OxTrDu0efXOCT6OvYg== x-ms-exchange-antispam-messagedata: om/8JtDb8GUxAeU8HH9cYtT8HEeinyJlBuXpSX1tDps6W+t8ZaeA7UYDxyG9uE1I6Wh7AYeaoKZA/hRW3MQiLyWiH6vYQ1LnkJ8HTGJA/yxKt0HzqdwJZddQSCb0DY6HCJ6juhuRobILCXcr4Rxtxw== X-MS-Exchange-CrossTenant-Network-Message-Id: f4f7ed8d-5186-46fe-25b8-08d7bed049c5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2020 17:36:49.4947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oE6SvmrYLrKkbb6C1lPRFJOvhpcAPCUHD/bSj0sIYKQ8P1HzYCZ59AaWzR4eHMKPVpL4aXPri3ub6Wxa/mizvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB0990 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 2 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-02_06:2020-03-02,2020-03-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003020116 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_TU4PR8401MB09095459EC65774D9C120638E0E70TU4PR8401MB0909_" --_000_TU4PR8401MB09095459EC65774D9C120638E0E70TU4PR8401MB0909_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Liming, You're right, it doesn't make sense to define this PCD on other architectur= es and it is not necessary. I wrote this patch before patch 1 (MdeModulePkg: Restrict libraries using S= MM to x86). With the other patch, this PCD is not used on other architectures, so *we c= an drop this patch*. Thanks, Daniel ________________________________ From: Gao, Liming Sent: Monday, March 2, 2020 14:19 To: Schaefer, Daniel (DualStudy) ; devel@edk2.grou= ps.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Chen, Gilb= ert ; Leif Lindholm ; Bi, Dandan <= dandan.bi@intel.com> Subject: RE: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode fal= se on non-x86 Daniel: PcdDxeIplSwitchToLongMode is only used in IA32 arch. It is also specified= in [FeaturePcd.IA32] section of DxeIpl.inf. So, I don't understand why def= ines this PCD in other ARCH in MdeModulePkg.dec. Thanks Liming > -----Original Message----- > From: Daniel Schaefer > Sent: Monday, March 2, 2020 6:33 PM > To: devel@edk2.groups.io > Cc: Abner Chang ; Gilbert Chen ; Leif Lindholm ; Bi, Dandan > ; Gao, Liming > Subject: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false= on non-x86 > > Otherwise the PCD isn't defined on other architectures. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2548 > > Signed-off-by: Daniel Schaefer > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Leif Lindholm > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/MdeModulePkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec > index 91a3c608231c..59645c860148 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -879,6 +879,9 @@ [PcdsFeatureFlag] > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] > > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE= |BOOLEAN|0x0001003a > > > > +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] > > + gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN= |0x0001003b > > + > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > ## Indicates if DxeIpl should switch to long mode to enter DXE phase. > > # It is assumed that 64-bit DxeCore is built in firmware if it is tru= e; otherwise 32-bit DxeCore > > -- > 2.25.0 --_000_TU4PR8401MB09095459EC65774D9C120638E0E70TU4PR8401MB0909_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Liming,

You're right, it doesn't make sense to define this PCD on other architectur= es and it is not necessary.
I wrote this patch before patch 1 (MdeModulePkg: Restrict libraries u= sing SMM to x86).
With the other patch, this PCD is not used on other architectures, so *we c= an drop this patch*.

Thanks,
Daniel
From: Gao, Liming <limin= g.gao@intel.com>
Sent: Monday, March 2, 2020 14:19
To: Schaefer, Daniel (DualStudy) <daniel.schaefer@hpe.com>; de= vel@edk2.groups.io <devel@edk2.groups.io>
Cc: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>= ;; Chen, Gilbert <gilbert.chen@hpe.com>; Leif Lindholm <leif@nuvia= inc.com>; Bi, Dandan <dandan.bi@intel.com>
Subject: RE: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongM= ode false on non-x86
 
Daniel:
  PcdDxeIplSwitchToLongMode is only used in IA32 arch. It is also spec= ified in [FeaturePcd.IA32] section of DxeIpl.inf. So, I don't understand wh= y defines this PCD in other ARCH in MdeModulePkg.dec.

Thanks
Liming
> -----Original Message-----
> From: Daniel Schaefer <daniel.schaefer@hpe.com>
> Sent: Monday, March 2, 2020 6:33 PM
> To: devel@edk2.groups.io
> Cc: Abner Chang <abner.chang@hpe.com>; Gilbert Chen <gilbert.= chen@hpe.com>; Leif Lindholm <leif@nuviainc.com>; Bi, Dandan
> <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com><= br> > Subject: [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode fa= lse on non-x86
>
> Otherwise the PCD isn't defined on other architectures.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2548
>
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg= .dec
> index 91a3c608231c..59645c860148 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -879,6 +879,9 @@ [PcdsFeatureFlag]
>  [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARC= H64]
>
>    gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResource= ForOptionRom|FALSE|BOOLEAN|0x0001003a
>
>
>
> +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH6= 4]
>
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|F= ALSE|BOOLEAN|0x0001003b
>
> +
>
>  [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
>
>    ## Indicates if DxeIpl should switch to long mode to= enter DXE phase.
>
>    #  It is assumed that 64-bit DxeCore is built i= n firmware if it is true; otherwise 32-bit DxeCore
>
> --
> 2.25.0

--_000_TU4PR8401MB09095459EC65774D9C120638E0E70TU4PR8401MB0909_--