From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=15.241.140.75; helo=g4t3426.houston.hpe.com; envelope-from=thomas.palmer@hpe.com; receiver=edk2-devel@lists.01.org Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1D9D3222275A5 for ; Mon, 8 Jan 2018 10:02:32 -0800 (PST) Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id EB8996E; Mon, 8 Jan 2018 18:07:41 +0000 (UTC) Received: from G4W8058.americas.hpqcorp.net (16.208.40.75) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Mon, 8 Jan 2018 18:07:35 +0000 Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G4W8058.americas.hpqcorp.net (16.208.40.75) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Mon, 8 Jan 2018 18:07:20 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.241.52.11) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1178.4 via Frontend Transport; Mon, 8 Jan 2018 18:07:20 +0000 Received: from TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM (10.169.47.149) by TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM (10.169.47.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Mon, 8 Jan 2018 18:07:18 +0000 Received: from TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4414:2699:cadd:c4ec]) by TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM ([fe80::4414:2699:cadd:c4ec%18]) with mapi id 15.20.0386.008; Mon, 8 Jan 2018 18:07:18 +0000 From: "Palmer, Thomas" To: Laszlo Ersek , edk2-devel-01 CC: Jaben Carsey , Liming Gao , Rebecca Cran , Ruiyu Ni Thread-Topic: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI call conv spec Thread-Index: AQHThymG/M5QRPJl/kWCPNYOTBUy2qNqSKgA Date: Mon, 8 Jan 2018 18:07:18 +0000 Message-ID: References: <20180106200353.18334-1-lersek@redhat.com> In-Reply-To: <20180106200353.18334-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=thomas.palmer@hpe.com; x-originating-ip: [15.211.195.15] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; TU4PR8401MB1069; 7:sWNa3w6Vr/k+ay51xYyeveFTD6u27OeCE8ot/gBuyGIwiMcLUal5h3RN5XVMqXrsE7PlUVnvlml4ddPdzPpmb+sKBoAA+6m5F5gtbzJja5GqQ40FhngpxZCblc0/JVDainlbwk/0bxjn0Cx04lMuoSct/+jc/a+Iiwe+eWhyAFaT/3DaGbDFHNCIpw0AOnNsJ082/WbUoyDTIYIjEYBcuSKvd0TNyhrZ+WgbAfnEv9JA4Gikw0/lsY955usUFCT/ x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 38921948-7a69-4c29-138f-08d556c2a7f9 x-microsoft-antispam: UriScan:(222181515654134); BCL:0; PCL:0; RULEID:(48565401081)(4534020)(4602075)(4627115)(8989060)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:TU4PR8401MB1069; x-ms-traffictypediagnostic: TU4PR8401MB1069: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861)(162533806227266)(222181515654134)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:TU4PR8401MB1069; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:TU4PR8401MB1069; x-forefront-prvs: 054642504A x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(376002)(39860400002)(396003)(366004)(346002)(199004)(189003)(13464003)(25786009)(106356001)(305945005)(3846002)(6436002)(2900100001)(102836004)(14454004)(53546011)(59450400001)(15760500003)(6116002)(478600001)(966005)(6246003)(3660700001)(2950100002)(74316002)(6506007)(5660300001)(3280700002)(66066001)(105586002)(229853002)(110136005)(53936002)(81156014)(8676002)(81166006)(8936002)(76176011)(55016002)(54906003)(99286004)(2906002)(316002)(4326008)(68736007)(7736002)(33656002)(7696005)(97736004)(6306002)(5250100002)(9686003)(86362001)(19627235001); DIR:OUT; SFP:1102; SCL:1; SRVR:TU4PR8401MB1069; H:TU4PR8401MB1069.NAMPRD84.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: aNA05ZkdyJWCBkzmCV8gYKvxsdErED3zkfM4JvwSPIoLU0zd+aClhvEM62Mq3pH/Og3Fm9/uU+GeKHHSkwnXcg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 38921948-7a69-4c29-138f-08d556c2a7f9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2018 18:07:18.3462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1069 X-OriginatorOrg: hpe.com Subject: Re: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI call conv spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 18:02:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed by thomas.palmer@hpe.com Regards, Thomas Palmer "I have only made this letter longer because I have not had the time to mak= e it shorter" - Blaise Pascal -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Saturday, January 6, 2018 2:04 PM To: edk2-devel-01 Cc: Jaben Carsey ; Liming Gao ; Rebecca Cran ; Ruiyu Ni ; Palm= er, Thomas Subject: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: add missing EFIAPI ca= ll conv spec UefiShellLevel2CommandsLib (somewhat questionably) calls the BaseLib-intern= al function InternalCharToUpper(). This function is declared in "MdePkg/Library/BaseLib/BaseLibInternals.h", which is not a public library class header. UefiShellLevel2CommandsLib ther= efore duplicates the function declaration, but a mistake was made: the EFIA= PI calling convention is not spelled out on the duplicated declaration. The= refore calls made from UefiShellLevel2CommandsLib will not match the actual= function definition in "MdePkg/Library/BaseLib/String.c", when GCC/X64 toolchains are used. One consequence of this is that cross-filesystem copies don't work in the U= EFI shell (see the StrniCmp() function in "UefiShellLevel2CommandsLib.c"). = >>From the original report: > FS0:\efi\ubuntu\> cp grubx64.efi fs1:\ > > cp: The source and destination are the same. Copy the declaration from "BaseLibInternals.h" to "UefiShellLevel2CommandsL= ib.c" verbatim. Reported-by: Rebecca Cran Analyzed-by: Thomas Palmer Analyzed-by: Liming Gao Ref: http://mid.mail-archive.com/47cd17d8-f022-6ca5-2f52-06a8250f8d14@cran.= org.uk Cc: Jaben Carsey Cc: Liming Gao Cc: Rebecca Cran Cc: Ruiyu Ni Cc: Thomas Palmer Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLib.c |= 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Com= mandsLib.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Com= mandsLib.c index 7948e53cfc46..e9ce63189224 100644 --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2CommandsLi= b.c +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Command +++ sLib.c @@ -268,8 +268,9 @@ VerifyIntermediateDirectories ( @return Char as an upper case character. **/ CHAR16 +EFIAPI InternalCharToUpper ( - IN CONST CHAR16 Char + IN CHAR16 Char ); =20 /** -- 2.14.1.3.gb7cf6e02401b